Help with adding TMs 50-100 to Item Expansion

[RadicalRadish]

I'm trying to add new TMs like this:

src/data/items.h
"I add the new item (TM51) directly under the entry for TM50"
[ITEM_TM51_OVERHEAT] =
{
.name = _("TM51"),
.itemId = ITEM_TM51_OVERHEAT,
.price = 0,
.description = sTM51Desc,
.importance = 1,
.pocket = POCKET_TM_HM,
.type = 1,
.fieldUseFunc = ItemUseOutOfBattle_TMHM,
.secondaryId = 0,
},

src/data/party_menu.h
"I add the move to the TM/HM list in party_menu.h"
static const u16 sTMHMMoves[] =
{
...
MOVE_SNATCH,
MOVE_OVERHEAT,
MOVE_OVERHEAT,
MOVE_CUT,
MOVE_FLY,
...
}

include/constants/items.h
"I change the number of TMs from 50 to 51"
...
#define NUM_TECHNICAL_MACHINES 51
#define NUM_HIDDEN_MACHINES 8
...

src/data/texyt/item_descriptions.h
"I'm adding TM51s item description""

...
static const u8 sTM50Desc[] = _(
"Enables full-power\n"
"attack, but sharply\n"
"lowers SP. ATK.");

static const u8 sTM51Desc[] = _(
"Enables full-power\n"
"attack, but sharply\n"
"lowers SP. ATK.");


static const u8 sHM01Desc[] = _(
"Attacks the foe\n"
"with sharp blades\n"
"or claws.");
...



Everytime I do that though it doesn't work and I get all kinds of error messages when compiling...

The TMs 50 to 100 are already defined in include/constants/items.h by the item_expansion...
I just don't get how to implement them into the game.
I'd really appreciate the help!

 

[Zafnok]

Well, one comment I would make is that it appears you are duplicating TM50 for TM51. I'm not sure how much bearing this has on any compilation errors, but try editing TM51 to the correct TM to start. After that, show a couple of the error messages that you get in a screenshot or copy-paste them.

 

[RadicalRadish]

Okay I changed the move to Ice Punch now and added my compile log below.

CHANGES TO:
src/data/items.h

Spoiler:

[ITEM_TM51_ICE_PUNCH] =
{
.name = _("TM51"),
.itemId = ITEM_TM51_ICE_PUNCH,
.price = 0,
.description = sTM51Desc,
.importance = 1,
.pocket = POCKET_TM_HM,
.type = 1,
.fieldUseFunc = ItemUseOutOfBattle_TMHM,
.secondaryId = 0,
},

CHANGES TO:
src/data/party_menu.h

Spoiler:

static const u16 sTMHMMoves[] =
{
...
MOVE_SNATCH,
MOVE_OVERHEAT,
MOVE_ICE_PUNCH,
MOVE_CUT,
MOVE_FLY,
...
}

CHANGES TO:
include/constants/items.h

Spoiler:

...
#define ITEM_TM50_OVERHEAT ITEM_TM50
#define ITEM_TM51_ICE_PUNCH ITEM_TM51

#define ITEM_HM01_CUT ITEM_HM01
#define ITEM_HM02_FLY ITEM_HM02
...

...
#define NUM_TECHNICAL_MACHINES 51
#define NUM_HIDDEN_MACHINES 8
...

CHANGES TO:
src/data/text/item_descriptions.h

Spoiler:

...
static const u8 sTM50Desc[] = _(
"Enables full-power\n"
"attack, but sharply\n"
"lowers SP. ATK.");

static const u8 sTM51Desc[] = _(
"An icy punch that may\n"
"freeze the foe.");


static const u8 sHM01Desc[] = _(
"Attacks the foe\n"
"with sharp blades\n"
"or claws.");
...

This is my compilation log:

Spoiler:

arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/mail_data.o build/emerald/src/mail_data.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/egg_hatch.o build/emerald/src/egg_hatch.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/item_use.o build/emerald/src/item_use.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_ai_switch_items.o build/emerald/src/battle_ai_switch_items.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/item_menu.o build/emerald/src/item_menu.s
In file included from src/battle_main.c:57:
include/constants/items.h:193: warning: "ITEM_OCCA_BERRY" redefined
193 | #define ITEM_OCCA_BERRY 179
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:25: note: this is the location of the previous definition
25 | #define ITEM_OCCA_BERRY 204
|
In file included from src/battle_main.c:57:
include/constants/items.h:194: warning: "ITEM_PASSHO_BERRY" redefined
194 | #define ITEM_PASSHO_BERRY 180
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:26: note: this is the location of the previous definition
26 | #define ITEM_PASSHO_BERRY 205
|
In file included from src/battle_main.c:57:
include/constants/items.h:195: warning: "ITEM_WACAN_BERRY" redefined
195 | #define ITEM_WACAN_BERRY 181
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:27: note: this is the location of the previous definition
27 | #define ITEM_WACAN_BERRY 206
|
In file included from src/battle_main.c:57:
include/constants/items.h:196: warning: "ITEM_RINDO_BERRY" redefined
196 | #define ITEM_RINDO_BERRY 182
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:28: note: this is the location of the previous definition
28 | #define ITEM_RINDO_BERRY 207
|
In file included from src/battle_main.c:57:
include/constants/items.h:197: warning: "ITEM_YACHE_BERRY" redefined
197 | #define ITEM_YACHE_BERRY 183
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:29: note: this is the location of the previous definition
29 | #define ITEM_YACHE_BERRY 208
|
In file included from src/battle_main.c:57:
include/constants/items.h:198: warning: "ITEM_CHOPLE_BERRY" redefined
198 | #define ITEM_CHOPLE_BERRY 184
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:30: note: this is the location of the previous definition
30 | #define ITEM_CHOPLE_BERRY 177
|
In file included from src/battle_main.c:57:
include/constants/items.h:199: warning: "ITEM_KEBIA_BERRY" redefined
199 | #define ITEM_KEBIA_BERRY 185
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:31: note: this is the location of the previous definition
31 | #define ITEM_KEBIA_BERRY 178
|
In file included from src/battle_main.c:57:
include/constants/items.h:200: warning: "ITEM_SHUCA_BERRY" redefined
200 | #define ITEM_SHUCA_BERRY 186
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:32: note: this is the location of the previous definition
32 | #define ITEM_SHUCA_BERRY 179
|
In file included from src/battle_main.c:57:
include/constants/items.h:201: warning: "ITEM_COBA_BERRY" redefined
201 | #define ITEM_COBA_BERRY 187
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:33: note: this is the location of the previous definition
33 | #define ITEM_COBA_BERRY 180
|
In file included from src/battle_main.c:57:
include/constants/items.h:202: warning: "ITEM_PAYAPA_BERRY" redefined
202 | #define ITEM_PAYAPA_BERRY 188
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:34: note: this is the location of the previous definition
34 | #define ITEM_PAYAPA_BERRY 181
|
In file included from src/battle_main.c:57:
include/constants/items.h:203: warning: "ITEM_TANGA_BERRY" redefined
203 | #define ITEM_TANGA_BERRY 189
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:35: note: this is the location of the previous definition
35 | #define ITEM_TANGA_BERRY 182
|
In file included from src/battle_main.c:57:
include/constants/items.h:204: warning: "ITEM_CHARTI_BERRY" redefined
204 | #define ITEM_CHARTI_BERRY 190
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:36: note: this is the location of the previous definition
36 | #define ITEM_CHARTI_BERRY 183
|
In file included from src/battle_main.c:57:
include/constants/items.h:205: warning: "ITEM_KASIB_BERRY" redefined
205 | #define ITEM_KASIB_BERRY 191
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:37: note: this is the location of the previous definition
37 | #define ITEM_KASIB_BERRY 184
|
In file included from src/battle_main.c:57:
include/constants/items.h:206: warning: "ITEM_HABAN_BERRY" redefined
206 | #define ITEM_HABAN_BERRY 192
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:38: note: this is the location of the previous definition
38 | #define ITEM_HABAN_BERRY 185
|
In file included from src/battle_main.c:57:
include/constants/items.h:207: warning: "ITEM_COLBUR_BERRY" redefined
207 | #define ITEM_COLBUR_BERRY 193
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:39: note: this is the location of the previous definition
39 | #define ITEM_COLBUR_BERRY 186
|
In file included from src/battle_main.c:57:
include/constants/items.h:208: warning: "ITEM_BABIRI_BERRY" redefined
208 | #define ITEM_BABIRI_BERRY 194
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:40: note: this is the location of the previous definition
40 | #define ITEM_BABIRI_BERRY 187
|
In file included from src/battle_main.c:57:
include/constants/items.h:209: warning: "ITEM_CHILAN_BERRY" redefined
209 | #define ITEM_CHILAN_BERRY 195
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:41: note: this is the location of the previous definition
41 | #define ITEM_CHILAN_BERRY 188
|
In file included from src/battle_main.c:57:
include/constants/items.h:210: warning: "ITEM_ROSELI_BERRY" redefined
210 | #define ITEM_ROSELI_BERRY 196
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:42: note: this is the location of the previous definition
42 | #define ITEM_ROSELI_BERRY 189
|
In file included from src/battle_main.c:57:
include/constants/items.h:218: warning: "ITEM_MICLE_BERRY" redefined
218 | #define ITEM_MICLE_BERRY 204
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:43: note: this is the location of the previous definition
43 | #define ITEM_MICLE_BERRY 197
|
In file included from src/battle_main.c:57:
include/constants/items.h:220: warning: "ITEM_CUSTAP_BERRY" redefined
220 | #define ITEM_CUSTAP_BERRY 206
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:44: note: this is the location of the previous definition
44 | #define ITEM_CUSTAP_BERRY 199
|
In file included from src/battle_main.c:57:
include/constants/items.h:221: warning: "ITEM_JABOCA_BERRY" redefined
221 | #define ITEM_JABOCA_BERRY 207
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:45: note: this is the location of the previous definition
45 | #define ITEM_JABOCA_BERRY 200
|
In file included from src/battle_main.c:57:
include/constants/items.h:222: warning: "ITEM_ROWAP_BERRY" redefined
222 | #define ITEM_ROWAP_BERRY 208
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:46: note: this is the location of the previous definition
46 | #define ITEM_ROWAP_BERRY 201
|
In file included from src/battle_main.c:57:
include/constants/items.h:223: warning: "ITEM_KEE_BERRY" redefined
223 | #define ITEM_KEE_BERRY 209
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:47: note: this is the location of the previous definition
47 | #define ITEM_KEE_BERRY 202
|
In file included from src/battle_main.c:57:
include/constants/items.h:224: warning: "ITEM_MARANGA_BERRY" redefined
224 | #define ITEM_MARANGA_BERRY 210
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:48: note: this is the location of the previous definition
48 | #define ITEM_MARANGA_BERRY 203
|
In file included from src/battle_main.c:57:
include/constants/items.h:388: warning: "ITEM_GRISEOUS_ORB" redefined
388 | #define ITEM_GRISEOUS_ORB 369
|
In file included from src/battle_main.c:53:
include/constants/battle_config.h:24: note: this is the location of the previous definition
24 | #define ITEM_GRISEOUS_ORB 0
|
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_main.o build/emerald/src/battle_main.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/pokeblock.o build/emerald/src/pokeblock.s
In file included from src/pokemon.c:1387:
src/data/pokemon/level_up_learnsets.h:2: warning: "LEVEL_UP_END" redefined
2 | #define LEVEL_UP_END (0xffff)
|
In file included from include/pokemon.h:4,
from include/global.h:526,
from src/pokemon.c:1:
include/constants/pokemon.h:233: note: this is the location of the previous definition
233 | #define LEVEL_UP_END 0xFFFF
|
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/pokemon.o build/emerald/src/pokemon.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/secret_base.o build/emerald/src/secret_base.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/pokemon_storage_system.o build/emerald/src/pokemon_storage_system.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/frontier_util.o build/emerald/src/frontier_util.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_debug.o build/emerald/src/battle_debug.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/ereader_helpers.o build/emerald/src/ereader_helpers.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/lottery_corner.o build/emerald/src/lottery_corner.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/dodrio_berry_picking.o build/emerald/src/dodrio_berry_picking.s
In file included from src/battle_controller_player.c:33:
include/constants/items.h:193: warning: "ITEM_OCCA_BERRY" redefined
193 | #define ITEM_OCCA_BERRY 179
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:25: note: this is the location of the previous definition
25 | #define ITEM_OCCA_BERRY 204
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:194: warning: "ITEM_PASSHO_BERRY" redefined
194 | #define ITEM_PASSHO_BERRY 180
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:26: note: this is the location of the previous definition
26 | #define ITEM_PASSHO_BERRY 205
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:195: warning: "ITEM_WACAN_BERRY" redefined
195 | #define ITEM_WACAN_BERRY 181
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:27: note: this is the location of the previous definition
27 | #define ITEM_WACAN_BERRY 206
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:196: warning: "ITEM_RINDO_BERRY" redefined
196 | #define ITEM_RINDO_BERRY 182
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:28: note: this is the location of the previous definition
28 | #define ITEM_RINDO_BERRY 207
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:197: warning: "ITEM_YACHE_BERRY" redefined
197 | #define ITEM_YACHE_BERRY 183
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:29: note: this is the location of the previous definition
29 | #define ITEM_YACHE_BERRY 208
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:198: warning: "ITEM_CHOPLE_BERRY" redefined
198 | #define ITEM_CHOPLE_BERRY 184
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:30: note: this is the location of the previous definition
30 | #define ITEM_CHOPLE_BERRY 177
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:199: warning: "ITEM_KEBIA_BERRY" redefined
199 | #define ITEM_KEBIA_BERRY 185
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:31: note: this is the location of the previous definition
31 | #define ITEM_KEBIA_BERRY 178
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:200: warning: "ITEM_SHUCA_BERRY" redefined
200 | #define ITEM_SHUCA_BERRY 186
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:32: note: this is the location of the previous definition
32 | #define ITEM_SHUCA_BERRY 179
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:201: warning: "ITEM_COBA_BERRY" redefined
201 | #define ITEM_COBA_BERRY 187
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:33: note: this is the location of the previous definition
33 | #define ITEM_COBA_BERRY 180
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:202: warning: "ITEM_PAYAPA_BERRY" redefined
202 | #define ITEM_PAYAPA_BERRY 188
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:34: note: this is the location of the previous definition
34 | #define ITEM_PAYAPA_BERRY 181
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:203: warning: "ITEM_TANGA_BERRY" redefined
203 | #define ITEM_TANGA_BERRY 189
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:35: note: this is the location of the previous definition
35 | #define ITEM_TANGA_BERRY 182
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:204: warning: "ITEM_CHARTI_BERRY" redefined
204 | #define ITEM_CHARTI_BERRY 190
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:36: note: this is the location of the previous definition
36 | #define ITEM_CHARTI_BERRY 183
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:205: warning: "ITEM_KASIB_BERRY" redefined
205 | #define ITEM_KASIB_BERRY 191
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:37: note: this is the location of the previous definition
37 | #define ITEM_KASIB_BERRY 184
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:206: warning: "ITEM_HABAN_BERRY" redefined
206 | #define ITEM_HABAN_BERRY 192
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:38: note: this is the location of the previous definition
38 | #define ITEM_HABAN_BERRY 185
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:207: warning: "ITEM_COLBUR_BERRY" redefined
207 | #define ITEM_COLBUR_BERRY 193
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:39: note: this is the location of the previous definition
39 | #define ITEM_COLBUR_BERRY 186
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:208: warning: "ITEM_BABIRI_BERRY" redefined
208 | #define ITEM_BABIRI_BERRY 194
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:40: note: this is the location of the previous definition
40 | #define ITEM_BABIRI_BERRY 187
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:209: warning: "ITEM_CHILAN_BERRY" redefined
209 | #define ITEM_CHILAN_BERRY 195
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:41: note: this is the location of the previous definition
41 | #define ITEM_CHILAN_BERRY 188
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:210: warning: "ITEM_ROSELI_BERRY" redefined
210 | #define ITEM_ROSELI_BERRY 196
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:42: note: this is the location of the previous definition
42 | #define ITEM_ROSELI_BERRY 189
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:218: warning: "ITEM_MICLE_BERRY" redefined
218 | #define ITEM_MICLE_BERRY 204
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:43: note: this is the location of the previous definition
43 | #define ITEM_MICLE_BERRY 197
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:220: warning: "ITEM_CUSTAP_BERRY" redefined
220 | #define ITEM_CUSTAP_BERRY 206
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:44: note: this is the location of the previous definition
44 | #define ITEM_CUSTAP_BERRY 199
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:221: warning: "ITEM_JABOCA_BERRY" redefined
221 | #define ITEM_JABOCA_BERRY 207
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:45: note: this is the location of the previous definition
45 | #define ITEM_JABOCA_BERRY 200
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:222: warning: "ITEM_ROWAP_BERRY" redefined
222 | #define ITEM_ROWAP_BERRY 208
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:46: note: this is the location of the previous definition
46 | #define ITEM_ROWAP_BERRY 201
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:223: warning: "ITEM_KEE_BERRY" redefined
223 | #define ITEM_KEE_BERRY 209
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:47: note: this is the location of the previous definition
47 | #define ITEM_KEE_BERRY 202
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:224: warning: "ITEM_MARANGA_BERRY" redefined
224 | #define ITEM_MARANGA_BERRY 210
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:48: note: this is the location of the previous definition
48 | #define ITEM_MARANGA_BERRY 203
|
In file included from src/battle_controller_player.c:33:
include/constants/items.h:388: warning: "ITEM_GRISEOUS_ORB" redefined
388 | #define ITEM_GRISEOUS_ORB 369
|
In file included from src/battle_controller_player.c:32:
include/constants/battle_config.h:24: note: this is the location of the previous definition
24 | #define ITEM_GRISEOUS_ORB 0
|
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_controller_player.o build/emerald/src/battle_controller_player.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_message.o build/emerald/src/battle_message.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/event_object_movement.o build/emerald/src/event_object_movement.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_setup.o build/emerald/src/battle_setup.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/shop.o build/emerald/src/shop.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/lilycove_lady.o build/emerald/src/lilycove_lady.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/apprentice.o build/emerald/src/apprentice.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_pyramid.o build/emerald/src/battle_pyramid.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/trade.o build/emerald/src/trade.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/item_menu_icons.o build/emerald/src/item_menu_icons.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/item_icon.o build/emerald/src/item_icon.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/field_tasks.o build/emerald/src/field_tasks.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_palace.o build/emerald/src/battle_palace.s
In file included from src/item.c:33:
src/data/items.h:4713: duplicate initializer for `gItems[532]'
Makefile:252: recipe for target 'build/emerald/src/item.o' failed
make: *** [build/emerald/src/item.o] Error 1

 

[Zafnok]

I'll come back to help later but what I gather from your log is that there isn't anything wrong with the additions listed, but something else, towards the end of the gItems array in src/data/items.h

It appears you have multiple entries with the same name somehow. I would go to the specified line (4713) in that file, and check out which entry is there, then search the file to see if you somehow have it in another place. If you could post the file that would be helpful.

 

[RadicalRadish]

...
.importance = 1,
.pocket = POCKET_TM_HM,
.type = 1,
.fieldUseFunc = ItemUseOutOfBattle_TMHM,
.secondaryId = 0,
}, <-------- This is line 4713

[ITEM_HM02_FLY] =
{
.name = _("HM02"),
.itemId = ITEM_HM02_FLY,
.price = 0,
.description = sHM02Desc,
.importance = 1,
...


The weird thing is I get a clean, error-free log before adding TM51.
I haven't changed anything else since, and when I roll back to my last backup (which was exactly before adding the TM) it works fine.

 

[PokemonCrazy]

Delete the item defines in include/constants/battle_config.h. It seems like that's your error.

 

[RadicalRadish]

Thx so much for the tipp...
I remember now that I did delete those entries when setting up my first repo and merging with dizzy's item expansion
This time I made alot of changes and only recently merged my repo with it...so I just forgot.

The problem is now I still get this error about a "duplicate initializer"?
Here is my compile log:

Spoiler:

arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_main.o build/emerald/src/battle_main.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_controller_player.o build/emerald/src/battle_controller_player.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_pike.o build/emerald/src/battle_pike.s
arm-none-eabi-as -mcpu=arm7tdmi --defsym MODERN=0 -o build/emerald/src/battle_interface.o build/emerald/src/battle_interface.s
In file included from src/item.c:33:
src/data/items.h:4713: duplicate initializer for `gItems[532]'
Makefile:252: recipe for target 'build/emerald/src/item.o' failed
make: *** [build/emerald/src/item.o] Error 1

4713 is this line here:

Spoiler:

[ITEM_HM01_CUT] =
{
.name = _("HM01"),
.itemId = ITEM_HM01_CUT,
.price = 0,
.description = sHM01Desc,
.importance = 1,
.pocket = POCKET_TM_HM,
.type = 1,
.fieldUseFunc = ItemUseOutOfBattle_TMHM,
.secondaryId = 0,
}, <------------------------------ (4713)

[ITEM_HM02_FLY] =
{
.name = _("HM02"),
.itemId = ITEM_HM02_FLY,
.price = 0,
.description = sHM02Desc,
.importance = 1,
.pocket = POCKET_TM_HM,
.type = 1,
.fieldUseFunc = ItemUseOutOfBattle_TMHM,
.secondaryId = 0,
},

 

[Zafnok]

Can you embed the file?

 

[RadicalRadish]

Sure.
Here you go:

 

[Zafnok]

I figured out the issue but the solution I've come up with thus far has far reaching implications, so I'm trying some other things out. Essentially the issue is that in include/constants/items.h, the HMs have the same ID assigned to them as the TMs in the 51-58 range. However, simply changing the HM IDs or TM IDs will affect learnsets. So, I'm not too sure the best way on how to tackle this problem.

EDIT: Actually, you will likely need to edit the learnsets to add TMs in the 51-100 range for this project as well... So a large amount of edits to the learnsets file will be needed either way.

 

[RadicalRadish]

do you mean?

/src/data/pokemon/tmhm_learnsets.h

Anyways... thx for all your help!
I'll play around with learnsets tomorrow and see if I can fix it that way.

 

[Zafnok]

do you mean?


Anyways... thx for all your help!
I'll play around with learnsets tomorrow and see if I can fix it that way.

Yes, that one. If you look in that file, no TMs from 51 onwards are included. Additionally, changing HMs to 582-589 (which aren't taken) causes some weird issue with bitshifts in that file when compiling. I'm not super comfortable in that realm just yet, so I can't quite pinpoint where it goes wrong.

 

[RadicalRadish]

Hmn...could you repoint the TM Table somehow to get rid of that problem?
I remember doing stuff like this on vanilla firered through hex editing but I'm still very new to Decomps/Pokeemerald...

 

[fatherlyuncle]

you should look at DizzyEgg's item_expansion branch, as it already has gone through the trouble of doing basically all of the hard parts of this.

 

[Lunos]

you should look at DizzyEgg's item_expansion branch, as it already has gone through the trouble of doing basically all of the hard parts of this.

As far as I can tell, that is not really the case. Egg seems to have defined the TMs 51 to 100, but that's it.
The actual data for the TMs is not present.

Speaking of which, I haven't seen it mentioned in this thread yet, but TMs 51 to 58 have the same Item ID number as the HMs 01 to 08, which shouldn't be the case as each item must have their own individual number ID, so you guys have to make sure to adjust those accordingly.

 

[RadicalRadish]

...the HMs have the same ID assigned to them as the TMs in the 51-58 range...

...changing HMs to 582-589 (which aren't taken) causes some weird issue with bitshifts in that file when compiling

Zafnok did mention that and I tried it myself aswell.

The problem is that if I change the tm/hm numbers I run against another wall and get errors coming from the "tmhm_learnset.h" file for which I haven't yet found a solution aswell.
There must be some file/change I'm missing cause otherwise it wouldn't screw up everything when you just change the ID of the TM/HM.
Before that everything runs smoothly...

 

[RadicalRadish]

you should look at DizzyEgg's item_expansion branch, as it already has gone through the trouble of doing basically all of the hard parts of this.

I just had the weirdest dejavu when I read your post x)

 

[fatherlyuncle]

As far as I can tell, that is not really the case. Egg seems to have defined the TMs 51 to 100, but that's it.
The actual data for the TMs is not present.

Speaking of which, I haven't seen it mentioned in this thread yet, but TMs 51 to 58 have the same Item ID number as the HMs 01 to 08, which shouldn't be the case as each item must have their own individual number ID, so you guys have to make sure to adjust those accordingly.

True, but he handled allocating the memory necessary, which they'd been having trouble with up til that point iirc.

Also, from what I've seen, it's set that way because there's no data included for the TMs 51-100. When I added 36 custom TMs the HMs wouldn't display in bag correctly until I set the item Ids equal to TMs 87-94.

 

[RadicalRadish]

True, but he handled allocating the memory necessary, which they'd been having trouble with up til that point iirc.

Also, from what I've seen, it's set that way because there's no data included for the TMs 51-100. When I added 36 custom TMs the HMs wouldn't display in bag correctly until I set the item Ids equal to TMs 87-94.

Thats interesting... so would they work correctly if I change all new TMs IDs (from 51 on upwards) starting with the ones from 87?
87 would be '568'
So I'd be going like this:

51 = 568
52 = 569
53 = 570
54 = 571
(and so on...)

EDIT: Now that I think about it... What I said doesn't make much sense... As there are other item ids after the tm block...

I tried giving TM51-100 IDs starting AFTER the last items but that didn't work either...

 

[RadicalRadish]

Well for now I'll put this problem away and work on some other stuff I wanted to do with my hack...I'll be returning to it once in a while and see if I can get it to work.

Really looking forward to a fix. It'd be so nice to have 100 TM instead of only 50.