[Scripting Question] Help with function code

[clawort]

I have this code for a move called Cyanide Spit. Aparently, the move is like Smack Down but instead of allowing the use of Ground-type moves on fliers, it allows the use of Poison-type moves on Steel-types.

Here's the WIP code:

Spoiler:

################################################################################
# Weakens Steel-type Pokemon, allowing Poison-type moves to deal normal damage. (Cyanide Spit)
################################################################################
class PokeBattle_Move_15A < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
ret=super(attacker,opponent,hitnum,alltargets,showanimation)
if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
opponent.effects[PBEffects::CyanideSpit]=true
showmsg=(opponent.pbHasType?(:STEEL))
end
@battle.pbDisplay(_INTL("{1} was weakened!",opponent.pbThis)) if showmsg
end
return ret
end
end

Any help please?

 

[Golisopod User]

What exactly do you need help with. Just look at how Smack Down works. Use Ctrl+Shift+F and look for Smack Down.

 

[clawort]

What exactly do you need help with. Just look at how Smack Down works. Use Ctrl+Shift+F and look for Smack Down.

Well, I keep getting Synax everytime and I need to know how on Earth I am supposed to make this code correct. I also don't want it to hit airborne Pokemon like Smack Down does.

 

[Marin]

I have this code for a move called Cyanide Spit. Aparently, the move is like Smack Down but instead of allowing the use of Ground-type moves on fliers, it allows the use of Poison-type moves on Steel-types.

Here's the WIP code:

Spoiler:

################################################################################
# Weakens Steel-type Pokemon, allowing Poison-type moves to deal normal damage. (Cyanide Spit)
################################################################################
class PokeBattle_Move_15A < PokeBattle_Move
def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
ret=super(attacker,opponent,hitnum,alltargets,showanimation)
if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
opponent.effects[PBEffects::CyanideSpit]=true
showmsg=(opponent.pbHasType?(:STEEL))
end
@battle.pbDisplay(_INTL("{1} was weakened!",opponent.pbThis)) if showmsg
end
return ret
end
end

Any help please?

Hi,

I've noticed you made a few coding-related posts recently, and would like you advise you to use the

 tags. That makes it much easier to read, as it will be properly indented.

 

[Turn20Negate]

Hey there,
Implementing this move shouldn't be that hard.
Let me help you. :)
First of all I guess you have something like this in your moves PBS file:

Spoiler:

XXX,CYANIDESPIT,CyanideSpit,ZZZ,50,DARK,Special,100,15,100,00,0,bef,"Spitting acid the user corrodes the target's steel plating, making them vulnerable to poison type attacks."

For you the "ZZZ" Should be a number, note it because we are going to need it.

Put this in PBEffects below "# These effects apply to a battler" (Look for the highest number then put this right below it):

Spoiler:

CyanideSpit        = YYY

"YYY" will be the highest number +1

Put this in PokeBattle_Battlers below "@effects[PBEffects::Yawn] = 0":

Spoiler:

@effects[PBEffects::CyanideSpit]             = false

Put this in PokeBattle_MoveEffects and Replace "ZZZ" with the number you noted:

Spoiler:

################################################################################
# Renders the target vulnerable to poison type damage if its steel type as long
# as it remains active.
################################################################################
class PokeBattle_Move_ZZZ < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
      opponent.effects[PBEffects::CyanideSpit]=true
      showmsg=opponent.pbHasType?(:STEEL)
      @battle.pbDisplay(_INTL("Acid melted through {1}'s steel plating!",opponent.pbThis)) if showmsg
    end
    return ret
  end
end

Now in PokeBattle_Move find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it:

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit] || @function==0xZZZ
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Replace "ZZZ" with the number you noted.

in PokeBattle_ZMove(only if you have Zmoves in your game) do basically the same(find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it):

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit]
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Now a little extra, if you want Pokemon hit by this move to also be susceptible to poisoning you may want to add these:

Spoiler:

in PokeBattle_BattlerEffects find and replace:

Spoiler:

This:

if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

With this:

if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && !@effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

Spoiler:

This:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

With this:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && !@effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

Spoiler:

And finally this:

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || pbHasType?(:STEEL)

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || (pbHasType?(:STEEL) && !@effects[PBEffects::CyanideSpit])

Here you go!
If you find any mistakes feel free to contact me. I didn't try out if the move works as intended so it could have some errors in its code.
Have a nice day .:)

 

[clawort]

Hey there,
Implementing this move shouldn't be that hard.
Let me help you. :)
First of all I guess you have something like this in your moves PBS file:

Spoiler:

XXX,CYANIDESPIT,CyanideSpit,ZZZ,50,POISON,Special,100,15,100,00,0,bef,"Spitting acid the user corrodes the target's steel plating, making them vulnerable to poison type attacks."

For you the "ZZZ" Should be a number, note it because we are going to need it.

Put this in PBEffects below "# These effects apply to a battler" (Look for the highest number then put this right below it):

Spoiler:

CyanideSpit        = YYY

"YYY" will be the highest number +1

Put this in PokeBattle_Battlers below "@effects[PBEffects::Yawn] = 0":

Spoiler:

@effects[PBEffects::CyanideSpit]             = false

Put this in PokeBattle_MoveEffects and Replace "ZZZ" with the number you noted:

Spoiler:

################################################################################
# Renders the target vulnerable to poison type damage if its steel type as long
# as it remains active.
################################################################################
class PokeBattle_Move_ZZZ < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
      opponent.effects[PBEffects::CyanideSpit]=true
      showmsg=(opponent.pbHasType?(:STEEL)
      @battle.pbDisplay(_INTL("Acid melted through {1}'s steel plating!",opponent.pbThis)) if showmsg
    end
    return ret
  end
end

Now in PokeBattle_Move find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it:

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit] || @function==0xZZZ
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Replace "ZZZ" with the number you noted.

in PokeBattle_ZMove(only if you have Zmoves in your game) do basically the same(find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it):

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit]
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Now a little extra, if you want Pokemon hit by this move to also be susceptible to poisoning you may want to add these:

Spoiler:

in PokeBattle_BattlerEffects find and replace:

Spoiler:

This:

if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

With this:

if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

Spoiler:

This:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

With this:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

Spoiler:

And finally this:

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || pbHasType?(:STEEL)

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])

Here you go!
If you find any mistakes feel free to contact me. I didn't try out if the move works as intended so it could have some errors in its code.
Have a nice day .:)

Okay!

 

[clawort]

Hey there,
Implementing this move shouldn't be that hard.
Let me help you. :)
First of all I guess you have something like this in your moves PBS file:

Spoiler:

XXX,CYANIDESPIT,CyanideSpit,ZZZ,50,POISON,Special,100,15,100,00,0,bef,"Spitting acid the user corrodes the target's steel plating, making them vulnerable to poison type attacks."

For you the "ZZZ" Should be a number, note it because we are going to need it.

Put this in PBEffects below "# These effects apply to a battler" (Look for the highest number then put this right below it):

Spoiler:

CyanideSpit        = YYY

"YYY" will be the highest number +1

Put this in PokeBattle_Battlers below "@effects[PBEffects::Yawn] = 0":

Spoiler:

@effects[PBEffects::CyanideSpit]             = false

Put this in PokeBattle_MoveEffects and Replace "ZZZ" with the number you noted:

Spoiler:

################################################################################
# Renders the target vulnerable to poison type damage if its steel type as long
# as it remains active.
################################################################################
class PokeBattle_Move_ZZZ < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
      opponent.effects[PBEffects::CyanideSpit]=true
      showmsg=(opponent.pbHasType?(:STEEL)
      @battle.pbDisplay(_INTL("Acid melted through {1}'s steel plating!",opponent.pbThis)) if showmsg
    end
    return ret
  end
end

Now in PokeBattle_Move find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it:

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit] || @function==0xZZZ
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Replace "ZZZ" with the number you noted.

in PokeBattle_ZMove(only if you have Zmoves in your game) do basically the same(find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it):

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit]
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Now a little extra, if you want Pokemon hit by this move to also be susceptible to poisoning you may want to add these:

Spoiler:

in PokeBattle_BattlerEffects find and replace:

Spoiler:

This:

if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

With this:

if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

Spoiler:

This:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

With this:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

Spoiler:

And finally this:

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || pbHasType?(:STEEL)

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])

Here you go!
If you find any mistakes feel free to contact me. I didn't try out if the move works as intended so it could have some errors in its code.
Have a nice day .:)

Oh! And Cyanide Spit is a Dark-type move. I forgot to tell you that! ^^,

 

[clawort]

Hey there,
Implementing this move shouldn't be that hard.
Let me help you. :)
First of all I guess you have something like this in your moves PBS file:

Spoiler:

XXX,CYANIDESPIT,CyanideSpit,ZZZ,50,POISON,Special,100,15,100,00,0,bef,"Spitting acid the user corrodes the target's steel plating, making them vulnerable to poison type attacks."

For you the "ZZZ" Should be a number, note it because we are going to need it.

Put this in PBEffects below "# These effects apply to a battler" (Look for the highest number then put this right below it):

Spoiler:

CyanideSpit        = YYY

"YYY" will be the highest number +1

Put this in PokeBattle_Battlers below "@effects[PBEffects::Yawn] = 0":

Spoiler:

@effects[PBEffects::CyanideSpit]             = false

Put this in PokeBattle_MoveEffects and Replace "ZZZ" with the number you noted:

Spoiler:

################################################################################
# Renders the target vulnerable to poison type damage if its steel type as long
# as it remains active.
################################################################################
class PokeBattle_Move_ZZZ < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute
      opponent.effects[PBEffects::CyanideSpit]=true
      showmsg=(opponent.pbHasType?(:STEEL)
      @battle.pbDisplay(_INTL("Acid melted through {1}'s steel plating!",opponent.pbThis)) if showmsg
    end
    return ret
  end
end

Now in PokeBattle_Move find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it:

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit] || @function==0xZZZ
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Replace "ZZZ" with the number you noted.

in PokeBattle_ZMove(only if you have Zmoves in your game) do basically the same(find "if opponent.effects[PBEffects::MiracleEye]" and place this right above it):

Spoiler:

# Cyanide Spit
    if opponent.effects[PBEffects::CyanideSpit]
      mod1=2 if isConst?(otype1,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
      mod2=2 if isConst?(otype2,PBTypes,:STEEL) && isConst?(atype,PBTypes,:POISON)
    end

Now a little extra, if you want Pokemon hit by this move to also be susceptible to poisoning you may want to add these:

Spoiler:

in PokeBattle_BattlerEffects find and replace:

Spoiler:

This:

if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

With this:

if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
      return false
    end

Spoiler:

This:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

With this:

def pbCanPoisonSynchronize?(opponent)
    return false if fainted?
    if (pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])) && !hasWorkingItem(:RINGTARGET)
      @battle.pbDisplay(_INTL("{1}'s {2} had no effect on {3}!",
         opponent.pbThis,PBAbilities.getName(opponent.ability),pbThis(true)))
      return false
    end

Spoiler:

And finally this:

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || pbHasType?(:STEEL)

def pbCanPoisonSpikes?(moldbreaker=false)
    return false if fainted?
    return false if self.status!=0
    return false if pbHasType?(:POISON) || (pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])

Here you go!
If you find any mistakes feel free to contact me. I didn't try out if the move works as intended so it could have some errors in its code.
Have a nice day .:)

I got Syntax. There is an error.

 

[Turn20Negate]

Hey again,
Can you send me the error message?

EDIT: Ok, it was my bad. I located the mistake in the PokeBattle_Move part, in this line:

Spoiler:

showmsg=[COLOR="Red"]([/COLOR]opponent.pbHasType?(:STEEL)

Remove the red parentheses then it should work out

Additionally I went over the script again and noticed that these parts in the PokeBattle_BattlerEffects were also wrong:

Spoiler:

It should have been:

(pbHasType?(:STEEL) && [COLOR="Red"]![/COLOR]@effects[PBEffects::CyanideSpit])

Instead of:

(pbHasType?(:STEEL) && @effects[PBEffects::CyanideSpit])

This has to be changed three times.

Sorry for my inconvenience and I hope it works now.
Also edited my original. :)