[Other✓] Pokeemerald-expansion with Day-Night cycle

[L3onix]

Hi guys! 👋
I wanted to implement the day/night cycle in my rom, so I wanted to ask for help but above all if it would be possible to merge Pokeemerald-expansion with the day-night cycle of Sierra ( Or any Day Night Cycle, I have no preference).
In the last 6 hours I've tried everything to no avail, also thanks to my total inability to use GitHub 🥲
If someone could help me(or even a simple no: is too difficult / not feasible) I would be very grateful!
Thanks in advance

 

[Lunos]

Hi guys! ������
I wanted to implement the day/night cycle in my rom, so I wanted to ask for help but above all if it would be possible to merge Pokeemerald-expansion with the day-night cycle of Sierra ( Or any Day Night Cycle, I have no preference).
In the last 6 hours I've tried everything to no avail, also thanks to my total inability to use GitHub ������
If someone could help me(or even a simple no: is too difficult / not feasible) I would be very grateful!
Thanks in advance

Yes, it's perfectly possible. It's all code built on top of the same base (Pokeemerald) at the end of the day, and the expansion touches none of the functions and arrays that Sierra's DN system modifies.
Is it difficult to merge? Well, that depends on how used you are to merging Git branches and how good you are at reading and understanding code.
Sierra's system, uses a rather limiting implementation of time-based encounters which requires her own special fork of Porymap too.
But you can deal with that by removing all the relevant code and if you really want time-based encounters, you can reimplement them differently.
There's one way to go about it posted in the Simple Modifications Directory iirc.
Another one would be to add new wild encounter tabels. Copies of the wild, surf, and such tables but for day, afternoon, night or w/e.

If what you want is an easier alternative, there's Xhyzi/Samu's.

EDIT: I feel it's relevant to mention for any potential future readers that ShinyDragonHunter aka Josh decided to make an up-to-date branch containing Sierra's DN system.
Unlike the original, it doesn't have time-based wild encounters, and like Sierra's, it's not properly compatible with dynamic overworld palettes though.
https://github.com/pret/pokeemerald/compare/master...ShinyDragonHunter:pokeemerald:DayNight

 

[L3onix]

Today after a few attempts I managed to merge them, tysm!