This happens when you battle yourself and you have the same pokemon against each other. The battle system can't tell which is which because there is no unique identifier for them.
I tried again with two different saves that had different players and different pokemon, and it worked this time, the "bag" button opens the pokemon screen, and the "pokemon" button opens the bag screen.
I did however get this error on the loser's screen
---------------------------
Pokémon Combustion
---------------------------
Exception: NameError
Message: uninitialized constant PokeBattle_OnlineBattle::ONLINEGAINMONEY
PokeBattle_OnlineBattle(PEO):3168:in `pbEndOfBattle'
PokeBattle_OnlineBattle(PEO):2155:in `pbStartBattleCore'
PokeBattle_OnlineBattle(PEO):1940:in `pbStartBattle'
Connect/Register/Login(PEO):468:in `start_battle'
Connect/Register/Login(PEO):448:in `check_battle'
Connect/Register/Login(PEO):82:in `handle'
Connect/Register/Login(PEO):62:in `update'
Connect/Register/Login(PEO):45:in `main'
Connect/Register/Login(PEO):43:in `loop'
Connect/Register/Login(PEO):50:in `main'
This exception was logged in ./errorlog.txt.
Press Ctrl+C to copy this message to the clipboard.
---------------------------
OK
---------------------------
Also, I beat the player on the left, and then it still asked what I wanted to do, even though there was no target, then I attacked, it said there was no target, then I lost on the left screen, and got the same error.
"image removed"
Some things I noticed are:
When you press X, it exits out of the server menu and when you try to log back in, it says the account is already logged into.
There is no saving before logging in, after trading, or after battling, which could result in multiplication of pokemon, although I'm sure it's a simple fix.
The music isn't battle music, it's the music of whatever building you're in.
To battle or trade, you had to type the other person's name on both screens, there was no popup sending a request, only one saying you accepted eachother's requests.
Since I was in debug mode I could hold ctrl and press "run" and treat it as a win, therefor both screens were wins.
It logs you out after a trade, then when you try to relog it says you're already logged in.
I've got some suggestions as well:
Adding a configurable music for the server menu
Maybe making it have more than one scene for pokecenter second floor use(Although this is just aesthetics and isn't really necessary)
A GTS
Battle music
Popups for trade and battle requests, or like an inbox system to keep track of them
A configurable music for trades
Make it keep your login after a trade
Pressing X on the main screen logs you out
some sort of wifi plaza
https://bulbapedia.bulbagarden.net/wiki/Wi-Fi_Plaza
Double battles between 2 people
double battles between 4 people
Forced signout when game crashes/ person quits
Maybe some sort of pal pad to have a list of your friends and be able to look at their trainer card, along with the recording, if they added one.
The ability to specify your location (Country, City, State)
The ability to trade triple triad cards
Dream World Features
https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon_Dream_World
Underground features
https://bulbapedia.bulbagarden.net/wiki/The_Underground
The ability to save your username and password to local variables so you don't need to constantly log in after quitting the game.
Multiple game support, IE if someone were to make two separate games that would be able to connect, but would have different player sprites.
An online pokemon storage system. (Separate from GTS)
Some sort of player vs player Duel (
https://pokemonessentials.wikia.com/wiki/Mini-games#Duel)
Other than those things, your scripts are amazing.
Thank you for this amazing multiplayer system :t192: