Scripting: PokeBattle_MoveEffects

[mewt_90]

Hello,
recently I downloaded the latest version of "Pokemon Essentials XP" and I tried to insert new move effects. Unfortunately, they didn't work because when tried to test them, simply NOTHING happend in the game. The idea was a move that should change the user's attack to 3 (150%) and I mean exactly 3! No matter which stage it had before.

Here is the code I wrote down in PokeBattle_MoveEffects:

Spoiler:

class PokeBattle_Move_126 < PokeBattle_Move
def pbEffect(attacker,opponent)

@battle.pbAnimation(@id,attacker,nil)
@battle.pbCommonAnimation("StatUp",attacker,nil)

attacker.stages[PBStats::SPEED]=3

@battle.pbDisplay(_INTL("{1}'s Attack sharply rose!",attacker.pbThis))
end
end

What could be the reason for this?

 

[Maruno]

That code looks fine in principle. What you mean by "nothing happened" is up for debate - did the move otherwise execute normally but there was no message/stat up animation/stat change, or did the game freeze, or was that move skipped over?

All I can guess, from what information you've provided, is that you haven't given the move that function code in moves.txt. Well, that or you didn't return 0 at the end of the def (it's probably important to do so). I'm sure you're comparing your code to PokeBattle_Move_01F, which is similar.

Perhaps you should improve your code by checking the Speed stage before the change, and either stat up, stat down (drastically/sharply/normally for both) or do nothing depending on the value.

 

[mewt_90]

The move was just skipped over. There was neither an animation a stat-up nor a text.
I've implemented "return 0" but still there is no change.

Here is the move I tried out:

Spoiler:

560,TRANSFORMATION,Transformation,126,0,NORMAL,Status,100,30,0,40,1,,Smart,"Testing"

 

[Maruno]

When adding your own function codes, start with PokeBattle_Move_133, because Shadow moves use up 126-132. You should do this even if you don't use Shadow moves, because they're already defined.

I used exactly your code (albeit with code 133), and it worked for me. I don't know why it isn't for you.

 

[mewt_90]

I've tried it again with different numbers and now it works fine! Thanks ;)

Another question: The window of the Essential Kit is pretty huge. How can I change the window size and i do not mean the screenwidth! I searched for some hints in the script but i didn't find any. The window size should just be a smaller one so the the graphic is more defined.

 

[Maruno]

I'm not sure what you mean. If you mean the zoom factor to make it overall smaller (and less pixellated), that setting is right next to the screen size settings in the scripts. It's the difference between 480x320 and 240x160.

If you meant something else, please clarify.