It depends. Shiny Pokemon are very rare, but a shiny Legendary would be more valuable than a shiny Bidoof. Also, some people collect them, but others don't care about them at all. Who you're trading with, and which shiny you're talking about is really what matters. If you're looking to trade a legit shiny, I'm sure you can find some people who would trade something good for it.