SOLVED [pokeemerald-expansion] HELP! - make rom error

[c.a.i.o.v.]

Hello!

I am deep into learning how to make changes using the pokeemerald-expansion decomp.

After some changes to the early game, I thought it would be good to "make" rom and test if I was going in the right direction.
I had some problems trying to make the rom, but was able to move past them after reviewing everything edited and correcting some mistakes in the code. However, I don't know how to deal with the following error:



I tried to find the solution everywhere, but did not find anyone commenting about this.

The "map_group_count.h" file don't even exist in the master branch, so I am lost.

Things I changed during editing:
- Created new route east of Oldale Town (Using Porymap, following all instructions)
- Added 1 trainer to the route (had an error about this when compiling, but moved past it)
- Added some wild encounters to the route
- Added some berries to it.

I have absolutely no experience coding (besides this one, of course).

Can someone help me?

Thanks!

 

[Lunos]

The "map_group_count.h" file don't even exist in the master branch

For reference, that file is generated by mapjson at the time of building a ROM as a part of the code related to the debug menu. That's why it's not included by default.
I imagine that if the file hasn't been built on your end, something might be stopping mapjson from generating it.
Have you tried a make clean and a make yet? Just make, no -j or extra arguments.
If there's 1 or more errors in your project that for X or Y reason haven't popped up until now, doing that would uncover them.

 

[c.a.i.o.v.]

For reference, that file is generated by mapjson at the time of building a ROM as a part of the code related to the debug menu. That's why it's not included by default.
I imagine that if the file hasn't been built on your end, something might be stopping mapjson from generating it.
Have you tried a make clean and a make yet? Just make, no -j or extra arguments.
If there's 1 or more errors in your project that for X or Y reason haven't popped up until now, doing that would uncover them.

So, I was able to PARTIALLY figure it out yesterday.


It seems the map_group_count.h isn't being generated because all maps on data>maps has their headers and events files erased after I opened the project using porymap. But I don't know why that happens.
I download a clean version of the pokeemerald repository, did not create any new maps, just messed with some route 1 encounters, and then tried to make the rom. It worked.

Now, when I go to the github online pokeemerald-expansion repository, the data>maps folders don't have headers and events files.
But when I download it, these files come together.

New maps I made with porymap did not come with these files.
Not only that, but simple fact of using porymap to create a new map, delete these files (headers and events) from the original maps' folders.

It is very weird, and I don't know how to fully solve this problem. I am kinda locked of using porymap.

Do you have any idea about it?

 

[Lunos]

I download a clean version of the pokeemerald repository, did not create any new maps, just messed with some route 1 encounters, and then tried to make the rom. It worked.

Now, when I go to the github online pokeemerald-expansion repository, the data>maps folders don't have headers and events files.
But when I download it, these files come together.

New maps I made with porymap did not come with these files.
Not only that, but simple fact of using porymap to create a new map, delete these files (headers and events) from the original maps' folders.

I'm not entirely sure what do you mean here.
When you download (as in git clone[I])[/I] the Pokeemerald-expansion there are no extra files in any of the maps' folders. What you see on GitHub is exactly what you get.
New files are generated as a part of the building-a-ROM process. Those files are built from scratch by the different tools the project uses.

That aside, I just cloned a fresh copy of the expansion, and to my surprise I got the exact same error you got about missing a data/map_group_count.h file.
This is most likely related to a problem in the project that has to be solved by its mantainers.
To solve it manually just make an empty copy of src/data/map_group_count.h, throw a make clean on your terminal and then make,
The project will build normally after that. I made a small change to Littleroot Town and a new map connected to it, and all that worked with no issues.


Also, as a side note and a clarification, when you need to delete a map you gotta do a bit more than just delete its files.
Check out the Pokeemerald wiki article on how to delete a map for more info.

 

[c.a.i.o.v.]

I'm not entirely sure what do you mean here.
When you download (as in git clone[I])[/I] the Pokeemerald-expansion there are no extra files in any of the maps' folders. What you see on GitHub is exactly what you get.
New files are generated as a part of the building-a-ROM process. Those files are built from scratch by the different tools the project uses.

That aside, I just cloned a fresh copy of the expansion, and to my surprise I got the exact same error you got about missing a data/map_group_count.h file.
This is most likely related to a problem in the project that has to be solved by its mantainers.
To solve it manually just make an empty copy of src/data/map_group_count.h, throw a make clean on your terminal and then make,
The project will build normally after that. I made a small change to Littleroot Town and a new map connected to it, and all that worked with no issues.
View attachment 167836

Also, as a side note and a clarification, when you need to delete a map you gotta do a bit more than just delete its files.
Check out the Pokeemerald wiki article on how to delete a map for more info.

Thank you Lunos, my fellow South American friend ;)

I just have to figure it out how to make this empty copy, I tried that on my first day and wasn't not successful. But it is relieving that it might not be a problem on my procedure. I was clueless as to why it was happening.

Gracias!

 

[Lunos]

I just have to figure it out how to make this empty copy,

If you're on Windows just go to the relevant folder and then right click -> New -> Text Document.