Tell me why my offensive team is bad.

[myrrh25]

Electrode Lead@Focus Sash
Timid, 252 Speed, 252 Sp Atk.
Ability: Static - Has a 30% chance to paralyze physical attackers.
Taunt
Swagger
Thunder Wave
Thunderbolt
Role: I use Elec-chode as a suicide lead. He taunts Stealth Rock away for the rest of my team then sets a Swagger.

Scizor Sweeper @Choice Band
Adamant, 252 Atk, 252 Speed.
Ability: Technician - Boosts moves with 60 base power or less by 50%.
Bullet Punch
U-Turn
Aerial Ace
Brick Break
Role: I use Scizor as my scouter mainly, and revenge killer when necessary.

Metagross Sweeper @Leftovers
Adamant, 252 Atk, 252 Speed.
Ability: Clear Body - Prevents stat loss.
Agility
Meteor Mash
Earthquake
Ice Punch
Role: Put him in on any predictable switch-out then use Agility on that turn, proceed to sweep.

Yanmega Late-Game Sweeper @Shell Bell
Modest, 252 Sp Atk, 252 Speed
Ability: Speed Boost - Speed is boosted one stage every turn.
Protect
Hidden Power [Ground]
Air Slash
Bug Buzz
Role: Undoubtedly my most reliable sweeper. Speed boost lets it outrun choice scarfers after a turn or two. Protect the first turn in unless I know the opponent is a Subber. Attract was recently switched for Hidden Power Ground.

Jirachi The Calm @Leftovers
Timid, 252 Speed, 252 HP
Ability: Serene Grace - Secondary effect chances are doubled.
Substitute
Calm Mind
Psychic
Thunderbolt
Role: My mid-game sweeper. Substitute, then Calm Mind until ready to attack.

Cresselia Wall @Leftovers
Bold, 252 Def, 252 HP
Ability: Levitate - Immune to Ground moves.
Toxic
Calm Mind
Psychic
Recover
Role: Wall. Toxic the opponent, then Calm Mind and Recover. Psychic is for when I need to do damage.

 

[Ninja Caterpie]

Because Electrode lead sucks. It doesn't do anything and doesn't belong anywhere except on Rain Dance teams where it can Dance and blow up.

Yours doesn't do either.

I dunno what to suggest here, because your whole team is going to need a revamp. 4 Fire weak and not one resist kinda means any Fire type (ie. Heatran, Infernape) can just come in and kill pretty much the whole team. The latter outspeeds everyone, too.

Oh, and one last thing, you lack SR. Stealth Rocks really helps offensive teams to net extra KOs and wear away walls if they switch around, so get a lead that can set it up, rather than just stop it being set up.

 

[Blueknight]

you have a HUGE fire weakness!!!

Electrode is used for rain teams, and it's a pretty bad Pokemon. If you want someone who can taunt, and set up stealth rocks (which electrode can't do) Replace Electrode with Azlef or Aerodactyl. Aero is the fastest you'll most likely see anyway.

Aerodactyl @Focus Sash
252 ATK, 252 Spd/ Jolly Nature
-Stealth Rock
-Taunt
-Earthquake
-Rock Slide

Replace Aerial ace with persuit on scizor. Otherwise Rotom walls it.

Never use shell bell, especially on yanmega. It depends on you to attack, and whenever you protect, you only get 1HP. :/ And yanmega needs to be replaced.

your cresselia is bad. Any dark type (like tyranitar) can switch into that set and ruin all your calm minds. Cresselia also can't learn recover, it's stuck with moonlight.

You need to replace cresselia with a water type like Vaporeon. It can wish pass to your team and it dosn't give you a huge fire weakness. It does a decent job at walling too.

Vaporeon @Leftovers
188 HP, 252 Def, 68 Spd/Bold Nature
-Surf
-Ice Beam
-Wish
-Protect

 

[aragornbird]

~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~

Holy crap, you have 4 Pokemon weak to Fire and none that resist it!
Heatran destroys your team, especially Substitute versions.

ELECTRODE

Electrode is a terrible lead in OU and you should never use Swagger. If you do, you are basically helping your opponent win. Confusion is very unreliable and wears off quickly. In many cases, the opponent will successfully attack without ever hurting themselves in confusion. Also, confusion is easily cured by switching out.

SCIZOR

CB Scizor should never have Max Speed. It's not a sweeper, it's a revenge-killer/scouter like you said. It needs lots of HP EVs so it can switch in, take a hit, and do its job. Use 248 HP / 252 Atk / 8 Spd instead.

Aerial Ace is a terrible move for Scizor. Even though it gains a Technician boost, Aerial Ace provides no sort of type coverage against Scizor's counters (who are mainly Steel and Electric Pokemon, types which resist Flying).

YANMA

Don't use Shell Bell. It's a bad item because it only works if you damage the opponent. But if you don't use a damaging move or you are prevented from attacking, then it doesn't do anything. As a healing item, Leftovers is always better because Leftovers always restores health no matter what you do.
However, Yanmega is to frail to use Leftovers effectively, so Life Orb is a better choice.

CRESSELIA

Cresselia can't learn Recover. If it did, it would probably be used more.

The rest of your sets are pretty standard.
Now it's time to fix the team:

First, get rid of Electrode. An offensive team really needs the benefit of Stealth Rock, but Electrode can't learn it. Use Aerodactyl, the next fastest Taunter.

Aerodactyl @Focus Sash
Pressure
Jolly Nature
4 HP / 252 Atk / 252 Spd

-Earthquake
-Stone Edge
-Taunt
-Stealth Rock

Next, get rid of Yanmega. There is no reason why Yanmega and Scizor should be on the same time. They are both walled by Zapdos. Since you have such a bad Fire weakness, get a Fire resist:

Starmie @Life Orb
Natural Cure
Timid Nature
4 HP / 252 SAtk / 252 Spd

-Surf
-Thunderbolt
-Ice Beam
-Recover

You'll find that Starmie is a better special sweeper than Yanmega.

Finally, get rid of Cresselia. It just isn't that good. It's completely walled by Steel types, Taunt shuts it down, and so does Trick. Furthermore, these is an OFFENSIVE team. Walls do NOT belong on an offensive team. A mixed sweeper is important for this team since it prevents you from being walled by either Special or Physical walls.

Dragonite @Life Orb
Rash/Mild Nature
116 Atk / 192 SpA / 200 Spd

-Superpower
-Flamethrower
-Draco Meteor
-Roost/Thunderbolt

~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~*~

 

[Exothermic]

What the people above me have said are correct, change Electrode to something else. xD

And I would suggest this set to replace your current Jirachi set.

Jirachi @ Leftovers
Jolly nature
EVs: 44 HP/212 Atk/252 Speed

- Iron Head
- Fire Punch
- Toxic
- Substitute

Stall breaker, annoyer, whatever. xD This set runs very easily and relies on the concept that anything that enjoys Iron head hates Toxic. Anythng that enjoys Iron head and Toxic will hate Fire punch. When you send this pokemon in for a revenge kill, either using Fire punch or Iron head; the first thing that comes to your opponent's mind is Scarf Jirachi. Now, they will send in a Scizor, Lucario or Swampert, depending on whether you used Iron head or Fire punch earlier. Now, you can take them down, surprise! :3 What I like about this is that it counters lead Machamps perfectly. They dynamic punch on the first turn and you switch into Cresselia, now they will payback and you switch into Jirachi. Iron head and then switch out. Now, it is in KO range from Starmie's thunderbolt. The 44 HP Evs ensure that you survive against a max Attack Focus punch from Breloom. I hope this helped. ^^

 

[Heart's Soul]

Replace Recover off Cresselia with Moonlight. I have my Cresselia as offensive, and it works great!

 

[Kylie-chan]

The main problem I see when I give this team a cursory glance is that you don't really have an effective way to deal with Fire-types like Infernape (which is faster than everything you have and tears through) and Heatran. You can Hidden Power Ground it with Yanmega, but Substitute and/or Shuca Berry Heatran will tear through. Metagross can't switch into Heatran either. If you use Dragonite (aragornbird's advice is very sound here), you can play around, but you can't switch in all day and Heatran often carries Dragon Pulse. Basically, you don't have any good switches and have to sacrifice something every time it comes in / predict it perfectly, and if the player is smart they can outplay you with it. Yanmega loses horribly to the extremely common Stealth Rock and you don't have a way to deal with that, so I suggest ditching it for a Water-type. aragornbird's suggested Life Orb Starmie, or alternatively Dragon Dance Kingdra / Dragon Dance Gyarados (maybe with Taunt, to help you break stall against the likes of Skarmory and set up on Blissey) would work well. I understand you may not want to get rid of it, but I believe a Water would help your team a lot.

Three Steels is really unnecessary nowadays and you're just compounding your Swords Dance Lucario issues. Lucario can nab a Swords Dance and wreck your team, especially if Stealth Rock is up and Dragonite has been weakened. Starmie is too frail to tank an ExtremeSpeed. That is partly why I suggested Gyarados, as it can Intimidate Lucario and chase it out until it dies. Faster threats will generally give you problems, so you could try a physical Scarf Jirachi instead of your Sub Calm Mind Jirachi set to revenge things:

Jirachi @ Choice Scarf
4 HP / 252 Atk / 252 Spe
Jolly
- Iron Head
- Fire Punch
- Ice Punch
- U-turn / Trick / ThunderPunch

Scizor is just redundant with Metagross and Jirachi in my opinion. If you want to keep SubCM Jirachi, you could try replacing it with something else. I can see Jolteon putting you in a tight spot as well, and Jirachi can weaken it, as can Metagross, but Meta will lose a lot of health in the process and Jolteon will just switch out in anticipation of Earthquake... something to keep in mind.

Good luck!