Trainer Card Flipping: N00b Problem

[BlackWaltz3]

Hey all,
As you can probably guess from the topic title, I'm having a n00b problem with some coding. Now, I'm not uninitiated with coding, being a student of programming presently at university, but RGSS remains 99% unfamiliar to me. All I've worked with is Pascal and C.

As such, I figured that with the need to eventually script some major stuff for my game, it'd be best to start small, so I followed the suggestions of many more experienced coders and began work on modifying the Trainer Card script.

My aim was to implement a feature such that when one has the Trainer Card open, pressing the A button (i.e. the Z key) would show a separate screen for the badges, along with their titles (and maybe more, if I have room). Once there, one would simply press B (i.e. Esc or X) to return to the original screen.

So I made a duplicate of the pbStartScene and pbDrawTrainerCardFront defs, naming them pbBadgeScene and pbDrawTrainerCardBack respectively, and started modifying it to show my new graphics instead. I also mucked around with the text a bit to be doubly sure it was drawing correctly.

So with all that done, I went to try it out in game. Did it work? Nope.avi. The Trainer Card stayed as is, and I noticed that trying to quit that caused it to do so without the usual fade effect. In addition, hitting C (i.e. Enter, C, Space) after having hit A cause the fade to occur, but leave the Trainer Card graphics up until one quit the Pause Menu itself.

Figuring I must have coded the button press thingy wrong, I simply took the calls and stuck them in directly after pbStartScene and pbTrainerCard in the PokemonTrainerCard class. Surely they would run then, if not at button press. Nope.avi.

This time, after exiting the TrainerCard normally, my graphic was finally there. But, like the dodgy regular Card from before, it didn't actually do anything (not even return to the original card) and was effectively just plastered on top of the Pause Menu.

I'm at a loss to understand what I'm doing wrong. I chucked in some Message Windows to track how far through my code it goes, but none of them show up. Can someone please educate me? I've included the relevant code below for reference. Blue indicated additions, while maroon indicates modifications.

Spoiler:

[COLOR=Navy]#CHANGED to include following 52 lines of code; 2353 HOURS 23 JUL 2012

  def pbBadgeScene
    @sprites={}
    @viewport=Viewport.new(0,0,Graphics.width,Graphics.height)
    @viewport.z=99999
    background=pbResolveBitmap(sprintf("Graphics/Pictures/trainercardbgf"))
    if $Trainer.gender==1 && background
      addBackgroundPlane(@sprites,"bg","trainercardbgf",@viewport)
    else
      addBackgroundPlane(@sprites,"bg","trainercardbg",@viewport)
    end
    [COLOR=DarkRed]cardexists=pbResolveBitmap(sprintf("Graphics/Pictures/trainercardbackf"))[/COLOR]
    @sprites["card"]=IconSprite.new(0,0,@viewport)
    if $Trainer.gender==1 && cardexists[COLOR=DarkRed]
      @sprites["card"].setBitmap("Graphics/Pictures/trainercardbackf")[/COLOR]
    else[COLOR=DarkRed]
      @sprites["card"].setBitmap("Graphics/Pictures/trainercardback")[/COLOR]
    end
    @sprites["overlay"]=BitmapSprite.new(Graphics.width,Graphics.height,@viewport)
    pbSetSystemFont(@sprites["overlay"].bitmap)
    pbDrawTrainerCardBack
    pbFadeInAndShow(@sprites) { update }
    [COLOR=DarkRed]
    Kernel.pbMessage(_INTL("BadgeScene ran correctly."))[/COLOR]
  end
    
  def pbDrawTrainerCardBack
    overlay=@sprites["overlay"].bitmap
    overlay.clear
    baseColor=Color.new(72,72,72)
    shadowColor=Color.new(160,160,160)
    textPositions=[
      [COLOR=DarkRed] [_INTL("Test Badge"),34,64,0,baseColor,shadowColor],
       [_INTL("[/COLOR][/COLOR][COLOR=DarkRed]Test Badge[/COLOR][COLOR=DarkRed]"),332,64,0,baseColor,shadowColor],
       [_INTL("[/COLOR][COLOR=DarkRed]Test Badge[/COLOR][COLOR=DarkRed]"),34,112,0,baseColor,shadowColor],
       [_INTL("[/COLOR][COLOR=DarkRed]Test Badge[/COLOR][COLOR=DarkRed]"),34,160,0,baseColor,shadowColor],
       [_INTL("[/COLOR][COLOR=DarkRed]Test Badge[/COLOR][COLOR=DarkRed]"),34,208,0,baseColor,shadowColor],
       [_INTL("[/COLOR][COLOR=DarkRed]Test Badge[/COLOR][COLOR=Navy][COLOR=DarkRed]"),34,256,0,baseColor,shadowColor],[/COLOR]
    ]
    pbDrawTextPositions(overlay,textPositions)
    x=72
    region=pbGetCurrentRegion(0) # Get the current region
    imagePositions=[]
    for i in 0...8
      if $Trainer.badges[i+region*8]
        imagePositions.push(["Graphics/Pictures/badges",x,310,i*32,region*32,32,32])
      end
      x+=48
    end
    pbDrawImagePositions(overlay,imagePositions)
    [COLOR=DarkRed]
    Kernel.pbMessage(_INTL("DrawTrainerCardBack ran correctly."))[/COLOR]
  end
  
  def pbBadgeCard
    loop do
      Graphics.update
      Input.update
      self.update
      if Input.trigger?(Input::B)
        break
      end
    end 
  end  
  
#END CHANGE[/COLOR]
  
  def pbTrainerCard
    loop do
      Graphics.update
      Input.update
      self.update
      if Input.trigger?(Input::B)
        break
      end
[COLOR=DarkRed]#      if Input.trigger?(Input::A) #CHANGED to include Input::C trigger + 9 lines; 0104 HOURS 24 JUL 2012
#            
#        @scene.pbBadgeScene
#        @scene.pbBadgeCard
#    
#        Kernel.pbMessage(_INTL("BadgeCard call ran correctly."))
#      end       [/COLOR]
    end 
  end

  def pbEndScene
    pbFadeOutAndHide(@sprites) { update }
    pbDisposeSpriteHash(@sprites)
    @viewport.dispose
  end
end



class PokemonTrainerCard
  def initialize(scene)
    @scene=scene
  end

  def pbStartScreen
    @scene.pbStartScene
    @scene.pbTrainerCard
    @scene.pbEndScene
[COLOR=DarkRed]#    @scene.pbBadgeScene
#    @scene.pbBadgeCard
#    @scene.pbEndScene[/COLOR]
  end
end

TL;DR Holy crap I type a lot.
Cheers, Jim.

 

[FL]

Take a look in: https://www.pokecommunity.com/threads/282535

 

[BlackWaltz3]

I've tried everything in that thread. I've put code in a dozen different places, I've deleted the whole damn thing and started again... I don't know what else to do. Obviously I'm doing something wrong, otherwise something would have changed by now. But no, at every stage it just keeps doing the exact same thing. I'm just gonna give up here, and abandon the idea. Thanks anyway.

 

[FL]

When you are with problems in any script, put a 'p "test 1" ', 'p "test 2" ', 'p "test 3" '... between every line to know where you code are stopping.

Use:

 def pbStartScreen
    @scene.pbStartScene
    @scene.pbTrainerCard
    @scene.pbEndScene
  end

In pbTrainerCard and pbBadgeCard put a button to cancel (break) and other to:

pbDisposeSpriteHash(@sprites)
@viewport.dispose
@scene.pbBadgeScene
@scene.pbBadgeCard
break

In pbBadgeCard, instead of call pbBadgeScene and pbBadgeCard, calls pbStartScene and pbTrainerCard.

 

[BlackWaltz3]

So let me get this straight, in regards to that second part... Lets say the Trainer Card loop is Loop A, and the Badge Card loop is Loop B. They are both identical, save for the fact that Loop A closes the A procedures while starting the B loop, while Loop B closes the B procedures while starting the A loop.

Thus rather than having a Superloop which initiates a Subloop (as I had above), it is two equal loops that self-terminate and alternate functioning until Input::B? Alright, I'll give it a shot and append my results later.

EDIT: I tried that, and it didn't work. It just functions as if it were pbEndScene, sans the slow fade out from pbFadeOutAndHide. I put in some of those p things to see where my code got to, as follows:

        pbDisposeSpriteHash(@sprites)
        @viewport.dispose
        p "test1"
        @scene.pbBadgeScene
        @scene.pbBadgeCard
        p "test2"
        break

and it only shows test1. I figure something must be preventing it from reaching test2. Something in trying to execute this code causes it to successfully dispose the scene and display test1, but then cease before executing the subsequent calls. This is frustrating me more than the time my programming teacher gave us the trick question of making a "readstring" function in C.

 

[FL]

I found it! In pbBadgeCard and pbTrainerCard change '@scene.pbBadgeScene' to 'pbBadgeScene', '@scene.pbBadgeCard' to 'pbBadgeCard', '@scene.pbStartScene' to 'pbStartScene' and '@scene.pbTrainerCard ' to 'pbTrainerCard'.

 

[TACHAN]

I go a lot of time trying to put a Trainer Card as in Pokemon's games, but I do not know do like that works.

It would be a good idea a tutorial of this.

 

[BlackWaltz3]

FL, you are a godsend. It had been driving me mad trying to understand why it wasn't working, and it all came down to that. Thank you for your help and your patience. Now, to figure out a non-linear algorithm that will plot my badges to fit the new graphic...

 

[FL]

I go a lot of time trying to put a Trainer Card as in Pokemon's games, but I do not know do like that works.

It would be a good idea a tutorial of this.

Trainer Card is a basic Essentials scene example, but is possible to make a even more basic Essential scene to better understand.

To understand Essentials scenes, first try to understand RPG Maker XP scenes, there are several tutorial on web.

 

[FL]

I made a tutorial of how to do simple scenes in Essentials: https://www.pokecommunity.com/threads/286554