Trainers with Multiple Pokemon Refuse to Send Them Out?

[Boeing747]

I'm not quite sure what I did, but in my game, any trainer with two or more Pokemon refuses to send any of them out after I defeat one of them. I don't know which script affects this, and I have no clue how to fix this.

Wild battles and Trainers with only one Pokemon work just fine, but other battles are broken. Also, the Pokemon's sprite lingers after it has fainted, which probably is connected to the problem.

 

[mej71]

What all have you edited in your scripts?

 

[Boeing747]

I've edited:

Compiler (to extend Pokemon names to 12 characters)
PokemonPokedex
PokeBattle_Move
TypesExtra
PokeBattle_Pokemon

I haven't edited Pokebattle_AI, so I don't see why the battles are working the way they are right now. I can't show what I mean since I haven't hit 15 posts yet, so that doesn't help.

 

[Boeing747]

Bump; I really can't go around with the trainers broken in my game.

 

[Radical Raptr]

try a stock essentials and make sure it works, then one by one add in your new codes and keep testing afyer each one until you find the one that breaks it

 

[Boeing747]

What could possibly have caused this? I must have broken something, but which script would affect this?

(BOSS BUS has no backsprite yet, so that's not the problem.

PBWeather

begin
  class PBWeather
    SUNNYDAY  = 1
    RAINDANCE = 2
    SANDSTORM = 3
    HAIL      = 4
    LIGHTNING = 5
    FOG       = 6
    TORNADO   = 7
  end

PBTypesExtra

Spoiler:

 def PBTypes.isSpecialType?(type)
    return PBTypes.loadTypeData()[1].include?(type)
  end

  def PBTypes.getEffectiveness(attackType,opponentType)
    return PBTypes.loadTypeData()[2][attackType*(PBTypes.maxValue+1)+opponentType]
  end

  def PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2=nil)
    if opponentType2==nil || opponentType3==nil
      return PBTypes.getEffectiveness(attackType,opponentType1)*2
    elsif
      opponentType3==nil
      mod1=PBTypes.getEffectiveness(attackType,opponentType1)
      mod2=(opponentType1==opponentType2) ? 2 : PBTypes.getEffectiveness(attackType,opponentType2)
      return (mod1*mod2)
    else
      mod1=PBTypes.getEffectiveness(attackType,opponentType1)
      mod2=(opponentType1==opponentType2) ? 2 : PBTypes.getEffectiveness(attackType,opponentType2)
      mod3=(opponentType2==opponentType3) ? 2 : PBTypes.getEffectiveness(attackType,opponentType3)
      return(mod1*mod2*mod3)
    end
    end
  def PBTypes.isNotVeryEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e=PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e>0 && e<4
  end

  def PBTypes.isNormalEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e=PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==4
  end

  def PBTypes.isIneffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e=PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e==0
  end

  def PBTypes.isSuperEffective?(attackType,opponentType1,opponentType2=nil,opponentType3=nil)
    e=PBTypes.getCombinedEffectiveness(attackType,opponentType1,opponentType2,opponentType3)
    return e>4
  end
end

PokemonSummary

Spoiler:

  elsif pokemon.gender==1
      textpos.push([_INTL("♀"),178,62,0,Color.new(248,56,32),Color.new(224,152,144)])
    end
    pbDrawTextPositions(overlay,textpos)
    drawMarkings(overlay,15,291,72,20,pokemon.markings)
    type1rect=Rect.new(0,pokemon.type1*28,64,28)
    type2rect=Rect.new(0,pokemon.type2*28,64,28)
    type3rect=Rect.new(0,pokemon.type3*28,64,28)
    if pokemon.type1==pokemon.type2 || pokemon.type1==pokemon.type3
      overlay.blt(402,146,@typebitmap.bitmap,type1rect)
    elsif pokemon.type2==pokemon.type3
      overlay.blt(370,146,@typebitmap.bitmap,type1rect)
      overlay.blt(436,146,@typebitmap.bitmap,type2rect)
    else
      overlay.blt(304,146,@typebitmap.bitmap,type1rect)
      overlay.blt(370,146,@typebitmap.bitmap,type2rect)
      overlay.blt(435,146,@typebitmap.bitmap,type3rect)
    end
    if pokemon.level<PBExperience::MAXLEVEL
      overlay.fill_rect(362,372,(pokemon.exp-startexp)*128/(endexp-startexp),2,Color.new(72,120,160))
      overlay.fill_rect(362,374,(pokemon.exp-startexp)*128/(endexp-startexp),4,Color.new(24,144,248))
    end
  end

PokeBattle_MoveEffects

Spoiler:

class PokeBattle_Move_134 < PokeBattle_Move
  def pbBaseDamage(basedmg,attacker,opponent)
    if opponent.status==PBStatuses::BURN &&
       opponent.effects[PBEffects::Substitute]==0
      return basedmg*2
    end
    return basedmg
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if opponent.damagestate.calcdamage>0 && !opponent.damagestate.substitute && 
       opponent.status==PBStatuses::BURN
      opponent.status=0
      @battle.pbDisplay(_INTL("{1} was cured of its burn.",opponent.pbThis))
    end
    return ret
  end
end

class PokeBattle_Move_133 < PokeBattle_Move
  def pbTwoTurnAttack(attacker)
    @immediate=false
    if !@immediate && isConst?(attacker.item,PBItems,:POWERHERB)
      itemname=PBItems.getName(attacker.item)
      @immediate=true
      attacker.pokemon.itemRecycle=attacker.item
      attacker.pokemon.itemInitial=0 if attacker.pokemon.itemInitial==attacker.item
      attacker.item=0
      @battle.pbDisplay(_INTL("{1} consumed its {2}!",attacker.pbThis,itemname))
    end
    return false if @immediate
    return attacker.effects[PBEffects::TwoTurnAttack]==0
  end

  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if @immediate || attacker.effects[PBEffects::TwoTurnAttack]>0
      pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation) # Placeholder for charging Common anim
      @battle.pbDisplay(_INTL("{1} is revving up!",attacker.pbThis))
    end
    return 0 if attacker.effects[PBEffects::TwoTurnAttack]>0
    return super
  end
end

PokeBattle_Pokemon

Spoiler:

################################################################################
# Types
################################################################################
# Returns whether this Pokémon has the specified type.
  def hasType?(type)
    if type.is_a?(String) || type.is_a?(Symbol)
      return isConst?(self.type1,PBTypes,type) || isConst?(self.type2,PBTypes,type) ||isConst?(self.type3,PBTypes,type)
    else
      return self.type1==type || self.type2==type || self.type3==type
    end
  end

# Returns this Pokémon's first type.
  def type1
    dexdata=pbOpenDexData
    pbDexDataOffset(dexdata,@species,8)
    ret=dexdata.fgetb
    dexdata.close
    return ret
  end

# Returns this Pokémon's second type.
  def type2
    dexdata=pbOpenDexData
    pbDexDataOffset(dexdata,@species,9)
    ret=dexdata.fgetb
    dexdata.close
    return ret
  end

  def type3
    dexdata=pbOpenDexData
    pbDexDataOffset(dexdata,@species,9.5)
    ret=dexdata.fgetb
    dexdata.close
    return ret
  end

PokeBattle_Battler

  attr_reader :totalhp
  attr_reader :fainted
  attr_reader :usingsubmove
  attr_accessor :lastAttacker
  attr_accessor :turncount
  attr_accessor :effects
  attr_accessor :species
  attr_accessor :type1
  attr_accessor :type2
  attr_accessor :type3
  attr_accessor :ability

  def pbInitBlank
    @name         = ""
    @species      = 0
    @level        = 0
    @hp           = 0
    @totalhp      = 0
    @gender       = 0
    @ability      = 0
    @type1        = 0
    @type2        = 0
    @type3        = 0

  end

  def pbUpdate(fullchange=false)
    if @pokemon
      @pokemon.calcStats
      @level     = @pokemon.level
      @hp        = @pokemon.hp
      @totalhp   = @pokemon.totalhp
      if !@effects[PBEffects::Transform]
        @attack    = @pokemon.attack
        @defense   = @pokemon.defense
        @speed     = @pokemon.speed
        @spatk     = @pokemon.spatk
        @spdef     = @pokemon.spdef
        if fullchange
          @ability = @pokemon.ability
          @type1   = @pokemon.type1
          @type2   = @pokemon.type2
          @type3   = @pokemon.type3
        end
      end
    end

  def pbHasType?(type)
    if type.is_a?(Symbol) || type.is_a?(String)
      ret=isConst?(self.type1,PBTypes,type.to_sym) ||
         isConst?(self.type2,PBTypes,type.to_sym) ||
         isConst?(self.type3,PBTypes,type.to_sym)
      return ret
    else
      return (self.type1==type||self.type2==type||self.type3==type)
    end

PokeBattle_Move

Spoiler:

################################################################################
# This move's type effectiveness
################################################################################
  def pbTypeModifier(type,attacker,opponent)
    return 4 if type<0
    return 4 if isConst?(type,PBTypes,:GROUND) && opponent.pbHasType?(:FLYING) &&
                isConst?(opponent.item,PBItems,:IRONBALL)
    atype=type # attack type
    otype1=opponent.type1
    otype2=opponent.type2
    otype3=opponent.type3
    if isConst?(otype1,PBTypes,:FLYING) && opponent.effects[PBEffects::Roost]
      if isConst?(otype2,PBTypes,:FLYING)
        if isConst?(otype3,PBTypes,:FLYING)
        otype1=getConst(PBTypes,:NORMAL) || 0
      else
        otype1=otype2
      end
    end
    if isConst?(otype2,PBTypes,:FLYING) && opponent.effects[PBEffects::Roost]
      otype2=otype1
    end
    if isConst?(otype3,PBTypes,:FLYING) && opponent.effects[PBEffects::Roost]
      otype3=otype2
    end
    end
    mod1=PBTypes.getEffectiveness(atype,otype1)
    mod2=(otype1==otype2) ? 2 : PBTypes.getEffectiveness(atype,otype2)
    mod3=(otype2==otype3) ? 2 : PBTypes.getEffectiveness(atype,otype3)
    if isConst?(opponent.item,PBItems,:RINGTARGET)
      mod1=2 if mod1==0
      mod2=2 if mod2==0
      mod3=2 if mod3==0
    end
    if isConst?(attacker.ability,PBAbilities,:SCRAPPY) ||
      opponent.effects[PBEffects::Foresight]
      mod1=2 if isConst?(otype1,PBTypes,:GHOST) &&
        (isConst?(atype,PBTypes,:NORMAL) || isConst?(atype,PBTypes,:FIGHTING))
      mod2=2 if isConst?(otype2,PBTypes,:GHOST) &&
        (isConst?(atype,PBTypes,:NORMAL) || isConst?(atype,PBTypes,:FIGHTING))
      mod3=2 if isConst?(otype3,PBTypes,:GHOST) &&
        (isConst?(atype,PBTypes,:NORMAL) || isConst?(atype,PBTypes,:FIGHTING))
    end
    if opponent.effects[PBEffects::Ingrain] ||
       opponent.effects[PBEffects::SmackDown] ||
       attacker.pbOwnSide.effects[PBEffects::Gravity]>0 ||
       attacker.pbOpposingSide.effects[PBEffects::Gravity]>0
      mod1=2 if isConst?(otype1,PBTypes,:FLYING) && isConst?(atype,PBTypes,:GROUND)
      mod2=2 if isConst?(otype2,PBTypes,:FLYING) && isConst?(atype,PBTypes,:GROUND)
      mod3=2 if isConst?(otype3,PBTypes,:FLYING) && isConst?(atype,PBTypes,:GROUND)
    end
    if opponent.effects[PBEffects::MiracleEye]
      mod1=2 if isConst?(otype1,PBTypes,:DARK) && isConst?(atype,PBTypes,:PSYCHIC)
      mod2=2 if isConst?(otype2,PBTypes,:DARK) && isConst?(atype,PBTypes,:PSYCHIC)
      mod3=2 if isConst?(otype3,PBTypes,:DARK) && isConst?(atype,PBTypes,:PSYCHIC)
    end
    return mod1*mod2
  end

PokeBattle_Battle

Spoiler:

      # Stealth Rock
      if pkmn.pbOwnSide.effects[PBEffects::StealthRock]
        if !isConst?(pkmn.ability,PBAbilities,:MAGICGUARD)
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.type3)
          if eff>0
            @scene.pbDamageAnimation(pkmn,0)
            pkmn.pbReduceHP([(pkmn.totalhp*eff/32).floor,1].max)
            pbDisplayPaused(_INTL("{1} was hurt by stealth rocks!",pkmn.pbThis))
          end
        end
      end

 end
    if isConst?(target.ability,PBAbilities,:CURSEDBODY) && self.pbRandom(10)<3
      if user.effects[PBEffects::Disable]<=0 && move.pp>0 && user.hp>0
        user.effects[PBEffects::Disable]=4
        user.effects[PBEffects::DisableMove]=move.id
        pbDisplay(_INTL("{1}'s {2} disabled {3}!",target.pbThis,
           PBAbilities.getName(target.ability),user.pbThis(true)))
      end
    end
    type=move.pbType(move.type,user,target)
    if isConst?(target.ability,PBAbilities,:COLORCHANGE) && target.hp>0 &&
       damage>0 && !PBTypes.isPseudoType?(type) && !target.pbHasType?(type)
      target.type1=type
      target.type2=type
      target.type3=type
      pbDisplay(_INTL("{1}'s {2} made it the {3} type!",target.pbThis,
         PBAbilities.getName(target.ability),PBTypes.getName(type)))
    end
    user.pbAbilityCureCheck
    target.pbAbilityCureCheck
    # Synchronize here
    s=@synchronize[0]
    t=@synchronize[1]
#   PBDebug.log("[synchronize:

 

[Nickalooose]

Try commenting out all the type3 things in PokeBattle_? or remove them.

 

[Boeing747]

I most likely did something wrong in the AI...

def pbTypeModifier(type,attacker,opponent)
    return 4 if type<0
    return 4 if isConst?(type,PBTypes,:GROUND) && opponent.pbHasType?(:FLYING) &&
                isConst?(opponent.item,PBItems,:IRONBALL)
    atype=type
    otype1=opponent.type1
    otype2=opponent.type2
    otype3=opponent.type3
    if isConst?(otype1,PBTypes,:FLYING) && opponent.effects[PBEffects::Roost]
      if isConst?(otype2,PBTypes,:FLYING)
        otype1=getConst(PBTypes,:NORMAL) || 0
      else
        otype1=otype2
      end
    end
    if isConst?(otype2,PBTypes,:FLYING) && opponent.effects[PBEffects::Roost]
      otype2=otype1
    end
    mod1=PBTypes.getEffectiveness(atype,otype1)
    mod2=(otype1==otype2) ? 2 : PBTypes.getEffectiveness(atype,otype2)
    if isConst?(attacker.ability,PBAbilities,:SCRAPPY) || opponent.effects[PBEffects::Foresight]
      mod1=2 if isConst?(otype1,PBTypes,:GHOST) &&
         (isConst?(atype,PBTypes,:NORMAL) || isConst?(atype,PBTypes,:FIGHTING))
      mod2=2 if isConst?(otype2,PBTypes,:GHOST) &&
         (isConst?(atype,PBTypes,:NORMAL) || isConst?(atype,PBTypes,:FIGHTING))
    end
    if opponent.effects[PBEffects::MiracleEye]
      mod1=2 if isConst?(otype1,PBTypes,:DARK) && isConst?(atype,PBTypes,:PSYCHIC)
      mod2=2 if isConst?(otype2,PBTypes,:DARK) && isConst?(atype,PBTypes,:PSYCHIC)
    end
    return mod1*mod2
  end

  def pbTypeModifier2(battlerThis,battlerOther)
    if battlerThis.type1==battlerThis.type2
      return 4*pbTypeModifier(battlerThis.type1,battlerThis,battlerOther)
    else
      ret=pbTypeModifier(battlerThis.type1,battlerThis,battlerOther)
      ret*=pbTypeModifier(battlerThis.type2,battlerThis,battlerOther)
      return ret # 0,1,2,4,8,_16_,32,64,128,256
    end
  end

  def pbRoughStat(battler,stat)
    stagemul=[10,10,10,10,10,10,10,15,20,25,30,35,40]
    stagediv=[40,35,30,25,20,15,10,10,10,10,10,10,10]
    stage=battler.stages[stat]
    value=0
    value=battler.attack if stat==PBStats::ATTACK
    value=battler.defense if stat==PBStats::DEFENSE
    value=battler.speed if stat==PBStats::SPEED
    value=battler.spatk if stat==PBStats::SPATK
    value=battler.spdef if stat==PBStats::SPDEF
    return (value*stagemul[stage]/stagediv[stage]).floor
  end

 

[Ratty524]

Don't know if it's been brought up, but have you made sure you specified how many Pokemon a trainer has in the PBS file Trainers.txt?

 

[Boeing747]

Yes, I have; however, the trainer battles still malfunction even if the proper number of Pokemon is given in the .txt.

 

[Nickalooose]

try a stock essentials and make sure it works, then one by one add in your new codes and keep testing afyer each one until you find the one that breaks it

Enough said really... If you're going to totally ignore advice, stop asking for help!
P.S. Why would you edit Pokemon AI? In all my time of Essentials and scripting, I have never edited the AI!

 

[Boeing747]

Enough said really... If you're going to totally ignore advice, stop asking for help!
P.S. Why would you edit Pokemon AI? In all my time of Essentials and scripting, I have never edited the AI!

I just need the right scripts to look in. The AI has a section on type matchups, so I needed to adjust some of that to create support for 3-type Pokemon.

 

[Nickalooose]

That's still not going to happen, you're pin pointing the AI, then remove your scripts... Why are you making this so hard...? Until you remove your scripts and slowly add your custom ones, you're not going to know where the problem is, because we didn't add any scripts, you did.