[v17.2] Get scripts to check variable

[Chdonga]

I'm trying to make a difficulty mode that uses a variable. Since global switches will always be seen as false according to the wiki.

This is the outcome I want:

Battle:

• If variable 14 = 2, Set battle style
• If variable 14 = 1, Switch battle style, but it won't tell you the opponent's next Pokemon.
• If variable 14 = 0, normal Switch battle style.

Storage:

• If variable 14 = 2, Pokemon won't be healed when you place them in a box, and something you just caught won't get healed when it gets sent to storage.
• If variable 14 != 2, then it's a normal storage system.

These are the changes I've made to the scripts (highlighted):

PokeBattle_Battle

Spoiler:

Line 1242

if [S-HIGHLIGHT]!$game_variables[014]==2[/S-HIGHLIGHT] && firstbattlerhp>0 && @opponent &&
              @internalbattle && pbCanChooseNonActive?(0) && pbIsOpposing?(index) &&
              @battlers[0].effects[PBEffects::Outrage]==0
[S-HIGHLIGHT]          if $game_variables[014]==1
            pbDisplayPaused(_INTL("{1} is about to send in a new Pokémon.",opponent.fullname,pbParty(index)[newenemyname].name))[/S-HIGHLIGHT]
        else
[S-HIGHLIGHT]          if $game_variables[014]==0[/S-HIGHLIGHT]
            pbDisplayPaused(_INTL("{1} is about to send in {2}.",opponent.fullname,pbParty(index)[newenemyname].name))
            if pbDisplayConfirm(_INTL("Will {1} change Pokémon?",self.pbPlayer.name))
              newpoke=pbSwitchPlayer(0,true,true)
              if newpoke>=0
                newpokename=newpoke
                if isConst?(@party1[newpoke].ability,PBAbilities,:ILLUSION)
                  newpokename=pbGetLastPokeInTeam(0)
                end
                pbDisplayBrief(_INTL("{1}, that's enough! Come back!",@battlers[0].name))
                pbRecallAndReplace(0,newpoke,newpokename)
                switched.push(0)
              end
            end
          end
[S-HIGHLIGHT]          end
          end[/S-HIGHLIGHT]

Pokemon_Storage

Spoiler:

Line 186

     pkmn = self[boxSrc,indexSrc]
      if !pkmn
        raise "Trying to copy nil to storage"
      end
[S-HIGHLIGHT]      if $game_variables[014]= 2 #Don't Heal Boxed Mons
        pkmn.heal
      end      [/S-HIGHLIGHT]
      pkmn.formTime = nil if pkmn.respond_to?("formTime") && pkmn.formTime 
      self[boxDst,indexDst] = pkmn
    end
    return true
  end

Line 206

def pbMoveCaughtToBox(pkmn,box)
    for i in 0...maxPokemon(box)
      if self[box,i]==nil
        if box>=0
[S-HIGHLIGHT]      if $game_variables[014] = 2  #Don't Heal Boxed Mons
        pkmn.heal
        end[/S-HIGHLIGHT]
          pkmn.formTime = nil if pkmn.respond_to?("formTime") && pkmn.formTime
        end
        self[box,i] = pkmn
        return true
      end
    end
    return false
  end

PScreen_PokemonStorage

Spoiler:

Line 1729

   if box>=0
[S-HIGHLIGHT]      if $game_variables[014] = 2  #Don't Heal Boxed Mons
        @heldpkmn.heal
        end[/S-HIGHLIGHT]
      @heldpkmn.formTime = nil if @heldpkmn.respond_to?("formTime") && @heldpkmn.formTime
    end
    @scene.pbPlace(selected,@heldpkmn)
    @storage[box,index] = @heldpkmn
    if box==-1
      @storage.party.compact!
    end
    @scene.pbRefresh
    @heldpkmn = nil
  end

Line 1759

    if box>=0
[S-HIGHLIGHT]      if $game_variables[014] = 2 #Don't Heal Boxed Mons
        @heldpkmn.heal
        end[/S-HIGHLIGHT]
      @heldpkmn.formTime = nil if @heldpkmn.respond_to?("formTime") && @heldpkmn.formTime
    end

It doesn't seem to matter what I change the value to. It doesn't seem to matter if I change it to "if... == 2" or "if... = 2". The game always treats the value like it's set to 2. And I'm not that sadistic. How do I fix this?

 

[Ego13]

first thing you need to know: if you want o compare a variable with somethin you use

==

So saying

if $game_variables[014]==1

means: "If the variable number 14 is equa to 1"
While

if $game_variables[014]=1

means: "if you set variable number 14 to 1" which will always result in this condition to be considered true.

Next thing to know: If you want to check if a variable is not euqal to something you use

!=

So saying

if $game_variables[014]!=2

means: "If the variable number 14 is not equal to 2"
while

if !$game_variables[014]==2

means: "if you invert "game variable number 14 is equal to 2""
See the exclamation mark at the beginning is a negation. So if you put it like in your code and $game_variables[014] is not equal to 2 then it would return true and therefore execute this code

 

[Chdonga]

I made those changes but now it only acts as if the value is 0. Should I add a "return" anywhere in the code? I don't quite understand its purpose but I see it used in a lot of "if" functions.

 

[Vendily]

I made those changes but now it only acts as if the value is 0. Should I add a "return" anywhere in the code? I don't quite understand its purpose but I see it used in a lot of "if" functions.

Okay, I think the issue here is because of the 014 for the variable number. The reason? Ruby interprets it as an octal number, specifically 12. You aren't checking variable 14, but rather the value of variable 12, which is the reason for the strange results.

You can try it for your sell by putting p 014 in a script command.

 

[Chdonga]

Okay, I think the issue here is because of the 014 for the variable number. The reason? Ruby interprets it as an octal number, specifically 12. You aren't checking variable 14, but rather the value of variable 12, which is the reason for the strange results.

You can try it for your sell by putting p 014 in a script command.

Well, I changed it to "if $game_variables[14]" and now everything works. Funny how an unnecessary zero can cause everything to screw up.

So the extra zero must've caused it to be read as an octal number. Would that mean "if $game_variables[000]" would look for variable -1?

 

[Vendily]

Would that mean "if $game_variables[000]" would look for variable -1?

0 is 0 regardless of base. Also, using a negative index causes it to add the length of the array, so it would return the value of variable 100. Variable 0 is unused, I think.