Script: Visible Overworld Wild Encounter

[derFischae]

It's not me who got the error, it's people on my discord who got it. I may have an idea where the error can be located, it may be in the perma anim thing. But since someone else tried to reproduce the same bug and was unsuccessful... Maybe the people who reported this bug used something to modify the data of game, I don't know. And I'm sorry if I can't give you more details, since people who got the bug didn't give me enough details about it. Also I don't think I can load a ES V21 plugin in a ES V20.1 game...

Do you use any other visible overworld wild encounter addons that are important to mention? Do you use the automatic spawning addon? Do you use fog on the map where the error occured? Or any other important Pokemon Essentials plugins?

And if you or your testers run into that error again and find any other idea what was going on the map before the crash, then let me know.

 

[derFischae]

You got it right. A wild battle event does also lose it's marks when being caught, so maybe I was wrong with calling out this plugin specifically. At this point I have no idea what's causing my issue, honestly.

I would guess, that the creator of the Improved Mementos plugin forgot to include the new saving routines for marks in wild battles that get triggered with the method wildbattle.start (in placed overworld events).

 

[derFischae]

Hello there! I have an error which i think that where it comes.

So i will give you as much detailed info as i can provide.


Where the error appeared?

I was on an outside map, ex: Route 1, and i was in battle using boons phenomena, in other words, a phenomenon grass encounters. When i run away from battle option, when the game was about "leaving/transiting" from the battle scene into the outside map, this error appeared, i was using the normal way to test my fan game and not using the debug mode, which it could be useful for this, but the error only appears at random and its hard to recreate it again.


I'm still using PEv20.1, i know that you may not give any support since thats PEv21 is out there, or if you can point me into the right direction, maybe my helper can help me fix it, currently we are both "blinded" about this.

Another thing, the map has a parallel process with this.

Sorry to bother you with that and thx for your time.

Spoiler:

View attachment 155689

Spoiler:

View attachment 155690

Spoiler:

View attachment 155691

Do you use any other addons in your fangame, such as automatic spawning? Please let me know about all your plugins and visible overworld wild encounter addons that are important to mention.

 

[mynameisumbreon]

Do you use any other addons in your fangame, such as automatic spawning? Please let me know about all your plugins and visible overworld wild encounter addons that are important to mention.

this is my list of plugins. I don't think any of them are affecting overworld encounters, but I could be wrong. I am also not using any overworld encounter addons at this time. Maybe I should be?

 

[derFischae]

View attachment 156100 this is my list of plugins. I don't think any of them are affecting overworld encounters, but I could be wrong. I am also not using any overworld encounter addons at this time. Maybe I should be?

Thank you for letting me know. You should test the following now:

1. Remove all plugins from your project, except for the Improved Mementos plugin and all plugins it requires.
2. Then place an event on the map that starts a wild battle when triggered.
3. Start your playtest, run into that event and test if the marks remain after battle.

If the pokemon loses its marks in this setting, then it is proven that the Improved Mementos plugin does not handle wild battles by its own. In that situation, you should contact the creator of the Improved Mementos plugin.

If the pokemon does not lose its marks, then we definitely know, that some of your used plugins override the Improved Mementos plugins handle of wild battles. In that case you can test the following:

1. Start with all of your plugins in your project.
2. Choose one project and remove it from your project.
3. Playtest with a handmade event as above.

If the pokemon does not keep its marks, then choose the next plugin to remove and redo the steps until the pokemon does not lose its marks anymore. The last chosen and removed plugin will be the problem maker.

 

[mynameisumbreon]

Thank you for letting me know. You should test the following now:

1. Remove all plugins from your project, except for the Improved Mementos plugin and all plugins it requires.
2. Then place an event on the map that starts a wild battle when triggered.
3. Start your playtest, run into that event and test if the marks remain after battle.

If the pokemon loses its marks in this setting, then it is proven that the Improved Mementos plugin does not handle wild battles by its own. In that situation, you should contact the creator of the Improved Mementos plugin.

If the pokemon does not lose its marks, then we definitely know, that some of your used plugins override the Improved Mementos plugins handle of wild battles. In that case you can test the following:

1. Start with all of your plugins in your project.
2. Choose one project and remove it from your project.
3. Playtest with a handmade event as above.

If the pokemon does not keep its marks, then choose the next plugin to remove and redo the steps until the pokemon does not lose its marks anymore. The last chosen and removed plugin will be the problem maker.

I'm sorry if I'm wasting your time, but I genuinely still have no idea what I could have done. I think I may have added then removed a plugin at some point and that may be what is causing issues. I went through and tested with a fresh essentials folder, added plugins, and everything worked just fine. I really don't know where to go from here. Again, I'm sorry if I've wasted your time.

 

[Richard PT]

Do you use any other addons in your fangame, such as automatic spawning? Please let me know about all your plugins and visible overworld wild encounter addons that are important to mention.

My bad, i forgot to mention that in case you needed, here's the full list for the visible overworld encounters plugins that i use --> Visible Overworld Wild Encounters + Additional Despawn Methods + Aggressive Encounters + Automatic Spawning + Different Spawn And Normal Encounters + Different Spawn And Normal Encounters + Ditto Transform + Overworld Lavender Town Ghosts.

 

[derFischae]

There is a critical bug that needs to be fixed as soon as possible with Additional Animations - Overworld Encounters Add On 1.4 for ES V20.1.
When you save in front of a shiny and reset the game (not with f12), the next shiny that will try to appear or trying again with the same shiny will send this error:

People can get past the titles screen but once they get to the screen to load their save, loading their save give this error.

I have good news for you.

I managed to reproduce your error and updated the "Additional Animations-Add On" to version 1.5. You can find it in the github repository now. Please, try it out and tell me if you get any errors.

It seems that the "Additional Animations - Add On" and the "Remove Poke Events On Load Save Transfer - Add On" were not totally compatible to each other. I would assume now, that you use both add-ons in your project, even though you did not mention it before. Please tell me, if that's correct.

 

[derFischae]

My bad, i forgot to mention that in case you needed, here's the full list for the visible overworld encounters plugins that i use --> Visible Overworld Wild Encounters + Additional Despawn Methods + Aggressive Encounters + Automatic Spawning + Different Spawn And Normal Encounters + Different Spawn And Normal Encounters + Ditto Transform + Overworld Lavender Town Ghosts.

Unfortunately, I still cannot reproduce your error.

However, I updated the additional animations add-on. Please download the newest version 1.5 and add it to your project. Maybe this removes your error. Please let me know.

Can you also post the whole error message with the whole backtrace and not just the first line. i would help me a lot.

 

[Richard PT]

Well, i only have the error that way, sorry. I tried to recreate the error, but its too hard and difficult. And i use PEv20.1 and i don't plan to update it anymore, so if i update your plugins, they eventualy could crash, i think.

 

[CelestialFearow]

I have good news for you.

I managed to reproduce your error and updated the "Additional Animations-Add On" to version 1.5. You can find it in the github repository now. Please, try it out and tell me if you get any errors.

It seems that the "Additional Animations - Add On" and the "Remove Poke Events On Load Save Transfer - Add On" were not totally compatible to each other. I would assume now, that you use both add-ons in your project, even though you did not mention it before. Please tell me, if that's correct.

Sorry for the late answer... I will check this update when I can. And to answer your questions, I don't use "Remove Poke Events On Load Save Transfer - Add On". I use "Additional Despawn Methods - Overworld Encounters Add On"

 

[derFischae]

Well, i only have the error that way, sorry. I tried to recreate the error, but its too hard and difficult. And i use PEv20.1 and i don't plan to update it anymore, so if i update your plugins, they eventualy could crash, i think.

The visible overworld wild encounters plugin and all its add-on are for Pokemon Essential v20.1. Moreover, all update of these add-ons - even the ones in the future - are designed to work in Pokemon essentials v20.1. At least as long as there is no Pokemon Essentials version 22. So, there is no need to worry about downloading an updated add-on.

 

[derFischae]

There is a way for the encounters to move only on the grass, and another thing, to be able to modify the priority of the encounters since if the player's head passes at the same time the encounter is above the player's head.I have the following Bug in version 1.6 for 16.2.
Attached video of the BUG

Thank you for reporting the bug. Indeed, Pokemon essentials version 16.2 has problems with sprite layers. This is not an error in the overworld encounters script. This error has been removed in pokemon essentials version 17. To remove this bug, you must unfortunately update your pokemon essentials version.

 

[kingdomharms]

Someone playing my game got this crash. The game is running on Essentials v21.1. It looks like the script tried spawning a Pokemon while a dialogue box was active? I'm not sure. In all my time playtesting I've never had an issue with this plugin and I can't replicate it so I'm a bit stumped.

Screenshot below spoiler.

Spoiler:

 

[systeromen_]

Someone playing my game got this crash. The game is running on Essentials v21.1. It looks like the script tried spawning a Pokemon while a dialogue box was active? I'm not sure. In all my time playtesting I've never had an issue with this plugin and I can't replicate it so I'm a bit stumped.

Screenshot below spoiler.

Spoiler:

Errors like this occur when an event is being added to the map while the map interpreter is running. So if a Pokemon is spawning, and the game is checking over the list of events within the map.

 

[riomarco]

Is this plugin work with a dexnav system?(On some other fangame with no overworld encounter, there's a dexnav system who forced next encounter to be a specific pokemon on that area, ro help with shiny hunt i think). I wonder if it is possible to have the same system with this plugin enabled. And also, i guess with this plugin enabled, repel item didn't work huh? I tried using repel but i can still can fight overworld pokemon

 

[viniciusan9elin]

hey, is there any way to make pokemons use different sprites when they appear in water? I found a resource with pokemon sprites in water and I would really like to be able to use it with this plugin, oh and I'm using the version for essentials v21.1

 

[UnOvA7]

Hey, big fan of the script and it's working fine. However does anyone know how to turn up the frequency? It takes ages for Pokémon to spawn and if they do it's mostly just one per grass batch

 

[derFischae]

Is this plugin work with a dexnav system?(On some other fangame with no overworld encounter, there's a dexnav system who forced next encounter to be a specific pokemon on that area, ro help with shiny hunt i think). I wonder if it is possible to have the same system with this plugin enabled.

Basically it is possible to make scripts for non overworld encounters work with this visible overworld wild encounters plugin.
There are instructions on how to modify code/plugins and addons for ordinary pokemon encounters to make them work with this plugin. You can find that instructions in the main post of your version of this plugin. See https://www.pokecommunity.com/threads/visible-overworld-wild-encounter.429019/post-10509636 for Pokemon Essentials Version 21.1.

Moreover, there is already an addon that helps with shiny hunting. The code of that script is added below. It is called "Let's Go Shiny Hunting" and was originally written for Pokemon Essentials Version 18. So I'm not sure if it still works with Pokemon Essentials 21. Maybe this script can do what you are looking for. And even if this code does not the same as your suggested Dexnav System does, or even if it is outdated, you can use it to see how to modify the code of your Dexnav System to make it work with overworld spawning encounters.
Here is the code of "Let's Go Shiny Hunting"

Spoiler:

#===============================================================================
# The Let's Go Shiny Hunting, inpired by Diego Mertens script
# - to make a chained pokemon shiny
#===============================================================================

# This is an add-on for the visible overworld wild encounter script.
# It adds shiny hunting by chaining a pokemon species to the script.
# This script is motified by Diego Mertens Lets's Go Catch Combo, see
# https://www.pokecommunity.com/showthread.php?p=10011513

# FEATURES INCLUDED:
# If you catch the same species in a row, then you increase the chance of
# spawning a shiny of that species.

# INSTALLATION:
# Copy this code and
# Paste it at the bottom of your visible wild overworld encounter script.

# PROPERTIES:
# You can choose how many encounters you have to catch to obtain the increased
# Shiny-Chance in parameter
#     CHAINLENGTH
# and the increased Shiny-Chance in parameter
#     SHINYPROBABILITY
# in the settings below.

# REMARK:
# If you want that killing instead of chaining has the effect on spawning shinies then replace "result == 4"
# at the bottom of the shiny chining script by "result==1".
# And If you want that killing and chaining also that effect then replace "result == 4" by "(result==1 || result == 4)".

#===============================================================================
# Settings
#===============================================================================
CHAINLENGTH      = 1 # default 10
#       number describes how many pokemon of the same species
#       you have to catch in a row to increase shiny propability

SHINYPROBABILITY = 10 # default 100 --> 10%
#       increasing this value decreases the probability of spawning a shiny

#===============================================================================
# adding a new instance variable to $PokemonTemp in script PField_Metadata to
# remember which pokemon and how many of that kind were caught in a row
#===============================================================================
class PokemonTemp
  attr_accessor :catchcombo # [chain length, species]
end

#===============================================================================
# adding a new event handler on pokemon create to make pokemon shiny on spawning
# and in instant battles if the chain is long enough
#===============================================================================
Events.onWildPokemonCreate+=proc {|sender,e|
  if !$PokemonGlobal.battlingSpawnedPokemon
    pokemon=e[0]
    next if pokemon.nil?
    $PokemonTemp.catchcombo=[0,0] if !$PokemonTemp.catchcombo
    if ($PokemonTemp.catchcombo[0]>=CHAINLENGTH && $PokemonTemp.catchcombo[1]==pokemon.species)
      if rand(SHINYPROBABILITY)<$PokemonTemp.catchcombo[0]
        pokemon.makeShiny
      end
    end
  end
}

#===============================================================================
# adding a new event handler on Battle end to update the catchchain (where the
# pokemon-catch-chain is saved)
#===============================================================================
Events.onWildBattleEnd+=proc {|sender,e|
   species=e[0]
   result=e[2]
   $PokemonTemp.catchcombo = [0,0] if !$PokemonTemp.catchcombo
   if $PokemonTemp.catchcombo[1]!=species
     $PokemonTemp.catchcombo=[0,species]
   end
   if result==4 && species==$PokemonTemp.catchcombo[1]
     $PokemonTemp.catchcombo[0]+=1
   end
}

 

[derFischae]

And also, i guess with this plugin enabled, repel item didn't work huh? I tried using repel but i can still can fight overworld pokemon

This plugin works with repels as intended. With the visible overword wild encouters plugin, repels prevent pokemon from spawning, as long as there is no reason why a pokemon should still encounter (for example the level of the spawning pokemon is higher than the first pokemon of the player). However, you can still fight already spawned pokemon while repels are active, since repels only prevent pokemon from spawning and do not prevent the player from running into a pokemon.

If repels do not work that way with the visible overworld wild encounters plugin then please inform us (for example with a short gif).