[Scripting Question] Would anyone know how to upgrade this script to v18.1? Please

[MessiDuvidoso]

This is a script that changes the character's sprite depending on the Pokémon present in your team when using surf.

Spoiler:

module Settings
SharpedoSurfFileName = [
"boy_surf_sharpedo", # Player A
"girl_surf_sharpedo", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

module Settings
GyaradosSurfFileName = [
"boy_surf_gyarados", # Player A
"girl_surf_gyarados", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end


def pbHasSpeciesWithMove?(species, move)
move=getID(PBMoves,move)
return nil if !move || move<=0
if species.is_a?(String) || species.is_a?(Symbol)
species=getID(PBSpecies,species)
end
for pokemon in $Trainer.party
next if pokemon.isEgg?
return true if pokemon.species==species && pokemon.hasMove?(move)
end
return false
end

def Kernel.pbUpdateVehicle
meta=pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
if meta
if $PokemonGlobal.diving
$game_player.character_name=pbGetPlayerCharset(meta,5) # Diving graphic
elsif $PokemonGlobal.surfing
###############################################################################
#Player Has A GYARADOS in Surf #
###############################################################################
if pbHasSpeciesWithMove?(:GYARADOS, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
###############################################################################
#Player Has A SHARPEDO in Surf #
###############################################################################
elsif pbHasSpeciesWithMove?(:SHARPEDO, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end

How to upgrade v18.1?

 

[StCooler]

Nothing fancy really. But you didn't post the whole code, the function pbUpdateVehicle is cut halfway.

Spoiler:

module Settings
  SharpedoSurfFileName = [
    "boy_surf_sharpedo", # Player A
    "girl_surf_sharpedo", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end

module Settings
  GyaradosSurfFileName = [
    "boy_surf_gyarados", # Player A
    "girl_surf_gyarados", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end


def pbHasSpeciesWithMove?(species, move)
  move=getID(PBMoves,move)
  return nil if !move || move<=0
  if species.is_a?(String) || species.is_a?(Symbol)
    species=getID(PBSpecies,species)
  end
  for pokemon in $Trainer.party
    next if pokemon.egg?
    return true if pokemon.species==species && pokemon.hasMove?(move)
  end
  return false
end

def pbUpdateVehicle
  meta=pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
  if meta
    if $PokemonGlobal.diving
      $game_player.character_name=pbGetPlayerCharset(meta,5) # Diving graphic
    elsif $PokemonGlobal.surfing
###############################################################################
#Player Has A GYARADOS in Surf                                               #
###############################################################################
      if pbHasSpeciesWithMove?(:GYARADOS, :SURF)
        trainer=$Trainer if !trainer
        outfit=trainer ? trainer.outfit : 0
        if outfit==0
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]
        else
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
        end
###############################################################################
#Player Has A SHARPEDO in Surf                                               #
###############################################################################
      elsif pbHasSpeciesWithMove?(:SHARPEDO, :SURF)
         trainer=$Trainer if !trainer
          outfit=trainer ? trainer.outfit : 0
          if outfit==0
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]
          else
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
          end

 

[MessiDuvidoso]

Nothing fancy really. But you didn't post the whole code, the function pbUpdateVehicle is cut halfway.

Spoiler:

module Settings
  SharpedoSurfFileName = [
    "boy_surf_sharpedo", # Player A
    "girl_surf_sharpedo", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end

module Settings
  GyaradosSurfFileName = [
    "boy_surf_gyarados", # Player A
    "girl_surf_gyarados", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end


def pbHasSpeciesWithMove?(species, move)
  move=getID(PBMoves,move)
  return nil if !move || move<=0
  if species.is_a?(String) || species.is_a?(Symbol)
    species=getID(PBSpecies,species)
  end
  for pokemon in $Trainer.party
    next if pokemon.egg?
    return true if pokemon.species==species && pokemon.hasMove?(move)
  end
  return false
end

def pbUpdateVehicle
  meta=pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
  if meta
    if $PokemonGlobal.diving
      $game_player.character_name=pbGetPlayerCharset(meta,5) # Diving graphic
    elsif $PokemonGlobal.surfing
###############################################################################
#Player Has A GYARADOS in Surf                                               #
###############################################################################
      if pbHasSpeciesWithMove?(:GYARADOS, :SURF)
        trainer=$Trainer if !trainer
        outfit=trainer ? trainer.outfit : 0
        if outfit==0
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]
        else
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
        end
###############################################################################
#Player Has A SHARPEDO in Surf                                               #
###############################################################################
      elsif pbHasSpeciesWithMove?(:SHARPEDO, :SURF)
         trainer=$Trainer if !trainer
          outfit=trainer ? trainer.outfit : 0
          if outfit==0
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]
          else
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
          end

This is a script from another version of essentials that was compatible, it changed a lot with essentials v18. Which currently looks like this:

Spoiler:

def pbUpdateVehicle
meta = pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
if meta
charset = 1 # Regular graphic
if $PokemonGlobal.diving; charset = 5 # Diving graphic
elsif $PokemonGlobal.surfing; charset = 3 # Surfing graphic
elsif $PokemonGlobal.bicycle; charset = 2 # Bicycle graphic
end
newCharName = pbGetPlayerCharset(meta,charset)
$game_player.character_name = newCharName if newCharName
end
end

There is also an interaction in my Following Pokemon Ex scripts from Golisopod:

Spoiler:

alias follow_pbEndSurf pbEndSurf
def pbEndSurf(xOffset,yOffset)
ret = follow_pbEndSurf(xOffset,yOffset)
if ret
$PokemonGlobal.callRefresh = [true,([0,false].include?($PokemonTemp.dependentEvents.refresh_sprite(false,true)))]
end
end

 

[MessiDuvidoso]

Nothing fancy really. But you didn't post the whole code, the function pbUpdateVehicle is cut halfway.

Spoiler:

module Settings
  SharpedoSurfFileName = [
    "boy_surf_sharpedo", # Player A
    "girl_surf_sharpedo", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end

module Settings
  GyaradosSurfFileName = [
    "boy_surf_gyarados", # Player A
    "girl_surf_gyarados", # Player B
    "", # Player C
    "", # Player D
    "", # Player E
    "", # Player F
  ]
end


def pbHasSpeciesWithMove?(species, move)
  move=getID(PBMoves,move)
  return nil if !move || move<=0
  if species.is_a?(String) || species.is_a?(Symbol)
    species=getID(PBSpecies,species)
  end
  for pokemon in $Trainer.party
    next if pokemon.egg?
    return true if pokemon.species==species && pokemon.hasMove?(move)
  end
  return false
end

def pbUpdateVehicle
  meta=pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
  if meta
    if $PokemonGlobal.diving
      $game_player.character_name=pbGetPlayerCharset(meta,5) # Diving graphic
    elsif $PokemonGlobal.surfing
###############################################################################
#Player Has A GYARADOS in Surf                                               #
###############################################################################
      if pbHasSpeciesWithMove?(:GYARADOS, :SURF)
        trainer=$Trainer if !trainer
        outfit=trainer ? trainer.outfit : 0
        if outfit==0
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]
        else
          $game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
        end
###############################################################################
#Player Has A SHARPEDO in Surf                                               #
###############################################################################
      elsif pbHasSpeciesWithMove?(:SHARPEDO, :SURF)
         trainer=$Trainer if !trainer
          outfit=trainer ? trainer.outfit : 0
          if outfit==0
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]
          else
            $game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
          end

With that, would you be able to make it work?

 

[StCooler]

With that, would you be able to make it work?

It could work, if you had given me the complete script. The function you gave me was truncated, it misses a part. I edited the script to v18.

 

[MessiDuvidoso]

It could work, if you had given me the complete script. The function you gave me was truncated, it misses a part. I edited the script to v18.

Spoiler:

module Settings
AeroBoyFileName = [
"aeroboy", # Player A
"aerogirl", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

module Settings
SharpedoSurfFileName = [
"boy_surf_sharpedo", # Player A
"girl_surf_sharpedo", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

module Settings
GyaradosSurfFileName = [
"boy_surf_gyarados", # Player A
"girl_surf_gyarados", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

module Settings
WailmerSurfFileName = [
"boy_surf_wail", # Player A
"girl_surf_wail", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

module Settings
MiloticSurfFileName = [
"boy_surf_milotic", # Player A
"girl_surf_milotic", # Player B
"", # Player C
"", # Player D
"", # Player E
"", # Player F
]
end

#ADICIONEI ESSE MÉTODO
def pbHasSpeciesWithMove?(species, move)
move=getID(PBMoves,move)
return nil if !move || move<=0
if species.is_a?(String) || species.is_a?(Symbol)
species=getID(PBSpecies,species)
end
for pokemon in $Trainer.party
next if pokemon.isEgg?
return true if pokemon.species==species && pokemon.hasMove?(move)
end
return false
end

def Kernel.pbUpdateVehicle
meta=pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
if meta
if $PokemonGlobal.diving
$game_player.character_name=pbGetPlayerCharset(meta,5) # Diving graphic
elsif $PokemonGlobal.surfing
###############################################################################
#Player Has A GYARADOS in Surf #
###############################################################################
if pbHasSpeciesWithMove?(:GYARADOS, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::GyaradosSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
###############################################################################
#Player Has A SHARPEDO in Surf #
###############################################################################
elsif pbHasSpeciesWithMove?(:SHARPEDO, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::SharpedoSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
###############################################################################
#Player Has A Wailmellon in Surf #
###############################################################################
elsif pbHasSpeciesWithMove?(:WAILMER, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::WailmerSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::WailmerSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
##############################################################################
#Player Has A Milotic in Surf #
###############################################################################
elsif pbHasSpeciesWithMove?(:MILOTIC, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::MiloticSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::MiloticSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
else
$game_player.character_name=pbGetPlayerCharset(meta,3)#Surf graphic
end
###############################################################################
#Player Has A Aerodactyl in Party #
###############################################################################
elsif $PokemonGlobal.bicycle
if pbHasSpecies?(:AERODACTYL)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::AeroBoyFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::AeroBoyFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
else
$game_player.character_name=pbGetPlayerCharset(meta,2) # Bicycle graphic
end #aerodactyl
else
$game_player.character_name=pbGetPlayerCharset(meta,1) # Regular graphic
end
end
end

The complete script is from an abandoned project that adapted the script from the topic:
https://www.pokecommunity.com/threads/354975

But anyway, I will test the solution that gave me <3 Thank you.

 

[MessiDuvidoso]

I decided to replace the change in
def pbUpdateVehicle in Game_Player
which is like this:

Spoiler:

def pbUpdateVehicle
meta = pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
if meta
charset = 1 # Regular graphic
if $PokemonGlobal.diving; charset = 5 # Diving graphic
elsif $PokemonGlobal.surfing; charset = 3 # Surfing graphic
elsif $PokemonGlobal.bicycle; charset = 2 # Bicycle graphic
end
newCharName = pbGetPlayerCharset(meta,charset)
$game_player.character_name = newCharName if newCharName
end
end

Into:

Spoiler:

def pbUpdateVehicle
meta = pbGetMetadata(0,MetadataPlayerA+$PokemonGlobal.playerID)
if meta
charset = 1 # Regular graphic
if $PokemonGlobal.diving; charset = 5 # Diving graphic
elsif $PokemonGlobal.surfing # Surfing graphic
if pbHasSpeciesWithMove?(:BLASTOISE, :SURF)
trainer=$Trainer if !trainer
outfit=trainer ? trainer.outfit : 0
if outfit==0
$game_player.character_name=Settings::BlastoiseSurfFileName[$PokemonGlobal.playerID]
else
$game_player.character_name=Settings::BlastoiseSurfFileName[$PokemonGlobal.playerID]+"_"+outfit.to_s
end
else
charset = 3
end
elsif $PokemonGlobal.bicycle; charset = 2 # Bicycle graphic
end
newCharName = pbGetPlayerCharset(meta,charset)
$game_player.character_name = newCharName if newCharName
end
end

It worked at first, I managed to surf in a blastoise that I created, but an error came:

https://imgur.com/oG3Gk0D

Upon returning to the land area, my character did not update his sprite ... Solutions? I feel like it's close to working ...

 

[MessiDuvidoso]

I did this because there was a syntax error because this script is from another version of essentials.