[Script] Yes/No Script doesn't work properly

[_HealBell_]

Hi. I'm very new to rom hacking and I've just started to learn how to script (XSE; FireRed].
I've been stuck on the compare, if and 0x5 commands for a couple days ... I think I've finally begun to understand better how they work today and I almost got it to work smoothly in my testing, but I still can't get the "No" option right and it's driving me crazy. I don't really seem to understand what's going on. Basically, when I select "No", the message doesn't change and a coin counting appears below. I don't understand why it's happening and how to avoid that. When I check the script again via AdvanceMap after the testing, the "No" msgbox vanished and it got replaced by several other commands.

Here's the code from XSE (opened in AdvanceMap) before testing:

Spoiler:

'-----------------------
#org 0x80135F
lock
faceplayer
msgbox 0x8801384 '"Hello! Are you having fun?"
callstd 0x5
compare LASTRESULT 0x1
if 0x1 goto 0x880137B
msgbox 0xF8013AF

'-----------------------
#org 0x80137B
msgbox 0x88013A0 '"Nice! Me too."

'---------
' Strings
'---------
#org 0x801384
= Hello! Are you having fun?

#org 0x8013A0
= Nice! Me too.

#org 0xF8013AF
= Oh, I'm sorry.

This is what it generates in-game:



And this is how the code appears after checking it in AdvanceMap 1.92 again:

Spoiler:

'-----------------------
#org 0x80135F
lock
faceplayer
msgbox 0x8801384 '"Hello! Are you having fun?"
callstd 0x5
compare LASTRESULT 0x1
if 0x1 goto 0x880137B
msgbox 0xF8013AF
[B]callstd 0xF
nop
checkgender
setfarbyte 0x80 0x6C020908
updatecoins 0xD9 0xE0[/B]

'-----------------------
#org 0x80137B
msgbox 0x88013A0 '"Nice! Me too."

'---------
' Strings
'---------
#org 0x801384
= Hello! Are you having fun?

#org 0x8013A0
= Nice! Me too.

Thank you to anyone willing to help :/

 

[Mason Shu]

First, you need 0x5 after the msg yes/no or MSG_YESNO
Second, for regular msgs, you need a 0x6 or a 0x2
Lastly, you need a release when you have a lock, and an 'end'

Here are the message types

Spoiler:

#define MSG_FIND 0x1
#define MSG_OBTAIN 0x0
#define MSG_FACE 0x2
#define MSG_SIGN 0x3
#define MSG_KEEPOPEN 0x4
#define MSG_YESNO 0x5
#define MSG_NORMAL 0x6

Here might be your script's structure

Spoiler:

#dynamic 0x800000 '---------searches fs from 0x800000
#org @start '------------the main script
lock '-------------lock the player
faceplayer '---------person faces player
msgbox @Arehavefun 0x5 '-----------Runs msg @areyouhavefun
compare LASTRESULT 0x1 '---------------Stores the last result in a variable and checks if it is 0x1 aka yes
if 0x1 goto @continue '------------------if yes then goto continue
msgbox @no 0x6 '-----------------------continues the no msg
release '--------------releases lock
end '----------------ends the script

#org @continue '-------------------------continues from continue
msgbox @meto 0x6 '--------------------------goes to me too (I know there's a mistake its metoo not meto)
release '-------------------------------releases
end '--------------------------end

#org @Arehavefun '---------------------msg
= Hello! Are you having fun?

#org @meto '---------------msg
= Nice! Me too.

#org @no '---------------------------msg
= Oh, I'm sorry.

https://www.mediafire.com/file/2d4lx9pz39izje0/help_JgmaVQRZ_uWXF.avi/file

 

[Asith]

To add on to what the previous user said, this "call std" msgbox format is something that I'm fairly sure is an old format (it predates me getting into rom hacking anyway) and I'm not even sure if XSE still supports it. If your msgboxes work fine, then great - ignore this bit! If not, you should consider using:
msgbox @textpointer 0x5
Simply enough, we've moved the "callstd" number to the end of the msgbox line. Nothing else changes, you just don't need to callstd seperately.

As for your real problem - you script being overwritten by different commands - that's likely a memory issue. You've run out of free space and the game is using script data from some other script. Try using a fresh rom or a different offset, making sure to search for a decent amount of free space!