[Scripting Question] Zygarde (Ability, Moves, Zygarde Cube)

[Poq]

Credit to me and WolfPP for this solution is appreciated. Thanks!
EDIT: I was mistaken.

 

[mybusiness]

Credit to me and WolfPP for this solution is appreciated. Thanks!

If you watch carefully, I published the Power Construct ability 10 minutes before WolfPP, and although what I said in this post may seem to suggest that I used your code, I didn't. The proof is that my code for Mimikyu and Zygarde are very different (my Mimikyu gets busted after the first hit of a multihit, per example, meanwhile yours don't), and Battle Bond is pretty standard. So, personally, I'll credit WolfPP for another help (not related to scripting), but no one for Disguise, Battle Bond and Power Construct.

 

[Poq]

If you watch carefully, I published the Power Construct ability 10 minutes before WolfPP, and although what I said in this post may seem to suggest that I used your code, I didn't.

My mistake. Thanks for clarifying.

 

[WolfPP]

Yearh dude. Relax and i didnt saw your post to make a script.

I will read your script when i back at home and see how can i edit mine to back zygarde into form 0 or 1 after battle.

Thanks for your script! I hope that save mine hauajau

Also, to Zygarde Cube, check this thread: https://www.pokecommunity.com/showthread.php?t=398562

EDIT: i tried to put your script. After battle, only one Zygarde turns back to form 1 and the other (before battle was form 0) keep form 2 (Complete Forme). :/
Where did I go wrong?
EDIT: When i fight with only one Zygarde (form 1 or 0), its works (turn form 2 and after battle, turns back to 1 or 0) lol So fokin good! Nice Script!
Thanks!

 

[mybusiness]

I found that if I catch a Zygarde Full Forme, it´ll stay that way forever. To fix that, I changed my def revertOtherForms with this new one:

def revertOtherForms
    if isConst?(self.species,PBSpecies,:GRENINJA) ||
       isConst?(self.species,PBSpecies,:MIMIKYU)
      self.form=0 
    elsif isConst?(self.species,PBSpecies,:ZYGARDE)
      if $zygardeform>=0
        self.form=$zygardeform
        $zygardeform=-1
      elsif self.form==2  # If caught a Full Forme
        self.form=rand(2)
      end
    end
  end

 

[WolfPP]

In PokeBattle_Battler:

Spoiler:

def pbFaint(showMessage=true)
    unless fainted?
      PBDebug.log("!!!***Can't faint with HP greater than 0")
      return true
    end
    if @fainted
#      PBDebug.log("!!!***Can't faint if already fainted")
      return true
    end
    @battle.scene.pbFainted(self)
    pbInitEffects(false)
    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
    [COLOR="Red"]@pokemon.revertOtherForms[/COLOR]
    @fainted=true
    # reset choice
    @battle.choices[@index]=[0,0,nil,-1]
    pbOwnSide.effects[PBEffects::LastRoundFainted][email protected]
    @battle.pbDisplayPaused(_INTL("{1} fainted!",pbThis)) if showMessage
    PBDebug.log("[Pokémon fainted] #{pbThis}")
    return true
  end

.

At least in my game, every time I killed the opponent pokemon, I was still in the battle, without seeing the enemy, I was "bugged" because regardless of the pokemon, the script would always call for '@pokemon.revertOtherForms'.
So I made a simple addition of:

@ pokemon.revertOtherForms [COLOR="Red"]if isConst? (self.species, PBSpecies,: ZYGARDE) && $ zygardeform> = 0[/COLOR]

And it did not happen again.

 

[mybusiness]

That's really strange. You must have modified your script a lot to have such bugs.

 

[WolfPP]

In the 'def pbFaint (showMessage = true)' part, no.
However, if there is anyone else besides me with this problem, here is the solution.

Spoiler:

  def pbFaint(showMessage=true)
    unless fainted?
      PBDebug.log("!!!***Can't faint with HP greater than 0")
      return true
    end
    if @fainted
#      PBDebug.log("!!!***Can't faint if already fainted")
      return true
    end
    @battle.scene.pbFainted(self)
    pbInitEffects(false)
    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
    @pokemon.revertOtherForms if isConst?(self.species,PBSpecies,:ZYGARDE) && $zygardeform>=0
    @pokemon.makeDisguised if self.isBusted?#
    @pokemon.makeUnUltra if self.isUltra?#
    @fainted=true
    # reset choice
    @battle.choices[@index]=[0,0,nil,-1]
    pbOwnSide.effects[PBEffects::LastRoundFainted][email protected]
    @battle.pbDisplayPaused(_INTL("{1} fainted!",pbThis)) if showMessage
    PBDebug.log("[Pokémon fainted] #{pbThis}")
    return true
  end