This hack looks too good to be true - I love the concept of stealing other pokemon - exactly what Team Rocket are about!! I will add that I too am slightly worried by the 25 types, especially with only the gen 1 family lines being added. I just don't want what happened in Pokemon Brown to happen, where new types are added but there are so few pokemon, with so few moves of those types that they never have a marked effect on gameplay. However, since this looks like a total overhaul of typings, it could well work and obviously it's your baby and you can do whatever you want with it!!
Wishing the best of luck in development!!
Thanks! You're right, there are definitely going to be some types with very little Pokemon underneath it (like Cyber or Bone). But, looking back at Gen 1, you had types like Ice, Dragon, and Ghost, with only 5, 3 and 3 Pokemon each, respectively.
So these types certainly can be removed without affecting game play. I don't think the addition of them hinders the gameplay, (besides players having to learn the type advantages/disadvantages), it just gives players more options of having an effective party, removes some repetitiveness of Pokemon encounters, and gives the players a new experience.
In terms of the moves being spread thin: I added in over 100 new moves (while also removing over 40 and updating others), bringing the total to 255 (the maximum possible using a single byte move ID).
Predictably, the types with the lowest amount of moves also have a low amount of Pokemon, these being Ghost, Bone, Radio, Dragon, and Goo. The types with the highest amount of moves are ones that contain attacks that Pokemon can typically learn even if they aren't of that type; these being Physical, Fighting, Sound, and Magic.
Also remember that along with these new types come new status ailments, new battle environments, new in-battle effects, and new trainers. And with all of the above comes new items, new HMs, new storylines, and new maps.
So I hope that eases your concern!