From what I understand, a good plot that makes sense, characters that stay in-character, at least decent spelling and grammar... but then again what makes a good fanfic varies from person to person, I'm sure.
I don't read them actively, I just read the fanficrants community on Livejournal. So I know about how to make an awful fanfic, but not so much what makes a good one. XD