KrustyKong said:

also have to have "#include "constants/map_groups.h" at the top of src\berry.c, or else it gives an error about the maps being undeclared in that function.

Click to expand...

Lunos said:

Quick heads up.
I pushed a new commit to my gen6_exp_share branch after Jaizu pointed out to me that I forgot to clear the value of gSaveBlock2Ptr->expShare upon starting a New Game.

Disable Pokémon animations [Em]
Nice and simple. It's also a repost from here.
These changes disable the sprite animations that Pokémon have in battle and in the Summary Screen too.
I'm posting it here because it'd be better archived here than in some random thread.

Showcase:

To implement this, y'all can either track my GitHub repository via git remote and pull the branch where I'm hosting the code:

Code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos disable_pkmn_anims

Or you can also apply the changes manually.
Your choice.

And that's pretty much it.​

Click to expand...

• There is an item for each HM except Fly and Waterfall
• Waterfall is now a script flag that'll need to be set to use.
• The items function both from item menu and by interacting with the overworld

git remote add ns https://github.com/NobodySociety/pokeemerald
git pull ns HMItems

Diego Mertens said:

POKEEMERALD
PSS IN THE START MENU​

Spoiler:

First, we add a new Flag in include/constants/flags.h

Code:

FLAG_POKEMONPCMENU

(this will be used after)
Then, we go to include/pokemon_storage_system.h
There, we add anywhere:

Code:

void Cb2_EnterPSS(u8 boxOption);

Then we go to src/pokemon_storage_system.c, and we delete

Code:

static void Cb2_EnterPSS(u8 boxOption);

(when its definied, the first one)
and we search for "static void Cb2_EnterPSS(u8 boxOption) ", then we erase the "static " (the second one)
Then, we search for:

Code:

static void FieldCb_ReturnToPcMenu(void)

And we replace it entirely for this:

Code:

static void FieldCb_ReturnToPcMenu(void)
{
    u8 taskId;
    MainCallback vblankCb = gMain.vblankCallback;
	if (FlagGet(FLAG_POKEMONPCMENU)==TRUE)
	{
		SetVBlankCallback(NULL);
		taskId = CreateTask(Task_PokemonStorageSystemPC, 80);
		gTasks[taskId].data[0] = 0;
		gTasks[taskId].data[1] = sPreviousBoxOption;
		Task_PokemonStorageSystemPC(taskId);
		SetVBlankCallback(vblankCb);
		FadeInFromBlack();
	}
	else
	{
	    SetVBlankCallback(CB2_ReturnToField);
		FadeInFromBlack();
		DisableInterrupts(FLAG_POKEMONPCMENU);
	}
}

Then, we go to src/start_menu.c, and we search for: static bool8 StartMenuBagCallback(void);, and right after, we add:
static bool8 StartMenuPCCallback(void);
Then, we go to "{gText_MenuBag, {.u8_void = StartMenuBagCallback}}," and again we add bellow:
{gText_MenuPC, {.u8_void = StartMenuPCCallback}},
Then, we go to "static bool8 StartMenuBagCallback(void)" and after the whole funcion we add:

Code:

static bool8 StartMenuPCCallback(void)
{
	u8 taskId;
    if (!gPaletteFade.active)
    {
        PlayRainStoppingSoundEffect();
        RemoveExtraStartMenuWindows();
		Cb2_EnterPSS(x);
        return TRUE;
    }

    return FALSE;
}

(in my case, its "0" the number for the Move Pokémon System, but I have made some changes {I changed the Move option to the first place}, and I'm sure the original number for the option is "2"...)

Then, we search for: "MENU_ACTION_BAG"
And after we add: "MENU_ACTION_PC,"

Now we go to: "if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)" and inside there we add:
AddStartMenuAction(MENU_ACTION_PC);
Like this:

Code:

    if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)
    {
        AddStartMenuAction(MENU_ACTION_POKEMON);
		AddStartMenuAction(MENU_ACTION_PC);
    }

Then, we go to "AddStartMenuAction(MENU_ACTION_BAG);" and right after we add:
AddStartMenuAction(MENU_ACTION_PC);

Then, we go to data/scripts/pc.inc and we add this after "playse SE_PC_ON" in "EventScript_PC:: @ 8271D92":
setflag FLAG_POKEMONPCMENU
Now, after "special DoPCTurnOffEffect", in "EventScript_TurnOffPC:: @ 8271E47" we add:
clearflag FLAG_POKEMONPCMENU

Lastly, we need to add the strings for the PC in the Start Menu, (thanks, Lunos)
We go to include/strings.h and we add this somewhere:

extern const u8 gText_MenuPC[];

And this is the last step. We go to src/strings.c and we add this somewhere:
const u8 gText_MenuPC[] = _("PC");

And we're done! this time, we are We should be able to enter the Move Pokémon PC, and the Pokécenter PC's won't be affected.

Click to expand...

Diego Mertens said:

POKEEMERALD
PSS IN THE START MENU​

Spoiler:

First, we add a new Flag in include/constants/flags.h

Code:

FLAG_POKEMONPCMENU

(this will be used after)
Then, we go to include/pokemon_storage_system.h
There, we add anywhere:

Code:

void Cb2_EnterPSS(u8 boxOption);

Then we go to src/pokemon_storage_system.c, and we delete

Code:

static void Cb2_EnterPSS(u8 boxOption);

(when its definied, the first one)
and we search for "static void Cb2_EnterPSS(u8 boxOption) ", then we erase the "static " (the second one)
Then, we search for:

Code:

static void FieldCb_ReturnToPcMenu(void)

And we replace it entirely for this:

Code:

static void FieldCb_ReturnToPcMenu(void)
{
    u8 taskId;
    MainCallback vblankCb = gMain.vblankCallback;
	if (FlagGet(FLAG_POKEMONPCMENU)==TRUE)
	{
		SetVBlankCallback(NULL);
		taskId = CreateTask(Task_PokemonStorageSystemPC, 80);
		gTasks[taskId].data[0] = 0;
		gTasks[taskId].data[1] = sPreviousBoxOption;
		Task_PokemonStorageSystemPC(taskId);
		SetVBlankCallback(vblankCb);
		FadeInFromBlack();
	}
	else
	{
	    SetVBlankCallback(CB2_ReturnToField);
		FadeInFromBlack();
		DisableInterrupts(FLAG_POKEMONPCMENU);
	}
}

Then, we go to src/start_menu.c, and we search for: static bool8 StartMenuBagCallback(void);, and right after, we add:
static bool8 StartMenuPCCallback(void);
Then, we go to "{gText_MenuBag, {.u8_void = StartMenuBagCallback}}," and again we add bellow:
{gText_MenuPC, {.u8_void = StartMenuPCCallback}},
Then, we go to "static bool8 StartMenuBagCallback(void)" and after the whole funcion we add:

Code:

static bool8 StartMenuPCCallback(void)
{
	u8 taskId;
    if (!gPaletteFade.active)
    {
        PlayRainStoppingSoundEffect();
        RemoveExtraStartMenuWindows();
		Cb2_EnterPSS(x);
        return TRUE;
    }

    return FALSE;
}

(in my case, its "0" the number for the Move Pokémon System, but I have made some changes {I changed the Move option to the first place}, and I'm sure the original number for the option is "2"...)

Then, we search for: "MENU_ACTION_BAG"
And after we add: "MENU_ACTION_PC,"

Now we go to: "if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)" and inside there we add:
AddStartMenuAction(MENU_ACTION_PC);
Like this:

Code:

    if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)
    {
        AddStartMenuAction(MENU_ACTION_POKEMON);
		AddStartMenuAction(MENU_ACTION_PC);
    }

Then, we go to "AddStartMenuAction(MENU_ACTION_BAG);" and right after we add:
AddStartMenuAction(MENU_ACTION_PC);

Then, we go to data/scripts/pc.inc and we add this after "playse SE_PC_ON" in "EventScript_PC:: @ 8271D92":
setflag FLAG_POKEMONPCMENU
Now, after "special DoPCTurnOffEffect", in "EventScript_TurnOffPC:: @ 8271E47" we add:
clearflag FLAG_POKEMONPCMENU

Lastly, we need to add the strings for the PC in the Start Menu, (thanks, Lunos)
We go to include/strings.h and we add this somewhere:

extern const u8 gText_MenuPC[];

And this is the last step. We go to src/strings.c and we add this somewhere:
const u8 gText_MenuPC[] = _("PC");

And we're done! this time, we are We should be able to enter the Move Pokémon PC, and the Pokécenter PC's won't be affected.

Click to expand...

DisableInterrupts(FLAG_POKEMONPCMENU);

static void FieldCb_ReturnToPcMenu(void)

[pokefirered] Native Real-Time Clock

git remote add sotomura https://github.com/Sotomura/pokefirered/
git pull sotomura pokefirered-rtc

TheXaman said:

[Pokeemerald] Register items in a list menu!
This adds a list menu on the L button, which allows registering a choosen amount of items, currently 10 (but less or more are possible with changing 1 define).

The menu offers:
-variable number of registered items
-allows changing the order by moving items with select!!!
-remembers last item used and opens on that
-includes a Cancel button for 1 handed mode
-if L=A button mode is choosen, button automatically changes to R
-retains the select register button for another item

HOW TO:

Code:

git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman tx_registered_items_menu
make

I hope you enjoy it, if you find any bugs or have suggestions: please let me know!


Credits:
ghoulslash
TheXaman

Click to expand...

DizzyEgg said:

Nature-affected stats colouring

I used the color red with light and dark shade to signify stat affected negatively and positively respectively. If you wish to use different colors, just modify the sTextNatureDown and sTextNatureUp strings, more specifically the byte value after {COLOR} special character.

Code:

src/pokemon_summary_screen.c

Changes include functions in range BufferLeftColumnStats - BufferRightColumnStats.

Spoiler:

Code:

static void BufferStat(u8 *dst, s8 natureMod, u32 stat, u32 strId, u32 n)
{
    static const u8 sTextNatureDown[] = _("{COLOR}{09}");
    static const u8 sTextNatureUp[] = _("{COLOR}{05}");
    static const u8 sTextNatureNeutral[] = _("{COLOR}{01}");
    u8 *txtPtr;

    if (natureMod == 0)
        txtPtr = StringCopy(dst, sTextNatureNeutral);
    else if (natureMod > 0)
        txtPtr = StringCopy(dst, sTextNatureUp);
    else
        txtPtr = StringCopy(dst, sTextNatureDown);

    ConvertIntToDecimalStringN(txtPtr, stat, STR_CONV_MODE_RIGHT_ALIGN, n);
    DynamicPlaceholderTextUtil_SetPlaceholderPtr(strId, dst);
}

static void BufferLeftColumnStats(void)
{
    u8 *currentHPString = Alloc(20);
    u8 *maxHPString = Alloc(20);
    u8 *attackString = Alloc(20);
    u8 *defenseString = Alloc(20);
    const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

    DynamicPlaceholderTextUtil_Reset();
    BufferStat(currentHPString, 0, sMonSummaryScreen->summary.currentHP, 0, 3);
    BufferStat(maxHPString, 0, sMonSummaryScreen->summary.maxHP, 1, 3);
    BufferStat(attackString, natureMod[STAT_ATK - 1], sMonSummaryScreen->summary.atk, 2, 7);
    BufferStat(defenseString, natureMod[STAT_DEF - 1], sMonSummaryScreen->summary.def, 3, 7);
    DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsLeftColumnLayout);

    Free(currentHPString);
    Free(maxHPString);
    Free(attackString);
    Free(defenseString);
}

static void PrintLeftColumnStats(void)
{
    SummaryScreen_PrintTextOnWindow(AddWindowFromTemplateList(sPageSkillsTemplate, PSS_DATA_WINDOW_SKILLS_STATS_LEFT), gStringVar4, 4, 1, 0, 0);
}

static void BufferRightColumnStats(void)
{
    const s8 *natureMod = gNatureStatTable[sMonSummaryScreen->summary.nature];

    DynamicPlaceholderTextUtil_Reset();
    BufferStat(gStringVar1, natureMod[STAT_SPATK - 1], sMonSummaryScreen->summary.spatk, 0, 3);
    BufferStat(gStringVar2, natureMod[STAT_SPDEF - 1], sMonSummaryScreen->summary.spdef, 1, 3);
    BufferStat(gStringVar3, natureMod[STAT_SPEED - 1], sMonSummaryScreen->summary.speed, 2, 3);
    DynamicPlaceholderTextUtil_ExpandPlaceholders(gStringVar4, sStatsRightColumnLayout);
}

Screenshot:

Spoiler:

I also have the code in my github branch called nature_color, so you can pull directly from it.

Click to expand...

Pyredrid said:

[PokeEmerald] Surfboard instead of HM Surf​

Spoiler:

Adds in a Surfboard that lets the player just walk into water.
No long, annoying animations~


How to use:

• Add the code to your pokeemerald decomp as described below.
• Give the player the item ITEM_SURFBOARD
• Have the player walk into water
• The player will now be surfing on the water

How to add:

• git remote add pyredrid https://github.com/Pyredrid/pokeemerald.git
• git pull pyredrid surfboard

Click to expand...

static bool8 CanStartSurfing(s16 x, s16 y, u8 direction)
{
    if (CheckBagHasItem(ITEM_SURFBOARD, 1) == FALSE)
    {
        return FALSE;
    }

    if ((gPlayerAvatar.flags & PLAYER_AVATAR_FLAG_ON_FOOT)        //also remove to jump from bike, side effects unknown
[COLOR="Red"]-     && MapGridGetZCoordAt(x, y) == 1[/COLOR]
[COLOR="Lime"]+    && IsPlayerFacingSurfableFishableWater()[/COLOR]
     && GetObjectEventIdByXYZ(x, y, 1) == OBJECT_EVENTS_COUNT)
    {
        CreateStartSurfingTask(direction);
        return TRUE;
    }
    else
    {
        return FALSE;
    }
}

PokemonCrazy said:

Showing IVs/EVs in Summary Screen [EM]​

Here's a quick demonstration of how it looks:

​

Just like in the older version, the nature coloring is only shown when the regular stats are being displayed (this Grovyle is Docile, so that's why there's no coloring here). This can be changed by editing the second value in BufferStat calls for cases 0 and 1. See the calls in case 2 to see how they work.
[/SPOILER]

If you'd like, you can use both the old and the new methods in tandem, as they don't conflict with each other. Thanks again to AkimotoBubble for their code.

Click to expand...