Script Help Thread (DO NOT REQUEST SCRIPTS)

Tropical Sunlight · Feb 9, 2011

Binary said:
Decompile an in-game script that deals with the same process. Figuring it out should be easy enough.

I have, but there were a lot of calls to different offsets. Is that it?

Skara · Feb 9, 2011

colcolstyles said:
You should probably reread whatever scripting tutorial you read (and more thoroughly this time) because your 'msgbox' commands are lacking the second parameter, something that is explained in any recent scripting tutorial. You also need to brush up on some basic concepts of hacking, like pointers and addresses, because your use of two "@text"s is faulty.

No tutorial, just PKSV generated.

fizzmaister · Feb 10, 2011

Tropical Sunlight said:
I have, but there were a lot of calls to different offsets. Is that it?

Take a look at the scientist that revives fossils in the Cinnabar lab. That mess of code should have everything that you need.

spidermight340 · Feb 10, 2011

what is the script so you need to talk to a certain person to proceed

destinedjagold · Feb 10, 2011

spidermight340 said:

what is the script so you need to talk to a certain person to proceed

Click to expand...

you need to use the setflag and checkflag commands.
how? tutorials are made for you in the Tutorials section.

Mana1 · Feb 10, 2011

Can anyone see why the text in this level script would not show? I've just started hacking again and it's thrown me off.

The script is implemented properly, it does start, move the sprites, then finish but no messages are shown.

From A-Map:

Spoiler:

Original:

Spoiler:

Nerketur · Feb 10, 2011

SwiftSign said:

Can anyone see why the text in this level script would not show? I've just started hacking again and it's thrown me off.

The script is implemented properly, it does start, move the sprites, then finish but no messages are shown.

From A-Map:

Spoiler:

'-----------------------
#org 0x800000
lock
setvar 0x7000 0x1
applymovement MOVE_PLAYER 0x8800033
waitmovement 0x0
msgbox 0x880003B //Missing type parameter '"Hero, before you continue your\njou..."
applymovement 0x1 0x8800038
waitmovement 0x0
applymovement 0x2 0x8800038
waitmovement 0x0
msgbox 0x8800087 //Missing type parameter '"Approach the Pokémon which most ref..."
release
end

'-----------
' Movements
'-----------
#org 0x800033
#raw 2 'Face Left
#raw 3 'Face Right
#raw 0 'Face Down
#raw FE 'End of Movements

#org 0x800038
#raw 10 'Step Down (Normal)
#raw FE 'End of Movements

'---------
' Strings
'---------
#org 0x80003B
= Hero, before you continue your\njourney you must pick your loyal\lpartner.

#org 0x800087
= Approach the Pokémon which most reflects you.

Original:

Spoiler:

#org @start
lock
setvar 0x7000 0x1
applymovement 0xFF @Move1
waitmovement 0x0
msgbox @Talk1 0x6 // HAS type parameter.
applymovement 0x1 @Move2
waitmovement 0x0
applymovement 0x2 @Move2
waitmovement 0x0
msgbox @Talk2 0x6 // HAS type parameter
release
end

#org @Move1
#raw 0x2 0x3 0x0 0xFE

#org @Move2
#raw 0x10 0xFE

#org @Talk1
= Hero, before you continue your\njourney you must pick your loyal\lpartner.

#org @Talk2
= Approach the Pokémon which most reflects you.

Click to expand...

The original is fine, Compiled version is NOT. Try compiling it, then replacing the script offset in Advance Map with the script offset that you get when you compile in XSE. Or, if you want to save space, at the very top of the script put "#removeall <oldoffset>" So, in your case, it would be "#removeall 0x800000" This works, because "removeall" basically COMPLETELY deletes (All movements, scripts, strings, and items involved) the script that was previously at that offset. (Assuming it has an "end" at the end of it.) Of course, this only works if you're using XSE, and it's only guaranteed to work if you're using the latest version of XSE.

Mana1 · Feb 10, 2011

Nerketur said:
The original is fine, Compiled version is NOT. Try compiling it, then replacing the script offset in Advance Map with the script offset that you get when you compile in XSE. Or, if you want to save space, at the very top of the script put "#removeall <oldoffset>" So, in your case, it would be "#removeall 0x800000" This works, because "removeall" basically COMPLETELY deletes (All movements, scripts, strings, and items involved) the script that was previously at that offset. (Assuming it has an "end" at the end of it.) Of course, this only works if you're using XSE, and it's only guaranteed to work if you're using the latest version of XSE.

Actually, that script offset is right, as clicking 'open script' makes it show the version before converting to the level script, which I did correctly.

Turns out the version of XSE I have rejects 'msgbox' and will only show 'message' commands instead. :S Problem solved.

Nerketur · Feb 10, 2011

Skara said:

AAAAAAAAAAAHHHHHH I WANT TO SCREAM!!!!

I made this script, and since it doesn't want to do anything I assume this isn't correct?

Spoiler:

#org @start
lock
faceplayer
msgbox @text ' Hm? oh, hey. Sorry, I closed my lab down.
msgbox @text ' You can still have a POKéMON though, here.
checkflag 0x0029
if 0x1 jump :end
setflag FR_POKEMON
countpokemon
compare LASTRESULT 6
if == jump @noroom
addpokemon CATERPIE 0x5 ORANBERRY 0 0 0
setflag 0x0029
storepokemon 0 CATERPIE
message @get-msg
fanfare 0x101
showmsg
waitfanfare
waitbutton
:end
release
end

#org @noroom
msgbox @noroom-msg
callstd MSG_NOCLOSE
release
end
callstd MSG_OBTAIN
release
end

#org @text
= Hm? oh, hey. Sorry, I closed my lab down.
= You can still have a POKéMON though, here.
#org @get-msg
= You got a \v\h02!
= And here's your POKéDEX...
setflag 0x829
= I'm Carp by the way, Professor Arty Carp /PWell, I'm out.
disappear

I need help like, now. My hack can't progress otherwise.

Click to expand...

Skara said:

No tutorial, just PKSV generated.

Click to expand...

If that was from PKSV, then PKSV sucks. Hardcore. There are so many errors, it would not compile in XSE unbless you did this (Changed to be a bit more efficient):

Code:

#include stdpoke.rbh #include stditem.rbh #org @start lock faceplayer msgbox @text [color="red"]MSG_NORMAL[/color] ' Hm? oh, hey. Sorry, I closed my lab down. checkflag 0x0828 if 0x1 [COLOR="Red"]goto @end[/COLOR] countpokemon compare LASTRESULT 6 if [COLOR="Red"]B_== goto[/COLOR] @noroom addpokemon [COLOR="Red"]PKMN_CATERPIE[/COLOR] 0x5 [COLOR="Red"]ITEM_ORANBERRY[/COLOR] 0 0 0 setflag [COLOR="Red"]0x828[/COLOR] [COLOR="Red"]hidesprite <Person event number of Professor>[/COLOR] storepokemon 0 PKMN_CATERPIE [COLOR="Red"]// Not sure about this command[/COLOR] [COLOR="Red"]msgbox[/COLOR] @getmsg [COLOR="Red"]MSG_KEEPOPEN[/COLOR] fanfare 0x101 waitfanfare [COLOR="Red"]closeonkeypress[/COLOR] release end #org @end release end #org @noroom msgbox @noroommsg [COLOR="Red"]MSG_KEEPOPEN //Where is this message?[/COLOR] release end #org @text = Hm? oh, hey. Sorry, I closed my lab down./pYou can still have a POKéMON though, here. #org @getmsg = You got a \v\h02!/pAnd here's your POKéDEX.../pI'm Carp by the way, Professor Arty Carp/pWell, I'm out. [COLOR="Red"]#org @noroommsg = You don't have room for this![/COLOR]

Then, set the professor person ID to 0x828, and he/she will disappear for good after the event.

Now, if you want the shortest possible script? You don't need to check when you get your first pokemon, and checking if it's run is pointless if they disappear. So the script becomes

Code:

#include stdpoke.rbh #include stditem.rbh #org @start lock faceplayer msgbox @text [color="red"]MSG_NORMAL[/color] ' Hm? oh, hey. Sorry, I closed my lab down. addpokemon [COLOR="Red"]PKMN_CATERPIE[/COLOR] 0x5 [COLOR="Red"]ITEM_ORANBERRY[/COLOR] 0 0 0 setflag [COLOR="Red"]0x828[/COLOR] [COLOR="Red"]hidesprite <Person event number of Professor>[/COLOR] storepokemon 0 PKMN_CATERPIE [COLOR="Red"]// Not sure about this command[/COLOR] [COLOR="Red"]msgbox[/COLOR] @getmsg [COLOR="Red"]MSG_KEEPOPEN[/COLOR] fanfare 0x101 waitfanfare [COLOR="Red"]closeonkeypress[/COLOR] release end #org @end release end #org @text = Hm? oh, hey. Sorry, I closed my lab down./pYou can still have a POKéMON though, here. #org @getmsg = You got a \v\h02!/pAnd here's your POKéDEX.../pI'm Carp by the way, Professor Arty Carp/pWell, I'm out.

All the RED is changed areas. If it doesn't do what you want, then you fix the rest =) I hope I helped. Next time, learn XSE before trying to do anything. xD

Koute · Feb 11, 2011

ok every time i try to put in a script to a event it never works, like i wanted to add another event to pallet town which i changed name to Birchwood Town it has a park and there was a boy that is gonna complain but thats not it when i open rom and go to that boy and talk to it the rom freezes HALP!

destinedjagold · Feb 12, 2011

Koute said:

ok every time i try to put in a script to a event it never works, like i wanted to add another event to pallet town which i changed name to Birchwood Town it has a park and there was a boy that is gonna complain but thats not it when i open rom and go to that boy and talk to it the rom freezes HALP!

Click to expand...

It would be helpful if you included your script in your post.

Koute · Feb 12, 2011

ok ill show my script its on XSE so....

Code:

'-----------------------
#org 0x900000
faceplayer
faceplayer
msgbox 0x899001C '"Whiney Boy: My mom won't let me go ..."
callstd 0x6
release
end


'---------
' Strings
'---------
#org 0x99001C
= Whiney Boy: My mom won't let me go to the park!

metapod23 · Feb 12, 2011

djvbb12 said:
The setvar stuff is the result of me using part of someone elses script and my lack of understanding. I'd rather not destroy the Daycare...What I want to do seems simple enough and I feel like I shouldn't have to re-write part of the game just to remove two pokemon from the game.

I just wanted to say that I (finally) understand how to do this with HackMew's routine :)

I added it to my previous tutorial for releasing Pokemon with the daycare script:

http://www.pokecommunity.com/showthread.php?p=5599198#asm

^ It's a much better way to release Pokemon you have no intention of having returned to you. I hadn't realized that special 0x9f stores the Pokemon's slot # in your party in the correct variable for HackMew's routine to work :embarrass

(Thanks to JPAN's study on the special commands for helping me with this :))

DrFuji · Feb 12, 2011

Koute said:

ok ill show my script its on XSE so....

Code:

'-----------------------
#org 0x900000
faceplayer
faceplayer
msgbox 0x899001C '"Whiney Boy: My mom won't let me go ..."
callstd 0x6
release
end
 
 
'---------
' Strings
'---------
#org 0x99001C
= Whiney Boy: My mom won't let me go to the park!

I'd suggest that you reread XSE's guide and this tutorial because there are a few problems in the way you constructed this script. Try this instead:

Code:

#org 0x[COLOR=red]8[/COLOR]00000
[COLOR=red]lock[/COLOR]
faceplayer
msgbox @talk [COLOR=red]0x6[/COLOR]
release
end
 
#org @talk
= Whiney Boy: My mom won't let me[COLOR=red]\n[/COLOR]go to the park!

Changes in red.

Koute · Feb 12, 2011

ok but uh like i said the rom freezes

masterquestmq · Feb 13, 2011

2 questions I've checked many tutorials but some of them are rather different to each other.

1) When making a giveitem script do we always need have to set a flag so the player wont be given the same item again if he/she talks to the person?

2)msgbox 0x5

#dynamic 0x800000

#org @start
msgbox @question 0x5
end

#org @questoin
= Will you go?

In the scipt above how do i continue it, for example when the player says yes the person will then say thank you. do we need to do the command like this: if 0x0 goto @thankyou etc?

appreciate the clarification

destinedjagold · Feb 13, 2011

masterquestmq said:

2 questions I've checked many tutorials but some of them are rather different to each other.

1) When making a giveitem script do we always need have to set a flag so the player wont be given the same item again if he/she talks to the person?

2)msgbox 0x5

#dynamic 0x800000

#org @start
msgbox @question 0x5
end

#org @questoin
= Will you go?

In the scipt above how do i continue it, for example when the player says yes the person will then say thank you. do we need to do the command like this: if 0x0 goto @thankyou etc?

appreciate the clarification

Click to expand...

1. yes.
2. msgbox 0x5 is a command wherein it checks the PLAYER's response to the Yes/No options. An example...

Code:

#dynamic 0x800000 #org @start faceplayer [COLOR="Blue"]msgbox @1 0x5[/COLOR] [COLOR="Red"]compare lastresult 0x1[/COLOR] [COLOR="DarkOrange"]if 0x1 goto @yes[/COLOR] goto @no end #org @1 = Will you go? #org @yes message @2 0x6 release end #org @no release end #org @2 = Thank you!

The msgbox 0x5 will ask the PLAYER a question. This will also automatically tell the ROM to pop-up the Yes/No options.
The compare lastresult are commands to tell the ROM if the PLAYER selected yes/0x1 or no/0x0...
The if 0x1 goto @yes will confirm if the PLAYER's input was a yes, and if it is, then it'll proceed to the @yes address. If not, then it'll move to the next line of the script.

pizzaz007 · Feb 13, 2011

I really don't get all this #define stuff, or call, or @blah, because i've learned to just Write it down on notepad. like, i dont know why, but i think it is a lot easier to do it that way, than to use XSE, or whatever. Like here, here is a script that I quickly put together for my game.

Game: Pokemon W.I.P (fire red)
Editor: Notepad (lol)
Script:

Spoiler:

I know, it seems humongus, but i find it easier than using a script editor like XSE. And if anyone didn't know what all that meant, it's basically a give pokedex and pokemon script, running shoes, and a mudkip. Does anyone else use this method? If not, them im going to need to learn how to use XSE...

quick edit: Every time it says 'end' There should be a space there, but on here, i guess they're not shown.

destinedjagold · Feb 13, 2011

pizzaz007 said:

...

Click to expand...

So, why are you posting this again?
Is there a problem with your script? Are you asking someone to rewrite it to XSE format? Or were you just asking if someone else is using this scripting format?

pizzaz007 · Feb 13, 2011

Well, what i was trying to say was just: How do you use XSE mostly. I included something that i typed up using notepad and pokescript, compiled, and put into my game. But you are all using commands like #define, #dynamic, msgbox, and i'm getting confused because i only use the notepad. So how do you use, say, XSE, or any script editor for that reason.

Script Help Thread (DO NOT REQUEST SCRIPTS)

More options

Tropical Sunlight

The Faltine

Skara

THIS. IS. SEMPITERNAL.

fizzmaister

spidermight340

Advanced Trainer

destinedjagold

You can contact me in PC's discord server...

Mana1

Nerketur

PokéScripter

Mana1

Nerketur

PokéScripter

Koute

destinedjagold

You can contact me in PC's discord server...

Koute

metapod23

Hardened Trainer

DrFuji

[I]Heiki Hecchara‌‌[/I]

Koute

masterquestmq

Enthusiastic Rom Hacker

destinedjagold

You can contact me in PC's discord server...

pizzaz007

Why not?

destinedjagold

You can contact me in PC's discord server...

pizzaz007

Why not?