All gen 7 abilities

[mybusiness]

If the player fights Minior x Minior, the colors will be the same (when the first trigger the ability, the opponent will have the same color, thanks @@miniorform= any number). We need to find a way for the program record each Minior Cores. I am trying to use some code inside 'Form' script, but I still don't get it:

MultipleForms.register(:UNOWN,{
"getFormOnCreation"=>proc{|pokemon|
   next rand(28)
}
})

I fixed it. The code is in the post that you quoted; I just replaced the class variable with an instance variable. This is my test of the new code:

 

[WolfPP]

Also we need to find a way to make the correct code for that ability:

At the start of battle or at the end of a turn, if Minior's HP is above half, it will change into its Meteor Form. At the end of the turn, if its HP is below half, it will change back to its Core Form.

The code must trigger when send out one time (like Pressure's codes) and each end of a turn (like Moody's code).

Also we have this situation:
Into the battle, the Minior will changes for Core and then the player runs into the player. If the player heals 100% HP Minior (overworld) its keep into Core Form until start a battle to trigger its ability and then, turn back for Meteor Form.

EDIT: About Follower Pokémon, this will help us. Inside 'Form' script, paste below Hoopa's code:

MultipleForms.register(:MINIOR,{
"getForm"=>proc{|pokemon|
   next 0 if pokemon.hp>((pokemon.totalhp/2).floor)
   next nil
}
})

EDIT: Done! Check here:
https://www.pokecommunity.com/posts/10074381

 

[mybusiness]

That's not necessary, because outside battle is in Core form, regardless of any situation.

 

[WolfPP]

I saw some battles and you're right. However still need a code to recognize to change its form into the end of turn plus hp<=1/2 instead only trigger when its have hp<=1/2.

EDIT: Done! Check here:
https://www.pokecommunity.com/posts/10074381

 

[WolfPP]

Wimp Out and Emergency Exit:
V1.0

Spoiler:

For Wimp Out and Emergency Exit I made this code, inside _Battler script, above Moxie's code:

Spoiler:

    # Wimp Out, Emergency Exit
    if (target.hasWorkingAbility(:WIMPOUT) || target.hasWorkingAbility(:EMERGENCYEXIT)) && 
    target.hp+turneffects[PBEffects::TotalDamage]>(target.totalhp/2).floor && target.hp<=(target.totalhp/2).floor
      PBDebug.log("[Ability triggered] #{target.pbThis}'s #{PBAbilities.getName(target.ability)}")
      if !isConst?(thismove.id,PBMoves,:SUBSTITUTE) || !isConst?(thismove.id,PBMoves,:BELLYDRUM) || 
      !isConst?(thismove.id,PBMoves,:DRAGONTAIL) || !isConst?(thismove.id,PBMoves,:CIRCLETHROW) ||
      !user.hasWorkingAbility(:SHEERFORCE) || !target.effects[PBEffects::SkyDrop] ||
      !target.effects[PBEffects::Confusion]>0 || pbWeather!=PBWeather::HAIL || pbWeather!=PBWeather::SANSTORM ||
      !isConst?(target.item,PBItems,:REDCARD) || !isConst?(target.item,PBItems,:EJECTBUTTON)
        if @battle.pbCanRun?(target.index)
          pbSEPlay("Battle flee")
          @battle.decision=3
        elsif @battle.pbCanChooseNonActive?(target.index)
          target.effects[PBEffects::Uturn]=true
        end
      end
    end

But IDK how to code these parts:
"If it falls below half and recovers back above half from a Shell Bell, Wimp Out/ Emergency Exit will activate even after the Shell Bell recovery, and cause the Pokémon to retreat.";
"If This Ability activates due to being hit by U-turn or Volt Switch, the user of that move will not be switched out".

Anyone know how to code that? Thank you!

V2.0: https://www.pokecommunity.com/posts/10106987

 

[WolfPP]

I made a better script for Wimp Out and Emergency Exit. Check it out!
Fixed Stealth Rock, Spikes, Confuse, Hail, Sandstorm effect (and finally the final version):

In 'PokeBattle_Battler' script:

Spoiler:

I edited Red Card and Eject Button to have a better effect between them plus Wimp Out/Emergency Exit:

Spoiler:

      # Red Card
      if target.hasWorkingItem(:REDCARD) && @battle.pbCanSwitch?(user.index,-1,false)
        @battle.pbDisplay(_INTL("{1} held up its {2} against the {3}!",target.pbThis,PBItems.getName(target.item),user.pbThis(true)))
        next if user.fainted?
        next if [email protected]?(user.index,-1,false)
        choices=[]
        [email protected](user.index)
        for j in 0...party.length
          choices.push(j) if @battle.pbCanSwitchLax?(user.index,j,false)
        end
        if choices.length>0
          newpoke=choices[@battle.pbRandom(choices.length)]
          newpokename=newpoke
          if isConst?(party[newpoke].ability,PBAbilities,:ILLUSION)
            newpokename=pbGetLastPokeInTeam(user.index)
          end
          user.pbResetForm
          @battle.pbRecallAndReplace(user.index,newpoke,newpokename,false,user.hasMoldBreaker)
          @battle.pbDisplay(_INTL("{1} was dragged out!",user.pbThis))
          @battle.choices[user.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
        end
        user.pbAbilitiesOnSwitchIn(true)
        target.pbConsumeItem
      # Eject Button
      elsif target.hasWorkingItem(:EJECTBUTTON) && @battle.pbCanChooseNonActive?(target.index)
        @battle.pbDisplay(_INTL("{1} is switched out with the {2}!",target.pbThis,PBItems.getName(target.item)))
        newpoke=0
        [email protected](target.index,true,false)
        newpokename=newpoke
        if isConst?(@battle.pbParty(target.index)[newpoke].ability,PBAbilities,:ILLUSION)
          newpokename=pbGetLastPokeInTeam(i)
        end
        @battle.battlers[target.index].pbResetForm
        @battle.pbRecallAndReplace(target.index,newpoke,newpokename,@battle.battlers[i].effects[PBEffects::BatonPass])
        @battle.choices[target.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
        target.pbAbilitiesOnSwitchIn(true)
        target.pbConsumeItem
      end

Search Shell Bell's code and paste inside:

Spoiler:

      # User's held items:
      # Shell Bell
      if user.hasWorkingItem(:SHELLBELL) && user.effects[PBEffects::HealBlock]==0
        PBDebug.log("[Item triggered] #{user.pbThis}'s Shell Bell (total damage=#{turneffects[PBEffects::TotalDamage]})")
        previoushp=user.hp
        hpgain=user.pbRecoverHP((turneffects[PBEffects::TotalDamage]/8).floor,true)
        if hpgain>0
          @battle.pbDisplay(_INTL("{1} restored a little HP using its {2}!",user.pbThis,PBItems.getName(user.item)))
        end
        # Wimp Out/ Emergency Exit
        if (user.hasWorkingAbility(:WIMPOUT) || user.hasWorkingAbility(:EMERGENCYEXIT)) && !user.fainted?
          if hpgain>0 && (previoushp<=(user.totalhp/2).floor && user.hp>(user.totalhp/2).floor)
            if [email protected]
              pbSEPlay("Battle flee")
              @battle.pbDisplay(_INTL("{1} fled!",user.pbThis))          
              @battle.choices[user.index][0]=-1; @battle.choices[user.pbPartner.index][0]=-1 if @battle.doublebattle
              @battle.choices[target.index][0]=-1; @battle.choices[target.pbPartner.index][0]=-1 if @battle.doublebattle
              @battle.decision=3
            else
              if @battle.pbCanSwitch?(user.index,-1,false) && [email protected]?(@battle.pbParty(user.index))
                newpoke=0
                [email protected](user.index,true,false)
                newpokename=newpoke
                if isConst?(@battle.pbParty(user.index)[newpoke].ability,PBAbilities,:ILLUSION)
                  newpokename=pbGetLastPokeInTeam(user.index)
                end
                user.pbResetForm
                @battle.pbRecallAndReplace(user.index,newpoke,newpokename) #,@battle.battlers[i].effects[PBEffects::BatonPass])
                @battle.choices[user.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
                user.pbAbilitiesOnSwitchIn(true)
              end
            end
          end
        end
      end

Now, above Moxie's code:

Spoiler:

    # Wimp Out/ Emergency Exit
    if (target.hasWorkingAbility(:WIMPOUT) || target.hasWorkingAbility(:EMERGENCYEXIT)) && !target.fainted?
      target.pbBerryCureCheck(true) if target.hasMovedThisRound?
      if !target.effects[PBEffects::SkyDrop]
        if target.hp+turneffects[PBEffects::TotalDamage]>(target.totalhp/2).floor && target.hp<=(target.totalhp/2).floor
          PBDebug.log("[Ability triggered] #{target.pbThis}'s #{PBAbilities.getName(target.ability)}")
          if !isConst?(thismove.id,PBMoves,:SUBSTITUTE) || !isConst?(thismove.id,PBMoves,:BELLYDRUM) || 
          !isConst?(thismove.id,PBMoves,:DRAGONTAIL) || !isConst?(thismove.id,PBMoves,:CIRCLETHROW) ||
          !(user.hasWorkingAbility(:SHEERFORCE) && thismove.addlEffect>0) || !pbConfusionDamage
            if [email protected]
              pbSEPlay("Battle flee")
              @battle.pbDisplay(_INTL("{1} fled!",target.pbThis))          
              @battle.choices[target.index][0]=-1; @battle.choices[target.pbPartner.index][0]=-1 if @battle.doublebattle
              @battle.choices[user.index][0]=-1; @battle.choices[user.pbPartner.index][0]=-1 if @battle.doublebattle
              @battle.decision=3
            else
              if @battle.pbCanSwitch?(target.index,-1,false) && [email protected]?(@battle.pbParty(target.index))
                newpoke=0
                [email protected](target.index,true,false)
                newpokename=newpoke
                if isConst?(@battle.pbParty(target.index)[newpoke].ability,PBAbilities,:ILLUSION)
                  newpokename=pbGetLastPokeInTeam(target.index)
                end
                target.pbResetForm
                @battle.pbRecallAndReplace(target.index,newpoke,newpokename)
                @battle.choices[target.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
                target.pbAbilitiesOnSwitchIn(true)
              end
            end
          end
        end
      end
    end

Now, in 'PokeBattle_MoveEffects' script:

Spoiler:

################################################################################
# After inflicting damage, user switches out. Ignores trapping moves.
# (U-turn, Volt Switch)
# TODO: Pursuit should interrupt this move.
################################################################################
class PokeBattle_Move_0EE < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    ret=super(attacker,opponent,hitnum,alltargets,showanimation)
    if !attacker.fainted? && opponent.damagestate.calcdamage>0 &&
    @battle.pbCanChooseNonActive?(attacker.index) &&
    [email protected]?(@battle.pbParty(opponent.index))
      attacker.effects[PBEffects::Uturn]=true
    end
    return ret
  end
  
  def pbEffectAfterHit(attacker,opponent,turneffects)
    if !attacker.fainted? && opponent.damagestate.calcdamage>0 && 
    @battle.pbCanChooseNonActive?(attacker.index) && [email protected]?(@battle.pbParty(opponent.index))
      if (opponent.hasWorkingAbility(:WIMPOUT) || opponent.hasWorkingAbility(:EMERGENCYEXIT)) && 
      opponent.hp+turneffects[PBEffects::TotalDamage]>(opponent.totalhp/2).floor && 
      opponent.hp<=(opponent.totalhp/2).floor
         attacker.effects[PBEffects::Uturn]=false
      end
    end
  end
end

Finally, 'PokeBattle_Battle' script inside 'def pbOnActiveOne(pkmn,onlyabilities=false,moldbreaker=false)', replace Stealth Rock and Spikes code:

Spoiler:

      # Spikes
      if pkmn.pbOwnSide.effects[PBEffects::Spikes]>0 && !pkmn.isAirborne?(moldbreaker)
        if !pkmn.hasWorkingAbility(:MAGICGUARD)
          PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Spikes")
          spikesdiv=[8,6,4][pkmn.pbOwnSide.effects[PBEffects::Spikes]-1]
          @scene.pbDamageAnimation(pkmn,0)
          previoushp=pkmn.hp
          pkmn.pbReduceHP((pkmn.totalhp/spikesdiv).floor)
          afterhp=pkmn.hp
          pbDisplayPaused(_INTL("{1} is hurt by the spikes!",pkmn.pbThis))
          # Wimp Out/ Emergency Exit
          if (pkmn.hasWorkingAbility(:WIMPOUT) || pkmn.hasWorkingAbility(:EMERGENCYEXIT)) && !pkmn.fainted?
            if previoushp>(pkmn.totalhp/2).floor && afterhp<=(pkmn.totalhp/2).floor
              PBDebug.log("[Ability triggered] #{pkmn.pbThis}'s #{PBAbilities.getName(pkmn.ability)}")
              if !@opponent && !pbCanSwitch?(pkmn.index,-1,false) && !pbAllFainted?(pbParty(pkmn.index))
                pbSEPlay("Battle flee")
                pbDisplay(_INTL("{1} fled!",pkmn.pbThis))          
                @choices[pkmn.index][0]=-1; @choices[pkmn.pbPartner.index][0]=-1 if @doublebattle
                @choices[pbIsOpposing?(pkmn).index][0]=-1; @choices[pbIsOpposing?(pkmn).pbPartner.index][0]=-1 if @doublebattle
                @decision=3
              else
                if pbCanSwitch?(pkmn.index,-1,false) && !pbAllFainted?(pbParty(pkmn.index))
                  newpoke=0
                  newpoke=pbSwitchInBetween(pkmn.index,true,false)
                  newpokename=newpoke
                  if isConst?(pbParty(pkmn.index)[newpoke].ability,PBAbilities,:ILLUSION)
                    newpokename=pbGetLastPokeInTeam(pkmn.index)
                  end
                  pkmn.pbResetForm
                  pbRecallAndReplace(pkmn.index,newpoke,newpokename)
                  @choices[pkmn.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
                  pkmn.pbAbilitiesOnSwitchIn(true)
                end
              end
            end
          end
        end
      end
      pkmn.pbFaint if pkmn.fainted?
      # Stealth Rock
      if pkmn.pbOwnSide.effects[PBEffects::StealthRock] && !pkmn.fainted?
        if !pkmn.hasWorkingAbility(:MAGICGUARD)
          atype=getConst(PBTypes,:ROCK) || 0
          eff=PBTypes.getCombinedEffectiveness(atype,pkmn.type1,pkmn.type2,pkmn.effects[PBEffects::Type3])
          if eff>0
            PBDebug.log("[Entry hazard] #{pkmn.pbThis} triggered Stealth Rock")
            @scene.pbDamageAnimation(pkmn,0)
            previoushp=pkmn.hp
            pkmn.pbReduceHP(((pkmn.totalhp*eff)/64).floor)
            afterhp=pkmn.hp
            pbDisplayPaused(_INTL("Pointed stones dug into {1}!",pkmn.pbThis))
            # Wimp Out/ Emergency Exit
            if (pkmn.hasWorkingAbility(:WIMPOUT) || pkmn.hasWorkingAbility(:EMERGENCYEXIT)) && !pkmn.fainted?
              if previoushp>(pkmn.totalhp/2).floor && afterhp<=(pkmn.totalhp/2).floor
                PBDebug.log("[Ability triggered] #{pkmn.pbThis}'s #{PBAbilities.getName(pkmn.ability)}")
                if !@opponent && !pbCanSwitch?(pkmn.index,-1,false) && !pbAllFainted?(pbParty(pkmn.index))
                  pbSEPlay("Battle flee")
                  pbDisplay(_INTL("{1} fled!",pkmn.pbThis))          
                  @choices[pkmn.index][0]=-1; @choices[pkmn.pbPartner.index][0]=-1 if @doublebattle
                  @choices[pbIsOpposing?(pkmn).index][0]=-1; @choices[pbIsOpposing?(pkmn).pbPartner.index][0]=-1 if @doublebattle
                  @decision=3
                else
                  if pbCanSwitch?(pkmn.index,-1,false) && !pbAllFainted?(pbParty(pkmn.index))
                    newpoke=0
                    newpoke=pbSwitchInBetween(pkmn.index,true,false)
                    newpokename=newpoke
                    if isConst?(pbParty(pkmn.index)[newpoke].ability,PBAbilities,:ILLUSION)
                      newpokename=pbGetLastPokeInTeam(pkmn.index)
                    end
                    pkmn.pbResetForm
                    pbRecallAndReplace(pkmn.index,newpoke,newpokename)
                    @choices[pkmn.index]=[0,0,nil,-1]   # Replacement Pokémon does nothing this round
                    pkmn.pbAbilitiesOnSwitchIn(true)
                  end
                end
              end
            end
          end
        end
      end
      pkmn.pbFaint if pkmn.fainted?
      # Toxic Spikes

And done! Cya

 

[Juno and Ice]

What's the difference between this one and the one made by mybusiness?

 

[WolfPP]

Pretty sure you can compare and check for yourself.

P.S: New and definitive script, check my previous post.

 

[WolfPP]

Upgrade about CORROSION ability. Only trigger about opponent type (POISON or METAL):
V1.0

Spoiler:

Spoiler:

################################################################################
# Poisons the target.
################################################################################
class PokeBattle_Move_005 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return super(attacker,opponent,hitnum,alltargets,showanimation) if pbIsDamaging?
    if attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
      opponent.pbPoison(attacker)
      return 0
    else
      return -1 if !opponent.pbCanPoison?(attacker,true,self)
    end
    return -1 if !opponent.pbCanPoison?(attacker,true,self)
    pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
    opponent.pbPoison(attacker)
    return 0
  end

  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanPoison?(attacker,false,self) ||
    attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      opponent.pbPoison(attacker)
    end
  end
end

Spoiler:

################################################################################
# Badly poisons the target. (Poison Fang, Toxic)
# (Handled in Battler's pbSuccessCheck): Hits semi-invulnerable targets if user
# is Poison-type and move is status move.
################################################################################
class PokeBattle_Move_006 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return super(attacker,opponent,hitnum,alltargets,showanimation) if pbIsDamaging?
    if attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
      opponent.pbPoison(attacker,nil,true)
      return 0
    else
      return -1 if !opponent.pbCanPoison?(attacker,true,self)
    end
    return -1 if !opponent.pbCanPoison?(attacker,true,self)
    pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation)
    opponent.pbPoison(attacker,nil,true)
    return 0
  end

  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanPoison?(attacker,false,self) ||
    attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      opponent.pbPoison(attacker,nil,true)
    end
  end
end

Spoiler:

################################################################################
# Hits twice. May poison the target on each hit. (Twineedle)
################################################################################
class PokeBattle_Move_0BE < PokeBattle_Move
  def pbIsMultiHit
    return true
  end

  def pbNumHits(attacker)
    return 2
  end

  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanPoison?(attacker,false,self) || 
    attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      opponent.pbPoison(attacker)
    end
  end
end

Spoiler:

################################################################################
# Poisons the target and lowers its speed. (Toxic Thread)
################################################################################
class PokeBattle_Move_1B9 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    return super(attacker,opponent,hitnum,alltargets,showanimation) if pbIsDamaging?
    speed=opponent.pbCanReduceStatStage?(PBStats::SPEED,attacker,false,self)
    poison=opponent.pbCanPoison?(attacker,false,self)
    pbShowAnimation(@id,attacker,opponent,hitnum,alltargets,showanimation) if speed || poison
    ret=false
    ret=opponent.pbReduceStat(PBStats::SPEED,1,attacker,true,self) if speed
    ret|=poison
    opponent.pbPoison(attacker) if poison || attacker.hasWorkingAbility(:CORROSION) && opponent.status==0  &&
                                             opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
    @battle.pbDisplay(_INTL("But it failed!")) if !ret
    return ret ? 0 : -1
  end

  def pbAdditionalEffect(attacker,opponent)
    return if opponent.damagestate.substitute
    if opponent.pbCanReduceStatStage?(PBStats::SPEED,attacker,false,self)
      opponent.pbReduceStat(PBStats::SPEED,1,attacker,false,self)
    end
    if opponent.pbCanPoison?(attacker,false,self) ||
    attacker.hasWorkingAbility(:CORROSION) && opponent.status==0 &&
    opponent.pbHasType?(:POISON) || opponent.pbHasType?(:STEEL)
      opponent.pbPoison(attacker)
    end
  end
end

V2.0

Spoiler:

if (attacker && attacker.hasWorkingAbility(:CORROSION))
  if !attacker || !attacker.hasMoldBreaker
    return true if (pbHasType?(:POISON) || pbHasType?(:STEEL))
    end
  end
end

Above:

if (pbHasType?(:POISON) || pbHasType?(:STEEL)) && !hasWorkingItem(:RINGTARGET)'

V3.0
Inside def pbPoison?(attacker,showMessages,move=nil), replace the code to recognize STEEL and POISON types to:

if (pbHasType?(:POISON) || pbHasType?(:STEEL))  && !(attacker && attacker.hasWorkingAbility(:CORROSION)) && !hasWorkingItem(:RINGTARGET)
  @battle.pbDisplay(_INTL("It doesn't affect {1}...",pbThis(true))) if showMessages
  return false
end

 

[mgriffin]

Upgrade about CORROSION ability. Only trigger about opponent type (POISON or METAL):

I didn't quite follow all your code, so maybe this suggestion is bad, but I'd recommend trying to change pbCanPoison? to do the Corrosion check because then you wouldn't need to change each move effect (and it should automatically work if you add new move effects that can poison).

 

[WolfPP]

I didn't quite follow all your code, so maybe this suggestion is bad, but I'd recommend trying to change pbCanPoison? to do the Corrosion check because then you wouldn't need to change each move effect (and it should automatically work if you add new move effects that can poison).

I tried but if I add for this unique case, sometimes will crash the game with this error:
https://www.pokecommunity.com/threads/401106

That is why I made that, adding inside Move Effect instead BattleEffect.

EDIT: New code (V3.0) into previous post than I made.

 

[Juno and Ice]

I tried but if I add for this unique case, sometimes will crash the game with this error:
https://www.pokecommunity.com/threads/401106

That is why I made that, adding inside Move Effect instead BattleEffect.

EDIT: New code (V3.0) into previous post than I made.

So If i put 3.0 i don't have to add the other scripts in Move Effects?

 

[WolfPP]

So If i put 3.0 i don't have to add the other scripts in Move Effects?

Correct. It is the last/final version.

 

[WolfPP]

Yeah, probably you have to replace "damagemult" with "finaldamagemult". Meanwhile you repair that, these are the next abilities:

Queenly Majesty and Dazzling:
In PokeBattle_Battler, just under def pbSuccessCheck":

Spoiler:

def pbSuccessCheck(thismove,user,target,turneffects,accuracy=true)
[COLOR="Red"]    if (target.hasWorkingAbility(:DAZZLING) || 
       target.hasWorkingAbility(:QUEENLYMAJESTY)) && thismove.priority>0 &&
       !thismove.doesIgnoreDazzling? && !user.hasMoldBreaker
      thismove.pp -=1
      PBDebug.log("#{target.pbThis}'s #{PBAbilities.getName(target)} prevented #{user.pbThis}'s priority move")
      @battle.pbDisplay(_INTL("{1} cannot use {2} due to {3}!",
                        user.pbThis,
                        PBMoves.getName(thismove),
                        PBAbilities.getName(target.ability)))
      return false
    end[/COLOR]
    if user.effects[PBEffects::TwoTurnAttack]>0
      return true
    end

In PokeBattle_Move, under def isBombMove?, place this def:

Spoiler:

def doesIgnoreDazzling?
    return isConst?(@id,PBMoves,:ELECTRICTERRAIN) ||
           isConst?(@id,PBMoves,:FAIRYLOCK) ||
           isConst?(@id,PBMoves,:GRASSYTERRAIN) ||
           isConst?(@id,PBMoves,:GRAVITY) ||
           isConst?(@id,PBMoves,:HAIL) ||
           isConst?(@id,PBMoves,:HAZE) ||
           isConst?(@id,PBMoves,:IONDELUGE) ||
           isConst?(@id,PBMoves,:MAGICROOM) ||
           isConst?(@id,PBMoves,:MISTYTERRAIN) ||
           isConst?(@id,PBMoves,:MUDSPORT) ||
           isConst?(@id,PBMoves,:PSYCHICTERRAIN) ||
           isConst?(@id,PBMoves,:RAINDANCE) ||
           isConst?(@id,PBMoves,:SANDSTORM) ||
           isConst?(@id,PBMoves,:SUNNYDAY) ||
           isConst?(@id,PBMoves,:TRICKROOM) ||
           isConst?(@id,PBMoves,:WATERSPORT) ||
           isConst?(@id,PBMoves,:WONDERROOM) ||
           isConst?(@id,PBMoves,:SPIKES) ||
           isConst?(@id,PBMoves,:STEALTHROCK) ||
           isConst?(@id,PBMoves,:STICKYWEB) ||
           isConst?(@id,PBMoves,:TOXICSPIKES)
  end

Done.

We need to add one more think for Queenly Majestic/ Dazzling:

Moves that target all Pokémon (except Perish Song, Flower Shield, and Rototiller) cannot be blocked by Queenly Majesty, even if they become priority moves. 
[URL="https://bulbapedia.bulbagarden.net/wiki/Queenly_Majesty_(Ability)"]Font.[/URL]

Am trying to code but I still don't get how to make this part: "except Perish Song, Flower Shield, and Rototiller".

What I have so far inside 'def pbSuccessCheck(thismove,user,target,turneffects,accuracy=true)':

    partner=target.pbPartner
    if (target.hasWorkingAbility(:DAZZLING)  || target.hasWorkingAbility(:QUEENLYMAJESTY) || 
        partner.hasWorkingAbility(:DAZZLING) || partner.hasWorkingAbility(:QUEENLYMAJESTY))
      if !user.hasMoldBreaker && p>0 && !PBTargets.hasMultipleTargets?(thismove)
        thismove.pp -=1
        @battle.pbDisplay(_INTL("{1} cannot use {2}!",user.pbThis,PBMoves.getName(thismove)))
        return false
      end
    end
    if target.pbOwnSide.effects[PBEffects::QuickGuard] && thismove.canProtectAgainst? &&

 

[Maruno]

We need to add one more think for Queenly Majestic/ Dazzling:

Moves that target all Pokémon (except Perish Song, Flower Shield, and Rototiller) cannot be blocked by Queenly Majesty, even if they become priority moves. 
[URL="https://bulbapedia.bulbagarden.net/wiki/Queenly_Majesty_(Ability)"]Font.[/URL]

Am trying to code but I still don't get how to make this part: "except Perish Song, Flower Shield, and Rototiller".

You don't need anything special for those exceptions. The moves should have a target of 20, which means they don't target specific Pokémon, and so they don't call def pbSuccessCheck at all. This means these moves bypass your code for Queenly Majesty/Dazzling as desired.

 

[WolfPP]

You don't need anything special for those exceptions. The moves should have a target of 20, which means they don't target specific Pokémon, and so they don't call def pbSuccessCheck at all. This means these moves bypass your code for Queenly Majesty/Dazzling as desired.

But if Pokémon with Prankster uses Perish Song/ Rototiller/ Flower Shield will put priority + 1 for them because they are "Status Move". So, Queenly Majestic/ Dazzling need to trigger. Am I wrong?

 

[Maruno]

The effect of Queenly Majesty/Dazzling need to be specially added to the function code methods for those particular moves.

 

[WolfPP]

Yep. Queenly Majesty and Dazzling:

First, in ' def pbSuccessCheck(thismove,user,target,turneffects,accuracy=true)' paste below 'if USENEWBATTLEMECHANICS':

    if p>0 && thismove.target!=PBTargets::AllOpposing && thismove.target!=PBTargets::BothSides
      for i in 0...4; [email protected][i]
        if @battle.field.effects[PBEffects::PsychicTerrain]>0 && !user.isAirborne?
          PBDebug.log("Psychic Terrain prevented #{user.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("The psychic terrain prevented the use of priority moves!"))
          return false
        elsif !user.hasMoldBreaker && pbIsOpposing?(i) && (battler.hasWorkingAbility(:QUEENLYMAJESTY) || 
                                                           battler.hasWorkingAbility(:DAZZLING))
          @battle.pbDisplay(_INTL("{1} cannot use {2}!",user.pbThis,PBMoves.getName(thismove)))
          return false
        end
      end
    end

Now, Replace the Perish Song, Rototiller and Flower Shield move scripts for:

Spoiler:

################################################################################
# All current battlers will perish after 3 more rounds. (Perish Song)
################################################################################
class PokeBattle_Move_0E5 < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if attacker.hasWorkingAbility(:PRANKSTER)
      for i in @battle.battlers
        if @battle.field.effects[PBEffects::PsychicTerrain]>0 && !i.isAirborne?
          PBDebug.log("Psychic Terrain prevented #{i.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("The psychic terrain prevented the use of priority moves!"))
          return -1
        elsif attacker.pbIsOpposing?(i.index) && 
             (i.hasWorkingAbility(:QUEENLYMAJESTY) || i.hasWorkingAbility(:DAZZLING))
          PBDebug.log("[Ability triggered] prevents #{attacker.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("{1} cannot use {2}!",attacker.pbThis,PBMoves.getName(@id)))
          return -1
        end
      end
    end
    failed=true
    for i in 0...4
      if @battle.battlers[i].effects[PBEffects::PerishSong]==0 &&
         (attacker.hasMoldBreaker ||
         [email protected][i].hasWorkingAbility(:SOUNDPROOF))
        failed=false; break
      end   
    end
    if failed
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation)
    @battle.pbDisplay(_INTL("All Pokémon that hear the song will faint in three turns!"))
    for i in 0...4
      if @battle.battlers[i].effects[PBEffects::PerishSong]==0
        if !attacker.hasMoldBreaker && @battle.battlers[i].hasWorkingAbility(:SOUNDPROOF)
          @battle.pbDisplay(_INTL("{1}'s {2} blocks {3}!",@battle.battlers[i].pbThis,
             PBAbilities.getName(@battle.battlers[i].ability),@name))
        else
          @battle.battlers[i].effects[PBEffects::PerishSong]=4
          @battle.battlers[i].effects[PBEffects::PerishSongUser]=attacker.index
        end
      end
    end
    return 0
  end
end

################################################################################
# Increases the Attack and Special Attack of all Grass-type Pokémon on the field
# by 1 stage each. Doesn't affect airborne Pokémon. (Rototiller)
################################################################################
class PokeBattle_Move_13E < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if attacker.hasWorkingAbility(:PRANKSTER)
      for i in @battle.battlers
        if @battle.field.effects[PBEffects::PsychicTerrain]>0 && !i.isAirborne?
          PBDebug.log("Psychic Terrain prevented #{i.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("The psychic terrain prevented the use of priority moves!"))
          return -1
        elsif attacker.pbIsOpposing?(i.index) && 
             (i.hasWorkingAbility(:QUEENLYMAJESTY) || i.hasWorkingAbility(:DAZZLING))
          PBDebug.log("[Ability triggered] prevents #{attacker.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("{1} cannot use {2}!",attacker.pbThis,PBMoves.getName(@id)))
          return -1
        end
      end
    end
    didsomething=false
    for i in [attacker,attacker.pbPartner,attacker.pbOpposing1,attacker.pbOpposing2]
      next if !i || i.fainted?
      next if !i.pbHasType?(:GRASS)
      next if i.isAirborne?(attacker.hasMoldBreaker)
      next if !i.pbCanIncreaseStatStage?(PBStats::ATTACK,attacker,false,self) &&
              !i.pbCanIncreaseStatStage?(PBStats::SPATK,attacker,false,self)
      pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation) if !didsomething
      didsomething=true
      showanim=true
      if i.pbCanIncreaseStatStage?(PBStats::ATTACK,attacker,false,self)
        i.pbIncreaseStat(PBStats::ATTACK,1,attacker,false,self,showanim)
        showanim=false
      end
      if i.pbCanIncreaseStatStage?(PBStats::SPATK,attacker,false,self)
        i.pbIncreaseStat(PBStats::SPATK,1,attacker,false,self,showanim)
        showanim=false
      end
    end
    if !didsomething
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    return 0
  end
end

################################################################################
# Increases the Defense of all Grass-type Pokémon on the field by 1 stage each.
# (Flower Shield)
################################################################################
class PokeBattle_Move_13F < PokeBattle_Move
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    if attacker.hasWorkingAbility(:PRANKSTER)
      for i in @battle.battlers
        if @battle.field.effects[PBEffects::PsychicTerrain]>0 && !i.isAirborne?
          PBDebug.log("Psychic Terrain prevented #{i.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("The psychic terrain prevented the use of priority moves!"))
          return -1
        elsif attacker.pbIsOpposing?(i.index) && 
             (i.hasWorkingAbility(:QUEENLYMAJESTY) || i.hasWorkingAbility(:DAZZLING))
          PBDebug.log("[Ability triggered] prevents #{attacker.pbThis}'s priority move")
          @battle.pbDisplay(_INTL("{1} cannot use {2}!",attacker.pbThis,PBMoves.getName(@id)))
          return -1
        end
      end
    end
    didsomething=false
    for i in [attacker,attacker.pbPartner,attacker.pbOpposing1,attacker.pbOpposing2]
      next if !i || i.fainted?
      next if !i.pbHasType?(:GRASS)
      next if !i.pbCanIncreaseStatStage?(PBStats::ATTACK,attacker,false,self)
      pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation) if !didsomething
      didsomething=true
      showanim=true
      if i.pbCanIncreaseStatStage?(PBStats::DEFENSE,attacker,false,self)
        i.pbIncreaseStat(PBStats::DEFENSE,1,attacker,false,self,showanim)
        showanim=false
      end
    end
    if !didsomething
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    return 0
  end
end

P.S: Added Psychic Terrain inside the code.

 

[WolfPP]

Better code for Disguise. Delete all you have (if so and want a new code for that ability):

In 'def pbConfusionDamage' replace for (Disguise will be trigger if Mimikyu hit itself by Confusion):

Spoiler:

  def pbConfusionDamage
    if isConst?(self.species,PBSpecies,:MIMIKYU) && self.hasWorkingAbility(:DISGUISE) && self.form!=1
      @battle.pbAnimation(getConst(PBMoves,:TACKLE),self,self) #nil)
      @battle.scene.pbDamageAnimation(self,0)
      @battle.pbDisplay(_INTL("Its disguise served it as a decoy!"))
      self.form=1; pbUpdate(true)
      @battle.scene.pbChangePokemon(self,@pokemon)
      @battle.pbDisplay(_INTL("{1}'s disguise was busted!",self.pbThis))
      PBDebug.log("[Form changed] #{self.pbThis} changed to form #{self.form}")
    else
      self.damagestate.reset
      confmove=PokeBattle_Confusion.new(@battle,nil)
      confmove.pbEffect(self,self)
      pbFaint if fainted?
    end
  end

Now, in 'def pbReduceHPDamage(damage,attacker,opponent)' add a 'elsif' below Substitute case, like:

Spoiler:

  def pbReduceHPDamage(damage,attacker,opponent)
    endure=false
    if opponent.effects[PBEffects::Substitute]>0 && !ignoresSubstitute?(attacker) &&
       (!attacker || attacker.index!=opponent.index)
      PBDebug.log("[Lingering effect triggered] #{opponent.pbThis}'s Substitute took the damage")
      damage=opponent.effects[PBEffects::Substitute] if damage>opponent.effects[PBEffects::Substitute]
      opponent.effects[PBEffects::Substitute]-=damage
      opponent.damagestate.substitute=true
      @battle.scene.pbDamageAnimation(opponent,0)
      @battle.pbDisplayPaused(_INTL("The substitute took damage for {1}!",opponent.name))
      if opponent.effects[PBEffects::Substitute]<=0
        opponent.effects[PBEffects::Substitute]=0
        @battle.pbDisplayPaused(_INTL("{1}'s substitute faded!",opponent.name))
        PBDebug.log("[End of effect] #{opponent.pbThis}'s Substitute faded")
      end
      opponent.damagestate.hplost=damage
      damage=0
    elsif isConst?(opponent.species,PBSpecies,:MIMIKYU) && opponent.hasWorkingAbility(:DISGUISE) && 
          opponent.form!=1
      @battle.scene.pbDamageAnimation(opponent,0)
      @battle.pbDisplay(_INTL("Its disguise served it as a decoy!"))
      opponent.form=1; opponent.pbUpdate(true)
      @battle.scene.pbChangePokemon(opponent,opponent.pokemon)
      @battle.pbDisplay(_INTL("{1}'s disguise was busted!",opponent.name))
      PBDebug.log("[Form changed] #{opponent.pbThis} changed to form #{opponent.form}")
    else opponent.hasWorkingAbility(:STURDY) && !attacker.hasMoldBreaker
      opponent.damagestate.substitute=false

Then, after battle (winning or losing) Mimikyu will turns back to Disguised form. So, go to 'def pbAfterBattle(decision,canlose)' and add for Mimikyu case, like:

Spoiler:

def pbAfterBattle(decision,canlose)
  for i in $Trainer.party
    (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil)
    i.form=0 if isConst?(i.species,PBSpecies,:MIMIKYU)  && i.form!=0 
  end
  if $PokemonGlobal.partner
    pbHealAll
    for i in $PokemonGlobal.partner[3]
      i.heal
      (i.makeUnmega rescue nil); (i.makeUnprimal rescue nil)
       i.form=0 if isConst?(i.species,PBSpecies,:MIMIKYU)  && i.form!=0 
    end
  end
  if decision==2 || decision==5 # if loss or draw

Finally if Mimikyu fainted will turns back to Disguised form. For that case, go inside 'def pbFaint(showMessage=true)' and add below '@pokemon.makeUnprimal if self.isPrimal?':

Spoiler:

    # Reset status
    self.status=0
    self.statusCount=0
    if @pokemon && @battle.internalbattle
      @pokemon.changeHappiness("faint")
    end
    @pokemon.makeUnmega if self.isMega?
    @pokemon.makeUnprimal if self.isPrimal?
    @pokemon.form=0 if isConst?(self.species,PBSpecies,:MIMIKYU) && self.form!=0
    @fainted=true
    # reset choice

P.S: If player revives Mimikyu, it can trigger its Disguise ability again.

Cya!

 

[WolfPP]

About Innards Out we have:

Inside 'PokeBattle_Battler' script, below 'PBDebug.log("Move did #{numhits} hit(s), total damage=#{turneffects[PBEffects::TotalDamage]}")', paste (like):

    PBDebug.log("Move did #{numhits} hit(s), total damage=#{turneffects[PBEffects::TotalDamage]}")
    # Innards Out
    if target.ability==PBAbilities::INNARDSOUT && target.fainted? && 
       thismove.basedamage>0 && !target.effects[PBEffects::GastroAcid] &&
       !user.hasWorkingAbility(:MAGICGUARD)
      PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
      user.pbReduceHP(turneffects[PBEffects::TotalDamage])
      @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
    end
    # Faint if 0 HP

But we still have to implement this part:

If a Pokémon with this Ability faints through Future Sight or Doom Desire, Innards Out will only activate if the user of the move is still on the field.

Any idea?

EDIT: SOLVED! The new code:

    # Innards Out
    if target.ability==PBAbilities::INNARDSOUT && target.fainted? && 
       thismove.basedamage>0 && !target.effects[PBEffects::GastroAcid] &&
       !user.hasWorkingAbility(:MAGICGUARD)
      if target.effects[PBEffects::FutureSight]>0
        for i in 0...4
          if target.effects[PBEffects::FutureSightUser][email protected][i].pokemonIndex &&
             [email protected][i].fainted?
            PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
            user.pbReduceHP(turneffects[PBEffects::TotalDamage])
            @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
            break
          end
        end
      else
        PBDebug.log("[Ability triggered] #{target.pbThis}'s Innards Out")
        user.pbReduceHP(turneffects[PBEffects::TotalDamage])
        @battle.pbDisplay(_INTL("{1} is hurt!",user.pbThis))
      end
    end