[Scripting Question] Creating a new utility

[Telemetius]

Hi forum

I just noticed that the utility pbHasType only works for your party.
So I tried writing a similar one that checks if the opponent has a particular type.
It's not working and I'd like to know why is that.

Is it because @battle.opponent.party is not a method?

def pbOppHasType?(type)
  if type.is_a?(String) || type.is_a?(Symbol)
    type=getID(PBTypes,type)
  end
  for pokemon in @battle.opponent.party
    next if pokemon.isEgg?
    return true if pokemon.hasType?(type)
  end
  return false
end

 

[Zeak6464]

Hi forum

I just noticed that the utility pbHasType only works for your party.
So I tried writing a similar one that checks if the opponent has a particular type.
It's not working and I'd like to know why is that.

Is it because @battle.opponent.party is not a method?

def pbOppHasType?(type)
  if type.is_a?(String) || type.is_a?(Symbol)
    type=getID(PBTypes,type)
  end
  for pokemon in @battle.opponent.party
    next if pokemon.isEgg?
    return true if pokemon.hasType?(type)
  end
  return false
end

wouldn't be "trainer[0]" instead of "@battle.opponent.party" ?

 

[Telemetius]

wouldn't be "trainer[0]" instead of "@battle.opponent.party" ?

Undefined local variable when using "trainer".
Is there anything else that might work?

 

[mej71]

You should read Lesson 2 here:
(broken link removed)

This is the danger of just plugging in words, they're most likely not defined.
Assuming you want to check the trainer outside of a battle, you'll have to instantiate that trainer yourself and then check.

Try

def pbOppHasType?(type, trainerid, trainername, partyid=0)
  if type.is_a?(String) || type.is_a?(Symbol)
    type=getID(PBTypes,type)
  end
  opp = pbLoadTrainer(trainerid,trainername,partyid=0)
  return false if opp.nil?
  for pokemon in opp[2]
    next if pokemon.isEgg?
    return true if pokemon.hasType?(type)
  end
  return false
end

 

[Telemetius]

An array saves the day.