Is there a fix for some animations having missing targets?

[Rayd12smitty]

There is an issue with the newest version of essentials with move animations. I know Maruno knows about it and has brought it up. In PokeBattle_MoveEffects for pbShowAnimation or something like that, in certain places it says nil instead of opponent. He said you need to fix some of these, but not specific. I can probably figure it out, but was wondering if anyone has already done this and would be willing to share.

 

[AlexTCGPro]

just change nil to opponent and that should fix it.

 

[ActionReplayer]

just change nil to opponent and that should fix it.

He knows that. But the thing is, there are MANY, MANY attacks, and not all of them should have this change. To see which animations require change would require actually testing each and every single attack in game that has an animation and that would take forever. That not to mention many attacks that don't have animations yet also need to make this change.

To resume: Ray knows about the nil to opponent thing, he made this thread to ask for a way to do it that wouldn't take a whole week.

 

[Rayd12smitty]

He knows that. But the thing is, there are MANY, MANY attacks, and not all of them should have this change. To see which animations require change would require actually testing each and every single attack in game that has an animation and that would take forever. That not to mention many attacks that don't have animations yet also need to make this change.

To resume: Ray knows about the nil to opponent thing, he made this thread to ask for a way to do it that wouldn't take a whole week.

Thank you haha. I thought I was pretty clear with this. It's not worth my entire week to fix this when it will get fixed eventually

 

[Maruno]

It took me 10 minutes to go through the appropriate script and add in opponent where necessary. It's just a matter of looking at the effect and deciding whether an animation which causes that effect would involve the target in some way. Growl, yes. Damaging moves, yes. Growth, no. That kind of thing. I didn't think it was difficult.

 

[Rayd12smitty]

It took me 10 minutes to go through the appropriate script and add in opponent where necessary. It's just a matter of looking at the effect and deciding whether an animation which causes that effect would involve the target in some way. Growl, yes. Damaging moves, yes. Growth, no. That kind of thing. I didn't think it was difficult.

I feel like I don't know quite enough. I gave it a try with teleport (or what I thought was teleport) and tested it and it didn't change anything. I feel like someone else can do this better... I'll try again though

 

[Maruno]

...Teleport doesn't involve the target. Why would it? It's the user who's teleporting.

In PokeBattle_MoveEffects for pbShowAnimation or something like that, in certain places it says nil instead of opponent. He said you need to fix some of these

This is all you need to do. You don't need to touch the animations themselves; they're fine.

 

[Rayd12smitty]

...Teleport doesn't involve the target. Why would it? It's the user who's teleporting.


This is all you need to do. You don't need to touch the animations themselves; they're fine.

When an opponent uses teleport the animation appears in the top left corner instead of on the attacker. I assumed it was a related issue.

 

[Maruno]

Teleport's animation is a placeholder, and just wrong (it's a copy of StatUp which focusses on the target). It does show the incorrect behaviour, but that's because it uses the wrong kind of animation, not because its scripts are wrong.

 

[Rayd12smitty]

Teleport's animation is a placeholder, and just wrong (it's a copy of StatUp which focusses on the target). It does show the incorrect behaviour, but that's because it uses the wrong kind of animation, not because its scripts are wrong.

Alright makes sense. Thank you