Pokémon DP/Pt summary screen

Github link: https://github.com/citrusbolt/pokeemerald/tree/summary_screen

After a few months (more than we would like to admit) we are happy to announce that our summary screen is ready for public use. It took us a lot of testing, tweaking and effort to get it working for public use, but we are hoping that the wait was worth it!

// Config options - Note that some config options need external modifications to fully work, such as CONFIG_CAN_FORGET_HM_MOVES, CONFIG_PHYSICAL_SPECIAL_SPLIT, and CONFIG_DECAPITALIZE_MET_LOCATION_STRINGS
#define CONFIG_CAN_FORGET_HM_MOVES                      TRUE
#define CONFIG_CAN_SWITCH_PAGES_WHILE_DETAILS_ARE_UP    TRUE
#define CONFIG_PHYSICAL_SPECIAL_SPLIT                   FALSE   // Takes precendence over CONFIG_SHOW_ICONS_FOR_OLD_SPLIT
#define CONFIG_SHOW_ICONS_FOR_OLD_SPLIT                 FALSE
#define CONFIG_EXPANDED_MET_LOCATIONS                   TRUE
#define CONFIG_TRUST_OUTSIDERS                          TRUE
#define CONFIG_SHOW_HIDDEN_POWER_STATS                  TRUE
#define CONFIG_DECAPITALIZE_TITLE_STRINGS               FALSE
#define CONFIG_DECAPITALIZE_MENU_STRINGS                TRUE
#define CONFIG_DECAPITALIZE_MET_LOCATION_STRINGS        FALSE
#define CONFIG_FATEFUL_ENCOUNTER_MARK                   TRUE
// Make sure gBallIconTable in src/data/item_icon_table.h is ordered correctly.  Default does not match RHH

Credits: Citrus Bolt, Jaizu
Special thanks: Pokémon Heliodor players for helping testing it out.

 

[Jaizu]

Why was my thread moved? This belongs to decomp resources: https://www.pokecommunity.com/forumdisplay.php?fn=decomp-resources

 

[retrogba]

Hi! It's a shame this was moved to the wrong spot, because more people need to see this. This summary screen is gorgeous!

One note though; it looks like a lot of things were written to take RHH configs into account, however, when I merge this and with the RHH expansions, I noticed there's a bit of a headache: it seems that the "CreateMonIcon" function gets overwritten without flagging as a merge conflict, and thus drops arguments from various occurrences.

There also seems to be an issue where duplicate occurrences of DestroySplitIcon / CreateSplitIcon in pokemon_summary_screen.c aren't caught as conflicts and end up existing at the same time. Not sure if that's just happening on my merges or if it happens with others as well.