[Script✓] PokeMart Script Issues in Fire Red

[MrMuggles]

Still quite new at ROM hacking and scripting in particular, so I may be missing something obvious that needs pointing out to me.

I've been trying to add a simple pokemart script into Pallet Town as a learning exercise, but I've ran into some issues. When I placed the person outside in Pallet Town, they couldn't be interacted with at all. When I placed them indoors (inside the player's home) they would be interactable and load up the initial message, but would lock the game without opening the pokemart menu. As a test, I assigned the person the script for Cerulean City's pokemart instead, and it worked perfectly. I've all but copied my script from the big XSE scripting tutorial on here, so I'm not sure what I could possibly have done wrong, and I was hoping someone could help.

My script:

Spoiler:

#dynamic 0x800000

#org @ShopKeep
lock
faceplayer
preparemsg @ShopGreetingsText
waitmsg
pokemart @ShopStock
msgbox @ShopLeavingText 0x6
release
end

#org @ShopGreetingsText
= Hi there! Can I help?

#org @ShopLeavingText
= Thanks for stopping by!

#org @ShopStock
#raw word 0x21
#raw word 0x2C
#raw word 0x2C
#raw word 0xAF
#raw word 0xBD
#raw word 0xBF
#raw word 0xCA

Cerulean City's pokemart script for comparison:

Spoiler:

'---------------
#org 0x16ACB0
special 0x187
compare LASTRESULT 0x2
if 0x1 goto 0x81A7AE0
lock
faceplayer
preparemsg 0x81A6211 '"Hi, there!\nMay I help you?"
waitmsg
pokemart 0x816ACD8
msgbox 0x81A5190 MSG_KEEPOPEN '"Please come again!"
release
end

'---------------
#org 0x1A7AE0
release
end


'---------
' Strings
'---------
#org 0x1A6211
= Hi, there!\nMay I help you?

#org 0x1A5190
= Please come again!


'-----------
' MartItems
'-----------
#org 0x16ACD8
#raw word 0x4
#raw word 0x16
#raw word 0xD
#raw word 0xE
#raw word 0x12
#raw word 0x11
#raw word 0xF
#raw word 0x55
#raw word 0x56
#raw word 0x0

The only key difference I can see between the two is the use of special 0x187, though JPAN's big post about Fire Red specials suggests it's an error checking special and nothing specific to pokemarts in particular. Either way, seeing as it features before the pokemart part of the script even happens, surely that can't be what's affecting it?

 

[Buffel Saft]

I suspect the issue is that you don't have #raw word 0x0 at the end of your item list, which is needed to tell the game where the list ends. Without that it'll keep looking past the end of the list for more items, find things that aren't items, and then crash.

Also a little tip: if you add #include stditems.rbh at the top of your script, you can use item names instead of looking up the item index (e.g. you'd have ITEM_REVIVALHERB instead of raw word 0x21). XSE should have come with some .rbh files for items, Pokemon, attacks and movements, so you can make use of those to make your scripts easier to read.

 

[MrMuggles]

Oh it needs to have #raw word 0x0 at the end? The tutorial did not mention this... If that's what that does then that would certainly explain some of the issues I had ahaha

With regards to the stditems.rbh file, funnily enough I had that open to use as a reference guide for the hex IDs. You're right though, it would make it easier for reading the script if I used it, I'll include it next time.

I'll try adding that change when I get home from work and report back, thanks for the advice!

 

[MrMuggles]

Thanks for your advice, adding in the 0x0 at the end of the list allowed it to work.

Still got a different... well, not issue per se but more a query. When I put the person event with the script attached outdoors in Pallet Town, they're still not interactable even with the revised script. Do you know if there's some quirk with the pokemart command which forces it to be used indoors? The curious thing is that, even when I set all the map data to "indoor" values, it still wouldn't function on that map. Bit of a headscratcher, though not a devastating issue by any means, so if you're not sure on this then I can just work around it.

 

[Meister_anon~Master_o f_None]

Thanks for your advice, adding in the 0x0 at the end of the list allowed it to work.

Still got a different... well, not issue per se but more a query. When I put the person event with the script attached outdoors in Pallet Town, they're still not interactable even with the revised script. Do you know if there's some quirk with the pokemart command which forces it to be used indoors? The curious thing is that, even when I set all the map data to "indoor" values, it still wouldn't function on that map. Bit of a headscratcher, though not a devastating issue by any means, so if you're not sure on this then I can just work around it.

what map tool are you using. and you don't need to change headers to make person events work.

Also why didn't you copy the entire script? If you want to make it work like the other script copy the whole thing.

 

[MrMuggles]

what map tool are you using. and you don't need to change headers to make person events work.

Also why didn't you copy the entire script? If you want to make it work like the other script copy the whole thing.

I was using AdvanceMap 1.95, which I understand is somewhat buggy but it should not have affected this particular thing.

This had nothing to do with making person events in general work, it was about making this specific person event work. For whatever reason, the script won't activate on the outdoor Pallet Town map, and I was asking if anyone knew why.

If you'll pay attention to the first post, you'll notice that I said I did this as a learning exercise. If I'm just copy-pasting scripts that other people make, I'm not learning anything, am I? By writing the script myself, even if it was meant to be functionally the same as the example script in the tutorial, I've made a mistake and consequently learned why it needs the #raw word 0x0 at the end of the list, which is far more valuable than anything I'd have gotten from copy-pasting their script into the ROM.

 

[Buffel Saft]

Thanks for your advice, adding in the 0x0 at the end of the list allowed it to work.

Still got a different... well, not issue per se but more a query. When I put the person event with the script attached outdoors in Pallet Town, they're still not interactable even with the revised script. Do you know if there's some quirk with the pokemart command which forces it to be used indoors? The curious thing is that, even when I set all the map data to "indoor" values, it still wouldn't function on that map. Bit of a headscratcher, though not a devastating issue by any means, so if you're not sure on this then I can just work around it.

You could try including that 0x187 special at the start of the script and see what happens; no idea why it's there, all it does is end the script if LASTRESULT is 2. Only other thing I could suggest is double checking that A-map hasn't messed up saving the script offset somehow; maybe it's missing and that's why the script doesn't run in Pallet Town, but will run inside.