Simple Modifications Directory

[DarkDown]

[Pokeemerald] DS-Style party screen (2 versions)
Changes the party screen to one similar to the DS versions. 2 different layouts available!
V1:

V2:

How to:
V1: Have a look at the following commit for the main implementation LINK.
V2: Implement the first version and the have a look at the commit LINK

Or clone it into your repo:

git remote add xaman https://github.com/TheXaman/pokeemerald/

For version 1:

git pull xaman tx_ui_party_screen_ds_style_1

For version 2:

git pull xaman tx_ui_party_screen_ds_style_2

Thats it! If you find any bugs, let me know.
If you want to change the look of the windows you need to alter graphics/interface/party_menu_bg.png

Eggs:

Double battles:

Known bugs ONLY V1: Healing via potion "breaks" the slash between hp and maxHp


Credits:
TheXaman
visually inpsired by Lunos binary version, but no code or assets used.

If you add DisplayPartyPokemonMaxHPCheck after DisplayPartyPokemonHPCheck in Task_PartyMenuModifyHP the potion bug does not occur

 

[DarkDown]

[pokeemerald] Power item and Destiny Knot breeding

I spent a few hours on this so I thought I would share.
Makes Power item holders pass the appropriate IVs to their offspring and makes Destiny Knot holders' offspring inherit 5 IVs from their parents instead of 3.
If both parents hold the same power item it takes the first ones' IV, not 50% chance for each like in the newer games.

In include/constants/daycare.h add:

#define INHERITED_IV_DESTINY_KNOT_COUNT 5

In src/daycare.c add:

#include "constants/hold_effects.h"

Change InheritIVs function in src/daycare.c to:

Spoiler:

static void InheritIVs(struct Pokemon *egg, struct DayCare *daycare)
{
    u8 i, j, k, index;
    u8 selectedIvs[INHERITED_IV_DESTINY_KNOT_COUNT];
    u8 availableIVs[NUM_STATS];
    u8 whichParents[INHERITED_IV_DESTINY_KNOT_COUNT];
    u8 iv;
	u8 inheritedN = INHERITED_IV_COUNT;

    // Initialize a list of IV indices.
    for (i = 0; i < NUM_STATS; i++)
    {
        availableIVs[i] = i;
    }

    // search for power items or destiny knot
	k = 0;
    for (i = 0; i < DAYCARE_MON_COUNT; i++)
    { 
                u16 item = GetBoxMonData(&daycare->mons[i].mon, MON_DATA_HELD_ITEM);
		if (gItems[item].holdEffect == HOLD_EFFECT_POWER_ITEM)
		{
			index = gItems[item].secondaryId;
			for (j = 0; j <= index; j++)
				if (availableIVs[j] == index)
				{
					selectedIvs[k] = index;
					RemoveIVIndexFromList(availableIVs, index);
					whichParents[k] = i;
					k++;
					break;
				}
		}
		else if (gItems[item].holdEffect == HOLD_EFFECT_DESTINY_KNOT)
			inheritedN = INHERITED_IV_DESTINY_KNOT_COUNT;
    }
	
    // Select the 1-5 remaining IVs that will be inherited randomly.
    for (i = k; i < inheritedN; i++)
    {
        index = Random() % (NUM_STATS - i);
        selectedIvs[i] = availableIVs[index];
        RemoveIVIndexFromList(availableIVs, index);
    }

    // Determine which parent each of the random IVs should inherit from.
    for (i = k; i < inheritedN; i++)
    {
        whichParents[i] = Random() % DAYCARE_MON_COUNT;
    }

    // Set each of inherited IVs on the egg mon.
    for (i = 0; i < inheritedN; i++)
    {
        switch (selectedIvs[i])
        {
            case 0:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_HP_IV);
                SetMonData(egg, MON_DATA_HP_IV, &iv);
                break;
            case 1:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_ATK_IV);
                SetMonData(egg, MON_DATA_ATK_IV, &iv);
                break;
            case 2:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_DEF_IV);
                SetMonData(egg, MON_DATA_DEF_IV, &iv);
                break;
            case 3:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPEED_IV);
                SetMonData(egg, MON_DATA_SPEED_IV, &iv);
                break;
            case 4:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPATK_IV);
                SetMonData(egg, MON_DATA_SPATK_IV, &iv);
                break;
            case 5:
                iv = GetBoxMonData(&daycare->mons[whichParents[i]].mon, MON_DATA_SPDEF_IV);
                SetMonData(egg, MON_DATA_SPDEF_IV, &iv);
                break;
        }
    }
}

edit: utilize power item secondary ids

 

[Diego Mertens]

[AI] Switch If Specific Pokémon Has Specific Super Effective Revealed Move [EM]
in battle_ai_switch_items.c

static bool8 EnemyMonHasSpecificSuperEffectiveRevealedMove(void)
{
    u8 opposingPosition = BATTLE_OPPOSITE(GetBattlerPosition(gActiveBattler));
	if (gBattleMons[GetBattlerAtPosition(opposingPosition)].species == [B]YOUR_SPECIES_HERE[/B]) {
		u8 moveFlags = AI_TypeCalc(gLastLandedMoves[gActiveBattler], gBattleMons[gActiveBattler].species, gBattleMons[gActiveBattler].ability);
		if (gLastLandedMoves[gActiveBattler] == [B]YOUR_MOVE_HERE[/B] && (moveFlags & MOVE_RESULT_SUPER_EFFECTIVE)) {
			*(gBattleStruct->AI_monToSwitchIntoId + gActiveBattler) = PARTY_SIZE;
			BtlController_EmitTwoReturnValues(1, B_ACTION_SWITCH, 0);
			return TRUE;
		}
	}
}

in ShouldSwitch

	if (EnemyMonHasSpecificSuperEffectiveRevealedMove())
		return TRUE;

Id love to add this feature, but each time ive tried it, it softlocks the game once a battle starts and im about to use a move, specially with stronger enemies, like the Elite 4

 

[rraykzu]

POKEEMERALD
PSS IN THE START MENU​

First, we add a new Flag in include/constants/flags.h

FLAG_POKEMONPCMENU

(this will be used after)
Then, we go to include/pokemon_storage_system.h
There, we add anywhere:

void EnterPokeStorage(u8);

Then we go to src/pokemon_storage_system.c, and we delete

static void EnterPokeStorage(u8);

(when its definied, the first one)
and we search for "static void EnterPokeStorage(u8 boxOption)", then we erase the "static " (the second one)
Then, we search for:

static void FieldTask_ReturnToPcMenu(void)

And we replace it entirely for this:

static void FieldTask_ReturnToPcMenu(void)
{
    u8 taskId;
    MainCallback vblankCb = gMain.vblankCallback;
	if (FlagGet(FLAG_POKEMONPCMENU)==TRUE)
	{
		SetVBlankCallback(NULL);
		taskId = CreateTask(Task_PCMainMenu, 80);
		gTasks[taskId].tState = 0;
		gTasks[taskId].tSelectedOption = sPreviousBoxOption;
		Task_PCMainMenu(taskId);
		SetVBlankCallback(vblankCb);
		FadeInFromBlack();
	}
	else {
		ScriptContext2_Disable();
		EnableBothScriptContexts();
		SetVBlankCallback(CB2_ReturnToField);
		FadeInFromBlack();
	}
}

Then, we go to src/start_menu.c, and we search for: static bool8 StartMenuBagCallback(void);, and right after, we add:
static bool8 StartMenuPCCallback(void);
Then, we go to "{gText_MenuBag, {.u8_void = StartMenuBagCallback}}," and again we add bellow:
{gText_MenuPC, {.u8_void = StartMenuPCCallback}},
Then, we go to "static bool8 StartMenuBagCallback(void)" and after the whole funcion we add:

static bool8 StartMenuPCCallback(void)
{
	u8 taskId;
    if (!gPaletteFade.active)
    {
        PlayRainStoppingSoundEffect();
        RemoveExtraStartMenuWindows();
		EnterPokeStorage(x);
        return TRUE;
    }

    return FALSE;
}

(in my case, its "0" the number for the Move Pokémon System, but I have made some changes {I changed the Move option to the first place}, and I'm sure the original number for the option is "2"...)

Then, we search for: "MENU_ACTION_BAG"
And after we add: "MENU_ACTION_PC,"

Now we go to: "if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)" and inside there we add:
AddStartMenuAction(MENU_ACTION_PC);
Like this:

    if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)
    {
        AddStartMenuAction(MENU_ACTION_POKEMON);
		AddStartMenuAction(MENU_ACTION_PC);
    }

Then, we go to "AddStartMenuAction(MENU_ACTION_BAG);" and right after we add:
AddStartMenuAction(MENU_ACTION_PC);

Then, we go to data/scripts/pc.inc and we add this after "playse SE_PC_ON" in "EventScript_PC:: @ 8271D92":
setflag FLAG_POKEMONPCMENU
Now, after "special DoPCTurnOffEffect", in "EventScript_TurnOffPC:: @ 8271E47" we add:
clearflag FLAG_POKEMONPCMENU

Lastly, we need to add the strings for the PC in the Start Menu, (thanks, Lunos)
We go to include/strings.h and we add this somewhere:

extern const u8 gText_MenuPC[];

And this is the last step. We go to src/strings.c and we add this somewhere:
const u8 gText_MenuPC[] = _("PC");

And we're done! this time, we are We should be able to enter the Move Pokémon PC, and the Pokécenter PC's won't be affected.

when i try to compile i get this error, "src/pokemon_storage_system.c: In function `FieldTask_ReturnToPcMenu':
src/pokemon_storage_system.c:1676: too few arguments to function `FlagGet'" would you know why?

 

[Diego Mertens]

when i try to compile i get this error, "src/pokemon_storage_system.c: In function `FieldTask_ReturnToPcMenu':
src/pokemon_storage_system.c:1676: too few arguments to function `FlagGet'" would you know why?

I really don't know why this would be happening, since FlagGet only has one argument. Maybe you've added that part of the tutorial wrong?
Could you attach one image of how that part of your code looks so i can see what's wrong?

 

[rraykzu]

heres an image

 

[AsparagusEdu]

"Move Pokémon" as first PSS option [EM]

In "src/pokemon_storage_system.c", look for the enum where OPTION_MOVE_MONS is defined and change its order.

Spoiler:

Finally decided to come back and update this post. Now that the PC has been more properly documented, changing the option order should be as simple as changing it in the enum

 

[resetes12]

[Pokeemerald] Earn battle points from trainer battles (with a variable)

The following changes allow you to earn battle frontier points from trainer battles by setting a variable.
Variable 0x8003 is used to activate this routine and also overrides the current trainer battle transition (a random transition from the battle frontier table is used instead).
Variable 0x8004 controls the amount of points earned from the battle. By default, the string is limited to 3 digits (999 points).

Both variables need to be set before the trainerbattle command, and they are automatically reset upon the player winning (or upon whiteout).

All of the changes can be found in this commit:
https://github.com/Scyrous/pokeemerald/commit/f69452cb557bc2b06bf68fab67a6920621e28541

Demonstration:

After defeating Steven in battle, the player earns a whopping 15 battle points.

Usage:

I found a couple of bizarre bugs.

I've been trying to make the code work for like an hour, but every time I got into a trainer battle with those vars, the game created a battle with a female swimmer for some reason (and crashed after battle). After a few code checks (which I'm sure it's perfectly implemented), I discovered that if you want the code to work, you need to talk with the NPC and not let the NPC see you.
The second bug is that even if you talk to the NPC, and get the BP as expected after battle, the trainer that you just defeated will now see you and start again a new trainerbattle. This time, again, with a female swimmer that crashes the game after battle.

 

[Lunos]

Text shortcut to print a Pokémon's nickname [Em]
I did this as a workaround to a problem I was having.
I decided to come and share it because why not.

Text strings have access to buffers that allow you to store whatever you want in them, or that store specific things such as words.
I added one such buffer that upon being invoked, gets filled with the nickname of the Pokémon whose slot is stored in the var 0x8004.
As one can guess, I made this to work in conjunction with things like the special ChoosePartyMon.

Usage:
Store the slot of a Pokémon in either the Player's or the Enemy's party in the variable 0x8004, and then write a text string invoking the buffer just like you would invoke any other string buffer.

MauvilleCity_EventScript_CitySign::
        special ChoosePartyMon
        waitstate
	msgbox MauvilleCity_Text_CitySign, MSGBOX_SIGN
	end

MauvilleCity_Text_CitySign:
	.string ""That's a cute {CHOSEN_MON_NICKNAME}!"$"

To put an example, let's say I picked my Torchic named Chckn.
The string will say ""That's a cute Chckn!"" InGame.

To implement this, you can track my GitHub repository via git remote and pull the branch chosenMonNickname which is where I'm hosting the code:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos chosenMonNickname

Or you can implement things manually:
https://github.com/pret/pokeemerald/compare/master...LOuroboros:chosenMonNickname

And that's pretty much it.​

 

[rraykzu]

IV Checker NPC [EM]​

If there's a better way to do this, please let me know! I'm rather new to decomp stuff, but wanted to try this out.​

In data\scripts.inc, add these lines:

	def_special GetHpIV
	def_special GetAtkIV
	def_special GetDefIV
	def_special GetSpAtkIV
	def_special GetSpDefIV
	def_special GetSpeedIV

In src\pokemon.c (or any file in src that has access to pokemon.h), add these lines:

u16 GetHpIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_HP_IV, NULL);
}
u16 GetAtkIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_ATK_IV, NULL);
}
u16 GetDefIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_DEF_IV, NULL);
}
u16 GetSpAtkIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPATK_IV, NULL);
}
u16 GetSpDefIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPDEF_IV, NULL);
}
u16 GetSpeedIV(void)
{
	return GetMonData(&gPlayerParty[GetLeadMonIndex()], MON_DATA_SPEED_IV, NULL);
}

Then, add these scripts to whatever map's scripts.inc that you want the IV Checker to be in.

Script_IVChecker::
	lock
	faceplayer
	bufferpartymonnick 0, 0
	msgbox Text_IVChecker_1, MSGBOX_DEFAULT
	specialvar VAR_RESULT, GetHpIV
	buffernumberstring 0, VAR_RESULT
	specialvar VAR_RESULT, GetAtkIV
	buffernumberstring 1, VAR_RESULT
	specialvar VAR_RESULT, GetDefIV
	buffernumberstring 2, VAR_RESULT
	msgbox Text_IVChecker_2, MSGBOX_DEFAULT
	specialvar VAR_RESULT, GetSpAtkIV
	buffernumberstring 0, VAR_RESULT
	specialvar VAR_RESULT, GetSpDefIV
	buffernumberstring 1, VAR_RESULT
	specialvar VAR_RESULT, GetSpeedIV
	buffernumberstring 2, VAR_RESULT
	msgbox Text_IVChecker_3, MSGBOX_DEFAULT
	release
	end

Text_IVChecker_1:
	.string "Your {STR_VAR_1}...$"

Text_IVChecker_2:
	.string "Its HP IV is {STR_VAR_1}.\p"
	.string "Its Attack IV is {STR_VAR_2}.\p"
	.string "Its Defense IV is {STR_VAR_3}.$"

Text_IVChecker_3:
	.string "Its Special Attack IV is {STR_VAR_1}.\p"
	.string "Its Special Defense IV is {STR_VAR_2}.\p"
	.string "Its Speed IV is {STR_VAR_3}.\n"
	.string "You're welcome.$"

Add Script_IVChecker to an NPC (I used PoryMap to do this), and talk to the NPC. Your result should look like this!

scripts.inc is meant to be specials.inc btw.

 

[TriedAndTRUE]

Is there a PoryScript version for the overworld mugshots? Thanks!

 

[Anon822]

Is there a PoryScript version for the overworld mugshots? Thanks!

It should be possible to edit any script to use poryscript's syntax, but if not you can always use the raw statement.

 

[Arkydon]

POKEEMERALD
PSS IN THE START MENU​

First, we add a new Flag in include/constants/flags.h

FLAG_POKEMONPCMENU

(this will be used after)
Then, we go to include/pokemon_storage_system.h
There, we add anywhere:

void EnterPokeStorage(u8);

Then we go to src/pokemon_storage_system.c, and we delete

static void EnterPokeStorage(u8);

(when its definied, the first one)
and we search for "static void EnterPokeStorage(u8 boxOption)", then we erase the "static " (the second one)
Then, we search for:

static void FieldTask_ReturnToPcMenu(void)

And we replace it entirely for this:

static void FieldTask_ReturnToPcMenu(void)
{
    u8 taskId;
    MainCallback vblankCb = gMain.vblankCallback;
	if (FlagGet(FLAG_POKEMONPCMENU)==TRUE)
	{
		SetVBlankCallback(NULL);
		taskId = CreateTask(Task_PCMainMenu, 80);
		gTasks[taskId].tState = 0;
		gTasks[taskId].tSelectedOption = sPreviousBoxOption;
		Task_PCMainMenu(taskId);
		SetVBlankCallback(vblankCb);
		FadeInFromBlack();
	}
	else {
		ScriptContext2_Disable();
		EnableBothScriptContexts();
		SetVBlankCallback(CB2_ReturnToField);
		FadeInFromBlack();
	}
}

Then, we go to src/start_menu.c, and we search for: static bool8 StartMenuBagCallback(void);, and right after, we add:
static bool8 StartMenuPCCallback(void);
Then, we go to "{gText_MenuBag, {.u8_void = StartMenuBagCallback}}," and again we add bellow:
{gText_MenuPC, {.u8_void = StartMenuPCCallback}},
Then, we go to "static bool8 StartMenuBagCallback(void)" and after the whole funcion we add:

static bool8 StartMenuPCCallback(void)
{
	u8 taskId;
    if (!gPaletteFade.active)
    {
        PlayRainStoppingSoundEffect();
        RemoveExtraStartMenuWindows();
		EnterPokeStorage(x);
        return TRUE;
    }

    return FALSE;
}

(in my case, its "0" the number for the Move Pokémon System, but I have made some changes {I changed the Move option to the first place}, and I'm sure the original number for the option is "2"...)

Then, we search for: "MENU_ACTION_BAG"
And after we add: "MENU_ACTION_PC,"

Now we go to: "if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)" and inside there we add:
AddStartMenuAction(MENU_ACTION_PC);
Like this:

    if (FlagGet(FLAG_SYS_POKEMON_GET) == TRUE)
    {
        AddStartMenuAction(MENU_ACTION_POKEMON);
		AddStartMenuAction(MENU_ACTION_PC);
    }

Then, we go to "AddStartMenuAction(MENU_ACTION_BAG);" and right after we add:
AddStartMenuAction(MENU_ACTION_PC);

Then, we go to data/scripts/pc.inc and we add this after "playse SE_PC_ON" in "EventScript_PC:: @ 8271D92":
setflag FLAG_POKEMONPCMENU
Now, after "special DoPCTurnOffEffect", in "EventScript_TurnOffPC:: @ 8271E47" we add:
clearflag FLAG_POKEMONPCMENU

Lastly, we need to add the strings for the PC in the Start Menu, (thanks, Lunos)
We go to include/strings.h and we add this somewhere:

extern const u8 gText_MenuPC[];

And this is the last step. We go to src/strings.c and we add this somewhere:
const u8 gText_MenuPC[] = _("PC");

And we're done! this time, we are We should be able to enter the Move Pokémon PC, and the Pokécenter PC's won't be affected.

It works until I reach the point where that Devcorp employee gives me the pokenav. The employee waits while I call the devcorp president and the "PC" option dissapears when I open start to do that call strangely, after the employee leaves and I press the start menu again the game freezes and I cant do anything. I've checked the code a dozen times and its exactly the same I'm not sure what I'm missing.

Also your code creates two PC options in the start menu after I recieve my starter

 

[Yak Attack]

Smogon Stats [EM]​

This allows you to use Smogon statistics for things. Maybe you could code an AI or a competitive Pokemon mode, idk.
In pokemon.h:

struct __attribute__((packed, aligned(2))) SmogonTeams {
    u16 species;
    u16 item;
    u8 ability;
    u16 moves[4];
    u8 evs[6];
    u8 ivs[6];
    u8 nature;
    u8 nickname[11];
};

struct SmogonMoves {
    u16 move;
    u16 usage;
};

struct SmogonSpreads {
	u8 nature;
    u8 spread[6];
    u16 usage;
};

struct SmogonItems {
    u16 item;
    u16 usage;
};

struct SmogonCaC {
    u16 species;
    u16 weightedScore;
};

struct SmogonTeammates {
    u16 species;
    u16 usage;
};

struct SmogonAbilities {
    u8 ability;
    u16 usage;
};

struct Smogon {
	const struct SmogonTeams (*teams)[6];
	u16 usage;
	const struct SmogonMoves *moves;
	const struct SmogonSpreads *spreads;
	const struct SmogonItems *items;
	const struct SmogonCaC *cac;
	const struct SmogonTeammates *teammates;
	const struct SmogonAbilities *abilities;
	u16 teamsCount;
	u8 movesCount, spreadsCount, itemsCount, cacCount, teammatesCount, abilitiesCount;
};

Attached is a smogon.h file you put in the src/data/pokemon folder (or wherever).

Update: Here's one for National Dex:

struct SmogonMoves 
{
    u16 move;
    u16 usage;
};

struct SmogonItems 
{
    u16 item;
    u16 usage;
};

struct SmogonChecksAndCounters 
{
    u16 species;
    u16 usage;
};

struct SmogonTeammates
{
    u16 species;
    u16 usage;
};

struct Smogon
{
    const struct SmogonMoves *moves;
    const struct SmogonItems *items;
    const struct SmogonChecksAndCounters *checksAndCounters;
    const struct SmogonTeammates *teammates;
    u16 usage, movesCount;
    u8 itemsCount;
    u16 cacCount, teammatesCount;
};

See smogon_nat_dex.h (for use with pokeemerald-expansion).

 

[Jessler]

[pokeemerald] Overworld Expansion

This has been around for a while now, but slawter's repo is pretty out of date and lost in other posts so I thought i would post here for posterity.

This simply expands the graphicsId from u8 to u16 (up to 65535). Link to my maintained branch

How to use:

• Pull from the repo
• Add new object graphics Ids to include/constants/event_objects.h
• Make sure you update NUM_OBJ_EVENT_GFX!!!
• Add new overworld objects as normal (see this wiki post)

Hey, just pulled this and literally every overworld sprite is now Brendan (playing as female). What did I do wrong?

EDIT: Doesn't seem to matter what gender I am. Everyone is still Brendan as the male player.

EDIT 2: A make clean fixed it, nevermind!

 

[Lunos]

Gen. 6 styled Exp. Share (Em)

For battle_engine users:

git remote add lunos https://github.com/LOuroboros/pokeemerald
git pull lunos gen6_exp_share_BE

EDIT (10/06/2022):
I edited the post yet again, linking an alternative branch I made for battle_engine users, mostly because handling the changes to Cmd_getexp can be daunting to newbies.
If anyone spots any mistakes I may have made, please let me know.

Also, this branch varies quiet a bit from the other one, as I now use an unused flag to handle toggling the system On/Off instead of adding a whole new variable to the SaveBlock1 for it pointlessly.
Feel free to change which flag is used or whatever if you want or need to.​

Quoting the most relevant parts as a heads up. I added a Gen. 6 Exp. Share branch for battle_engine users.

 

[amouthtofeed]

Quoting the most relevant parts as a heads up. I added a Gen. 6 Exp. Share branch for battle_engine users.

I tried this, but it said the Pokémon in party received "0 exp points". I used the BE branch

 

[Lunos]

I tried this, but it said the Pokémon in party received "0 exp points". I used the BE branch

Fixed. Please git pull again to get the latest commit.

 

[Deokishisu]

Move Item [EM]

Spoiler:

Adds a MOVE option to the ITEM menu which allows you to move held items directly between Pokémon in your party, instead of having to use the bag as a middle man.

I've had this up in my pokeemerald fork for a while, but I never got around to writing it up here. Since I originally made it, the relevant functions got actual names in pokeemerald, so I'm taking this as an opportunity to update it and post it here.

There's going to be multiple changes required across multiple files, so I'm going to try to keep them in a logical order that minimizes jumping between files. Also, at the end of each step, pokeemerald will still be in a compilable state if done properly.

In the code blocks throughout this post, new lines of code are highlighted with the color green. Red highlights denote deleted lines of code. If a line of code isn't highlighted either color, it is only included for context.

Adding the strings

In include/strings.h, add the following to the end of the file:

Spoiler:

[span="background-color:green"]extern const u8 gMenuText_Move[];
extern const u8 gText_MoveItemWhere[];
extern const u8 gText_XsYAnd[];
extern const u8 gText_XsYWereSwapped[];[/span]

#endif // GUARD_STRINGS_H

In src/strings.c, add the following to the end of the file:

Spoiler:

[span="background-color:green"]
const u8 gMenuText_Move[] = _("MOVE");
const u8 gText_MoveItemWhere[] = _("Move item to where?");
const u8 gText_XsYAnd[] = _("{STR_VAR_1}'s\n{STR_VAR_2} and\l");
const u8 gText_XsYWereSwapped[] = _("{STR_VAR_1}'s\l{STR_VAR_2} were swapped!{PAUSE_UNTIL_PRESS}");
[/span]

Adding the code

You'll need to add a forward declaration for CursorCb_MoveItem in src/party_menu.c, like so:

Spoiler:

static void CursorCb_Summary(u8);
static void CursorCb_Switch(u8);
static void CursorCb_Cancel1(u8);
static void CursorCb_Item(u8);
static void CursorCb_Give(u8);
static void CursorCb_TakeItem(u8);
[span="background-color:green"]static void CursorCb_MoveItem(u8);[/span]
static void CursorCb_Mail(u8);
static void CursorCb_Read(u8);
static void CursorCb_TakeMail(u8);
static void CursorCb_Cancel2(u8);
static void CursorCb_SendMon(u8);
static void CursorCb_Enter(u8);
static void CursorCb_NoEntry(u8);
static void CursorCb_Store(u8);
static void CursorCb_Register(u8);
static void CursorCb_Trade1(u8);
static void CursorCb_Trade2(u8);
static void CursorCb_Toss(u8);
static void CursorCb_FieldMove(u8);

At the end of src/party_menu.c, add the following:

Spoiler:

[span="background-color:green"]
void CursorCb_MoveItemCallback(u8 taskId)
{
    u16 item1, item2;
    u8 buffer[100];

    if (gPaletteFade.active || sub_81221EC())
        return;

    switch (PartyMenuButtonHandler(&gPartyMenu.slotId2))
    {
    case 2:     // User hit B or A while on Cancel
        HandleChooseMonCancel(taskId, &gPartyMenu.slotId2);
        break;
    case 1:     // User hit A on a Pokemon
        // Pokemon can't give away items to eggs or themselves
        if (GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_IS_EGG)
            || gPartyMenu.slotId == gPartyMenu.slotId2)
        {
            PlaySE(SE_HAZURE);
            return;
        }

        PlaySE(SE_SELECT);
        gPartyMenu.action = PARTY_ACTION_CHOOSE_MON;

        // look up held items
        item1 = GetMonData(&gPlayerParty[gPartyMenu.slotId], MON_DATA_HELD_ITEM);
        item2 = GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM);

        // swap the held items
        SetMonData(&gPlayerParty[gPartyMenu.slotId], MON_DATA_HELD_ITEM, &item2);
        SetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM, &item1);

        // update the held item icons
        UpdatePartyMonHeldItemSprite(
            &gPlayerParty[gPartyMenu.slotId],
            &sPartyMenuBoxes[gPartyMenu.slotId]
        );

        UpdatePartyMonHeldItemSprite(
            &gPlayerParty[gPartyMenu.slotId2],
            &sPartyMenuBoxes[gPartyMenu.slotId2]
        );

        // create the string describing the move
        if (item2 == ITEM_NONE)
        {
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId2], gStringVar1);
            CopyItemName(item1, gStringVar2);
            StringExpandPlaceholders(gStringVar4, gText_PkmnWasGivenItem);
        }
        else
        {
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId], gStringVar1);
            CopyItemName(item1, gStringVar2);
            StringExpandPlaceholders(buffer, gText_XsYAnd);

            StringAppend(buffer, gText_XsYWereSwapped);
            GetMonNickname(&gPlayerParty[gPartyMenu.slotId2], gStringVar1);
            CopyItemName(item2, gStringVar2);
            StringExpandPlaceholders(gStringVar4, buffer);
        }

        // display the string
        DisplayPartyMenuMessage(gStringVar4, TRUE);

        // update colors of selected boxes
        AnimatePartySlot(gPartyMenu.slotId2, 0);
        AnimatePartySlot(gPartyMenu.slotId, 1);

        // return to the main party menu
        schedule_bg_copy_tilemap_to_vram(2);
        gTasks[taskId].func = Task_UpdateHeldItemSprite;
        break;
    }
}

void CursorCb_MoveItem(u8 taskId)
{
    struct Pokemon *mon = &gPlayerParty[gPartyMenu.slotId];

    PlaySE(SE_SELECT);

    // delete old windows
    PartyMenuRemoveWindow(&sPartyMenuInternal->windowId[1]);
    PartyMenuRemoveWindow(&sPartyMenuInternal->windowId[0]);

    if (GetMonData(mon, MON_DATA_HELD_ITEM) != ITEM_NONE)
    {
        gPartyMenu.action = PARTY_ACTION_SWITCH;

        // show "Move item to where" in bottom left
        DisplayPartyMenuStdMessage(PARTY_MSG_MOVE_ITEM_WHERE);
        // update color of first selected box
        AnimatePartySlot(gPartyMenu.slotId, 1);

        // set up callback
        gPartyMenu.slotId2 = gPartyMenu.slotId;
        gTasks[taskId].func = CursorCb_MoveItemCallback;
    }
    else
    {
        // create and display string about lack of hold item
        GetMonNickname(mon, gStringVar1);
        StringExpandPlaceholders(gStringVar4, gText_PkmnNotHolding);
        DisplayPartyMenuMessage(gStringVar4, TRUE);

        // return to the main party menu
        schedule_bg_copy_tilemap_to_vram(2);
        gTasks[taskId].func = Task_UpdateHeldItemSprite;
    }
}
[/span]

Open include/constants/party_menu.h, and look for #defines of the form PARTY_MSG_WHATEVER. We need to add a #define for PARTY_MSG_MOVE_ITEM_WHERE like so:

Spoiler:

#define PARTY_MSG_CHOOSE_MON                0
#define PARTY_MSG_CHOOSE_MON_OR_CANCEL      1
#define PARTY_MSG_CHOOSE_MON_AND_CONFIRM    2
#define PARTY_MSG_MOVE_TO_WHERE             3 
#define PARTY_MSG_TEACH_WHICH_MON           4
#define PARTY_MSG_USE_ON_WHICH_MON          5
#define PARTY_MSG_GIVE_TO_WHICH_MON         6
#define PARTY_MSG_NOTHING_TO_CUT            7
#define PARTY_MSG_CANT_SURF_HERE            8
#define PARTY_MSG_ALREADY_SURFING           9
#define PARTY_MSG_CURRENT_TOO_FAST          10
#define PARTY_MSG_ENJOY_CYCLING             11
#define PARTY_MSG_ALREADY_IN_USE            12
#define PARTY_MSG_CANT_USE_HERE             13
#define PARTY_MSG_NO_MON_FOR_BATTLE         14
#define PARTY_MSG_CHOOSE_MON_2              15
#define PARTY_MSG_NOT_ENOUGH_HP             16
#define PARTY_MSG_X_MONS_ARE_NEEDED         17
#define PARTY_MSG_MONS_CANT_BE_SAME         18
#define PARTY_MSG_NO_SAME_HOLD_ITEMS        19
#define PARTY_MSG_UNUSED                    20
#define PARTY_MSG_DO_WHAT_WITH_MON          21
#define PARTY_MSG_RESTORE_WHICH_MOVE        22
#define PARTY_MSG_BOOST_PP_WHICH_MOVE       23
#define PARTY_MSG_DO_WHAT_WITH_ITEM         24
#define PARTY_MSG_DO_WHAT_WITH_MAIL         25
#define PARTY_MSG_ALREADY_HOLDING_ONE       26
[span="background-color:green"]#define PARTY_MSG_MOVE_ITEM_WHERE           27[/span]
#define PARTY_MSG_NONE                      127

Updating relevant data

Everything from here on will be in src/data/party_menu.h.

Look for an unnamed enum with values such as MENU_SUMMARY. Add MENU_MOVE_ITEM to the enum's list of values, like so:

Spoiler:

enum
{
    MENU_SUMMARY,
    MENU_SWITCH,
    MENU_CANCEL1,
    MENU_ITEM,
    MENU_GIVE,
    MENU_TAKE_ITEM,
    [span="background-color:green"]MENU_MOVE_ITEM,[/span]
    MENU_MAIL,
    MENU_TAKE_MAIL,
    MENU_READ,
    MENU_CANCEL2,
    MENU_SHIFT,
    MENU_SEND_OUT,
    MENU_ENTER,
    MENU_NO_ENTRY,
    MENU_STORE,
    MENU_REGISTER,
    MENU_TRADE1,
    MENU_TRADE2,
    MENU_TOSS,
    MENU_FIELD_MOVES,
};

Now, we need to add an entry to the sCursorOptions array. Add an entry for MENU_MOVE_ITEM like so:

Spoiler:

struct
{
    const u8 *text;
    TaskFunc func;
} static const sCursorOptions[] =
{
    [MENU_SUMMARY] = {gText_Summary5, CursorCb_Summary},
    [MENU_SWITCH] = {gText_Switch2, CursorCb_Switch},
    [MENU_CANCEL1] = {gText_Cancel2, CursorCb_Cancel1},
    [MENU_ITEM] = {gText_Item, CursorCb_Item},
    [MENU_GIVE] = {gMenuText_Give, CursorCb_Give},
    [MENU_TAKE_ITEM] = {gText_Take, CursorCb_TakeItem},
    [span="background-color:green"][MENU_MOVE_ITEM] = {gMenuText_Move, CursorCb_MoveItem},[/span]
    [MENU_MAIL] = {gText_Mail, CursorCb_Mail},
    [MENU_TAKE_MAIL] = {gText_Take2, CursorCb_TakeMail},
    [MENU_READ] = {gText_Read2, CursorCb_Read},
    [MENU_CANCEL2] = {gText_Cancel2, CursorCb_Cancel2},
    [MENU_SHIFT] = {gText_Shift, CursorCb_SendMon},
    [MENU_SEND_OUT] = {gText_SendOut, CursorCb_SendMon},
    [MENU_ENTER] = {gText_Enter, CursorCb_Enter},
    [MENU_NO_ENTRY] = {gText_NoEntry, CursorCb_NoEntry},
    [MENU_STORE] = {gText_Store, CursorCb_Store},
    [MENU_REGISTER] = {gText_Register, CursorCb_Register},
    [MENU_TRADE1] = {gText_Trade4, CursorCb_Trade1},
    [MENU_TRADE2] = {gText_Trade4, CursorCb_Trade2},
    [MENU_TOSS] = {gMenuText_Toss, CursorCb_Toss},
    [MENU_FIELD_MOVES + FIELD_MOVE_CUT] = {gMoveNames[MOVE_CUT], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_FLASH] = {gMoveNames[MOVE_FLASH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_ROCK_SMASH] = {gMoveNames[MOVE_ROCK_SMASH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_STRENGTH] = {gMoveNames[MOVE_STRENGTH], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SURF] = {gMoveNames[MOVE_SURF], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_FLY] = {gMoveNames[MOVE_FLY], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_DIVE] = {gMoveNames[MOVE_DIVE], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_WATERFALL] = {gMoveNames[MOVE_WATERFALL], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_TELEPORT] = {gMoveNames[MOVE_TELEPORT], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_DIG] = {gMoveNames[MOVE_DIG], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SECRET_POWER] = {gMoveNames[MOVE_SECRET_POWER], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_MILK_DRINK] = {gMoveNames[MOVE_MILK_DRINK], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SOFT_BOILED] = {gMoveNames[MOVE_SOFT_BOILED], CursorCb_FieldMove},
    [MENU_FIELD_MOVES + FIELD_MOVE_SWEET_SCENT] = {gMoveNames[MOVE_SWEET_SCENT], CursorCb_FieldMove},
};

Next, find the definition of sActionStringTable. Add an entry to the end like so:

Spoiler:

static const u8 *const sActionStringTable[] =
{
    [PARTY_MSG_CHOOSE_MON]             = gText_ChoosePokemon,
    [PARTY_MSG_CHOOSE_MON_OR_CANCEL]   = gText_ChoosePokemonCancel,
    [PARTY_MSG_CHOOSE_MON_AND_CONFIRM] = gText_ChoosePokemonConfirm,
    [PARTY_MSG_MOVE_TO_WHERE]          = gText_MoveToWhere,
    [PARTY_MSG_TEACH_WHICH_MON]        = gText_TeachWhichPokemon,
    [PARTY_MSG_USE_ON_WHICH_MON]       = gText_UseOnWhichPokemon,
    [PARTY_MSG_GIVE_TO_WHICH_MON]      = gText_GiveToWhichPokemon,
    [PARTY_MSG_NOTHING_TO_CUT]         = gText_NothingToCut,
    [PARTY_MSG_CANT_SURF_HERE]         = gText_CantSurfHere,
    [PARTY_MSG_ALREADY_SURFING]        = gText_AlreadySurfing,
    [PARTY_MSG_CURRENT_TOO_FAST]       = gText_CurrentIsTooFast,
    [PARTY_MSG_ENJOY_CYCLING]          = gText_EnjoyCycling,
    [PARTY_MSG_ALREADY_IN_USE]         = gText_InUseAlready_PM,
    [PARTY_MSG_CANT_USE_HERE]          = gText_CantUseHere,
    [PARTY_MSG_NO_MON_FOR_BATTLE]      = gText_NoPokemonForBattle,
    [PARTY_MSG_CHOOSE_MON_2]           = gText_ChoosePokemon2,
    [PARTY_MSG_NOT_ENOUGH_HP]          = gText_NotEnoughHp,
    [PARTY_MSG_X_MONS_ARE_NEEDED]      = gText_PokemonAreNeeded,
    [PARTY_MSG_MONS_CANT_BE_SAME]      = gText_PokemonCantBeSame,
    [PARTY_MSG_NO_SAME_HOLD_ITEMS]     = gText_NoIdenticalHoldItems,
    [PARTY_MSG_UNUSED]                 = gText_EmptyString2,
    [PARTY_MSG_DO_WHAT_WITH_MON]       = gText_DoWhatWithPokemon,
    [PARTY_MSG_RESTORE_WHICH_MOVE]     = gText_RestoreWhichMove,
    [PARTY_MSG_BOOST_PP_WHICH_MOVE]    = gText_BoostPp,
    [PARTY_MSG_DO_WHAT_WITH_ITEM]      = gText_DoWhatWithItem,
    [PARTY_MSG_DO_WHAT_WITH_MAIL]      = gText_DoWhatWithMail,
    [PARTY_MSG_ALREADY_HOLDING_ONE]    = gText_AlreadyHoldingOne,
    [span="background-color:green"][PARTY_MSG_MOVE_ITEM_WHERE]        = gText_MoveItemWhere,[/span]
};

And finally, we need to adjust the ITEM menu so that it actually includes our new menu option.

Find the definition of sPartyMenuAction_GiveTakeItemCancel, and modify it:

Spoiler:

[span="background-color:red"]static const u8 sPartyMenuAction_GiveTakeItemCancel[] = {MENU_GIVE, MENU_TAKE_ITEM, MENU_CANCEL2};[/span]
[span="background-color:green"]static const u8 sPartyMenuAction_GiveTakeItemCancel[] = {MENU_GIVE, MENU_TAKE_ITEM, MENU_MOVE_ITEM, MENU_CANCEL2};[/span]

Find the definition of sItemGiveTakeWindowTemplate and modify it:

Spoiler:

static const struct WindowTemplate sItemGiveTakeWindowTemplate =
{
    .bg = 2,
    .tilemapLeft = 23,
    [span="background-color:red"].timemapTop = 13,[/span]
    [span="background-color:green"].tilemapTop = 11,[/span]
    .width = 6,
    [span="background-color:red"].height = 6,[/span]
    [span="background-color:green"].height = 8,[/span]
    .paletteNum = 14,
    .baseBlock = 0x39D,
};

And that's it. Let me know if you have problems.

Edit: Oh, since I forgot to mention, my code here is licensed under the 0BSD license. In short, use it for whatever. Attribution is appreciated, but not required.

This code leaves out an important restriction. The player should not be able to initiate moving an item on a Pokemon with an item and then swap it with a Pokemon holding mail. Doing so can create blank mails that cannot be removed from a Pokemon by normal means.

In CursorCb_MoveItemCallback, under the check for eggs and giving to the same Pokemon in case 1, add this code:

    case 1:     // User hit A on a Pokemon
        // Pokemon can't give away items to eggs or themselves
        if (GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_IS_EGG)
            || gPartyMenu.slotId == gPartyMenu.slotId2)
        {
            PlaySE(SE_FAILURE);
            return;
        }

        [span="background-color:green"]if(GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM) >= ITEM_ORANGE_MAIL[/span]
        [span="background-color:green"]&& GetMonData(&gPlayerParty[gPartyMenu.slotId2], MON_DATA_HELD_ITEM) <= ITEM_RETRO_MAIL)[/span]
        [span="background-color:green"]{[/span]
            [span="background-color:green"]PlaySE(SE_FAILURE);[/span]
            [span="background-color:green"]return;[/span]
        [span="background-color:green"]}[/span]

 

[AlmightyK]

[Pokeemerald] Toggle Trainers "Seeing" You

This is probably mostly useful for a debug menu, but could have utility for certain game events.

• Add FLAG_TOGGLE_TRAINER_BATTLES in include/constants/flags
• Change CheckForTrainersWantingBattle in src/trainer_see.c to:
  

  bool8 CheckForTrainersWantingBattle(void)
  {
      u8 i;
      
      if (FlagGet(FLAG_TOGGLE_TRAINER_BATTLES))
          return FALSE;
      
      gNoOfApproachingTrainers = 0;
      //etc...

• set FLAG_TOGGLE_TRAINER_BATTLES in a script or function!

Obviously, still talking directly to the trainer will trigger the battle, but they won't catch sight of you.

I don't know why but this causes problem specifically with the team fight with Steven. Any trainer fight after that match will make you fight Maxie again and then no encounters after that.