Soft EXP Level Caps

[Lunos]

This thread's probably dead so this is a long shot, but could anyone help me out? I can't find the file src\battle_scripts_commands.c and a bunch of other lines seem to be missing. Does this still work with the current release of CFRU?

What do you mean by "still"?
This area of the forum encompasses ROM Hacking with Pret's decompilation projects.
The CFRU is a C injection that goes into a ROM, which is binary hacking territory. It is not related to decomp hacking.
This was never meant to be used with the CFRU. It's a modification of code for Pokeemerald.
If you want to port it to the CFRU, you're free to do so, but this isn't the right part of the forum to ask about it.

 

[GandalfTheGreen]

Oh lmao sorry, seems I'm barking up the wrong tree. I'll see myself out

 

[eatthepear]

I'd like to report a bug in the daycare functionality. In src/daycare.c, cap is never related to sLevelCaps anywhere, so it's by default set to zero. This means every single mon will be affected by the soft level cap on experience for the daycare. This can be easily fixed by adding cap = sLevelCaps; at the beginning of both for loops.

 

[Bruland]

Can someone help me implement this via discord? Bruland#0647

 

[Jaizu]

I do appreciate the tutorial but I do think this would fit better in a pokeemerald branch. It's easier to maintain and notice if there is any bugfix uploaded.

 

[ZekroSlice]

Hello! Just to know. Is this possible to do with a Ruby hack ? And 2nd what application are you using to do this ?

 

[Lunos]

Hello! Just to know. Is this possible to do with a Ruby hack ?

Yeah, it should be. It's all code, so in the worst case scenario, it can be adjusted.
Keep in mind this is a feature written for the decompilation projects though.

And 2nd what application are you using to do this ?

No programs besides a good text editor to read and write code with.
Notepad++, Visual Code Studio, or any equivalents to either of those would do.

 

[ZekroSlice]

Okay so can I get some explaining to how to do this in ruby(if it's different from the others gen 3 hacks)

 

[ZekroSlice]

I got several questions. 1 what application can I use to do that? And 2. Is the code different in a Ruby hack ? If not. Just explain to me how to add all of this if you can please 🙏🏾

 

[ZekroSlice]

How do I open a rom with theses ?

 

[Lunos]

Okay so can I get some explaining to how to do this in ruby(if it's different from the others gen 3 hacks)

I got several questions. 1 what application can I use to do that? And 2. Is the code different in a Ruby hack ? If not. Just explain to me how to add all of this if you can please ������������

How do I open a rom with theses ?

You have to understand that this is not a feature you can apply to a ROM.
As explained above, this is a feature meant to be merged into a project created using the decompilation projects made by Pret.
In a few words, the decompilation projects are copies of the games' source code created from scratch by exporting and translating ASM Routines into code written in C, the same programming language in which Game Freak wrote these games back in the day.
When you use the decompilation projects to perform modifications of these games, you don't work with a ROM. You work with plain source code.
As a result of this all being code and as you were already told, it can be handled or edited using a good text eitor such as Notepad++, a source code editor such as Visual Studio Code, or any equivalents.

Explaining to you the exact step-by-step process to implement this feature in a Pokeruby project would be too tiresome.
I suggest you to get acquainted with the decomps and give it a shot yourself.
You have a tutorial on how to set up an environment to use the decomps with here.
The rest is just a matter of copying and pasting the pieces of code that PokemonCrazy wrote in the main post, and then trying to build a ROM with it.
Depending on the label differences, you may need to tweak the code a bit to get it to build.
That's expected, as Pokeruby is far behind in terms of documentation compared to Pokefirered or Pokeemerald.

 

[ZekroSlice]

Thanks for your honesty and your response I've used HMA Editor so I think I can't even do what you're saying because it's in binary. But now I know what to do if I ever want to make another gen 3 game. Thanks at least for that

 

[Snibble]

I'm trying to implement the code, but at some point the code you provide differs from mine too much. I'm using the rh-hideout expansion (v 1.6.2) which is probably the reason.

you wrote, that one should search for the line

if (GetMonData(&gPlayerParty[gBattleStruct->expGetterMonId], MON_DATA_HP))

in case 2.

However, case 2 is structured completely different in my version.

Spoiler:

case 2: // set exp value to the poke in expgetter_id and print message
        if (gBattleControllerExecFlags == 0)
        {
            bool32 wasSentOut = ((gBattleStruct->expSentInMons & gBitTable[*expMonId]) != 0);
            holdEffect = GetMonHoldEffect(&gPlayerParty[*expMonId]);

            if ((holdEffect != HOLD_EFFECT_EXP_SHARE && !wasSentOut && !IsGen6ExpShareEnabled())
             || GetMonData(&gPlayerParty[*expMonId], MON_DATA_SPECIES_OR_EGG) == SPECIES_EGG)
            {
                gBattleScripting.getexpState = 5;
                gBattleMoveDamage = 0; // used for exp
            }
            else if ((gBattleTypeFlags & BATTLE_TYPE_INGAME_PARTNER && *expMonId >= 3)
                  || GetMonData(&gPlayerParty[*expMonId], MON_DATA_LEVEL) == MAX_LEVEL)
            {
                gBattleScripting.getexpState = 5;
                gBattleMoveDamage = 0; // used for exp
            #if B_MAX_LEVEL_EV_GAINS >= GEN_5
                MonGainEVs(&gPlayerParty[*expMonId], gBattleMons[gBattlerFainted].species);
            #endif
            }
            else
            {
                // Music change in a wild battle after fainting opposing pokemon.
                if (!(gBattleTypeFlags & BATTLE_TYPE_TRAINER)
                    && (gBattleMons[0].hp || (gBattleTypeFlags & BATTLE_TYPE_DOUBLE && gBattleMons[2].hp))
                    && !IsBattlerAlive(GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT))
                    && !IsBattlerAlive(GetBattlerAtPosition(B_POSITION_OPPONENT_RIGHT))
                    && !gBattleStruct->wildVictorySong)
                {
                    BattleStopLowHpSound();
                    PlayBGM(MUS_VICTORY_WILD);
                    gBattleStruct->wildVictorySong++;
                }

                if (IsValidForBattle(&gPlayerParty[*expMonId]))
                {
                    if (wasSentOut)
                        gBattleMoveDamage = gBattleStruct->expValue;
                    else
                        gBattleMoveDamage = 0;

                    if ((holdEffect == HOLD_EFFECT_EXP_SHARE || IsGen6ExpShareEnabled())
#if B_SPLIT_EXP >= GEN_6
                            // only give exp share bonus in later gens if the mon wasn't sent out
                            && gBattleMoveDamage == 0
#endif
                       )
                    {
                        gBattleMoveDamage += gBattleStruct->expShareExpValue;
                    }

                    ApplyExperienceMultipliers(&gBattleMoveDamage, *expMonId, gBattlerFainted);

                    if (IsTradedMon(&gPlayerParty[*expMonId]))
                    {
                        // check if the pokemon doesn't belong to the player
                        if (gBattleTypeFlags & BATTLE_TYPE_INGAME_PARTNER && *expMonId >= 3)
                            i = STRINGID_EMPTYSTRING4;
                        else
                            i = STRINGID_ABOOSTED;
                    }
                    else
                    {
                        i = STRINGID_EMPTYSTRING4;
                    }

                    // get exp getter battler
                    if (gBattleTypeFlags & BATTLE_TYPE_DOUBLE)
                    {
                        if (gBattlerPartyIndexes[2] == *expMonId && !(gAbsentBattlerFlags & gBitTable[2]))
                            gBattleStruct->expGetterBattlerId = 2;
                        else
                        {
                            if (!(gAbsentBattlerFlags & gBitTable[0]))
                                gBattleStruct->expGetterBattlerId = 0;
                            else
                                gBattleStruct->expGetterBattlerId = 2;
                        }
                    }
                    else
                    {
                        gBattleStruct->expGetterBattlerId = 0;
                    }

                    PREPARE_MON_NICK_WITH_PREFIX_BUFFER(gBattleTextBuff1, gBattleStruct->expGetterBattlerId, *expMonId);
                    // buffer 'gained' or 'gained a boosted'
                    PREPARE_STRING_BUFFER(gBattleTextBuff2, i);
                    PREPARE_WORD_NUMBER_BUFFER(gBattleTextBuff3, 6, gBattleMoveDamage);

                    if (wasSentOut || holdEffect == HOLD_EFFECT_EXP_SHARE)
                    {
                        PrepareStringBattle(STRINGID_PKMNGAINEDEXP, gBattleStruct->expGetterBattlerId);
                    }
                    else if (IsGen6ExpShareEnabled() && !gBattleStruct->teamGotExpMsgPrinted) // Print 'the rest of your team got exp' message once, when all of the sent-in mons were given experience
                    {
                        gLastUsedItem = ITEM_EXP_SHARE;
                        PrepareStringBattle(STRINGID_TEAMGAINEDEXP, gBattleStruct->expGetterBattlerId);
                        gBattleStruct->teamGotExpMsgPrinted = TRUE;
                    }

                    MonGainEVs(&gPlayerParty[*expMonId], gBattleMons[gBattlerFainted].species);
                }
                gBattleScripting.getexpState++;
            }
        }
        break;

I don't know if the soft-level cap is even possible with this setup. Do you have a solution for that? That would be really great.

 

[Anon822]

I'm trying to implement the code, but at some point the code you provide differs from mine too much. I'm using the rh-hideout expansion (v 1.6.2) which is probably the reason.

you wrote, that one should search for the line



in case 2.

However, case 2 is structured completely different in my version.

Spoiler:

case 2: // set exp value to the poke in expgetter_id and print message
        if (gBattleControllerExecFlags == 0)
        {
            bool32 wasSentOut = ((gBattleStruct->expSentInMons & gBitTable[*expMonId]) != 0);
            holdEffect = GetMonHoldEffect(&gPlayerParty[*expMonId]);

            if ((holdEffect != HOLD_EFFECT_EXP_SHARE && !wasSentOut && !IsGen6ExpShareEnabled())
             || GetMonData(&gPlayerParty[*expMonId], MON_DATA_SPECIES_OR_EGG) == SPECIES_EGG)
            {
                gBattleScripting.getexpState = 5;
                gBattleMoveDamage = 0; // used for exp
            }
            else if ((gBattleTypeFlags & BATTLE_TYPE_INGAME_PARTNER && *expMonId >= 3)
                  || GetMonData(&gPlayerParty[*expMonId], MON_DATA_LEVEL) == MAX_LEVEL)
            {
                gBattleScripting.getexpState = 5;
                gBattleMoveDamage = 0; // used for exp
            #if B_MAX_LEVEL_EV_GAINS >= GEN_5
                MonGainEVs(&gPlayerParty[*expMonId], gBattleMons[gBattlerFainted].species);
            #endif
            }
            else
            {
                // Music change in a wild battle after fainting opposing pokemon.
                if (!(gBattleTypeFlags & BATTLE_TYPE_TRAINER)
                    && (gBattleMons[0].hp || (gBattleTypeFlags & BATTLE_TYPE_DOUBLE && gBattleMons[2].hp))
                    && !IsBattlerAlive(GetBattlerAtPosition(B_POSITION_OPPONENT_LEFT))
                    && !IsBattlerAlive(GetBattlerAtPosition(B_POSITION_OPPONENT_RIGHT))
                    && !gBattleStruct->wildVictorySong)
                {
                    BattleStopLowHpSound();
                    PlayBGM(MUS_VICTORY_WILD);
                    gBattleStruct->wildVictorySong++;
                }

                if (IsValidForBattle(&gPlayerParty[*expMonId]))
                {
                    if (wasSentOut)
                        gBattleMoveDamage = gBattleStruct->expValue;
                    else
                        gBattleMoveDamage = 0;

                    if ((holdEffect == HOLD_EFFECT_EXP_SHARE || IsGen6ExpShareEnabled())
#if B_SPLIT_EXP >= GEN_6
                            // only give exp share bonus in later gens if the mon wasn't sent out
                            && gBattleMoveDamage == 0
#endif
                       )
                    {
                        gBattleMoveDamage += gBattleStruct->expShareExpValue;
                    }

                    ApplyExperienceMultipliers(&gBattleMoveDamage, *expMonId, gBattlerFainted);

                    if (IsTradedMon(&gPlayerParty[*expMonId]))
                    {
                        // check if the pokemon doesn't belong to the player
                        if (gBattleTypeFlags & BATTLE_TYPE_INGAME_PARTNER && *expMonId >= 3)
                            i = STRINGID_EMPTYSTRING4;
                        else
                            i = STRINGID_ABOOSTED;
                    }
                    else
                    {
                        i = STRINGID_EMPTYSTRING4;
                    }

                    // get exp getter battler
                    if (gBattleTypeFlags & BATTLE_TYPE_DOUBLE)
                    {
                        if (gBattlerPartyIndexes[2] == *expMonId && !(gAbsentBattlerFlags & gBitTable[2]))
                            gBattleStruct->expGetterBattlerId = 2;
                        else
                        {
                            if (!(gAbsentBattlerFlags & gBitTable[0]))
                                gBattleStruct->expGetterBattlerId = 0;
                            else
                                gBattleStruct->expGetterBattlerId = 2;
                        }
                    }
                    else
                    {
                        gBattleStruct->expGetterBattlerId = 0;
                    }

                    PREPARE_MON_NICK_WITH_PREFIX_BUFFER(gBattleTextBuff1, gBattleStruct->expGetterBattlerId, *expMonId);
                    // buffer 'gained' or 'gained a boosted'
                    PREPARE_STRING_BUFFER(gBattleTextBuff2, i);
                    PREPARE_WORD_NUMBER_BUFFER(gBattleTextBuff3, 6, gBattleMoveDamage);

                    if (wasSentOut || holdEffect == HOLD_EFFECT_EXP_SHARE)
                    {
                        PrepareStringBattle(STRINGID_PKMNGAINEDEXP, gBattleStruct->expGetterBattlerId);
                    }
                    else if (IsGen6ExpShareEnabled() && !gBattleStruct->teamGotExpMsgPrinted) // Print 'the rest of your team got exp' message once, when all of the sent-in mons were given experience
                    {
                        gLastUsedItem = ITEM_EXP_SHARE;
                        PrepareStringBattle(STRINGID_TEAMGAINEDEXP, gBattleStruct->expGetterBattlerId);
                        gBattleStruct->teamGotExpMsgPrinted = TRUE;
                    }

                    MonGainEVs(&gPlayerParty[*expMonId], gBattleMons[gBattlerFainted].species);
                }
                gBattleScripting.getexpState++;
            }
        }
        break;

I don't know if the soft-level cap is even possible with this setup. Do you have a solution for that? That would be really great.

The code you posted calls a function called "ApplyExperienceMultipliers". That sounds like a good place to insert the code that multiplies exp by the result of GetPkmnExpMultiplier.

 

[Snibble]

So if I Get this right, the function should change as follows:

Spoiler:

void ApplyExperienceMultipliers(s32 *expAmount, u8 expGetterMonId, u8 faintedBattler)
{
    u32 holdEffect = GetMonHoldEffect(&gPlayerParty[expGetterMonId]);
    [COLOR="Lime"]double expMultiplier = GetPkmnExpMultiplier(gPlayerParty[gBattleStruct->expGetterMonId].level);[/COLOR]

    if (IsTradedMon(&gPlayerParty[expGetterMonId])) //Traded Mons
        [COLOR="Red"]*expAmount = (*expAmount * 150) / 100;[/COLOR]
        [COLOR="Lime"]*expAmount = ((*expAmount * 150) / 100) * expMultiplier;[/COLOR]
    if (holdEffect == HOLD_EFFECT_LUCKY_EGG) //Lucky Egg
        [COLOR="Lime"]*expAmount = (*expAmount * 150) / 100;[/COLOR]
       [COLOR="Lime"] *expAmount = ((*expAmount * 150) / 100) * expMultiplier;[/COLOR]
    if (B_UNEVOLVED_EXP_MULTIPLIER >= GEN_6 && IsMonPastEvolutionLevel(&gPlayerParty[expGetterMonId])) //Unevolved Mons
        [COLOR="Red"]*expAmount = (*expAmount * 4915) / 4096;[/COLOR]
        [COLOR="Lime"]*expAmount = ((*expAmount * 4915) / 4096) * expMultiplier;[/COLOR]
    if (B_AFFECTION_MECHANICS == TRUE && GetBattlerFriendshipScore(expGetterMonId) >= FRIENDSHIP_50_TO_99) //Friendship Multiplier
        [COLOR="Red"]*expAmount = (*expAmount * 4915) / 4096;[/COLOR]
        [COLOR="Lime"]*expAmount = ((*expAmount * 4915) / 4096) * expMultiplier[/COLOR];
    if (CheckBagHasItem(ITEM_EXP_CHARM, 1)) //is also for other exp boosting Powers if/when implemented
       [COLOR="Red"] *expAmount = (*expAmount * 150) / 100;[/COLOR]
        [COLOR="Lime"]*expAmount = ((*expAmount * 150) / 100) * expMultiplier;[/COLOR]

    if (B_SCALED_EXP >= GEN_5 && B_SCALED_EXP != GEN_6)
    {
        // Note: There is an edge case where if a pokemon receives a large amount of exp, it wouldn't be properly calculated
        //       because of multiplying by scaling factor(the value would simply be larger than an u32 can hold). Hence u64 is needed.
        u64 value = *expAmount;
        u8 faintedLevel = gBattleMons[faintedBattler].level;
        u8 expGetterLevel = GetMonData(&gPlayerParty[expGetterMonId], MON_DATA_LEVEL);

        value *= sExperienceScalingFactors[(faintedLevel * 2) + 10];
        value /= sExperienceScalingFactors[faintedLevel + expGetterLevel + 10];
        [COLOR="Red"]*expAmount = value + 1;[/COLOR]
        [COLOR="Lime"]*expAmount = (value + 1) * expMultiplier;[/COLOR]
    }
}

I'll try this out now.

 

[Snibble]

Okay, it does not work.

instead, I'm greeted with this error when trying to make the gba file:

`__cmpdi2' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_cmpdi2.o)
`__floatdidf' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_floatdidf.o)

I have no idea what's happening in that error msg tbh. I get the syntax but I don't get, why it's happening.

Edit:

This error occurs once I edit void ApplyExperienceMultipliers. It does not appear before that.

 

[Anon822]

Okay, it does not work.

instead, I'm greeted with this error when trying to make the gba file:

`__cmpdi2' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_cmpdi2.o)
`__floatdidf' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_floatdidf.o)

I have no idea what's happening in that error msg tbh. I get the syntax but I don't get, why it's happening.

Edit:

This error occurs once I edit void ApplyExperienceMultipliers. It does not appear before that.

Seems like the linker doesn't like you multiplying a u64 with a double.
Here's a version of the function that doesn't do that:

Spoiler:

void ApplyExperienceMultipliers(s32 *expAmount, u8 expGetterMonId, u8 faintedBattler)
{
    u32 holdEffect = GetMonHoldEffect(&gPlayerParty[expGetterMonId]);
[COLOR="Lime"]    u8 expGetterLevel = GetMonData(&gPlayerParty[expGetterMonId], MON_DATA_LEVEL);
    *expAmount *= GetPkmnExpMultiplier(expGetterLevel);[/COLOR]

    if (IsTradedMon(&gPlayerParty[expGetterMonId]))
        *expAmount = (*expAmount * 150) / 100;
    if (holdEffect == HOLD_EFFECT_LUCKY_EGG)
        *expAmount = (*expAmount * 150) / 100;
    if (B_UNEVOLVED_EXP_MULTIPLIER >= GEN_6 && IsMonPastEvolutionLevel(&gPlayerParty[expGetterMonId]))
        *expAmount = (*expAmount * 4915) / 4096;
    if (B_AFFECTION_MECHANICS == TRUE && GetBattlerFriendshipScore(expGetterMonId) >= FRIENDSHIP_50_TO_99)
        *expAmount = (*expAmount * 4915) / 4096;
    if (CheckBagHasItem(ITEM_EXP_CHARM, 1)) //is also for other exp boosting Powers if/when implemented
        *expAmount = (*expAmount * 150) / 100;

    if (B_SCALED_EXP >= GEN_5 && B_SCALED_EXP != GEN_6)
    {
        // Note: There is an edge case where if a pokemon receives a large amount of exp, it wouldn't be properly calculated
        //       because of multiplying by scaling factor(the value would simply be larger than an u32 can hold). Hence u64 is needed.
        u64 value = *expAmount;
        u8 faintedLevel = gBattleMons[faintedBattler].level;
[COLOR="Red"]        //u8 expGetterLevel = GetMonData(&gPlayerParty[expGetterMonId], MON_DATA_LEVEL);[/COLOR]

        value *= sExperienceScalingFactors[(faintedLevel * 2) + 10];
        value /= sExperienceScalingFactors[faintedLevel + expGetterLevel + 10];
        *expAmount = value + 1;
    }
}

 

[Filup Cat]

Okay, it does not work.

instead, I'm greeted with this error when trying to make the gba file:

`__cmpdi2' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_cmpdi2.o)
`__floatdidf' referenced in section `.text' of src/battle_script_commands.o: defined in discarded section `.text' of ../../tools/agbcc/lib/libgcc.a(_floatdidf.o)

I have no idea what's happening in that error msg tbh. I get the syntax but I don't get, why it's happening.

Edit:

This error occurs once I edit void ApplyExperienceMultipliers. It does not appear before that.

Hey, I'm running into the same issue using Pokeemerald-expansion. Wondering if you figured this out and/or if Anon822's solution worked for you.

Edit: For anyone else that ends up here, I added Snibble's code with Anon822 extra lines and everything seems to be working. No errors and some test battles in game are yielding exp numbers that I would expect.