• Just a reminder that providing specifics on, sharing links to, or naming websites where ROMs can be accessed is against the rules. If your post has any of this information it will be removed.
  • Ever thought it'd be cool to have your art, writing, or challenge runs featured on PokéCommunity? Click here for info - we'd love to spotlight your work!
  • PokéCommunity's Easter Egg Hunt is now on! If you're interested in looking for some eggs and earning badges, click here!
  • Our weekly protagonist poll is now up! Vote for your favorite Conquest protagonist in the poll by clicking here.
  • Welcome to PokéCommunity! Register now and join one of the best fan communities on the 'net to talk Pokémon and more! We are not affiliated with The Pokémon Company or Nintendo.
    Register

Improved Battle Menu and Summary Screen [v17.2]

Super cool script, something that stands out for me is the correct type for HP, judgement etc.

how compatible (minus the type effectiveness i'd say, as its in there) is it to add to ebs? guessing you've not tested but surely it could be done, and if not the new menu stab etc. but the correct type displayment would be great to add ^^
 
ArchyTheArc said:
Super cool script, something that stands out for me is the correct type for HP, judgement etc.

how compatible (minus the type effectiveness i'd say, as its in there) is it to add to ebs? guessing you've not tested but surely it could be done, and if not the new menu stab etc. but the correct type displayment would be great to add ^^
Click to expand...

I'm sure its doable. But I personally don't use the EBS so I don't plan on supporting it. I don't mind looking into it in the future though.
 
All fine, im sure the stab and new summary stuff is easy (As summary isnt even ebs really and ebs use move.type)

from what i see of the code, while im not sure WHY it fixes stuff, its movetype right? and it just replaces move.type ?

EDIT: got it working :O barely had to change how it worked either; tested with normalize on zangoose and yea, (unless it always shows normal rn but xP

[PokeCommunity.com] Improved Battle Menu and Summary Screen [v17.2]
 
Last edited:
ArchyTheArc said:
EDIT: got it working :O barely had to change how it worked either; tested with normalize on zangoose and yea, (unless it always shows normal rn but xP

[PokeCommunity.com] Improved Battle Menu and Summary Screen [v17.2]
Click to expand...

O.o Nice. Can you PM the code with me. I wouldn't mind putting it in the Main post.
 
One really small suggestion. In the official games (at least in SM I haven't played SwSh lol), the effectiveness is initially displayed as the greater of the 2 effectivenesses on the opponents, but it's coded here as the average of the 2. This makes it a little odd especially if one opponent is immune to the attack and the other is normally affected by it (displays as not-very-effective before clicking on the move).
Basically what I'm recommending is changing
Code: 
typemod=(moves[i].effectiveness(moveType,battler,opp)+ moves[i].effectiveness(moveType,battler,opp.pbPartner))*0.5
to
Code: 
typemod=[moves[i].effectiveness(moveType,battler,opp),moves[i].effectiveness(moveType,battler,opp.pbPartner)].max
 
silverlime said:
One really small suggestion. In the official games (at least in SM I haven't played SwSh lol), the effectiveness is initially displayed as the greater of the 2 effectivenesses on the opponents, but it's coded here as the average of the 2. This makes it a little odd especially if one opponent is immune to the attack and the other is normally affected by it (displays as not-very-effective before clicking on the move).
Click to expand...

Sure that should be easy to do. I'll try to add that in the next update which should hopefully be coming tomorrow. Almost all bugs with the Summary Screen have been fixed, and I have cleaned up the code a bit more so it should be a substantial upgrade.
 
v3.4 Update!
  • Fixes all issues with the new Summary Screen.
  • Changed how types are displayed in double battles
  • Added Text and Arrow Indicators to guide people when using the new summary screen.
 
I have qution where should I put this script. Above dynamax script or directly above main
 
I am getting this error message when I battle any trainer or wild pokemon

---------------------------
Error
---------------------------
Script '[Advance battle Menu]' line 358: NoMethodError occurred.

undefined method `battlers' for #<Viewport:0xc140d58>

from 'Advance battle Menu' line 358 in `refresh'
from 'Advance battle Menu' line 340 in `initialize'
from 'Advance battle Menu' line 200 in `new'
from 'Advance battle Menu' line 200 in `initialize'
from 'PokeBattle_Scene' line 1917 in `new'
from 'PokeBattle_Scene' line 1917 in `pbStartBattle'
from 'PokeBattle_Battle' line 2464 in `pbStartBattleCore'
from 'PokeBattle_Battle' line 2431 in `pbStartBattle'
from 'Overworl Pokemon Enconter' line 673 in `pbWildBattle'
from 'Overworl Pokemon Enconter' line 672 in `pbSceneStandby'
from 'Overworl Pokemon Enconter' line 674 in `pbWildBattle'
from 'Overworl Pokemon Enconter' line 671 in `pbBattleAnimation'
---------------------------
OK
---------------------------
 
Subhajit said:
I am getting this error message when I battle any trainer or wild pokemon

---------------------------
Error
---------------------------
Click to expand...

Did you follow the instructions correctly?
 
After I installed this script, every battle has caused a crash, even with the pre-made "I like shorts!" guy. Did I do something wrong?

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: RuntimeError

Message: Script error within event 23 (coords 29,7), map 3 (AAA's house):

Exception: ArgumentError

Message: PokeBattle_Scene:1913:in `initialize'wrong number of arguments(4 for 2)

***Full script:

pbTrainerBattle(:YOUNGSTER,"Ben",_I("Aww, I lost."),false,0,false,0)

Interpreter:243:in `pbExecuteScript'

PokeBattle_Scene:1913:in `new'

PokeBattle_Scene:1913:in `pbStartBattle'

PokeBattle_Battle:2456:in `pbStartBattleCore'

PokeBattle_Battle:2351:in `pbStartBattle'

PField_Battles:288:in `pbTrainerBattle'

PField_Battles:287:in `pbSceneStandby'

PField_Battles:289:in `pbTrainerBattle'

PField_Battles:286:in `pbBattleAnimation'

PField_Battles:286:in `pbTrainerBattle'



Interpreter:276:in `pbExecuteScript'

Interpreter:794:in `command_111'

Interpreter:320:in `execute_command'

Interpreter:193:in `update'

Interpreter:106:in `loop'

Interpreter:198:in `update'

Scene_Map:163:in `update'

Scene_Map:161:in `loop'

Scene_Map:170:in `update'

Scene_Map:234:in `main'



This exception was logged in

C:\Users\MYNAME\Saved Games\Pokemon Essentials\errorlog.txt.

Press Ctrl+C to copy this message to the clipboard.
---------------------------
OK
---------------------------
 
Golisopod User said:
Did you follow the instructions correctly?
Click to expand...

Ok now it is working but I have a question if a pokemon has a stab move and opponent pokemon resist the move what will this script do? Will it show the stab or not very effective. (sorry my English is bad)
 
Subhajit said:
Ok now it is working but I have a question if a pokemon has a stab move and opponent pokemon resist the move what will this script do? Will it show the stab or not very effective. (sorry my English is bad)
Click to expand...

It will show both
 
Installation of Script
Place this in a New Script Section above Main
Use Ctrl + Shift + F to look for FightMenuDisplay.new in PokeBattle_Scene and replace that line with this:
@sprites["fightwindow"]=FightMenuDisplay.new(nil,battle,@viewport,-1)
Paste the items in the folder to your Graphics/Pictures/Summary folder
Edit the Customizable Options
Start a new save (Not necessary, but just to be on the safe side)

What do you mean "this"?

What is the "this" i need to paste? I have completed every step except "paste this in a new script section above main", which I do not understand. FightMenuDisplay.new has been replaced, the items are in my graphics folder, I made my choices in the customizable options, I've started a new save. What's left?

edit: also this

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: NoMethodError

Message: undefined method `*' for nil:NilClass

Game_Character:202:in `screen_z'

Sprite_Character:154:in `shadow_update'

Sprite_DynamicShadows:164:in `update_or'

Tilemap_Perspective:436:in `update'

Sprite_Character:44:in `shadow_initialize'

Sprite_DynamicShadows:141:in `perspectivetilemap_initialize'

Tilemap_Perspective:430:in `initialize'

Spriteset_Map:64:in `new'

Spriteset_Map:64:in `_animationSprite_initialize'

Spriteset_Map:63:in `each'



This exception was logged in

C:\Users\MYNAME\Saved Games\Pokemon Essentials\errorlog.txt.

Press Ctrl+C to copy this message to the clipboard.
---------------------------
OK
---------------------------
 
Last edited:
SuperSpyroDragon64 said:
Installation of Script
Place this in a New Script Section above Main
Use Ctrl + Shift + F to look for FightMenuDisplay.new in PokeBattle_Scene and replace that line with this:
@sprites["fightwindow"]=FightMenuDisplay.new(nil,battle,@viewport,-1)
Paste the items in the folder to your Graphics/Pictures/Summary folder
Edit the Customizable Options
Start a new save (Not necessary, but just to be on the safe side)

What do you mean "this"?

What is the "this" i need to paste? I have completed every step except "paste this in a new script section above main", which I do not understand. FightMenuDisplay.new has been replaced, the items are in my graphics folder, I made my choices in the customizable options, I've started a new save. What's left?

edit: also this

---------------------------
Pokemon Essentials
---------------------------
[Pokémon Essentials version 17.2]

Exception: NoMethodError

Message: undefined method `*' for nil:NilClass

Game_Character:202:in `screen_z'

Sprite_Character:154:in `shadow_update'

Sprite_DynamicShadows:164:in `update_or'

Tilemap_Perspective:436:in `update'

Sprite_Character:44:in `shadow_initialize'

Sprite_DynamicShadows:141:in `perspectivetilemap_initialize'

Tilemap_Perspective:430:in `initialize'

Spriteset_Map:64:in `new'

Spriteset_Map:64:in `_animationSprite_initialize'

Spriteset_Map:63:in `each'



This exception was logged in

C:\Users\MYNAME\Saved Games\Pokemon Essentials\errorlog.txt.

Press Ctrl+C to copy this message to the clipboard.
---------------------------
OK
---------------------------
Click to expand...

"This" is the contents of Improved Battle Menu and Summary Screen.txt

Also are you using EBS?
 
I'm not using EBS. Where do I get "the contents of Improved Battle Menu and Summary Screen.txt"?

When I click your download link, all I see is one .txt file and a folder for graphics.
 
You must log in or register to reply here.
Back
Top