Script Help Thread (DO NOT REQUEST SCRIPTS)

[wwmb]

Hello!
I'm hacking Pokémon emerald; I'm writing my scripts in XSE; and I am trying to create a script-tile that when stepped upon teleports the player (with animation) to a random location on the map. Realizing this would be a scripting nightmare (due to getting stuck in the walls) I simply made the script choose a random of 8 predefined locations to teleport to.

Here

warpteleport 0x22 0x0 0xFF 0x4 0x4

is one of the 8 lines of code executed, and are doing so almost exactly how I want them to be. The problem I am having is that this reloads the map; causing my map script to trigger, refresh flags and re-randomize the dungeon. So now I'm here asking: what command I should be using instead?

Thanks!


-------------------------------------------------------------------------------

I just have two quick questions. First I don't know which flags are available in emerald and secondly I want to create a give pokedex script, but I dont even know where to begin. I use pokescript, not XSE so can anyone give me any advice?

You should start by opening up the script in which the professor gives you the pokédex


(Hmmm, I can't seem to find it... I searched using PKSV-UI and found the script 1FA3B5

Spoiler:

XSE:
//---------------
#org 0x1FA3B5
setflag 0x861
special 0x1F0
setflag 0x8E4
setvar 0x40CD 0x1
return

PKSV:
#org 0x81FA3B5
'-----------------------------------
setflag 0x861
special 0x1F0
setflag 0x8E4
setvar 0x40CD 0x1
return

I am not entirely sure where the script is called from however.

Anyways, set the flag 0x861 and you will have set the pokédex in emerald.

(Hmmmm, I wonder where that script is.....)

 

[Renegade]

I have a question. Hope someone can answer.

Is there a way to check if a var has been set? Maybe something like "checkvar 0x5004".
Thank you for your time in advance!

 

[itman]

I have a question. Hope someone can answer.

Is there a way to check if a var has been set? Maybe something like "checkvar 0x5004".
Thank you for your time in advance!

Use the "compare" command.
So if you want to see if variable 5004 is equal to 1, do this:

compare 0x5004 0x1
if 0x1 goto @Wherever
...

So basically, in this script, it's checking if the var is set to 1. If it is, it goes to @Wherever.
Now, if a var is not set, it will equal zero, so...

compare 0x5004 0x0
if 0x1 goto @Wherever
...

There you go, that's how to check if a var is not set.

 

[crystalmole]

Hi guys I have a problem with this script.

Spoiler:

#dynamic 0x800000
#org @start
checkflag 0x511
if 0x1 goto @done
release
end

#org @done
checkflag 0x828
if 0x1 goto @end
msgbox @1 0x6
release
end


#org @1
= [blue_fr]Oak: Where are you\ngoing?\pPick a Pokémon.

#org @end
release
end

#org @move
#raw 0x10
#raw 0xFE

It should do nothing when you first pass over it, and after a flag is set it should stop you from moving on. However when you first pass over it the game freezes.

 

[wwmb]

Hi guys I have a problem with this script.

Spoiler:

#dynamic 0x800000
#org @start
checkflag 0x511
if 0x1 goto @done
release
end

#org @done
checkflag 0x828
if 0x1 goto @end
msgbox @1 0x6
release
end


#org @1
= [blue_fr]Oak: Where are you\ngoing?\pPick a Pokémon.

#org @end
release
end

#org @move
#raw 0x10
#raw 0xFE

It should do nothing when you first pass over it, and after a flag is set it should stop you from moving on. However when you first pass over it the game freezes.

Check the "var number" and "var values" on the script tile in A-Map.

Another way you could do this (much like how you rival sits and waits for you in OLDALE TOWN after battling him/her in RSE) is to have a variable start at 0, and then go up to 1 (or what ever number 'var value' equals) when you want the player stopped, and then make it change to 2+ after that event is done. (You would still need to set a flag to hide any sprites... but anyways: the script tiles like variables.)

Good luck!

 

[Herpahermaderp]

Hi guys I have a problem with this script.

Spoiler:

#dynamic 0x800000
#org @start
checkflag 0x511
if 0x1 goto @done
release
end

#org @done
checkflag 0x828
if 0x1 goto @end
msgbox @1 0x6
release
end


#org @1
= [blue_fr]Oak: Where are you\ngoing?\pPick a Pokémon.

#org @end
release
end

#org @move
#raw 0x10
#raw 0xFE

It should do nothing when you first pass over it, and after a flag is set it should stop you from moving on. However when you first pass over it the game freezes.

Where does the movement come into play? Also, flag 511 is a flag already used by the game, you need to use one over 1000. You also don't need a release if you don't have a lock.

#dynamic 0x800000

#org @start
checkflag 0x1111
compare LASTRESULT 0x1
if 0x1 goto @done
release
end

#org @done
lock
checkflag 0x828
compare LASTRESULT 0x1
if 0x1 goto @end
msgbox @1 0x6
applymovement 0xFF @move
release
end

#org @end
release
end

#org @move
#raw 0x10
#raw 0xFE

#org @1
= [blue_fr]Oak: Where are you\ngoing?\pPick a Pokemon.

All bold parts are the things you need to add, slashes must be removed...

 

[SeoCypher]

NOTE: Reposted from the Simple questions thread, and now bumped, this place seems like a better place for it, even if it is a little hardcore

Game: Pokemon FireRed
Type: HEX/XSE/Pokescript for music
Editor: XSE/PKSV

I've been on these forums awhile, but never posted posted once, hiya!

Anyway, I'm not EXACTLY sure if my question fits this thread, so apologies.
Question:
So far the only way to change what music plays at any given time in FireRed (specifically in battle) is MMX's Music Replacement hex code thing, right?

I'm trying to use it, but I've only been learning hex for about 3 weeks (because relying on tools is for noob hackers).
Here's the main routine, as you can see it's not changed from the one at sfc.pokefans.net
(just go to the lessons page, "Fancy Knowledge #3." I'm not at 15 posts yet and I don't think you would appreciate me gumming up your forum trying to reach 15 before posting this. The site is just there for reference, hopefully all the information needed is in this post)

Spoiler:

0071DB20 FE B4 05 1C 1B 48 20 49 00 F0 33 F8 00 22 90 42 þ´...H I.ð3ø.".B
0071DB30 0B D0 03 88 1B 49 8B 42 07 D0 AB 42 05 D1 17 48 .Ð.ˆ.I‹B.ЫB.Ñ.H
0071DB40 19 49 00 F0 26 F8 05 88 12 E0 13 48 16 49 00 F0 .I.ð&ø.ˆ.à.H.I.ð
0071DB50 20 F8 00 22 90 42 0B D0 03 88 12 49 8B 42 07 D0 ø.".B.Ð.ˆ.I‹B.Ð
0071DB60 AB 42 05 D1 0E 48 10 49 00 F0 13 F8 05 88 FF E7 «B.Ñ.H.I.ð.ø.ˆÿç
0071DB70 28 04 FE BC 0D 4A 04 B4 0D 4A 0E 49 40 0B 40 18 (.þ¼.J.´.J.I@.@.
0071DB80 83 88 59 00 C9 18 89 00 89 18 0A 68 01 68 10 1C ƒˆY.É.‰.‰..h.h..
0071DB90 00 BD 08 47 14 10 00 00 15 10 00 00 16 10 00 00 .½.G............
0071DBA0 17 10 00 00 FF FF 00 00 55 E4 06 08 0F D1 1D 08 ....ÿÿ..Uä...Ñ..
0071DBB0 9C 32 4A 08 CC 32 4A 08 00 00 00 00 00 00 00 00 œ2J.Ì2J.........

And my edited musicloader:

Spoiler:

01 49 08 47 00 00 20 DB 71 08 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

The game loads perfectly, all music and sounds: check.
however, I have been, as of yet, unable to actually REPLACE any music.
quick example:

Spoiler:

#org 0x74079A
setvar 0x1014 0x109
setvar 0x1016 0x10A
trainerbattle 0x0 0x0 0x0 0x87407C5 0x87407D9
msgbox 0x87407E9 MSG_NORMAL '"I can also say something after the..."
setvar 0x1014 0x10A
setvar 0x1016 0x109
end


'---------
' Strings
'---------
#org 0x7407C5
= I will crush you!!!

#org 0x7407D9
= You crushed me[.]

#org 0x7407E9
= I can also say something after the battle

(Yes I know it's in pokescript. The website specifically says pokescript, and who am I to argue with the great and powerful overlords known as the people who can actually hex?)

The music values are just there for test, I forgot which is which, I actually created TWO scripts that flops them around.
I'm TRYING to replace basic battle music. What I replace it with isn't important at the moment, I'm testing this in a clean ROM before even daring to attempt it on my hack, which uses an extended music table.
I am not EXACTLY sure what the problem is, but I may have narrowed it down:
a. I'm just using the wrong music values?
b. I'm just using the setvar command wrong? (unlikely imo, setvar isn't that hard)
c. There has been some babble about variable values being the cause of most, if not all problems had with this loader, if that is the case, help me out!
d. I derped up a pointer or something. Very likely.

EDIT:
Ran a quick test, trying to change the overworld music for Pallet, didn't work. Not sure if it's just the map header overriding what I put in, but that leads me to think it might be a problem with the hex or syntax, not the actual music values.

Whatever the problem is, please point me in the right direction for fixing it! (Or if this is the wrong thread, please point me to the right one!)

Thank you so much in advance!

 

[Dddzort]

What command do I put in a trainer battle script to make the vs seeker work?

 

[tajaros]

What command do I put in a trainer battle script to make the vs seeker work?

Use Trainerbattle 0x3.

Look here for more detail. https://www.pokecommunity.com/posts/7400738/

 

[awipe1]

Hello, this is such a simple question yet I can't find the answer anywhere!
What kind of trainbattle do I use to make the script keep going regarless of defeat? Kinda like the one where you face your rival but without prof oak talking.

 

[itman]

Hello, this is such a simple question yet I can't find the answer anywhere!
What kind of trainbattle do I use to make the script keep going regarless of defeat? Kinda like the one where you face your rival but without prof oak talking.

There is none. -_- Unfortunately. BUT, you can get around this.

Using JPAN's hacked engine, you can set anywhere to be a healing place.
So before you battle, set that spot as a healing place.
When you whiteout, nothing will show up because in the hacked engine, there is an option to do so.
Then make a level script continuing the script.
As for the losing money, it'll still say you lost it...but if that's REALLY that big of a deal, you can store the players money in a variable before hand and blahblahblah return it afterward.

 

[Dddzort]

Spoiler:

#dynamic 0x800000

#org @start
lock
faceplayer
msgbox @what 0x6
trainerbattle 0x0 0x5E 0x0 @what @defeat
special2 0x800D 0x39
compare 0x800D 0x1
if 0x1 goto @rematch
msgbox @after 0x6
release
end

#org @what
= What do you want?

#org @defeat
= Hmph!

#org @after
= Your a good trainer.

#org @rematch1
= Lets battle again!

#org @rematch
trainerbattle 0x5 0x5D 0x0 @rematch1 @defeat
msgbox @after 0x6
end

I cant get this script to work. It should be a regular trainerbattle then you should be able to use VS Seeker for rematch. But when the trainer sees me in the map the screen goes red.

 

[Jambo51]

Spoiler:

#dynamic 0x800000

#org @start
trainerbattle 0x0 0x5E 0x0 @what @defeat
special2 0x800D 0x39
compare 0x800D 0x1
if 0x1 goto @rematch
msgbox @after 0x6
release
end

#org @what
= What do you want?

#org @defeat
= Hmph!

#org @after
= You're a good trainer.

#org @rematch1
= Let's battle again!

#org @rematch
trainerbattle 0x5 0x5D 0x0 @rematch1 @defeat
msgbox @after 0x6
end

That should work. Your mistake was having normal scripting code at the start of the script. In trainerbattle scripts of type 0x0 and 0x2, you MUST have the trainerbattle command itself FIRST in the script. The game is quite clever, it only executes it when necessary, and skips it at all other times.

Hope that helps! (Also, I fixed a spelling error. :P)

 

[Dddzort]

Thank you very much!
It works now :D

 

[Jambo51]

And my edited musicloader:

Spoiler:

01 49 08 47 00 00 20 DB 71 08 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

It is, quite frankly, a miracle that your game doesn't crash on all music changes, because you haven't done this part correctly.

That 20 (the one I bolded) should be a 21. You MUST ALWAYS add 1 to a pointer when putting in a piece of custom THUMB ASM (which is what this is). In practice, your ROM should crash, because you're telling it to execute the wrong type of code. The fact that it doesn't is just down to sheer luck.

Make that change, and that'll be a good start.

Spoiler:

#org 0x74079A
setvar 0x1014 0x109
setvar 0x1016 0x10A
trainerbattle 0x0 0x0 0x0 0x87407C5 0x87407D9
msgbox 0x87407E9 MSG_NORMAL '"I can also say something after the..."
setvar 0x1014 0x10A
setvar 0x1016 0x109
end


'---------
' Strings
'---------
#org 0x7407C5
= I will crush you!!!

#org 0x7407D9
= You crushed me[.]

#org 0x7407E9
= I can also say something after the battle

Spoiler:

What script editor you use is irrelevant, but you CANNOT put ANYTHING other than the trainerbattle command at the top of a trainerbattle script of type 0x0 or 0x2. That's why this method of music swapping is so limited; It can only truly be used on rival/gym leader style battles. If you're very careful and clever with your use of the variables in level scripts, you can just about achieve a regional music split, but nothing more than that.

In simpler terms, the setvars I bolded cannot go there. The game will crash, or at best, ignore them, because trainerbattle type 0x0 (and 0x2 as it happens) REQUIRE the trainerbattle command to be at the top of the script.

There are other ways to define class related battle music, which are less flexible, but are guaranteed to work.

 

[ArcHeLL]

Game: Pokemon Fire Red
Type:XSE
Editor:XSE
Script:

Spoiler:

#dynamic 0x800000

#org @start
lock
faceplayer
cry 0x19 0x0
msgbox @roar 0x6
waitcry
wildbattle 0x19 0x5 0x0 0x0
fadescreen 0x0
hidesprite 0x800F
fadescreen 0x1
setflag 0x1000
release
end

#org @roar
= PIKACHU: PIKA!

Screenshots and/or videos: http :// imgur.com/a/jD4yh (remove the spaces because i can't post url)

Guys please help me i made a wildbattle script with XSE to battle pikachu and i have 2 problems, 1st the message box don't appear and 2nd after i finish the battle the pikachu's sprite get's removed but when i move again it appears again! and i can battle it over and over again but i want it only once to battle it please help me.

 

[tajaros]

Game: Pokemon Fire Red
Type:XSE
Editor:XSE
Script:

Spoiler:

#dynamic 0x800000

#org @start
lock
faceplayer
cry 0x19 0x0
msgbox @roar 0x6
waitcry
wildbattle 0x19 0x5 0x0 0x0
fadescreen 0x0
hidesprite 0x800F
fadescreen 0x1
setflag 0x1000
release
end

#org @roar
= PIKACHU: PIKA!

Screenshots and/or videos: http :// imgur.com/a/jD4yh (remove the spaces because i can't post url)

Guys please help me i made a wildbattle script with XSE to battle pikachu and i have 2 problems, 1st the message box don't appear and 2nd after i finish the battle the pikachu's sprite get's removed but when i move again it appears again! and i can battle it over and over again but i want it only once to battle it please help me.

I am quite sure that you got this script from my tutorial... :/

Nothing seems to be wrong with the msgbox it's just there's an extra 0x0 in the wildbattle script. And if you want to make pikachu disappear completely you have to put 1000 to Pikachu's Person ID in A-map because, you have set flag 0x1000.

Here's the fixed script. although I just removed the 0x0... :D

#dynamic 0x800000

#org @start
lock
faceplayer
cry 0x19 0x0
msgbox @roar 0x6
waitcry
wildbattle 0x19 0x5 0x0
fadescreen 0x0
hidesprite 0x800F
fadescreen 0x1
setflag 0x1000
release
end

#org @roar
= PIKACHU: PIKA!

Hope this helps.

 

[ArcHeLL]

Ok thanks man, i putted the last 0x0 because XSE requires 4 of those 0x that's why. :P
but still i have the problem with the msgbox..

 

[tajaros]

Ok thanks man, i putted the last 0x0 because XSE requires 4 of those 0x that's why. :P
but still i have the problem with the msgbox..

Also the script works perfectly fine with me, maybe you missed some things when compiling and getting the offset.

 

[M.L]

#dynamic 0x800000

#org @start
applymovement 0x04 @move
waitmovement 0x0
checkflag 0x828
if 0x1 goto @done
msgbox @1 0x5
compare LASTRESULT 0x1
if 0x1 goto @take
msgbox @2 0x6
checkflag 0x828
if 0x1 goto @start
release
end

#org @take
givepokemon 0x84 0x5 0x0 0x0 0x0 0x0
fanfare 0x13E
msgbox @3 0x4
waitfanfare
closeonkeypress
setflag 0x828
msgbox @4 0x5
compare LASTRESULT 0x1
if 0x1 gosub @name
msgbox @5 0x6
setflag 0x829
msgbox @6 0x6
msgbox @7 0x6
fadescreen 0x1
hidesprite 0x800F
fadescreen 0x0
setflag 0x8A0
release
end

#org @name
call 0x1A74EB
return

#org @done
release
end

#org @move
#raw 0x11
#raw 0x11
#raw 0x11
#raw 0x11
#raw 0x11
#raw 0xFE

#org @1
= Hello.\nI am Proffessor Riley.\nyour pokemon was transfere from\nKanto..\pSo I am here to give it to you\nWill you take it?

#org @2
= You don't want you pokemon?

#org @3
= [black_fr]You received a DITTO!

#org @4
= [black_fr]Would you like to give a\nnickname to DITTO?

#org @5
= I also have a pokedex for you.

#org @6
= [black_fr]You received the Pokedex.

#org @7
= Your brother had sent a\npackage for you, although\lit appears to have ended up in\nResno town.\pYou may want to go fetch it.



I compile it and insert it, as i walk on the script nothing happens. did i miss something?