Our software update is now concluded. You will need to reset your password to log in. In order to do this, you will have to click "Log in" in the top right corner and then "Forgot your password?".
Welcome to PokéCommunity! Register now and join one of the best fan communities on the 'net to talk Pokémon and more! We are not affiliated with The Pokémon Company or Nintendo.
Make the game read the dynamic type of Hidden Power in battles (Em)
To be honest, this is something I already tried to look into, but none of the things I tried worked.
After seeing Jirachii's post, I decided to take a stab at it once more and learning from their implementation, I was able to successfully pull it off.
The changes are done in the MoveSelectionDisplayMoveType function located in the src/battle_controller_player.c file.
We calculate Hidden Power's dynamic type normally, store the result in a variable called type and then copy the Type Name string of said type instead of the Type Name string of its true type.
This snippet needs to be placed after the "else if (JOY_NEW(B_BUTTON))" statement in that method not at the end of the method (inside the last bracket before the end bracket).
It should look like this:
Spoiler:
Code:
else if (JOY_NEW(B_BUTTON))
{
StopPokemonAnimations();
PlaySE(SE_SELECT);
BeginCloseSummaryScreen(taskId);
}
[COLOR="Lime"][B]// show IVs/EVs/stats on button presses[/B][/COLOR]
[COLOR="SeaGreen"][B]else if (JOY_NEW(R_BUTTON))
{
if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
BufferIvOrEvStats(0);
}
else if (JOY_NEW(L_BUTTON))
{
if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
BufferIvOrEvStats(1);
}
else if (JOY_NEW(START_BUTTON))
{
if (sMonSummaryScreen->currPageIndex == PSS_PAGE_SKILLS)
BufferIvOrEvStats(2);
}[/B][/COLOR]
}
}
static void ChangeSummaryPokemon(u8 taskId, s8 delta)
Seems like it works just fine, applied it myself and no softlock. Maybe an update in pokeemerald itself fixed it automatically, not sure but yeah it's working just fine (I followed the exact steps as in the post about the patch).
Make the game read the dynamic type of Hidden Power in battles (Em)
To be honest, this is something I already tried to look into, but none of the things I tried worked.
After seeing Jirachii's post, I decided to take a stab at it once more and learning from their implementation, I was able to successfully pull it off.
The changes are done in the MoveSelectionDisplayMoveType function located in the src/battle_controller_player.c file.
We calculate Hidden Power's dynamic type normally, store the result in a variable called type and then copy the Type Name string of said type instead of the Type Name string of its true type.
What's left to do:
- For people who use the old power calculation, show the right power as well (but I changed Hidden Power to gen VI+ where it's always 60 base power)
Basically what we do is, after checking that the move isn't MOVE_NONE (aka a moveIndex of 0), check if the move is Hidden Power. If so, calculate its power using Hidden Power's special formula, store it in a variable, convert it to a string, and store the string in the variable used for displaying a move's power. If the move isn't Hidden Power, then the function does the stuff it does prior to being edited. After that, the move's power is printed and the function then goes on to display the accuracy.
Sample Image:
Natu has Poison-type Hidden Power with a base power of 48.
[Pokeemerald] Fully functional debug menu with Flags, Vars, Items, Pokemon and more!
This is my implementation of a debug menu based on Ketsuban's tutorial and some code from Pyredrid, AsparagusEduardo and Ghoulslash.
Features:
Spoiler:
Utility:
Heal player party
Clock: check and set
Fly to all cities: ----------------------------Warp to any map warp: --------------Check saveblock space:
Check weekday: does nothing, left in as a simple spot to add some test stuff for you guys
Change Trainer name, gender and OIT:
Flags:
Added some usefull debug flags like ignore collision, no wild encounters (Inmortal) and no trainers attacking you.
Toggle any flag ingame: -------------Toggle specific usefull flags
Vars:
Read and change any vars ingame:
Give:
Items:
All TMs:
Pokemon in 2 versions:
---Simple: only takes the ID (source code, not ingame) and a level:
---Complex: ID, level, shiny?, nature and ability (including hidden with PE), individual IVs and up to 4 custom moves.
How to:
Add and clone it into your repo:
Code:
git remote add xaman https://github.com/TheXaman/pokeemerald/
git pull xaman tx_debug_system
make clean
make debug
Access ingame:
From now one if you want the menu to show up you have to run your make command with the addition parameter: debug or debug _modern, for example make debug -j8. Those parameters already include DINFO=1.
To access ingame press R + Start.
That it, now enjoy and if you find any bugs or if you write some cool additions you think others could profit from, please let me know in this threat, via pm or over on github!
Credits: If you use this, you have to give credit to all following people!
TheXaman
Ketsuban
Pyredrid
AsparagusEduardo
Ghoulslash
exposneed
This debug menu is awesome and I have been using it since you first posted; there's a little issue if used in tandem with the rhh expansions though, specifically the pokemon_expansion one. The reason is that they axed the special Deoxys handling that is checked by some functions of src/debug.c; I managed to solve it and build the ROM by just deleting ,TRUE in the lines 1597, 1635 and 1683.
This debug menu is awesome and I have been using it since you first posted; there's a little issue if used in tandem with the rhh expansions though, specifically the pokemon_expansion one. The reason is that they axed the special Deoxys handling that is checked by some functions of src/debug.c; I managed to solve it and build the ROM by just deleting ,TRUE in the lines 1597, 1635 and 1683.
Provides control over most aspects of NPC trainers and homogenizes party types. Based off part of Syreldar's hack. Thanks to UltimaSoul for helping me get it to work.
src/data/trainer_parties.h will need all structs changed to TrainerMon and src/data/trainers.h needs to have .TrainerMon instead of .NoItemDefaultMoves et al. Those are both already applied to vanilla, but if you've done substantial edits, keep your versions and then do the find-replace to change structs and .party type.
There is an issue if used with the battle_engine: in the file src/battle_tower.c there is a block(that controls the multi-battle partner feature, I suppose) inside the function FillPartnerParty that still uses the old structs like TrainerMonNoItemCustomMoves, etc. that in your branch have been fused into TrainerMon. Hence the compiler does not accept them, I tried to do something myself but I'm not too sure on how to do that :\
There is an issue if used with the battle_engine: in the file src/battle_tower.c there is a block(that controls the multi-battle partner feature, I suppose) inside the function FillPartnerParty that still uses the old structs like TrainerMonNoItemCustomMoves, etc. that in your branch have been fused into TrainerMon. Hence the compiler does not accept them, I tried to do something myself but I'm not too sure on how to do that :\
[Pokeemerald] Improved scrolling options menu with faster text, HP and EXP bar speeds and a metric unit option!
This is an improved options menu with the ability to scroll for more than the standard amount of options, developed by DizzyEgg.
Features:
Text speed: Slow, Mid, Fast, Fatser (based on the work of ella_trifle)
Unit system: Metric, Imperial
HP bar speed: 0-10(instant)
Exp bar speed: 0-10(instant)
Warning:
This implementations slighty changes SaveBlock2, but I've been extra carefull and as far as I can tell no problems with old savegames should occure.
I hope you enjoy and if you find any bugs, please let me know in this threat, via pm or over on github!
Credits: If you use this, you have to give credit to all following people!
DizzyEgg
Lunos
AsparagusEduardo
ella_trifle
OK, I can't tell you how proud I am to finally have something worth contributing to one of these research/development threads.
But today I bring you a fix to make shedinja a good pokemon.
So those that know shedinja, know it sucks because its base hp stat is stuck at one never increasing.
I have a fix for that. I did mine in cfru, but I imagine it should work for pokefirered and pokeemerald or anything else as well.
for cfru this is done in the file build_pokemon.c
for regular decomps its just the pokemon.c file.
What you need to do is search for all instances of
#ifdef species_Shedinja
there should be 2, within the file.
So reading the function there you can tell that shedinja's hp is limited because, shedinja literally has its own hp calc function.
The fix is to make that work on the ability WonderGuard instead. so what you need to do is replace
#ifdef Species_Shedinja with #ifdef ABILITY_WONDERGUARD
next step
on the line under both #ifdefs you'll see
if (species == SPECIES_SHEDINJA)
we need to replace those as well. we replace it with,
if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
So the code should now look like this,
Code:
#ifdef ABILITY_WONDERGUARD
if (GetMonAbility(mon) == ABILITY_WONDERGUARD)
But you can change it to literally any ability at this point, if you want shedinja to just operate as a normal pokemon I recommend changing it to illuminate.
Illuminate Raises the likelihood of meeting wild Pokémon. I'm sure not many would miss that ability.
Then just use any program to change shedinja's base hp stat.
Well that's it a simple two step change and shedinja is a good pokemon; for sake of balance I recommend keeping their base hp on the low side. For reference the lowest base stat hp in the game is for shuckle at 20.
Thanks to both anon822 and Mklok103, for tips, getting me started on decomp etc.
quick edit, I'm relatively new to decomp so in case these changes are important I want to make sure everything is included.
To make sure the file can find and define the ability I added abilities.h from the include/constants folder to the list of includes at the top of the file.
I also listed the type for ability, at the bottom of the main function that #ifdef Species_Shedinja is in, shown below (I added u8 ability; )
also normally evs are u8 if you're just copying what I have, your evs should not be u16.
Ok I think that's everything.
edit edit:
so looking at the ability table, if you don't want to waste illuminate you could probably change it to work on ability_none, that way shedinja works, and no pokemon is made less viable.
Haven't yet tested it, but no reason it shouldn't work.
There is a bug regarding the battle type effectiveness in doubles.
enemy team, geodude, mudkip
my team: goldeen, bellsprout
if i use goldeen's water gun on geodude it will be green, but if i faint it the next turn water gun will still be green even though it's not very effective on the mudkip.
In that case I need to click it and select the mudkip to update its effectiveness to red.
There are 2 solutions:
1. don't display effectiveness of a move in doubles until a move and a target is selected (don't show any effectiveness on moves that hit multiple targets ofc).
2. try to update the possible target instantly, before even selecting the move.
[Pokeemerald]Changing encounter groups with map scripts
Porymap makes it easy to add new encounter groups to a map. This is a little guide on how to utilize and switch encounter groups with map scripts.
1. Add a new encounter group to a map
I'd recommend doing this in Porymap (as seen in the link above), but basically you add a new encounter table for the map with a new base label in src/data/wild_encounters.json. In my case, I decided to add a new encounter group to Route 111, with Pokémon intended to be encountered in tall grass in the southern section of the map.
2. Add a new var in include/constants/vars.h
This new var will be used to determine which encounter group gets used for the map. I decided to use one of the unused vars.
3. Update GetCurrentMapWildMonHeaderId in src/wild_encounter.c
This function handles which pokémon encounters to load on a map. By default, it doesn't take into consideration if a map has multiple encounter groups and only use the first one defined for a map. In vanilla pokeemerald, only Altering Cave has multiple encounter groups, so it has it own check to load the appropriate encounter group. A similar check has to be added for the map with newly added encounter groups.
Code:
static u16 GetCurrentMapWildMonHeaderId(void)
{
u16 i;
for (i = 0; ; i++)
{
const struct WildPokemonHeader *wildHeader = &gWildMonHeaders[i];
if (wildHeader->mapGroup == 0xFF)
break;
if (gWildMonHeaders[i].mapGroup == gSaveBlock1Ptr->location.mapGroup &&
gWildMonHeaders[i].mapNum == gSaveBlock1Ptr->location.mapNum)
{
[COLOR="Green"]+ if (gSaveBlock1Ptr->location.mapGroup == MAP_GROUP(ROUTE111) &&
+ gSaveBlock1Ptr->location.mapNum == MAP_NUM(ROUTE111))
+ i += VarGet(VAR_ROUTE111_WILD_SET);
+
[/COLOR] if (gSaveBlock1Ptr->location.mapGroup == MAP_GROUP(ALTERING_CAVE) &&
gSaveBlock1Ptr->location.mapNum == MAP_NUM(ALTERING_CAVE))
{
u16 alteringCaveId = VarGet(VAR_ALTERING_CAVE_WILD_SET);
if (alteringCaveId > 8)
alteringCaveId = 0;
i += alteringCaveId;
}
return i;
}
}
return -1;
}
4. Add map scripts that changes the encounter group var
You can now switch encounter groups by using the setvar script command in a map script and setting the encounter group var to the corresponding value of the desired encounter group.
Code:
setvar VAR_EXAMPLE_NAME, [I]n[/I]
0 is the value for the first encounter group, 1 for the second group etc.
A simple option would be to add new map trigger scripts to act as switches for the var.
Code:
Map_EventScript_WildSet1Trigger::
setvar VAR_EXAMPLE_NAME, 0
end
Map_EventScript_WildSet2Trigger::
setvar VAR_EXAMPLE_NAME, 1
end
But you can let your imagination free on how to actually switch the encounter group. For example, this can be used as a way of to increase levels of Pokémon in the area after battling a trainer or legendary Pokémon.
In my case, I settled on taking advantage of the pre-existing weather scripts on Route 111. Basically, the grass encounters get set when clear weather appears, and the desert encounters get set when a sandstorm appears.
That's pretty much it!
PS. This is the first time I've tried write a guide like this, so I'm sorry if it is unclear or otherwise rough around the edges. 😅
If you open "src\new_game.c" you'll come across this:
These are the attributes you can change from the "Options" window in the start menu - text speed, the menu frame, battle style (set/shift) etc. Having the text speed automatically set to fast is something I'd recommend to everyone, since going straight to the options menu and changing it is one of the first things a lot of people do in-game!
