Gen 3 had the best protagonist ever, Leaf, and the only male protagonist worth talking about, Wes from Colosseum, so I guess 3rd gen.
A few other gens had one great protagonist each: Gen 4 had Dawn, Gen 5 had Rosa, and Gen 6 had Serena, but otherwise, the protagonists from those games were forgettable at best.