[Custom Feature Question] Custom Function Codes Help

[TheShinySylveon]

Can someone help me with making a custom function code

Effect 159 - Blue Moon

Spoiler:

It's similar to the terrain moves like electric terrain excepts it only boosts move of the magic type (A custom type i'm adding to the game) and reverses atk and sp.atk stats
ex:
If atk is 15
and sp.atk is 20
it'll make
atk 20
and sp.atk 15

Effect 160 - Alchemy

Spoiler:

It'll make certain held items heal or damage the user and any allies
ex:
Recovery held items such as
Leftovers, Any Berry, Potion, etc will heal the target

Damaging items such as
Sticky Barb, Black Sludge, Flame Orb, etc will damage the target

Black Sludge will heal poison-types and have no effect on steel-types
flame orb will heal fire-types

Misc Held items such as
Focus Sash, Kings Rock, Griseous Orb, etc will have no effect
basically any key items for other forms

if this move is used and it does affect the target either healing or damaging the held item can't be used for the rest of the battle but will return back after the battle

 

[Lucidious89]

For the first one, you can probably accomplish this by simply copying an existing terrain and just renumbering/renaming everything. Then look at the code for Power Trick (does the same stat change function you're talking about, but for Atk/Def), and use that as a guide for adding in this additional effect.

For the second one, it sounds pretty easy, just tedious since you're probably going to have to manually write out every single item that this effect works with, since there isn't any classifications for "healing item", "damaging item", etc. that I know of. So you're probably going to have to write out a whole list for each item "type" as an array, and then write out a simple if/then statement for what happens if a Pokemon is holding each item type. Something like:

if poketohealhere.hasWorkingItem?(HEALINGITEMS); poketohealhere.pbRecoverHP(amounthealed,true); end

and then the same thing for the other effects, just with damage instead.

 

[Turn20Negate]

Hey there :)
I'll try to help you out with the Blue Moon Effect.

In PBEffects add below "WonderRoom = 12"

Spoiler:

BlueMoon = YY

Change "YY" to the highest number +1

In PokeBattle_ActiveSideField add below "@effects[PBEffects::WonderRoom] = 0"

Spoiler:

@effects[PBEffects::BlueMoon]      = 0

In PokeBattle_Battle add this above "# Grassy Terrain"

Spoiler:

# Blue Moon
    if @field.effects[PBEffects::BlueMoon]>0
      @field.effects[PBEffects::BlueMoon]-=1
      if @field.effects[PBEffects::BlueMoon]==0
        pbDisplay(_INTL("The blue moonlight faded."))
        PBDebug.log("[End of effect] Blue Moon ended")
      end
    end

In PokeBattle_Move find "if @battle.field.effects[PBEffects::GrassyTerrain]>0 &&" and paste above it:

Spoiler:

if @battle.field.effects[PBEffects::BlueMoon]>0 &&
       isConst?(type,PBTypes,:MAGIC)
      damagemult=(damagemult*1.5).round
    end

Now to switch Attack and Special Attack stats (only for moves I guess?)

Spoiler:

Replace this:

##### Calculate attacker's attack stat #####
    atk=attacker.attack
    atkstage=attacker.stages[PBStats::ATTACK]+6
    if @function==0x121 # Foul Play
      atk=opponent.attack
      atkstage=opponent.stages[PBStats::ATTACK]+6
    end
    if type>=0 && pbIsSpecial?(type)
      atk=attacker.spatk
      atkstage=attacker.stages[PBStats::SPATK]+6
      if @function==0x121 # Foul Play
        atk=opponent.spatk
        atkstage=opponent.stages[PBStats::SPATK]+6
      end
    end

With this:

##### Calculate attacker's attack stat #####
    if @battle.field.effects[PBEffects::BlueMoon]>0
      atk=attacker.spatk
      atkstage=attacker.stages[PBStats::SPATK]+6
      if @function==0x121 # Foul Play
        atk=opponent.spatk
        atkstage=opponent.stages[PBStats::SPATK]+6
      end
      if type>=0 && pbIsSpecial?(type)
        atk=attacker.attack
        atkstage=attacker.stages[PBStats::ATTACK]+6
        if @function==0x121 # Foul Play
          atk=opponent.attack
          atkstage=opponent.stages[PBStats::ATTACK]+6
        end
      end
    else
      atk=attacker.attack
      atkstage=attacker.stages[PBStats::ATTACK]+6
        if @function==0x121 # Foul Play
        atk=opponent.attack
        atkstage=opponent.stages[PBStats::ATTACK]+6
      end
      if type>=0 && pbIsSpecial?(type)
        atk=attacker.spatk
        atkstage=attacker.stages[PBStats::SPATK]+6
        if @function==0x121 # Foul Play
          atk=opponent.spatk
          atkstage=opponent.stages[PBStats::SPATK]+6
        end
      end
    end

Right now there is no way to summon the moon, so you'll have to add some yourself(moves, abilities, weather...).
If you need any more help with this be sure to ask. :)

 

[TheShinySylveon]

Hey there :)
I'll try to help you out with the Blue Moon Effect.

In PBEffects add below "WonderRoom = 12"

Spoiler:

BlueMoon = YY

Change "YY" to the highest number +1

In PokeBattle_ActiveSideField add below "@effects[PBEffects::WonderRoom] = 0"

Spoiler:

@effects[PBEffects::BlueMoon]      = 0

In PokeBattle_Battle add this above "# Grassy Terrain"

Spoiler:

# Blue Moon
    if @field.effects[PBEffects::BlueMoon]>0
      @field.effects[PBEffects::BlueMoon]-=1
      if @field.effects[PBEffects::BlueMoon]==0
        pbDisplay(_INTL("The blue moonlight faded."))
        PBDebug.log("[End of effect] Blue Moon ended")
      end
    end

In PokeBattle_Move find "if @battle.field.effects[PBEffects::GrassyTerrain]>0 &&" and paste above it:

Spoiler:

if @battle.field.effects[PBEffects::BlueMoon]>0 &&
       isConst?(type,PBTypes,:MAGIC)
      damagemult=(damagemult*1.5).round
    end

Now to switch Attack and Special Attack stats (only for moves I guess?)

Spoiler:

Replace this:

##### Calculate attacker's attack stat #####
    atk=attacker.attack
    atkstage=attacker.stages[PBStats::ATTACK]+6
    if @function==0x121 # Foul Play
      atk=opponent.attack
      atkstage=opponent.stages[PBStats::ATTACK]+6
    end
    if type>=0 && pbIsSpecial?(type)
      atk=attacker.spatk
      atkstage=attacker.stages[PBStats::SPATK]+6
      if @function==0x121 # Foul Play
        atk=opponent.spatk
        atkstage=opponent.stages[PBStats::SPATK]+6
      end
    end

With this:

##### Calculate attacker's attack stat #####
    if @battle.field.effects[PBEffects::BlueMoon]>0
      atk=attacker.spatk
      atkstage=attacker.stages[PBStats::SPATK]+6
      if @function==0x121 # Foul Play
        atk=opponent.spatk
        atkstage=opponent.stages[PBStats::SPATK]+6
      end
      if type>=0 && pbIsSpecial?(type)
        atk=attacker.attack
        atkstage=attacker.stages[PBStats::ATTACK]+6
        if @function==0x121 # Foul Play
          atk=opponent.attack
          atkstage=opponent.stages[PBStats::ATTACK]+6
        end
      end
    else
      atk=attacker.attack
      atkstage=attacker.stages[PBStats::ATTACK]+6
        if @function==0x121 # Foul Play
        atk=opponent.attack
        atkstage=opponent.stages[PBStats::ATTACK]+6
      end
      if type>=0 && pbIsSpecial?(type)
        atk=attacker.spatk
        atkstage=attacker.stages[PBStats::SPATK]+6
        if @function==0x121 # Foul Play
          atk=opponent.spatk
          atkstage=opponent.stages[PBStats::SPATK]+6
        end
      end
    end

Right now there is no way to summon the moon, so you'll have to add some yourself(moves, abilities, weather...).
If you need any more help with this be sure to ask. :)

Thank you it worked as far as i know, do you think you can figure out the alchemy move next?

 

[Golisopod User]

Effect 160 - Alchemy

Spoiler:

It'll make certain held items heal or damage the user and any allies
ex:
Recovery held items such as
Leftovers, Any Berry, Potion, etc will heal the target

Damaging items such as
Sticky Barb, Black Sludge, Flame Orb, etc will damage the target

Black Sludge will heal poison-types and have no effect on steel-types
flame orb will heal fire-types

Misc Held items such as
Focus Sash, Kings Rock, Griseous Orb, etc will have no effect
basically any key items for other forms

if this move is used and it does affect the target either healing or damaging the held item can't be used for the rest of the battle but will return back after the battle

This move already exists somewhat. Its called Fling. So what you can do is look at how Fling works (it has different effects based on the item the user is holding, just like your move does) and try to implement it that way.

 

[Turn20Negate]

Here you go!
I must add that I was pretty lazy and hope it doesn't come back to bite me. I tried to get around the part where you said the item loses its effect for the rest of the battle by using the effect of the move "Corosive Gas".So long story short this move won't work if you don't have Generation 8 in your game(more specifically the move "Corrosive Gas"). Additionally the Pokemon's item functions again after switching out of battle.
If you want to know how to implement Generation 8 moves check out this thread(https://www.pokecommunity.com/showthread.php?t=422817) otherwise ask again and I'll fix it for you.
Just thought it would be easier this way. :)

Quick reminder: You need to change the "YYY" to the function code of the move in your moves.txt file. Add any items you want to heal the Pokemon with to the first array and any you want to damage them with to the second.

Spoiler:

###############################################################################
# (Alchemy)
################################################################################
class PokeBattle_Move_YYY < PokeBattle_Move
  
  def healingitems
    [:POTION[COLOR="Red"],[/COLOR]
     [COLOR="Red"]:SUPERPOTION[/COLOR]
    ]
  end
  
  def damagingitems
    [:STICKYBARB
    ]
  end
  
  def pbEffect(attacker,opponent,hitnum=0,alltargets=nil,showanimation=true)
    failed=true
    for i in [attacker,attacker.pbPartner]
      next if !i || i.isFainted?
      for j in healingitems
        if i.hasWorkingItem(j)
          failed=false
          break
        end
      end
      for j in damagingitems
        if i.hasWorkingItem(j) || i.hasWorkingItem(:BLACKSLUDGE) || i.hasWorkingItem(:FLAMEORB)
          failed=false
          break
        end
      end
    end
    if failed==true
      @battle.pbDisplay(_INTL("But it failed!"))
      return -1
    end
    pbShowAnimation(@id,attacker,nil,hitnum,alltargets,showanimation)
    for i in [attacker,attacker.pbPartner]
      next if !i || i.isFainted?
      for j in healingitems
        if i.hasWorkingItem(j)
          itemhealed=true
        end
      end
      for j in damagingitems
        if i.hasWorkingItem(j)
          itemdamaged=true
        end
      end
      if i.hasWorkingItem(:BLACKSLUDGE) && i.type!=getConst(PBTypes,:POISON)
        if i.type!=getConst(PBTypes,:STEEL)
          itemdamaged=true
        end
      elsif i.hasWorkingItem(:BLACKSLUDGE) && i.type==getConst(PBTypes,:POISON)
        itemhealed=true
      end
      if i.hasWorkingItem(:FLAMEORB)
        if i.type==getConst(PBTypes,:FIRE)
          itemhealed=true
        else
          itemdamaged=true
        end
      end
      if itemdamaged==true
        i.pbReduceHP((i.totalhp/2).round)
        @battle.pbDisplay(_INTL("{1} was damaged by its {2}.",i.pbThis,PBItems.getName(i.item)))
        i.effects[PBEffects::CorrosiveGas]=true
      elsif itemhealed==true
        i.pbRecoverHP((i.totalhp/2).round,true)
        @battle.pbDisplay(_INTL("{1}'s HP was restored by its {2}.",i.pbThis,PBItems.getName(i.item)))
        i.effects[PBEffects::CorrosiveGas]=true
      end
    end
    return 0
  end
end