Crystal is my favorite, mainly because it added to an already great region. The choice between a boy or a girl character was amazing to me, and the Battle Tower is a neat challenge.
Silver is my second favorite, but that's probably a biased opinion since it was my first second gen game. Gold is awesome too, but if you're choosing between Gold and Silver, you might as well just pick based on version exclusive Pokemon.