[Pokeemerald] PokedexPlus in HGSS style UPDATED

[Dvsein]

Excellent version of the pokedex, I liked it a lot so I inserted it in my repository, I tried it in the game and everything is fine, now only the dexnav remains

<3 thanks for this and I will not forget to give credits!

 

[TheXaman]

Just pushed a huge update, I hope you enjoy!
Now with ALL follow up evolutions, improved layout and information display style!

If you use my dex in your project and its public let me know, I'll add a link!

 

[tahayarkhan]

please give Ips patch download link I'm not familiar with deep programing

 

[Jaizu]

please give Ips patch download link I'm not familiar with deep programing

That's not how decomp works buddy, a patch wouldn't allow your rom to get edited with binary tools, luckily for you!

 

[NobodySociety]

Hey xaman started a new project and tried pulling this into it, got a couple of errors, that seem to stem from gEvolutionTable.

I was guessing that for some reason it can't get the function, so I tried adding #include "data/pokemon/evolution.h" to the top, but it causes other issues.

 

[Lunos]

Hey xaman started a new project and tried pulling this into it, got a couple of errors, that seem to stem from gEvolutionTable.

I was guessing that for some reason it can't get the function, so I tried adding #include "data/pokemon/evolution.h" to the top, but it causes other issues.

To solve your problem you just have to define gEvolutionTable as an extern function in the file where you intend to make use of it.
In other words, throwing in a extern struct Evolution gEvolutionTable[][EVOS_PER_MON]; somewhere near the top at src/pokedex.c should fix it.

Ex:

Also yeah, remove that #include "data/pokemon/evolution.h". That's incorrect.

 

[NobodySociety]

To solve your problem you just have to define gEvolutionTable as an extern function in the file where you intend to make use of it.
In other words, throwing in a extern struct Evolution gEvolutionTable[][EVOS_PER_MON]; somewhere near the top at src/pokedex.c should fix it.

Ex:

Also yeah, remove that #include "data/pokemon/evolution.h". That's incorrect.

Ah, that did it. Thanks a lot. I had seen extern functions all over the decomp, but I wasn't sure what they were. Still new to C.

 

[trikop]

This looks awesome! definitively going to be using this!

 

[shadow300]

First, thank you. while i have some problem when compiling, when its success it works nice.
but i wanna ask about something (sorry for bad english).

https://im.ge/i/DsHEr
in this picture, the text kinda overflowing the selector.
so i wanna ask, how can i change the size of the selector? is it from function in pokedex.c file or image?
thanks in advance.

While im at it, i wanna share an issue and fix while compiling this project.

Spoiler:

if you get error when compile about this var undefined in pokedex.c

TEXT_COLOR_LIGHT_GREY
TEXT_COLOR_DARK_GREY

change that to this

TEXT_COLOR_LIGHT_GRAY
TEXT_COLOR_DARK_GRAY

and if you experience cant go back from search result page to pokedex. try this:

Spoiler:

1. Go to this function in pokedex.c
   

   static void Task_HandleSearchResultsInput(u8 taskId)

2. Go to this section
   

   else if (JOY_NEW(B_BUTTON))

   and add this
   

   gTasks[taskId].func = Task_ReturnToPokedexFromSearchResults;

   so it'll look like this
   

   else if (JOY_NEW(B_BUTTON))
           {
               BeginNormalPaletteFade(PALETTES_ALL, 0, 0, 0x10, RGB_BLACK);
               TryDestroyStatBars(); //HGSS_Ui
               gTasks[taskId].func = Task_ReturnToPokedexFromSearchResults;
               PlaySE(SE_PC_OFF);
           }

i hope this can be useful

 

[trikop]

This looks really good! But I spotted something a little weird? I don't know why, but there seems to be something weird on the EVO screen
https://imgur.com/1MbsDay

 

[TheXaman]

First, thank you. while i have some problem when compiling, when its success it works nice.
but i wanna ask about something (sorry for bad english).

https://im.ge/i/DsHEr
in this picture, the text kinda overflowing the selector.
so i wanna ask, how can i change the size of the selector? is it from function in pokedex.c file or image?
thanks in advance.

While im at it, i wanna share an issue and fix while compiling this project.

Spoiler:

if you get error when compile about this var undefined in pokedex.c

TEXT_COLOR_LIGHT_GREY
TEXT_COLOR_DARK_GREY

change that to this

TEXT_COLOR_LIGHT_GRAY
TEXT_COLOR_DARK_GRAY

and if you experience cant go back from search result page to pokedex. try this:

Spoiler:

1. Go to this function in pokedex.c
   

   static void Task_HandleSearchResultsInput(u8 taskId)

2. Go to this section
   

   else if (JOY_NEW(B_BUTTON))

   and add this
   

   gTasks[taskId].func = Task_ReturnToPokedexFromSearchResults;

   so it'll look like this
   

   else if (JOY_NEW(B_BUTTON))
           {
               BeginNormalPaletteFade(PALETTES_ALL, 0, 0, 0x10, RGB_BLACK);
               TryDestroyStatBars(); //HGSS_Ui
               gTasks[taskId].func = Task_ReturnToPokedexFromSearchResults;
               PlaySE(SE_PC_OFF);
           }

i hope this can be useful

Thank you for telling me, fixed it!

 

[TheXaman]

This looks really good! But I spotted something a little weird? I don't know why, but there seems to be something weird on the EVO screen
https://imgur.com/1MbsDay

Thank you, should be fixed now!

 

[vashy_777]

So I followed your tutorial to a T and i also have the the newer battle engine by RHH. This is the error I'm getting

make: *** No rule to make target `src/tx_difficulty_challenges.h', needed by `build/emerald/src/pokedex.o'.  Stop.

 

[TheXaman]

So I followed your tutorial to a T and i also have the the newer battle engine by RHH. This is the error I'm getting

make: *** No rule to make target `src/tx_difficulty_challenges.h', needed by `build/emerald/src/pokedex.o'.  Stop.

pushed a fix!

 

[vashy_777]

pushed a fix!

Thank you, it works fine now.

 

[TheXaman]

Reworked the stats page to use "windows", reduced load times and reduced the flickering a lot!

 

[Velius Gefion]

New to decomp hacking and tried using this but this error pop up when I tried compiling it and I have no idea what to do. Been using RHH as the base decomp.

https://imgur.com/BzET9Pt

 

[thornpi]

Had an issue where gFormSpeciesIdTable is undefined. How can I fix it?

 

[TheXaman]

New to decomp hacking and tried using this but this error pop up when I tried compiling it and I have no idea what to do. Been using RHH as the base decomp.

https://imgur.com/BzET9Pt

Had an issue where gFormSpeciesIdTable is undefined. How can I fix it?

I forgot to add an inlcude, Lunos provided a fix and it should work now I hope, just pull the newest change.

 

[Ammy175]

Hi there. I'm also new to decomp, and I'm trying to implement this using the RHH as well.

I followed the instructions in the first post to the best of my ability, and got some merge conflicts. A friend helped me out through those, but now when I go to make the game, I get this and no game:

Any idea what to do?

Edit: My friend figured it out and it's working for us now. She said "i had to replace all instances of the sSpriteXXXXXX stuff with gSpriteXXXXXXX in the pokedex thing"; the files with these changes can be found here if anyone else is having the same problem: https://www.mediafire.com/file/eqowlmvn1uw9zi4/PokedexPlus_Fixes.zip/file