Help Thread: Script Help Thread

[DrFuji]

Thank you. I also seemed to have misplaced the offset and forgot #dynamic entirely. Unless that part gets replaced or deleted.

*EDIT*
The code healed when I did not have money. I tried fixing it, but now the person just continues the same beginning phrase.

Spoiler:

#dynamic 0x800000

#org @start
faceplayer
lockall
preparemsg 0x8801411 '"Your POKéMON look tired[.]\nYou sh..."
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x4 goto 0x8801447
msgbox @notenough 0x6
waitmsg
waitkeypress
fadescreen 0x1
closeonkeypress
special 0x0
fadescreen 0x0
msgbox 0x8801447 MSG_NORMAL '"There. All better now!"
paymoney 0x50 0x0
releaseall
end

#org 0x801411
= Your POKéMON look tired[.]\nYou should give them a rest.

#org 0x801447
= There. All better now!

#org @notenough
= Looks like you do not have enough.

Can you tell me what I am doing wrong?

Here's a working version of your script. I've highlighted some changes and explained why they've been altered.

Spoiler:

#dynamic 0x800000

#org @start
msgbox @talk 0x2 // You had a lot of extra frivolous commands so I've shortened this whole part
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough // In this situation, 0x0 = 'Lower than'. In your script you used 0x4 which means 'Greater than or Equal to'. This mixed around what their actual financial situation was though: Players with enough money wouldn't be able to heal while players who were broke could
fadescreen 0x1
special 0x0
fadescreen 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough // In your script, @NotEnough was pointing to a text string, when it should have pointing to a separate part of the script. I simply added a msgbox command to the text you wanted to display
msgbox @MoreMoney 0x2
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough.

You really need to look out for when you're mistaking a text pointer for a regular branching script pointer :P

 

[Neko Mizu]

Here's a working version of your script. I've highlighted some changes and explained why they've been altered.

Spoiler:

#dynamic 0x800000

#org @start
msgbox @talk 0x2 // You had a lot of extra frivolous commands so I've shortened this whole part
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough // In this situation, 0x0 = 'Lower than'. In your script you used 0x4 which means 'Greater than or Equal to'. This mixed around what their actual financial situation was though: Players with enough money wouldn't be able to heal while players who were broke could
fadescreen 0x1
special 0x0
fadescreen 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough // In your script, @NotEnough was pointing to a text string, when it should have pointing to a separate part of the script. I simply added a msgbox command to the text you wanted to display
msgbox @MoreMoney 0x2
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough.

You really need to look out for when you're mistaking a text pointer for a regular branching script pointer :P

The screen turns black and does not return.

 

[DrFuji]

The screen turns black and does not return.

It works fine for me. Did you remove my annotations? Are you using XSE 1.1.1?

 

[Neko Mizu]

It works fine for me. Did you remove my annotations? Are you using XSE 1.1.1?

Yeah none of the annotations are in the script. I have no idea what version I have. Should I update?

 

[DrFuji]

Yeah none of the annotations are in the script. I have no idea what version I have. Should I update?

You can check which version you have by going to 'Help > About' and then reading the pop-up. If you aren't using v1.1.1 here's a download link.

 

[Neko Mizu]

You can check which version you have by going to 'Help > About' and then reading the pop-up. If you aren't using v1.1.1 here's a download link.

Yes I am using v1.1.1

This is what I have gotten:

Spoiler:

#dynamic 0x8018C5

#org @start
msgbox @talk 0x2
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough
fadescreen 0x1
special 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough
= Looks like you do not have enough\nPokeyen. Sorry for the\linconvience.
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough.

 

[DrFuji]

Yes I am using v1.1.1

This is what I have gotten:

Spoiler:

#dynamic 0x8018C5

#org @start
msgbox @talk 0x2
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough
fadescreen 0x1
special 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough
= Looks like you do not have enough\nPokeyen. Sorry for the\linconvience.
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough.

You removed the fadescreen 0x0 command and added text in the middle of the script rather than giving it to a text pointer :P

Here's your script again:

Spoiler:

#dynamic 0x800000 // You can just leave the dynamic command at 0x800000 as it will find freespace from the point in the ROM onwards

#org @start
msgbox @talk 0x2
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough
fadescreen 0x1
special 0x0
fadescreen 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough
msgbox @MoreMoney 0x2 // Do not put pure text here. Use a msgbox if you want the script to say something like I have done.
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough\nPokeyen. Sorry for the\linconvience.

 

[Neko Mizu]

You removed the fadescreen 0x0 command and added text in the middle of the script rather than giving it to a text pointer :P

Here's your script again:

Spoiler:

#dynamic 0x800000 // You can just leave the dynamic command at 0x800000 as it will find freespace from the point in the ROM onwards

#org @start
msgbox @talk 0x2
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough
fadescreen 0x1
special 0x0
fadescreen 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough
msgbox @MoreMoney 0x2 // Do not put pure text here. Use a msgbox if you want the script to say something like I have done.
release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough\nPokeyen. Sorry for the\linconvience.

Spoiler:

#dynamic 0x801A64

#org @start
msgbox @talk 0x2
checkmoney 0x50 0x0
compare 0x800D 0x1
if 0x0 goto @NotEnough
fadescreen 0x1
special 0x0
fadescreen 0x0
msgbox @talk2 0x2
paymoney 0x50 0x0
release
end

#org @NotEnough
msgbox @MoreMoney 0x2

release
end

#org @talk
= Your POKéMON look tired[.]\nYou should give them a rest.

#org @talk2
= There. All better now!

#org @MoreMoney
= Looks like you do not have enough\nPokeyen. Sorry for the\linconvience.

Would this be correct? If so, it is still not working.

 

[DrFuji]

Would this be correct? If so, it is still not working.

That scripts works for me, if you're still having problems then I'm not sure what else to do other than to make sure you're saving it in Advance Map and reopen your ROM in VBA whenever you test the script.

 

[Neko Mizu]

That scripts works for me, if you're still having problems then I'm not sure what else to do other than to make sure you're saving it in Advance Map and reopen your ROM in VBA whenever you test the script.

Is there a person ID or anything else I need to change?

 

[DrFuji]

Is there a person ID or anything else I need to change?

No, there is nothing overworld/ script-related that I can think of which would stop it from working. Like I said, its working for me so I have no other answers.

 

[Neko Mizu]

No, there is nothing overworld/ script-related that I can think of which would stop it from working. Like I said, its working for me so I have no other answers.

I have figured out the problem. For some reason when it was put into AM, the script changes. So I just redid it in the AM part and the game does come back as usual. I just need to put the words in for when you do not have enough. Thank you for all the help. Now I just need to learn the part in Viridian City where a guy blocks the garden and stuff.

 

[awipe1]

I believe that you can't have a trainer to battle you more than once. At least, that's what I observed from when i was still hacking SkyLine (and the reason why the player is forced to talk to trainers if they want to battle them)...

I dont want the trainer to battle me more than once, I want him to battle me once and his pokemon will depend on where the player is in the game.

 

[ShyRayq]

I dont want the trainer to battle me more than once, I want him to battle me once and his pokemon will depend on where the player is in the game.

This would be easy with some checkflags and various setflags throughout the game. Alternatively, use variables as it would be easier to check them and you would save space.

 

[Neko Mizu]

Okay I have made the script for the guy to block the garden, but it seems when you try talking to him before the third badge (He just leaves after that), the game freezes.

Spoiler:

#dynamic 0x801E29

#org @start
lock
faceplayer
checkflag 0x822
if 0x1 goto @done
msgbox @1 0x6
setflag 0x822
release
end

#org @done
msgbox @2 0x6
clearflag 0x822
release
end

#org @2
= yes

#org @1
= no

Can someone tell me what is wrong with the script?

 

[Mana1]

Your script is kind of contradictory. For instance, you don't need a 'set flag' in it as that flag is set when you get the badge. You also don't need a clearflag at all.

As to why it's freezing, I can't see anything obvious - half asleep mind XD.

 

[Neko Mizu]

Your script is kind of contradictory. For instance, you don't need a 'set flag' in it as that flag is set when you get the badge. You also don't need a clearflag at all.

As to why it's freezing, I can't see anything obvious - half asleep mind XD.

That actually worked. Thank you.

 

[awipe1]

This would be easy with some checkflags and various setflags throughout the game. Alternatively, use variables as it would be easier to check them and you would save space.

But I know JPANs hack engine made it possible so you can have what I wanted happen but the seeing the player part only happens once.

 

[ShyRayq]

But I know JPANs hack engine made it possible so you can have what I wanted happen but the seeing the player part only happens once.

Wait. If I understand correctly, you want to have trainer standing in a map. First time you walk past them, they walk up to you and battle. Then next time, they don't walk up to you, but you can battle them. Correct me if I'm wrong.

I believe you can still use flags. So, have the trainer walk up and battle. Say you use trainer no. 0x003. The corresponding trainerflag is 0x500 + Trainer no. (If I remember correctly) , in this case 0x503. So checkflag 0x503 before the trainerbattle, and branch to another battle if already battled. I think that would work. But that's assuming I got your scenario correct.

 

[awipe1]

Wait. If I understand correctly, you want to have trainer standing in a map. First time you walk past them, they walk up to you and battle. Then next time, they don't walk up to you, but you can battle them. Correct me if I'm wrong.

I believe you can still use flags. So, have the trainer walk up and battle. Say you use trainer no. 0x003. The corresponding trainerflag is 0x500 + Trainer no. (If I remember correctly) , in this case 0x503. So checkflag 0x503 before the trainerbattle, and branch to another battle if already battled. I think that would work. But that's assuming I got your scenario correct.

Close I guess I will explain it in more detail.

EDIT: Also I know I can use flags for this but I was almost certain I could just use the function that JPAN added in his fire red hack applier to make it so I didn't have to use flags.

When you first walk past a trainer he will walk up to you like normal, however what battle happens depends on what badge you have (Those are the variables I have set). If you have one badge then it will play the first battle, if you have two badges it will play the second battle and if you have three badges it will play the third battle.

Once you battle the trainer and win, great you will never battle that trainer again. You can walk up to him and talk to him and he will say a little "Oh you beat me" type of deal (I just made that talking 3 in my script). However if you lose to him, when you walk by he will want to battle you again.

It's the exact same as a normal trainer in the game but this time it will change the difficulty depending on your progress in the game.