My all-time favorite Pokemon city is kind of an odd choice, as it's not from the main series: Gateon Port. It's just extremely relaxing and I never feel that I've explored all of it.
Other faves: The Under, Goldenrod, Lumiose, Fuchsia, Four Island, Saffron, Veilstone, Eterna, Slateport, Olivine...