Code: Ability Resource Thread

[Chaotix]

FB 20 E3 03 02 SS SS SS 08

have you changed the FB to FA here?

The code for Fire Red has it as FA to start,

That segment of code as it is in my ROM:

FA 20 C0 03 02 90 50 77 08

 

[Trainer 781]

The code for Fire Red has it as FA to start,

That segment of code as it is in my ROM:

FA 20 C0 03 02 90 50 77 08

Oops, my bad. The issue must be setword command not being set up properly if you are getting the animation to play properly. Try to redo the steps from scratch.

 

[Chaotix]

Oops, my bad. The issue must be setword command not being set up properly if you are getting the animation to play properly. Try to redo the steps from scratch.

Started from back-up before adding the one new ability, battle string loader, and setword; after re-implementing all of them it was the same result.

The changes made so far are: Doesn't's 1.6 PSS, repointed attack everything and added 1 new attack, Repointed BS command table, added callasm to F8, First Side Routine Rewrite. Could any of that cause a problem?

Either way gonna try straight from a clean FR now and add only the ability, repoint the BSC table and add F8 Callasm, FA Setword, and Battle String Loader.

Edit: From clean FR start after KOing a pokemon the animation for attack up plays then the message displayed is the Rival's "WHAT? Unbelievable! I Picked the wrong pokemon!" RAM offset issue for one of the things?

 

[Trainer 781]

Started from back-up before adding the one new ability, battle string loader, and setword; after re-implementing all of them it was the same result.

The changes made so far are: Doesn't's 1.6 PSS, repointed attack everything and added 1 new attack, Repointed BS command table, added callasm to F8, First Side Routine Rewrite. Could any of that cause a problem?

Either way gonna try straight from a clean FR now and add only the ability, repoint the BSC table and add F8 Callasm, FA Setword, and Battle String Loader.

Edit: From clean FR start after KOing a pokemon the animation for attack up plays then the message displayed is the Rival's "WHAT? Unbelievable! I Picked the wrong pokemon!" RAM offset issue for one of the things?

Check the contents of 0x203C020 in the VBA memory viewer at the time of message display.

 

[Chaotix]

Check the contents of 0x203C020 in the VBA memory viewer at the time of message display.

All 0s anywhere near it. That section isn't having anything stored there at all while doing anything in the game.

Instead it seems to be loading from 0x202298C. Can advance frame by frame until it loads the Rival message then manually replace the contents with the bytes for the string and it prints "WO's Moxie Raised its attack!"

I have no idea why it isn't using 0x203C020..

Edit: while viewing the memory in VBA at 0x2023D74 it seems to have a pointer to what is currently happening in battle, when it lands on the FA in the Moxie script it jumps to the next byte after SS SS SS 08. Is it skipping the 20 C0 03 02 then?

 

[Trainer 781]

All 0s anywhere near it. That section isn't having anything stored there at all while doing anything in the game.

Instead it seems to be loading from 0x202298C. Can advance frame by frame until it loads the Rival message then manually replace the contents with the bytes for the string and it prints "WO's Moxie Raised its attack!"

I have no idea why it isn't using 0x203C020..

Edit: while viewing the memory in VBA at 0x2023D74 it seems to have a pointer to what is currently happening in battle, when it lands on the FA in the Moxie script it jumps to the next byte after SS SS SS 08. Is it skipping the 20 C0 03 02 then?

If set word is not working then you can try:
2E 20 C0 03 02 SS
2E 21 C0 03 02 SS
2E 22 C0 03 02 SS
2E 23 C0 03 02 08

instead of
FA 20 C0 03 02 SS SS 08

 

[Chaotix]

If set word is not working then you can try:
2E 20 C0 03 02 SS
2E 21 C0 03 02 SS
2E 22 C0 03 02 SS
2E 23 C0 03 02 08

instead of
FA 20 C0 03 02 SS SS 08

Yup, that worked just fine. Still, I wish it would work the way it's supposed to but I can't figure out what could have gone wrong with the Setword command.
I used the compiled asm you posted on page 3 when someone else was having trouble with it; couldn't find it posted anywhere else other than there.

Was there anything else that needed to be changed other than inserting the compiled asm in free space and adding a pointer to it in the battle script commands table?

 

[Trainer 781]

Yup, that worked just fine. Still, I wish it would work the way it's supposed to but I can't figure out what could have gone wrong with the Setword command.
I used the compiled asm you posted on page 3 when someone else was having trouble with it; couldn't find it posted anywhere else other than there.

Was there anything else that needed to be changed other than inserting the compiled asm in free space and adding a pointer to it in the battle script commands table?

I don't think so. I think the hex dump I uploaded might not be correct. You can try ripping setword from MrDS' rombase.

 

[Chaotix]

I don't think so. I think the hex dump I uploaded might not be correct. You can try ripping setword from MrDS' rombase.

The one in MrDS is literally the exact same as what you posted, but I tried it anyway and it worked... I don't even... Thanks for all the help KDS, hope it wasn't too much of a bother. Gonna do it from scratch one more time to be sure but it will probably work.

 

[Skeli]

I rewrote Mr. DS's Multiscale and Fur Coat code, to incorporate Shadow Shield and Fluffy as well. Thanks to KDS for helping me out with this. Replace the bolded code with the proper ability IDs.
Fire Red

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global multiscaleandfurcoat
 
Main:
	ldr r2, [sp, #0x28]
	ldrb r0, [r2]
	cmp r0, #0x3F
	bne Multiscale
	ldr r0, .Return
	bx r0
Multiscale:
	cmp r0, #0x[B]MULTISCALE[/B]
	beq CheckHP
ShadowShield:
	cmp r0, #0x[B]SHADOWSHIELD[/B]
	bne FurCoat
CheckHP:
	ldr r1, [sp, #0x4]
	ldrh r0, [r1, #0x28]
	ldrh r1, [r1, #0x2C]
	cmp r1, r0
	bne Return
HalveDamage:
	lsr r7, r7, #0x1
	mov r0, r8
	lsr r0, r0, #0x1
	mov r8, r0
FurCoat:
	ldrb r0, [r2]
	cmp r0, #0x[B]FURCOAT[/B]
	bne Fluffy
DefenseBoost:
	ldr r1, [sp, #0x14]
	mov r0, r1
	add r1, r0, r0
	str r1, [sp, #0x14]
	b Return
Fluffy:
	ldrb r0, [r2]
	cmp r0, #0x[B]FLUFFY[/B]
	bne Return
CheckFireType:
	mov r2, r9
	cmp r2, #0xA
	bne DefenseBoost
DoubleDamage:
	lsl r7, r7, #0x1
	mov r0, r8
	lsl r0, r0, #0x1
	mov r8, r0
	b DefenseBoost
Return:
	ldr r2, .Return2
	bx r2

.align 2
.Return: .word 0x0803F0E9
.Return2: .word 0x0803F103

insert 00 48 00 47 xx+1 xx xx 08 at 03F0E0

 

[ThatNihha]

.

Can you post your routine for Imposter that you have in your Emerald base so it can be ported to Firered? Please?

 

[Trainer 781]

Can you post your routine for Imposter that you have in your Emerald base so it can be ported to Firered? Please?

Well, it isn't in asm. It is in C and cannot be extracted out separately becoz it is linked with other parts of the engine code.

 

[DavyChan]

Can someone explain what any of this is... this is why I don't mess with this stuff. I'm not a computer geek, I don't understand what this stuff is :(

 

[BluRose]

Can someone explain what any of this is... this is why I don't mess with this stuff. I'm not a computer geek, I don't understand what this stuff is :(

basically the lot of this is assembly, a very basic computer coding language. what is done when adding abilities is editing the battle engine (the code that makes battles what you see on the screen and otherwise) to branch off from the original code so we can insert our code, which has our desired effects covered in it; halving the power will branch off from the damage calulator, halving defense would also do so, an ability to make hail start would branch off at the battle's first steps, etc.

 

[Aiolia.leo]

So, related to Desolate Land, Deltra Stream and Primordial Sea, I see that Drought, Air Lock and Drizzle makes almost the "same" effect. So is it possible to make it work like those? How do I do that? (I mean like redirect some pointer and make both Desolate Land and Drought works the same way).

 

[Panda Face]

It is easily portable to FR, I'll update soon. It's just I never use FR so every time I do a routine I'm too lazy to seek for FR offset. But if someone ask I guess I can make an effort

I have also the -ate abilities done :

Spoiler:

Emerald :

Spoiler:

.text
.align 2
.thumb
.thumb_func
.global ateabilities

Start:
push {r0-r4}
mov r0, r10
cmp r0, #0	/*Normal type*/
beq AteCheck

PopAndClassic:
pop {r0-r4}

Classic:
ldrh r0, [r6, #0x2E]
cmp r0, #0xAF
bne Back
ldr r1, SomeLoc
ldr r2, Return
mov pc, r2

Back:
ldr r0, Return1
mov pc, r0

AteCheck:
mov r4, #0x20
ldrb r4, [r6, r4]
cmp r4, #0xB7	/*Index number Pixilate*/
beq Pixi
cmp r4, #0xB9	/*Index number Aerilate*/
beq Aeri
cmp r4, #0xAF	/*Index number Refrigerate*/
beq Refri
b PopAndClassic

Pixi:
mov r0, #0x17	/*Index number of your Fairy type*/
b StoreAndBoost

Aeri:
mov r0, #2	/*Index number of your Flying type*/
b StoreAndBoost

Refri:
mov r0, #0xF	/*Index number of your Ice type*/

StoreAndBoost:
Store:
ldr r1, ChangeTypeLoc
ldr r1, [r1]
add r1, #0x13
ldrb r2, [r1]
cmp r2, #0
bne PopAndClassic
strb r0, [r1]
mov r2, r0
mov r10, r0

Boost:
mov r0, r8
mov r3, #0xA7
mul r0, r3
lsr r0, #7
mov r8, r0
mul r7, r3
lsr r7, #7
b PopAndClassic



.align 2
Return: .word 0x0806961C+1
Return1: .word 0x08069634+1
ChangeTypeLoc: .word 0x0202449C
SomeLoc: .word 0x02024404

/*00 48 00 47 xx+1 xx xx 08 at 08069614*/

What is the hex form of that?

 

[Catman12]

Hi ! I have a question about abilities. Let's suppose that i create a new ability(i name it Test for example) thanks to ASM. How can i do to associate with Test its effect ?
(sorry if there are grammar/syntax mistakes, i'm not an english native)

 

[BluRose]

Hi ! I have a question about abilities. Let's suppose that i create a new ability(i name it Test for example) thanks to ASM. How can i do to associate with Test its effect ?
(sorry if there are grammar/syntax mistakes, i'm not an english native)

the asm covers everything for you; abilities are actually done by a check for the ability in the battle engine (i.e. the damage calculator) which then modifies the result until that point (to continue with the example, halving the attack or something)

 

[Catman12]

Thank you for your answer. I have another question about battle scripting this time. I saw there is a battle script editor, but it can be only used for a fire red ROM. How can i do to use battle script into emerald if i need it ? Is there an alternative ?

 

[DizzyEgg]

Thank you for your answer. I have another question about battle scripting this time. I saw there is a battle script editor, but it can be only used for a fire red ROM. How can i do to use battle script into emerald if i need it ? Is there an alternative ?

You use ASM macros.