Mach and Acro Bike script

[Super Dedenne]

Hmm, hmm! I find this script to be very well done and extremely helpful. I never really wanted to create an account and post on these forums, but there was something I wanted to say and that was to show my appreciation to this type of work... and also to chime in with my own bit for the Acro Bike part of this script.

Yes, the script for the most part is complete, but what bothered me about it was that it didn't support Essential V13's awesome ability to let the creator give X/Y-esque outfits to the player. I have hundreds of combinations of outfits, but the character would revert to the default outfit whenever I press and hold Z to try to make a wheelie! Why? Because there's nothing to define the change in the first place and will always take the images defined in the settings at the top of the script. Wouldn't it be weird if we had to change clothes just to pop a wheelie? Sure is!

So I thought, for anyone with little to no experience with RGSS1 still lurking around these parts and are using the X/Y outfit mechanic who would like to use this script too, would find that it's a super simple change! Nothing much too it and no credit needed whatsoever. I just thought it was something ... missing.

Anywho, for anyone wanting to use this script along with $Trainer.outfit, all you have to do is hunt out ###Graphical things and change...

 ### Graphical things
    graphic = Settings::AcroBikeFileName[$PokemonGlobal.playerID]
    if FileTest.image_exist?("Graphics/Characters/" + graphic) && Input.press?(Input::A) &&
      $PokemonGlobal.acrobike
      $game_player.character_name = graphic
    elsif Input.release?(Input::A)
      Kernel.pbUpdateVehicle
    end

to...

graphic = Settings::AcroBikeFileName[$PokemonGlobal.playerID]
    trainer=$Trainer if !trainer
    outfit=trainer ? trainer.outfit : 0
    if FileTest.image_exist?("Graphics/Characters/"+graphic+"_"+outfit.to_s) && Input.press?(Input::A) &&
      $PokemonGlobal.acrobike
      $game_player.character_name = graphic+"_"+outfit.to_s
    elsif Input.release?(Input::A) #Z on keyboard by default
      Kernel.pbUpdateVehicle
    end

Simple enough, right? I already renamed my files to more uniform names than boyAcro, but by default you should have files simply by the name of boyAcro_ followed by the outfit number. "boyAcro_0", "boyAcro_1", "boyAcro_2", and so on... Make sure the default outfit's file ends with "_0"!

This will only apply to the Acro Bike and nothing else as the Mach Bike is simply a modified version of the usual Bicycle and will take on the usual meta for that. Aaaand there you have it. Thanks, Hanisec! Feel free to mend this change into your OP if you want.

 

[Sharazel]

Hey ive got a problem:
I get this error:
https://i.imgur.com/JQEoJ55.jpg?1

 

[Maruno]

It's a module in newer versions of Essentials.

 

[Richard PT]

I used this script in essentials v15 and its works fine. But in v16 i've got this error and i don't know what i must do to fix it. What should i do?

 

[FL]

I used this script in essentials v15 and its works fine. But in v16 i've got this error and i don't know what i must do to fix it. What should i do?

The method 'pbIsPassableWaterTag?' was replaced by 'PBTerrain.isPassableWater?'. Try to replace at script.

 

[Richard PT]

Ok, i will test it that way. Thx.

 

[chacu34]

I don't know if this post is still alive but. I got a bug.

If I'm using Acro or Mach bike, doesn't matter which one, and I go inside a map where you can't use a bike (Allow bike = false), I'm not riding the bike anymore, but I still have its properties, and it's VERY weird.

I don't know how to fix that, so please, if someone knows about that huge bug, help me.

 

[etique]

Does anyone have this updated script? it seems that this script only works on old versions

 

[Tw_raZ]

Does anyone have this updated script? it seems that this script only works on old versions

It needs some slight modifications but this script works just fine in v17. Removing the water passability check (or simply changing it to its new name) fixes one issue, and PBTerrain is a module, not a class.

That being said, I would love it if someone made it so you can pass under the rails if you haven't already gone on them, like a bridge. Not sure how to do that.

 

[mybusiness]

It needs some slight modifications but this script works just fine in v17. Removing the water passability check (or simply changing it to its new name) fixes one issue, and PBTerrain is a module, not a class.

If you refer to this check,

# Make water tiles passable if player is surfing
      elsif PBTerrain.isPassableWater?(@terrain_tags[tile_id]) &&
         $PokemonGlobal.surfing && self_event==$game_player
        return true

then removing it doesn't solve the problem on walking on the 'shores of waters' like I showed here.

We plan to solve it. This is my code, with a note for WolfPP.

Spoiler:

module Settings
  AcroBikeFileName = [
  "boyAcro", # Player A
  "girlAcro", # Player B
  "", # Player C
  "", # Player D
  "", # Player E
  "", # Player F
  ]
end


module PBTerrain
  ACROBIKE = 18
  ACROBIKEHOP = 19
  MACHBIKE = 20
end


class Game_Map
  attr_accessor :acrobike
  attr_accessor :acrobike_held
  attr_accessor :forceacro
  attr_accessor :machbike_speed
  
  alias initialize_ab initialize
  def initialize
    @acrobike = 0
    @acrobike_held = 0
    @forceacro = 0
    @machbike_speed = 0
    initialize_ab
  end
  
# WolfPP, this is the main problem of the script. There are other issues with the rest, but 
# this gives everybody problems with bridges and water

=begin   
  def passable?(x, y, d, self_event = nil)
    return false if !valid?(x, y)
    bit = (1 << (d / 2 - 1)) & 0x0f
    for event in events.values
      if event.tile_id >= 0 and event != self_event and
         event.x == x and event.y == y and not event.through
        return false if @passages[event.tile_id] & bit != 0
        return false if @passages[event.tile_id] & 0x0f == 0x0f
        return true if @priorities[event.tile_id] == 0
      end
    end
    for i in [2, 1, 0]
      tile_id = data[x, y, i]
      next if tile_id && @terrain_tags[tile_id]==PBTerrain::Bridge &&
              $PokemonGlobal && $PokemonGlobal.bridge==0
      if tile_id == nil
        return false
      # Make water tiles passable if player is surfing
      elsif PBTerrain.isPassableWater?(@terrain_tags[tile_id]) &&
         $PokemonGlobal.surfing && self_event==$game_player
         return true
      elsif @terrain_tags[tile_id]==PBTerrain::TallGrass &&
         $PokemonGlobal.bicycle && self_event==$game_player
        return false
      elsif @terrain_tags[tile_id]==PBTerrain::Bridge && $PokemonGlobal &&
            $PokemonGlobal.bridge>0
        if @passages[tile_id] & bit != 0 ||
           @passages[tile_id] & 0x0f == 0x0f
          return false
        else
          return true
        end
      elsif @terrain_tags[tile_id]==PBTerrain::MACHBIKE
        return self_event==$game_player || self_event==nil
      elsif @terrain_tags[tile_id]==PBTerrain::ACROBIKE && self_event==$game_player &&
      $PokemonGlobal.acrobike && (@passages[tile_id] & bit == 0)
        return true
      elsif (@terrain_tags[tile_id]==PBTerrain::ACROBIKEHOP || @terrain_tags[tile_id]==PBTerrain::ACROBIKE) && 
        @acrobike==2 && self_event==$game_player && $PokemonGlobal.acrobike
        return true
      elsif @terrain_tags[tile_id]==PBTerrain::ACROBIKE && !$PokemonGlobal.acrobike
        return false
      elsif @terrain_tags[tile_id]==PBTerrain::ACROBIKEHOP && !$PokemonGlobal.acrobike
        return false
      elsif @passages[tile_id] & bit != 0
        return false
      elsif @passages[tile_id] & 0x0f == 0x0f
        return false
      elsif @priorities[tile_id] == 0
        return true
      end
    end
    return true
  end
=end
  
  alias update_ab update
  def update
    @acrobike_held += 1 if !$game_player.moving?
    @acrobike_held = 0 if !Input.press?(Input::B) || !$PokemonGlobal.acrobike
    @acrobike_held = 1 if Input.press?(Input::B) && $game_player.moving? &&
                          @acrobike < 2 && @acrobike != 0
    tag = pbGetTerrainTag($game_player)
    @forceacro = 0
    @forceacro = 1 if tag == PBTerrain::ACROBIKEHOP
    @acrobike = @forceacro
    @acrobike = 1 if @acrobike_held > 0
    if acrobike_held >= Graphics.frame_rate * 2
      @acrobike = 2
    end
    
    
    if $game_player.passableEx?($game_player.x, $game_player.y,
      $game_player.direction) && $PokemonGlobal.machbike && Input.dir4 != 0
      @machbike_speed += 0.1
      @machbike_speed = 3 if @machbike_speed > 3
    else
      @machbike_speed = 0
    end
    
    ### Graphical things
    graphic = Settings::AcroBikeFileName[$PokemonGlobal.playerID]
    if FileTest.image_exist?("Graphics/Characters/" + graphic) && Input.press?(Input::B) &&
      $PokemonGlobal.acrobike
      $game_player.character_name = graphic
    elsif Input.release?(Input::B)
      Kernel.pbUpdateVehicle
    end
    if @acrobike > 1
      if !$game_player.jumping?
        Kernel.pbJumpToward(0)
        pbSEPlay("jump")
      end
    end
    update_ab
  end
  
end

class Game_Player
  alias update_ab update
  def update
    dir = @direction
    update_ab
    dir2 = @direction
    # Make it so you can't turn incorrectly on rails
    if $PokemonGlobal.acrobike && terrain_tag == PBTerrain::ACROBIKE
      if !passableEx?(x, y, @direction, false)
        @direction=dir
      end
    end

    # Do a jump onto another rail
    if !passableEx?(x, y, dir2, false) && Input.trigger?(Input::B) && $PokemonGlobal.acrobike
      dir = @direction
      if (dir2 == 2) # Down
        tag = $game_map.terrain_tag(x, y + 1, false)
        if tag == PBTerrain::ACROBIKE
          $game_player.jump(0,1)
          pbSEPlay("jump")
        end
      elsif (dir2 == 4) # Left
        tag = $game_map.terrain_tag(x - 1, y, false)
        if tag == PBTerrain::ACROBIKE
          $game_player.jump(-1,0)
          pbSEPlay("jump")
        end
      elsif (dir2 == 6) # Right
        tag = $game_map.terrain_tag(x + 1, y, false)
        if tag == PBTerrain::ACROBIKE
          $game_player.jump(1,0)
          pbSEPlay("jump")
        end
      elsif (dir2 == 8) # Up
        tag = $game_map.terrain_tag(x, y - 1, false)
        if tag == PBTerrain::ACROBIKE
          $game_player.jump(0,-1)
          pbSEPlay("jump")
        end
      end
      @direction = dir
    end
    
    #### Mach Bike
    if $PokemonGlobal.machbike
      @move_speed = 3 + $game_map.machbike_speed.floor
    end
    if $game_map.machbike_speed < 2 && terrain_tag == PBTerrain::MACHBIKE
      move_down(false)
      $game_map.machbike_speed = 0
    end
  end
end

class PokemonGlobalMetadata
  attr_accessor :acrobike
  attr_accessor :machbike
end

ItemHandlers::UseInField.add(:BICYCLE,proc{|item|
    if pbBikeCheck
     $PokemonGlobal.machbike = false
     $PokemonGlobal.acrobike = false
     if $PokemonGlobal.bicycle
       Kernel.pbDismountBike
     else
       Kernel.pbMountBike 
     end
     next 1
   end
   next 0
})

# Add Acro Bike Property
ItemHandlers::UseInField.add(:ACROBIKE,proc{|item|
   if pbBikeCheck
     $PokemonGlobal.machbike = false
     if $PokemonGlobal.acrobike
       Kernel.pbDismountBike
       $PokemonGlobal.acrobike = false
     else
       Kernel.pbMountBike 
       $PokemonGlobal.acrobike = true
     end
     next 1
   end
   next 0
})

# Add Mach Bike Property
ItemHandlers::UseInField.add(:MACHBIKE,proc{|item|
   if pbBikeCheck
     $PokemonGlobal.acrobike = false
     if $PokemonGlobal.machbike
       Kernel.pbDismountBike
       $PokemonGlobal.machbike = false
     else
       Kernel.pbMountBike 
       $PokemonGlobal.machbike = true
     end
     next 1
   end
   next 0
})