Report bugs and errors in unmodified Essentials version 21

[#Not Important]

Redownload Essentials, there's a new bugfix version.

When was it released?
EDIT:

Today at 3:11 AM
I've re-released Essentials v18 with a couple of extra bug fixes relating to editing PBS data via the in-game Debug menu (and a minor update to the plugin manager, and a tweak to the exclaim overworld animation). If you've already downloaded it, you should get it again. It's the same download link.

I should be fine...

 

[derFischae]

In the method pbRoamingPokemonBattle in script section PField_RoamingPokemon in lines 234 and 235, the parameter index is not defined. I guess, it should be idxRoamer instead.

This forces the game to crash when killing an roaming Pokemon.

 

[DrawnToast]

Catching Pokémon doesn't give out Exp. even if the setting is on.
Not sure why this is, the code appears to be the same. Maybe I overlooked something.

 

[HM100]

It appears that dancer is triggered in every move the user does, not in specific dance-based moves (Such as Swords Dance). Is it intentional?

 

[Golisopod User]

It appears that dancer is triggered in every move the user does, not in specific dance-based moves (Such as Swords Dance). Is it intentional?

Say that again.... But slowly.... Swords D A N C E.

 

[#Not Important]

Say that again.... But slowly.... Swords D A N C E.

I think he meant Swords Dance as an example of a dance based move, not that swords dance was triggering it.

 

[Aioross]

Spoiler:

i was trying to add steely spirit and the dmg values weren't adding up, since I was using steelworker as a template I decided to test it to see what was happening

in my tests a dhelmise with steelworker was hiting nearly 1.1 times harder then a dhelmise with a random ability I gave it (pickup), checked showdown calculator to see if the ratios should be being watered down along the dmg calculation but according to it the increase in dmg should be 1.5 times

method of testing:
2v1 vs a wild kakuna
dhelmise hitting my 2nd pokemon (species, defense, defense evs, nature, etc all remained constant)
with steelworker dhelmise was doing 1.1* more dmg instead of 1.5*


someone please try to replicate and confirm if it's also happening to you, this could have smth to do with how the dmg is calculated having a wrong value


edit: i wanted to also test it out with other similar abilities like overgrow, when i did my tests the dmg was exactly equal with or without overgrow procced... i thought it was weird so i added a p "proc"

BattleHandlers::DamageCalcUserAbility.add(:OVERGROW,
  proc { |ability,user,target,move,mults,baseDmg,type|
    if user.hp<=user.totalhp/3 && isConst?(type,PBTypes,:GRASS)
      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round
      p "proc"
    end
  }
)

like so to overgrow ability, my pokemon with 1 hp using grass moves was not proccing it at all... i may be doing smth very stupid here idk, i'd appreciate if someone tests steelworker dmg and overgrow and reaches same conclusion (steelworker doing 1.1x dmg instead of 1.5x and overgrow not working)

edit2: i retested steelworker with level 100 pokemons, the dmg were about the same with and without steelworker, i altered script to make steelworker give 10*mult instead of 1.5*, the dmg still remains the same, earlier when i got the results that it was doing around 1.1* dmg was at level 20 so i assume its a fluke

according to what i've tested neither overgrow nor steelworker are functioning

edit3: still trying to make sense of it

BattleHandlers::DamageCalcUserAbility.add(:STEELWORKER,
  proc { |ability,user,target,move,mults,baseDmg,type|
    if isConst?(type,PBTypes,:STEEL)
      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round
      p "ui"
    else
      p type
    end
  }
)

with this i noticed not only the if isnt working (it doesnt return ui) it returns 40 (when i used bullet punch) or 120 with heavy slam, etc for some reason p type is giving the base power of the move

edit4: used spoiler on previous comments to go straight to the point
apparently in abilities the baseDmg and type are swapped, every condition like if isConst?(type,PBTypes,:STEEL)
when i added "p type" and "p baseDmg" to testing it was constantly returning 40 on p type (base dmg of bullet punch which i was using to test) and 8 on baseDmg (8th type is steel)
so from what i can tell that's the bug, those 2 things are swapped

(i then did a temporary "fix" with this

BattleHandlers::DamageCalcUserAbility.add(:STEELWORKER,
  proc { |ability,user,target,move,mults,baseDmg,type|
#    if isConst?(type,PBTypes,:STEEL)
    if baseDmg == 8
      mults[ATK_MULT] = (mults[ATK_MULT]*1.5).round
      p "ui"
    else
      p move.type
    end
  }
)

to check if the value of dmg is correct and the value of the dmg IS correct)

 

[HM100]

Another issue; When you evolve a Pokémon that it is set into an alternative form and its evolved form does not decide which form to be set automatically (Such as an Alolan Vulpix into Alolan Ninetales using Ice Stone), it will correctly display the alternative form when it evolves (Alolan Ninetales) but the outcome is the base form (AKA Alolan Vulpix evolved into Kantonian Ninetales). You can workaround this one:

In PScreen_Evolution, find oldspeciesname = PBSpecies.getName(@pokemon.species) and paste below it:

oldform        = @pokemon.form

Then find @pokemon.form = 0 if isConst?(@pokemon.species,PBSpecies,:MOTHIM) and paste above it the following code:

@pokemon.form    = oldform

2nd Issue Found: Some issues arise in Fling Code because in pbCheckFlingSuccess it lacks the user variable defined. Replace the whole Fling Function code with this:

Spoiler:

#===============================================================================
# User flings its item at the target. Power/effect depend on the item. (Fling)
#===============================================================================
class PokeBattle_Move_0F7 < PokeBattle_Move
  def initialize(battle,move)
    super
    # 80 => all Mega Stones
    # 10 => all Berries
    @flingPowers = {
      130 => [:IRONBALL
             ],
      100 => [:HARDSTONE,:RAREBONE,
              # Fossils
              :ARMORFOSSIL,:CLAWFOSSIL,:COVERFOSSIL,:DOMEFOSSIL,:HELIXFOSSIL,
              :JAWFOSSIL,:OLDAMBER,:PLUMEFOSSIL,:ROOTFOSSIL,:SAILFOSSIL,
              :SKULLFOSSIL
             ],
       90 => [:DEEPSEATOOTH,:GRIPCLAW,:THICKCLUB,
              # Plates
              :DRACOPLATE,:DREADPLATE,:EARTHPLATE,:FISTPLATE,:FLAMEPLATE,
              :ICICLEPLATE,:INSECTPLATE,:IRONPLATE,:MEADOWPLATE,:MINDPLATE,
              :PIXIEPLATE,:SKYPLATE,:SPLASHPLATE,:SPOOKYPLATE,:STONEPLATE,
              :TOXICPLATE,:ZAPPLATE
             ],
       80 => [:ASSAULTVEST,:DAWNSTONE,:DUSKSTONE,:ELECTIRIZER,:MAGMARIZER,
              :ODDKEYSTONE,:OVALSTONE,:PROTECTOR,:QUICKCLAW,:RAZORCLAW,:SACHET,
              :SAFETYGOGGLES,:SHINYSTONE,:STICKYBARB,:WEAKNESSPOLICY,
              :WHIPPEDDREAM
             ],
       70 => [:DRAGONFANG,:POISONBARB,
              # EV-training items (Macho Brace is 60)
              :POWERANKLET,:POWERBAND,:POWERBELT,:POWERBRACER,:POWERLENS,
              :POWERWEIGHT,
              # Drives
              :BURNDRIVE,:CHILLDRIVE,:DOUSEDRIVE,:SHOCKDRIVE
             ],
       60 => [:ADAMANTORB,:DAMPROCK,:GRISEOUSORB,:HEATROCK,:LUSTROUSORB,
              :MACHOBRACE,:ROCKYHELMET,:STICK,:TERRAINEXTENDER
             ],
       50 => [:DUBIOUSDISC,:SHARPBEAK,
              # Memories
              :BUGMEMORY,:DARKMEMORY,:DRAGONMEMORY,:ELECTRICMEMORY,:FAIRYMEMORY,
              :FIGHTINGMEMORY,:FIREMEMORY,:FLYINGMEMORY,:GHOSTMEMORY,
              :GRASSMEMORY,:GROUNDMEMORY,:ICEMEMORY,:POISONMEMORY,
              :PSYCHICMEMORY,:ROCKMEMORY,:STEELMEMORY,:WATERMEMORY
             ],
       40 => [:EVIOLITE,:ICYROCK,:LUCKYPUNCH
             ],
       30 => [:ABSORBBULB,:ADRENALINEORB,:AMULETCOIN,:BINDINGBAND,:BLACKBELT,
              :BLACKGLASSES,:BLACKSLUDGE,:BOTTLECAP,:CELLBATTERY,:CHARCOAL,
              :CLEANSETAG,:DEEPSEASCALE,:DRAGONSCALE,:EJECTBUTTON,:ESCAPEROPE,
              :EXPSHARE,:FLAMEORB,:FLOATSTONE,:FLUFFYTAIL,:GOLDBOTTLECAP,
              :HEARTSCALE,:HONEY,:KINGSROCK,:LIFEORB,:LIGHTBALL,:LIGHTCLAY,
              :LUCKYEGG,:LUMINOUSMOSS,:MAGNET,:METALCOAT,:METRONOME,
              :MIRACLESEED,:MYSTICWATER,:NEVERMELTICE,:PASSORB,:POKEDOLL,
              :POKETOY,:PRISMSCALE,:PROTECTIVEPADS,:RAZORFANG,:SACREDASH,
              :SCOPELENS,:SHELLBELL,:SHOALSALT,:SHOALSHELL,:SMOKEBALL,:SNOWBALL,
              :SOULDEW,:SPELLTAG,:TOXICORB,:TWISTEDSPOON,:UPGRADE,
              # Healing items
              :ANTIDOTE,:AWAKENING,:BERRYJUICE,:BIGMALASADA,:BLUEFLUTE,
              :BURNHEAL,:CASTELIACONE,:ELIXIR,:ENERGYPOWDER,:ENERGYROOT,:ETHER,
              :FRESHWATER,:FULLHEAL,:FULLRESTORE,:HEALPOWDER,:HYPERPOTION,
              :ICEHEAL,:LAVACOOKIE,:LEMONADE,:LUMIOSEGALETTE,:MAXELIXIR,
              :MAXETHER,:MAXPOTION,:MAXREVIVE,:MOOMOOMILK,:OLDGATEAU,
              :PARALYZEHEAL,:PARLYZHEAL,:PEWTERCRUNCHIES,:POTION,:RAGECANDYBAR,
              :REDFLUTE,:REVIVALHERB,:REVIVE,:SHALOURSABLE,:SODAPOP,
              :SUPERPOTION,:SWEETHEART,:YELLOWFLUTE,
              # Battle items
              :XACCURACY,:XACCURACY2,:XACCURACY3,:XACCURACY6,
              :XATTACK,:XATTACK2,:XATTACK3,:XATTACK6,
              :XDEFEND,:XDEFEND2,:XDEFEND3,:XDEFEND6,
              :XDEFENSE,:XDEFENSE2,:XDEFENSE3,:XDEFENSE6,
              :XSPATK,:XSPATK2,:XSPATK3,:XSPATK6,
              :XSPECIAL,:XSPECIAL2,:XSPECIAL3,:XSPECIAL6,
              :XSPDEF,:XSPDEF2,:XSPDEF3,:XSPDEF6,
              :XSPEED,:XSPEED2,:XSPEED3,:XSPEED6,
              :DIREHIT,:DIREHIT2,:DIREHIT3,
              :ABILITYURGE,:GUARDSPEC,:ITEMDROP,:ITEMURGE,:RESETURGE,
              # Vitamins
              :CALCIUM,:CARBOS,:HPUP,:IRON,:PPUP,:PPMAX,:PROTEIN,:ZINC,
              :RARECANDY,
              # Most evolution stones (see also 80)
              :EVERSTONE,:FIRESTONE,:ICESTONE,:LEAFSTONE,:MOONSTONE,:SUNSTONE,
              :THUNDERSTONE,:WATERSTONE,
              # Repels
              :MAXREPEL,:REPEL,:SUPERREPEL,
              # Mulches
              :AMAZEMULCH,:BOOSTMULCH,:DAMPMULCH,:GOOEYMULCH,:GROWTHMULCH,
              :RICHMULCH,:STABLEMULCH,:SURPRISEMULCH,
              # Shards
              :BLUESHARD,:GREENSHARD,:REDSHARD,:YELLOWSHARD,
              # Valuables
              :BALMMUSHROOM,:BIGMUSHROOM,:BIGNUGGET,:BIGPEARL,:COMETSHARD,
              :NUGGET,:PEARL,:PEARLSTRING,:RELICBAND,:RELICCOPPER,:RELICCROWN,
              :RELICGOLD,:RELICSILVER,:RELICSTATUE,:RELICVASE,:STARDUST,
              :STARPIECE,:STRANGESOUVENIR,:TINYMUSHROOM
             ],
       20 => [# Wings
              :CLEVERWING,:GENIUSWING,:HEALTHWING,:MUSCLEWING,:PRETTYWING,
              :RESISTWING,:SWIFTWING
             ],
       10 => [:AIRBALLOON,:BIGROOT,:BRIGHTPOWDER,:CHOICEBAND,:CHOICESCARF,
              :CHOICESPECS,:DESTINYKNOT,:DISCOUNTCOUPON,:EXPERTBELT,:FOCUSBAND,
              :FOCUSSASH,:LAGGINGTAIL,:LEFTOVERS,:MENTALHERB,:METALPOWDER,
              :MUSCLEBAND,:POWERHERB,:QUICKPOWDER,:REAPERCLOTH,:REDCARD,
              :RINGTARGET,:SHEDSHELL,:SILKSCARF,:SILVERPOWDER,:SMOOTHROCK,
              :SOFTSAND,:SOOTHEBELL,:WHITEHERB,:WIDELENS,:WISEGLASSES,:ZOOMLENS,
              # Terrain seeds
              :ELECTRICSEED,:GRASSYSEED,:MISTYSEED,:PSYCHICSEED,
              # Nectar
              :PINKNECTAR,:PURPLENECTAR,:REDNECTAR,:YELLOWNECTAR,
              # Incenses
              :FULLINCENSE,:LAXINCENSE,:LUCKINCENSE,:ODDINCENSE,:PUREINCENSE,
              :ROCKINCENSE,:ROSEINCENSE,:SEAINCENSE,:WAVEINCENSE,
              # Scarves
              :BLUESCARF,:GREENSCARF,:PINKSCARF,:REDSCARF,:YELLOWSCARF
             ]
    }
  end

  def pbCheckFlingSuccess(user)
    @willFail = false
    @willFail = true if user.item==0 || !user.itemActive? || user.unlosableItem?(user.item)
    if pbIsBerry?(user.item)
      @willFail = true if @battle.pbCheckOpposingAbility(:UNNERVE,user.index)
      return
    end
    return if pbIsMegaStone?(user.item)
    flingableItem = false
    @flingPowers.each do |power,items|
      items.each do |i|
        next if !isConst?(user.item,PBItems,i)
        flingableItem = true
        break
      end
      break if flingableItem
    end
    @willFail = true if !flingableItem
  end

  def pbMoveFailed?(user,targets)
    if @willFail
      @battle.pbDisplay(_INTL("But it failed!"))
      return true
    end
    return false
  end

  def pbDisplayUseMessage(user)
    super
    pbCheckFlingSuccess(user)
    if !@willFail
      @battle.pbDisplay(_INTL("{1} flung its {2}!",user.pbThis,user.itemName))
    end
  end

  def pbNumHits(user,targets); return 1; end

  def pbBaseDamage(baseDmg,user,target)
    return 10 if pbIsBerry?(user.item)
    return 80 if pbIsMegaStone?(user.item)
    @flingPowers.each do |power,items|
      items.each { |i| return power if isConst?(user.item,PBItems,i) }
    end
    return 10
  end

  def pbEffectAgainstTarget(user,target)
    return if target.damageState.substitute
    return if target.hasActiveAbility?(:SHIELDDUST) && [email protected]
    if isConst?(user.item,PBItems,:POISONBARB)
      target.pbPoison(user) if target.pbCanPoison?(user,false,self)
    elsif isConst?(user.item,PBItems,:TOXICORB)
      target.pbPoison(user,nil,true) if target.pbCanPoison?(user,false,self)
    elsif isConst?(user.item,PBItems,:FLAMEORB)
      target.pbBurn(user) if target.pbCanBurn?(user,false,self)
    elsif isConst?(user.item,PBItems,:LIGHTBALL)
      target.pbParalyze(user) if target.pbCanParalyze?(user,false,self)
    elsif isConst?(user.item,PBItems,:KINGSROCK) ||
          isConst?(user.item,PBItems,:RAZORFANG)
      target.pbFlinch(user)
    else
      target.pbHeldItemTriggerCheck(user.item,true)
    end
  end

  def pbEndOfMoveUsageEffect(user,targets,numHits,switchedBattlers)
    # NOTE: The item is consumed even if this move was Protected against or it
    #       missed. The item is not consumed if the target was switched out by
    #       an effect like a target's Red Card.
    # NOTE: There is no item consumption animation.
    user.pbConsumeItem(true,true,false) if user.item>0
  end
end

 

[Zettai]

I have encountered what I believe to be a bug.
I have so far, only made the changes from HM100's errors, dynamic leveling, as well as adding pokemon and some simple sprite UI mods.
My first error occurred when trying to access the Kanto Pokedex after turning it on via the debug menu.
The latter occurs when I attempt to create a new save game, there is no difference whether I do it via changing title or clicking new game.

Error #1:

Spoiler:

[Fri Sep 04 22:12:11 Eastern Daylight Time 2020]
[Pokémon Essentials version 18]
Exception: NoMethodError
Message: undefined method `[]' for nil:NilClass

Backtrace:
PScreen_PokedexMain:328:in `pbGetDexList'
PScreen_PokedexMain:325:in `each'
PScreen_PokedexMain:325:in `pbGetDexList'
PScreen_PokedexMain:345:in `pbRefreshDexList'
PScreen_PokedexMain:260:in `pbStartScene'
PScreen_PokedexMain:1187:in `pbStartScreen'
PScreen_PokedexMenu:121:in `pbStartScreen'
PScreen_PokedexMenu:118:in `pbFadeOutIn'
PScreen_PokedexMenu:122:in `pbStartScreen'
PScreen_PokedexMenu:113:in `loop'

Error #1.5:

Spoiler:

[Fri Sep 04 21:50:32 Eastern Daylight Time 2020]
[Pokémon Essentials version 18]
Exception: NoMethodError
Message: undefined method `*' for nil:NilClass

Backtrace:
PScreen_PokedexMain:328:in `pbGetDexList'
PScreen_PokedexMain:325:in `each'
PScreen_PokedexMain:325:in `pbGetDexList'
PScreen_PokedexMain:345:in `pbRefreshDexList'
PScreen_PokedexMain:260:in `pbStartScene'
PScreen_PokedexMain:1187:in `pbStartScreen'
PScreen_PokedexMenu:121:in `pbStartScreen'
PScreen_PokedexMenu:118:in `pbFadeOutIn'
PScreen_PokedexMenu:122:in `pbStartScreen'
PScreen_PokedexMenu:113:in `loop'

Error #2:

Spoiler:

[Sat Sep 05 11:08:42 Eastern Daylight Time 2020]
[Pokémon Essentials version 18]
Exception: NoMethodError
Message: undefined method `*' for nil:NilClass

Backtrace:
Tilemap_XP:409:in `addTile'
Tilemap_XP:843:in `refresh'
Tilemap_XP:840:in `each'
Tilemap_XP:840:in `refresh'
Tilemap_XP:938:in `update'
TilemapLoader:49:in `update'
Spriteset_Map:130:in `_animationSprite_update'
Sprite_AnimationSprite:89:in `update'
Spriteset_Map:68:in `_animationSprite_initialize'
Sprite_AnimationSprite:50:in `shadow_initialize'

Edit: I was tired when I wrote this last night and didn't realize I mixed up two different dex errors and one single new game error.

Edit2: I moved all my changes to a fresh copy of v18 and found the pokedex error was due to an error in my pokemon.txt PBS file. As for the saving error, this is presumably from some typo, as I cannot replicate it again on the fresh version.

 

[Aioross]

there's a bug when you overwrite same weather using an ability (i originally was testing sand spit when i found this out, i then tested with tyranitar sand stream and confirmed)
how to replicate:
send tyranitar in, switch him out turn 2
send tyranitar in turn 3: you get the ability pop up graphic bugged and the ability doesnt fail

how should work: ability should fail


----------
i did some testing and changed

def pbBattleWeatherAbility(weather,battler,battle,ignorePrimal=false)

i added

return if battle.field.weather==weather

with this the bug is gone
i also dont know if the weather duration -1 is supposed to permanent unremovable weather, but if thats the case then this line

return if battle.field.weather==weather && battle.field.weatherDuration==-1

would work if there was a || instead of &&

 

[Aioross]

in Protean this line

if user.pbHasOtherType?(moveType) && !PBTypes.isPseudoType?(move.calcType)

was causing an error that forced the mon into an infinite loop of using same attack and displaying an error message

i changed the 1st (moveType) to (move.calcType) and it's now working

 

[Kiribartlett]

"Go! *POKEMON*!" text didn't showed up if the foe's HP is full when I switch out.

  def pbMessagesOnReplace(idxBattler,idxParty)
    party = pbParty(idxBattler)
    newPkmnName = party[idxParty].name
    if isConst?(party[idxParty].ability,PBAbilities,:ILLUSION)
      newPkmnName = party[pbLastInTeam(idxBattler)].name
    end
    if pbOwnedByPlayer?(idxBattler)
      opposing = @battlers[idxBattler].pbDirectOpposing
      if opposing.fainted? || opposing.hp==opposing.totalhp
        pbDisplayBrief(_INTL("You're in charge, {1}!",newPkmnName))
      elsif opposing.hp>=opposing.totalhp/2
        pbDisplayBrief(_INTL("Go for it, {1}!",newPkmnName))
      elsif opposing.hp>=opposing.totalhp/4
        pbDisplayBrief(_INTL("Just a little more! Hang in there, {1}!",newPkmnName))
      else
        pbDisplayBrief(_INTL("Your opponent's weak! Get 'em, {1}!",newPkmnName))
      end
    else
      owner = pbGetOwnerFromBattlerIndex(idxBattler)
      pbDisplayBrief(_INTL("{1} sent out {2}!",owner.fullname,newPkmnName))
    end
  end

"*TRAINER* is about to send in *FOE POKEMON*. Will you switch your Pokémon?" text still shows up after this Pokemon faint and I switch a next one.
And the Faint Cry sound isn't hear.

This code is not the same in the gameplay but still a error.

 

[MFilice]

The Kee Berry, Maranga Berry and the Enigma Berry are all not consumed on use.

 

[94lolface]

So... I posted this over on Relic already, but I thought I might as well post it here too.

When forcing the use of Salac Berry and it's cousins, it doesn't work when the user is at full HP.
I tried to code in Stuff Cheeks, actually got it to work as well.
But in testing I noticed that it doesn't actually get the effects of the held Salac Berry if I was at Full HP.
At first I thought it was a mistake on my end, so I tried to shift some stuff around but it didn't work.

Anyways, next thing I tried was using something Essentials already came with: Bug Bite.

So instead of using Stuff Cheeks, I tricked my Salac Berry and used Bug Bite afterwards and saw the same results.
Bug Bite itself works, but the user only gains the +1 Speed from the Salac Berry while not at Full HP.

Since Bug Bite utilizes "pbHeldItemTriggerCheck", that was the thing I checked first. Due to the bahaviour of only triggering when having taken at least 1 HP damage, I figured I look into "pbItemHPHealCheck", which also lead to a dead end.
Ultimately I checked the Salac Berry itself:

BattleHandlers::HPHealItem.add(:SALACBERRY,
  proc { |item,battler,battle,forced|
    next pbBattleStatIncreasingBerry(battler,battle,item,forced,PBStats::SPEED)
  }
)

"HPHealItem.add"
The game treats it as a healing item, making it unable to be used when at Full HP, even if it's forced to be used.

 

[DannyPhantump]

1) PBS: Alolan Nintetales is set to evolve into itself upon using an Ice Stone

Spoiler:

#-------------------------------
[NINETALES,1]
FormName = Alolan
Type1 = ICE
Type2 = FAIRY
BaseStats = 73,67,75,109,81,100
EffortPoints = 0,0,0,2,0,0
Abilities = SNOWCLOAK
HiddenAbility = SNOWWARNING
Moves = 0,DAZZLINGGLEAM,1,DAZZLINGGLEAM,1,IMPRISON,1,NASTYPLOT,1,ICEBEAM,1,ICESHARD,1,CONFUSERAY,1,SAFEGUARD
Color = Blue
Pokedex = It lives on mountains perpetually covered in snow and is revered as a deity incarnate. It appears draped in a blizzard.
WildItemUncommon = SNOWBALL
Evolutions = NINETALES,Item,ICESTONE
#-------------------------------

2) draining moves such as Leech Life do not restore HP when it is the final move in a battle (my Mega Beedrill one-hit KO'ed a Mewtwo with Leech Life, but did not recover any HP)

 

[Aioross]

In soak code ->

#===============================================================================
# Target becomes Water type. (Soak)
#===============================================================================
class PokeBattle_Move_061 < PokeBattle_Move
  def pbFailsAgainstTarget?(user,target)
    if !target.canChangeType? ||
       !target.pbHasOtherType?(getConst(PBTypes,:WATER))
      @battle.pbDisplay(_INTL("But it failed!"))
      return true
    end
    return false
  end

  def pbEffectAgainstTarget(user,target)
    newType = getConst(PBTypes,:WATER)
    user.pbChangeTypes(newType)
    typeName = PBTypes.getName(newType)
    @battle.pbDisplay(_INTL("{1} transformed into the {2} type!",target.pbThis,typeName))
  end
end

user.pbChangeTypes(newType)

needs to be changed to

target.pbChangeTypes(newType)

else it'll change user type instead of its target

 

[Turn20Negate]

The abilities Beast Boost and Battlebond don't trigger when knocking out another Pokemon(even if the opponent has at least one other Pokemon left). I tried playing around with their functions a bit to find the error and I came as far as this:
This line stops the code from working, because the if statement inside the block never returns true.

Spoiler:

# Greninja - Battle Bond
    if !user.fainted? && !user.effects[PBEffects::Transform] &&
       isConst?(user.species,PBSpecies,:GRENINJA) &&
       isConst?(user.ability,PBAbilities,:BATTLEBOND)
      if [email protected]?(user.idxOpposingSide) &&
         [email protected][user.index&1][user.pokemonIndex]
        numFainted = 0
        targets.each { |b| numFainted += 1 [COLOR="Red"]if b.damageState.fainted[/COLOR] }
        if numFainted>0 && user.form!=1 
          @battle.battleBond[user.index&1][user.pokemonIndex] = true
          @battle.pbDisplay(_INTL("{1} became fully charged due to its bond with its Trainer!",user.pbThis))
          @battle.pbShowAbilitySplash(user,true)
          @battle.pbHideAbilitySplash(user)
          user.pbChangeForm(1,_INTL("{1} became Ash-Greninja!",user.pbThis))
        end
      end
    end

When I changed it to b.damageState.unaffected and used a move that didn't affect the opponent it returned true, meaning the error has to do with the .fainted attribute.
But looking at def pbRecordDamageLost, I noticed target.damageState.fainted turns true(which it does, I tested it):

Spoiler:

# Used by Counter/Mirror Coat/Metal Burst/Revenge/Focus Punch/Bide/Assurance.
  def pbRecordDamageLost(user,target)
    damage = target.damageState.hpLost
    # NOTE: In Gen 3 where a move's category depends on its type, Hidden Power
    #       is for some reason countered by Counter rather than Mirror Coat,
    #       regardless of its calculated type. Hence the following two lines of
    #       code.
    moveType = nil
    moveType = getID(PBTypes,:NORMAL) if @function=="090"   # Hidden Power
    if physicalMove?(moveType)
      target.effects[PBEffects::Counter]       = damage
      target.effects[PBEffects::CounterTarget] = user.index
    elsif specialMove?(moveType)
      target.effects[PBEffects::MirrorCoat]       = damage
      target.effects[PBEffects::MirrorCoatTarget] = user.index
    end
    if target.effects[PBEffects::Bide]>0
      target.effects[PBEffects::BideDamage] += damage
      target.effects[PBEffects::BideTarget] = user.index
    end
    [COLOR="Red"]target.damageState.fainted = true if target.fainted?[/COLOR]
    target.lastHPLost = damage             # For Focus Punch
    target.tookDamage = true if damage>0   # For Assurance
    target.lastAttacker.push(user.index)   # For Revenge
    if target.opposes?(user)
      target.lastHPLostFromFoe = damage              # For Metal Burst
      target.lastFoeAttacker.push(user.index)        # For Metal Burst
    end
  end

In conclusion target.damageState.fainted is true for every fainted target in the damage calculation, but never in the block call.

targets.each { |b| numFainted += 1 if b.damageState.fainted }

I tried to find this error's source but failed. If anyone has some time they could look into this. :)

 

[Eurritimia]

The abilities Beast Boost and Battlebond don't trigger when knocking out another Pokemon(even if the opponent has at least one other Pokemon left).

This also seems to be true with Moxie.

 

[#Not Important]

The code for eachOpposing has no block to yield, so it gives a LocalJumpError. This is my fix:

# Yields each unfainted opposing Pokémon.
  def eachOpposing
    #@battle.battlers.each { |b| yield b if b && !b.fainted? && b.opposes?(@index) } OLD METHOD
   #                             ^ cannot yield nothing
    @battle.battlers.each { |b| return b if b && !b.fainted? && b.opposes?(@index) }
  end

 

[Vendily]

The code for eachOpposing has no block to yield, so it gives a LocalJumpError. This is my fix:

# Yields each unfainted opposing Pokémon.
  def eachOpposing
    #@battle.battlers.each { |b| yield b if b && !b.fainted? && b.opposes?(@index) } OLD METHOD
   #                             ^ cannot yield nothing
    @battle.battlers.each { |b| return b if b && !b.fainted? && b.opposes?(@index) }
  end

That doesn't seem right, It's supposed to yield, and you call it with a block, else it would crash the second a battler was set up and sent in.
with this code, I believe that some battlers won't be properly set up as participants, and fainting them will give no experience.