Generally, I choose the Grass type for my starter, but for some reason, I always make an exception in Johto and go with Totodile. Don't really know why, but for some reason I just have to choose him.
Now, I haven't played any of the Sinnoh games, but if I ever did, I'd probably pick Turtwig.