Code: Ability Resource Thread

AkimotoBubble · Sep 30, 2015

kleenexfeu said:

UPDATE : 100% working afaik, here is :

Stance Change:

Spoiler:

Emerald :

Spoiler:

The battle scripts come first :

Spoiler:

Main routine : (same hook than mold break, we'll see later for compatibility)

Spoiler:

Code:

.thumb

push {r4-r7}
ldr r0, FreeRam
ldrb r1, [r0]
cmp r1, #0
bne Return
ldr r0, Bank
ldrb r0, [r0]
mov r5, r0
mov r1, #1
and r1, r0
cmp r1, #0
beq Player

AI:
ldr r6, AIParty
mov r1, #3
b CheckAegi

Player:
ldr r6, PlayerParty
mov r1, #0

CheckAegi:
ldr r0, MemLoc
ldr r0, [r0]
add r0, #0x60
ldrb r0, [r0, r1]
mov r1, #2
and r1, r5
cmp r1, #0
beq Continue
lsl r0, r0, #4
lsr r0, r0, #4
lsl r0, r0, #4

Continue:
lsr r0, r0, #0x4
mov r1, r6
mov r2, #0x64
mul r0, r2
add r0, r1
mov r1, #0xB
mov r4, r0
ldr r3, getattr
bl Jump
ldr r1, ABlade
cmp r0, r1
beq CheckKing
ldr r1, AShield
cmp r0, r1
beq CheckMove

Return:
pop {r4-r7}
ldr r3, =0x8041A6C+1
bl Jump
lsl r0, r0, #0x18
lsr r2, r0, #0x18
cmp r2, #0
beq ReturnPos
ldr r0, =0x8046398+1
mov pc, r0

ReturnPos:
ldr r0, =0x8046072+1
mov pc, r0

CheckMove:
bl BData
ldr r0, CurMove
ldrh r0, [r0]
ldr r1, KingShield
cmp r0, r1
beq Return
ldr r1, ABlade
strh r1, [r5]
ldr r2, var8004
mov r7, r1
b ChangePokeParty

CheckKing:
bl BData
ldr r0, CurMove
ldrh r0, [r0]
ldr r1, KingShield
cmp r0, r1
bne Return
ldr r1, AShield
strh r1, [r5]
ldr r2, var8004
mov r7, r1

ChangePokeParty:
strh r1, [r2]
mov r0, r4
mov r1, #0xB
ldr r3, setattr
bl Jump
mov r0, r4
ldr r3, calcstats
bl Jump

ChangeBattleStats:
mov r1, #0x54
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #2]
mov r1, #0x55
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #4]
mov r1, #0x56
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #6]
mov r1, #0x57
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #8]
mov r1, #0x58
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #0xA]

KeepAttackSafe:
ldr r3, ScriptPusher
bl Jump

ldr r1, ABlade
cmp r7, r1
bne ShieldScript

BladeScript:
ldr r2, BladeBS
b Store

ShieldScript:
ldr r2, ShieldBS

Store:
ldr r1, CurBS
str r2, [r1]
ldr r0, FreeRam
mov r1, #1
strb r1, [r0]
pop {r4-r7}
ldr r3, Test

Jump:
mov pc, r3

Jumpr4:
mov pc, r4

BData:
push {lr}
mov r1, #0x58
mul r5, r1
ldr r1, BattleData
add r5, r1
pop {pc}

.align 2
BladeBS: .word 0x08____
ShieldBS: .word 0x08____
BattleData: .word 0x02024084
KingShield: .word 0x5E /*Move King Shield*/
ABlade: .word 0x__ /*Index number of Aegislash Blade*/
AShield: .word 0x__ /*Aegislash Shield*/
MemLoc: .word 0x0202449C
getattr: .word 0x0806A518+1
Bank: .word 0x0202420B
PlayerParty: .word 0x020244EC
AIParty: .word 0x02024744
calcstats: .word 0x08068D0C+1
setattr: .word 0x0806ACAC+1
var8004: .word 0x020275D8 + (0x8004*2)
ScriptPusher: .word 0x0803FAFC+1
CurMove: .word 0x020241EA
CurBS: .word 0x02024214
Test: .word 0x08046398+1
FreeRam: .word 0x0203E33C

/*00 48 00 47 xx+1 xx xx 08 at 08046064. It should be include in Mold breaker*/

Modification of the "end" command :

Spoiler:

Switch out check :

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global regenerator
 
AbilityBuffer:
	add r0, r1, r3
	add r0, #0x20
	ldrb r0, [r0]

RegeneratorCheck:
	cmp r0, #[B]0x91 [/B]	/*Index number of your ability Regenerator*/
	beq Regenerator

NaturalCureCheck:
	cmp r0, #0x1E
	bne CheckDelta

NaturalCure:
	ldr r0, .Return
	bx r0

CheckAegi:
	push {r0-r7}
	ldr r0, Bank
	ldrb r0, [r0]
	mov r5, r0
	mov r1, #1
	and r1, r0
	cmp r1, #0
	beq Player

AI:
	ldr r7, AIParty
	mov r1, #3
	b CheckAegis

Player:
	ldr r7, PlayerParty
	mov r1, #0

CheckAegis:
	ldr r0, MemLoc
	ldr r0, [r0]
	add r0, #0x60
	ldrb r0, [r0, r1]
	lsr r0, r0, #0x4
	mov r1, r7
	mov r2, #0x64
	mul r0, r2
	add r0, r1
	mov r1, #0xB
	mov r4, r0
	ldr r3, getattr
	bl Jump
	ldr r1, ABlade
	cmp r0, r1
	beq Revert

BackEnd:
	pop {r0-r7}
	
NoAbility:
	ldr r0, .Return2
	bx r0

Revert:
	ldr r1, AShield
	ldr r2, var8004
	strh r1, [r2]
	mov r0, r4
	mov r1, #0xB
	ldr r3, setattr
	bl Jump
	mov r0, r4
	ldr r3, calcstats
	bl Jump
	b BackEnd

Regenerator:
GetHP:
	add r3, #0x28
	add r3, r1, r3
	mov r1, #0x20
	mul r0, r1
	mov r1, #0x60
	push {r3}
	bl Divide
	pop {r3}
	ldrh r1, [r3]
	add r0, r0, r1
	b CheckHP

CheckDelta:
	cmp r0, #[B]0xC0 [/B]	/*Index number of your ability Delta Stream*/
	beq Delta
	b CheckDesolate

CheckHP:
	ldrh r2, [r3, #0x4]
	cmp r0, r2
	ble StoreHP

MaxHP:
	mov r0, r2

StoreHP:
	strh r0, [r3]

BufferHealthChange:
	ldr r2, .CommandTable
	ldrb r1, [r4]
	ldr r0, .RamLoc
	ldr r0, [r0]
	add r0, r1, r0
	add r0, #0x58
	ldrb r0, [r0]
	lsl r0, r0, #0x2
	add r0, r0, r2
	ldrb r2, [r0]
	mov r0, r1
	mul r0, r6
	add r0, r0, r3
	str r0, [sp]
	mov r0, #0x0

HealthChangeIndex:
	mov r1, #0x2A

Success:
	ldr r3, .Return3
	bx r3

Divide:
	ldr r3, .DivideLoc
	bx r3

CheckDesolate:
	cmp r0, #[B]0xBF [/B]	/*Index number of yout ability Desolate Land*/
	beq Desolate

CheckPrimordial:
	cmp r0, #[B]0xBE[/B] 	/*Index number of yout ability Primordial Sea*/
	beq Primordial
	b CheckAegi

NormalWeather:
	push {lr}
	bl ScriptPusher
	ldr r1, ActiveBS
	ldr r2, ScriptNormalWeather
	str r2, [r1]
	pop {pc}
	bl ScriptPoper
	b NoAbility

Delta:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xC0 [/B]	/*Index number of your ability Delta Stream*/
	bne NoAbility
	b ClearWeather
	
Desolate:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xBF[/B] 	/*Index number of your ability Desolate Land*/
	bne NoAbility
	b ClearWeather

Primordial:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xBE [/B]	/*Index number of your ability Primordial Sea*/
	bne NoAbility
	
ClearWeather:
	mov r0, #0x00
	strb r0, [r2]
	ldr r2, .CurrentWeather	
	mov r0, #0x00
	strb r0, [r2]
	b NormalWeather

ScriptPusher:
	ldr r0, ScriptPush
	bx r0

ScriptPoper:
	ldr r0, ScriptPop
	bx r0

Jump:
	mov pc, r3

.align 2
.CurrentWeather: .word 0x020243CC
.FreeRam: .word 0x0203E331
.Return: .word 0x08055A9F
.Return2: .word 0x08055AD3
.CommandTable: .word 0x08A20000
.RamLoc: .word 0x0202449C
.Return3: .word 0x08055AC7
.DivideLoc: .word 0x082E7541
ActiveBS: .word 0x02024214
ScriptNormalWeather: .word 0x08A1FCF0
ScriptPush: .word 0x0803FAFC+1
ScriptPop: .word 0x0803FB24+1
ABlade: .word 0xFD
AShield: .word 0xFE
MemLoc: .word 0x0202449C
getattr: .word 0x0806A518+1
Bank: .word 0x0202420B
PlayerParty: .word 0x020244EC
AIParty: .word 0x02024744
calcstats: .word 0x08068D0C+1
setattr: .word 0x0806ACAC+1
var8004: .word 0x020275D8 + (0x8004*2)

/*Insert 00 48 00 47 XX XX XX 08 00 00 at 0x55A94*/

This includes the check for the Primal weathers

Revert in the end of the battle :

Spoiler:

Note:

Spoiler:

Look great.And i have A problem You use the 1C animation make image change And when i change pokemon Will the image change?And when battle end?

kleenexfeu · Sep 30, 2015

AkimotoBubble said:
Look great.And i have A problem You use the 1C animation make image change And when i change pokemon Will the image change?And when battle end?

With the 0x1C animation the sprite will automatically update.
With the transform animation too, ~~though the palette of your poke will be slightly brighter (because of how transform animation works).~~ Fixed bright problem !

AkimotoBubble · Oct 4, 2015

kleenexfeu said:

UPDATE : 100% working afaik, here is :

Stance Change:

Spoiler:

Emerald :

Spoiler:

The battle scripts come first :

Spoiler:

Main routine : (same hook than mold break, we'll see later for compatibility)

Spoiler:

Code:

.thumb

Start:
push {r0-r7}
ldr r0, FreeRam
ldrb r1, [r0]
cmp r1, #0
bne Return
ldr r0, Bank
ldrb r0, [r0]
mov r5, r0
mov r1, #1
and r1, r0
cmp r1, #0
beq Player

AI:
ldr r6, AIParty
mov r1, #3
b CheckAegi

Player:
ldr r6, PlayerParty
mov r1, #0

CheckAegi:
ldr r0, MemLoc
ldr r0, [r0]
add r0, #0x60
ldrb r0, [r0, r1]
mov r1, #2
and r1, r5
cmp r1, #0
beq Continue
lsl r0, r0, #4
lsr r0, r0, #4
lsl r0, r0, #4

Continue:
lsr r0, r0, #0x4
mov r1, r6
mov r2, #0x64
mul r0, r2
add r0, r1
mov r1, #0xB
mov r4, r0
ldr r3, getattr
bl Jump
ldr r2, movedata
ldr r3, CurMove
ldrh r6, [r3]
ldr r1, KingShield
cmp r6, r1
beq AegiForms
lsl r1, r6, #1
add r1, r1, r6
lsl r1, r1, #2
add r1, r1, r2
add r1, #10
ldrb r3, [r1]
cmp r3, #2
bne CheckAegiForms2
b Return

AegiForms:
ldr r1, ABlade
cmp r0, r1
beq DoKing
b Return

CheckAegiForms2:
ldr r1, AShield
cmp r0, r1
beq DoBlade

Return:
pop {r0-r7}
Return2:
ldr r3, =0x8041A6C+1
bl Jump
lsl r0, r0, #0x18
lsr r2, r0, #0x18
cmp r2, #0
beq ReturnPos
ldr r0, =0x8046398+1
mov pc, r0

ReturnPos:
ldr r0, =0x8046072+1
mov pc, r0

DoBlade:
bl BData
ldr r1, ABlade
strh r1, [r5]
ldr r2, var8004
mov r7, r1
b ChangePokeParty

DoKing:
bl BData
ldr r1, AShield
strh r1, [r5]
ldr r2, var8004
mov r7, r1

ChangePokeParty:
strh r1, [r2]
mov r0, r4
mov r1, #0xB
ldr r3, setattr
bl Jump
mov r0, r4
ldr r3, calcstats
bl Jump

ChangeBattleStats:
mov r1, #0x54
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #2]
mov r1, #0x55
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #4]
mov r1, #0x56
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #6]
mov r1, #0x57
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #8]
mov r1, #0x58
mov r0, r4
ldr r3, getattr
bl Jump
strh r0, [r5, #0xA]

KeepAttackSafe:
ldr r3, ScriptPusher
bl Jump

ldr r1, ABlade
cmp r7, r1
bne ShieldScript

BladeScript:
ldr r2, BladeBS
b Store

ShieldScript:
ldr r2, ShieldBS

Store:
ldr r1, CurBS
str r2, [r1]
ldr r0, FreeRam
mov r1, #1
strb r1, [r0]
pop {r0-r7}
ldr r3, Test

Jump:
mov pc, r3

Jumpr4:
mov pc, r4

BData:
push {lr}
mov r1, #0x58
mul r5, r1
ldr r1, BattleData
add r5, r1
pop {pc}

.align 2
FreeRam: .word 0x0203E33C /*Freeram loc we need for stance change*/
BladeBS: .word 0x08______
ShieldBS: .word 0x08________
BattleData: .word 0x02024084
KingShield: .word 0x190
ABlade: .word 0x113		/*Index number Aegi blade*/
AShield: .word 0x142	/*Aegi shield*/
MemLoc: .word 0x0202449C
getattr: .word 0x0806A518+1
Bank: .word 0x0202420B
PlayerParty: .word 0x020244EC
AIParty: .word 0x02024744
calcstats: .word 0x08068D0C+1
setattr: .word 0x0806ACAC+1
var8004: .word 0x020275D8 + (0x8004*2)
ScriptPusher: .word 0x0803FAFC+1
CurMove: .word 0x020241EA
CurBS: .word 0x02024214
Test: .word 0x08046398+1

/*00 48 00 47 xx+1 xx xx 08 at 08046064. It should be include in Mold breaker*/

Modification of the "end" command :

Spoiler:

Switch out check :

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global regenerator
 
AbilityBuffer:
	add r0, r1, r3
	add r0, #0x20
	ldrb r0, [r0]

RegeneratorCheck:
	cmp r0, #[B]0x91 [/B]	/*Index number of your ability Regenerator*/
	beq Regenerator

NaturalCureCheck:
	cmp r0, #0x1E
	bne CheckDelta

NaturalCure:
	ldr r0, .Return
	bx r0

CheckAegi:
	push {r0-r7}
	ldr r0, Bank
	ldrb r0, [r0]
	mov r5, r0
	mov r1, #1
	and r1, r0
	cmp r1, #0
	beq Player

AI:
	ldr r7, AIParty
	mov r1, #3
	b CheckAegis

Player:
	ldr r7, PlayerParty
	mov r1, #0

CheckAegis:
	ldr r0, MemLoc
	ldr r0, [r0]
	add r0, #0x60
	ldrb r0, [r0, r1]
	lsr r0, r0, #0x4
	mov r1, r7
	mov r2, #0x64
	mul r0, r2
	add r0, r1
	mov r1, #0xB
	mov r4, r0
	ldr r3, getattr
	bl Jump
	ldr r1, ABlade
	cmp r0, r1
	beq Revert

BackEnd:
	pop {r0-r7}
	
NoAbility:
	ldr r0, .Return2
	bx r0

Revert:
	ldr r1, AShield
	ldr r2, var8004
	strh r1, [r2]
	mov r0, r4
	mov r1, #0xB
	ldr r3, setattr
	bl Jump
	mov r0, r4
	ldr r3, calcstats
	bl Jump
	b BackEnd

Regenerator:
GetHP:
	add r3, #0x28
	add r3, r1, r3
	mov r1, #0x20
	mul r0, r1
	mov r1, #0x60
	push {r3}
	bl Divide
	pop {r3}
	ldrh r1, [r3]
	add r0, r0, r1
	b CheckHP

CheckDelta:
	cmp r0, #[B]0xC0 [/B]	/*Index number of your ability Delta Stream*/
	beq Delta
	b CheckDesolate

CheckHP:
	ldrh r2, [r3, #0x4]
	cmp r0, r2
	ble StoreHP

MaxHP:
	mov r0, r2

StoreHP:
	strh r0, [r3]

BufferHealthChange:
	ldr r2, .CommandTable
	ldrb r1, [r4]
	ldr r0, .RamLoc
	ldr r0, [r0]
	add r0, r1, r0
	add r0, #0x58
	ldrb r0, [r0]
	lsl r0, r0, #0x2
	add r0, r0, r2
	ldrb r2, [r0]
	mov r0, r1
	mul r0, r6
	add r0, r0, r3
	str r0, [sp]
	mov r0, #0x0

HealthChangeIndex:
	mov r1, #0x2A

Success:
	ldr r3, .Return3
	bx r3

Divide:
	ldr r3, .DivideLoc
	bx r3

CheckDesolate:
	cmp r0, #[B]0xBF [/B]	/*Index number of yout ability Desolate Land*/
	beq Desolate

CheckPrimordial:
	cmp r0, #[B]0xBE[/B] 	/*Index number of yout ability Primordial Sea*/
	beq Primordial
	b CheckAegi

NormalWeather:
	push {lr}
	bl ScriptPusher
	ldr r1, ActiveBS
	ldr r2, ScriptNormalWeather
	str r2, [r1]
	pop {pc}
	bl ScriptPoper
	b NoAbility

Delta:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xC0 [/B]	/*Index number of your ability Delta Stream*/
	bne NoAbility
	b ClearWeather
	
Desolate:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xBF[/B] 	/*Index number of your ability Desolate Land*/
	bne NoAbility
	b ClearWeather

Primordial:
	ldr r2, .FreeRam
	ldrb r0, [r2]
	cmp r0, #[B]0xBE [/B]	/*Index number of your ability Primordial Sea*/
	bne NoAbility
	
ClearWeather:
	mov r0, #0x00
	strb r0, [r2]
	ldr r2, .CurrentWeather	
	mov r0, #0x00
	strb r0, [r2]
	b NormalWeather

ScriptPusher:
	ldr r0, ScriptPush
	bx r0

ScriptPoper:
	ldr r0, ScriptPop
	bx r0

Jump:
	mov pc, r3

.align 2
.CurrentWeather: .word 0x020243CC
.FreeRam: .word 0x0203E331
.Return: .word 0x08055A9F
.Return2: .word 0x08055AD3
.CommandTable: .word 0x08A20000
.RamLoc: .word 0x0202449C
.Return3: .word 0x08055AC7
.DivideLoc: .word 0x082E7541
ActiveBS: .word 0x02024214
ScriptNormalWeather: .word 0x08A1FCF0
ScriptPush: .word 0x0803FAFC+1
ScriptPop: .word 0x0803FB24+1
ABlade: .word 0xFD
AShield: .word 0xFE
MemLoc: .word 0x0202449C
getattr: .word 0x0806A518+1
Bank: .word 0x0202420B
PlayerParty: .word 0x020244EC
AIParty: .word 0x02024744
calcstats: .word 0x08068D0C+1
setattr: .word 0x0806ACAC+1
var8004: .word 0x020275D8 + (0x8004*2)

/*Insert 00 48 00 47 XX XX XX 08 00 00 at 0x55A94*/

This includes the check for the Primal weathers

Revert in the end of the battle :

Spoiler:

Solve the brightness of Transform anim:

Spoiler:

Note:

Spoiler:

Sorry where have You are documentation on the battle script commands for the "nop3"

kleenexfeu · Oct 4, 2015

AkimotoBubble said:
Sorry where have You are documentation on the battle script commands for the "nop3"

This might be what you're seeking for

pokefreak890 · Oct 6, 2015

okay so the upgraded sturdy worked and now im trying to do no guard so i got to the point where i had to insert 00 49 08 47 xx xx xx 08 00 00 at 046754 and i did that and my offset is A0A1A8 but i did it reverse so it should be A9A1A0 so when i test it i miss but when i put 00 instead of 08 i dont miss but the game freezes plz help

Trainer 781 · Oct 12, 2015

kleenexfeu said:
UPDATE : 100% working afaik, here is :

Stance Change:

Brilliant work on this! It is functioning properly.
You missed one case though - reversion during user faint.

I will port this to FR after you are able to do this case.

pokefreak890 · Oct 12, 2015

so i changed for no guard the cmp r 0x64 both of them to 82 in hex number of course and machamp is still missing plz help

kleenexfeu · Oct 12, 2015

KDS said:
Brilliant work on this! It is functioning properly.
You missed one case though - reversion during user faint.

I will port this to FR after you are able to do this case.

Yeah I have to hook in the faintpokemon command, I'll include that in the future along with the primal/mega weathers

Thanks for pointing me that out though as I already had forgot that point

Trainer 781 · Oct 13, 2015

Defiant/Competitive:

Spoiler:

Fire Red:-

Spoiler:

Battle Script at XXXXXX:

Spoiler:

String at PPPPPP:

Code:

FD 10 B4 E7 00 FD 19 00 E7 DC D5 E6 E4 E0 ED FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 FD 00 AB FF

Main ASM Routine:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global defiantcompetitive

Start:
                ldr r1, =0x2023D6B
                ldrb r1, [r1]
                push {r0}
                bl StringFunc
CheckFoeStatDropString:
                pop {r0}
                cmp r0, #0xD8
                bne Exit

CheckIfTargetIsAllyOrUser:
                ldr r0, =0x2023D6B
                ldrb r1, [r0]
                add r0, #0x1
                ldrb r2, [r0]
                mov r3, #0x1
                and r1, r3
                and r2, r3
                cmp r1, r2
                beq Exit

CheckAbility:
                mov r1, #0x58
                ldrb r2, [r0]
                mul r2, r1
                ldr r1, =0x2023c04
                add r1, r2
                ldrb r1, [r1]
                cmp r1, [U][B]#0xAD[/B][/U]   /*Index of Competitive*/
                beq Competitive
                cmp r1, [U][B]#0x81[/B][/U]   /*Index of Defiant*/
                bne Exit

Defiant:
                ldr r1, .StatBoostByte
                mov r0, #0x21
                b Common

Competitive:
                ldr r1, .StatBoostByte
                mov r0, #0x24

Common:
                
                strh r0, [r1]
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]
                bl ScriptPusher
                ldr r0, .StatBoostScript
                str r0, [r4]
                ldr r1, .StringArguement
                ldr r0, .StringOffset
                str r0, [r1]
                b Exit2

Exit:
                
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]

Exit2:
                mov r0, #0x1
                strb r0, [r5, #0x7]
                pop {r4,r5}
                pop {r0}
                bx r0

ScriptPusher:
                ldr r1, =0x08017545
                bx r1
StringFunc:
                ldr r2, =0x080173AD
                bx r2
.align 2
.StatBoostScript: .word [B]0x8XXXXXX[/B]
.StatBoostByte: .word 0x2023FDE
.StringArguement: .word 0x203C020
.StringOffset: .word [B]0x8PPPPPP[/B]

@At x1fe5c: 00 49 08 47 ZZ+1 ZZ ZZ 08, where ZZZZZZ is the address of routine.

Will add the case of Intimidate later.

kleenexfeu · Oct 14, 2015

KDS said:

Defiant/Competitive:

Spoiler:

Fire Red:-

Spoiler:

Battle Script at XXXXXX:

Spoiler:

String at PPPPPP:

Code:

FD 10 B4 E7 00 FD 19 00 E7 DC D5 E6 E4 E0 ED FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 FD 00 AB FF

Main ASM Routine:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global defiantcompetitive


CheckFoeStatDropString:
                pop {r0}
                cmp r0, #0xD8
                bne Exit

CheckIfTargetIsAllyOrUser:
                ldr r0, =0x2023D6B
                ldrb r1, [r0]
                add r0, #0x1
                ldrb r2, [r0]
                mov r3, #0x1
                and r1, r3
                and r2, r3
                cmp r1, r2
                beq Exit

CheckAbility:
                mov r1, #0x58
                ldrb r2, [r0]
                mul r2, r1
                ldr r1, =0x2023c04
                add r1, r2
                ldrb r1, [r1]
                cmp r1, [U][B]#0xAD[/B][/U]   /*Index of Competitive*/
                beq Competitive
                cmp r1, [U][B]#0x81[/B][/U]   /*Index of Defiant*/
                bne Exit

Defiant:
                ldr r1, .StatBoostByte
                mov r0, #0x21
                b Common

Competitive:
                ldr r1, .StatBoostByte
                mov r0, #0x24

Common:
                
                strh r0, [r1]
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]
                bl ScriptPusher
                ldr r0, .StatBoostScript
                str r0, [r4]
                ldr r1, .StringArguement
                ldr r0, .StringOffset
                str r0, [r1]
                b Exit2

Exit:
                
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]

Exit2:
                mov r0, #0x1
                strb r0, [r5, #0x7]
                pop {r4,r5}
                pop {r0}
                bx r0

ScriptPusher:
                ldr r1, =0x08017545
                bx r1

.align 2
.StatBoostScript: .word [B]0x8XXXXXX[/B]
.StatBoostByte: .word 0x2023FDE
.StringArguement: .word 0x203C020
.StringOffset: .word [B]0x8PPPPPP[/B]

@At x1fe60: 01 B4 00 00 F7 F7 A2 FA 00 48 00 47 ZZ+1 ZZ ZZ 08, where ZZZZZZ is the address of routine.

Will add the case of Intimidate later.

Wow thanks for that ! I struggled and failed so many times to do that, I really appreciate you've done this in a clean way !

Spherical Ice · Oct 18, 2015

kleenexfeu said:

For sturdy, the problem is the same than for defiant/competitive : display a message.
Display that message stop the multi hit move, and somehow makes the pokémon unbeatable for that turn, even if you don't use the 0x0202427C location

So I used the same way than protean to display the message :

Sturdy

Spoiler:

Emerald

Spoiler:

Handle damage:

Spoiler:

Handle fix damage (dragon rage, seismic toss, etc) :

Spoiler:

Display message:

Spoiler:

Notes:

Spoiler:

I've somewhat successfully ported this to FireRed (it only needed two routines), but I can't get it to display the message string.

Spoiler:

Any ideas?

kleenexfeu · Oct 19, 2015

Spherical Ice said:

I've somewhat successfully ported this to FireRed (it only needed two routines), but I can't get it to display the message string.

Spoiler:

Any ideas?

I can't check right now, but it could be a problem with the banks you're using.

Also, are you sure you're using the good string ? Some of them are blank for some reason, like the one use by earthquake, so that also might be the problem.

Last thing, did you test sturdy with moves like dragon rage/seismic toss ? That would be surprising that FR doesn't need the second routine since EM and FR use the same battle engine

Spherical Ice · Oct 19, 2015

kleenexfeu said:
I can't check right now, but it could be a problem with the banks you're using.

Oh, you might be right because I used the user's bank there, but even after I changed it to be the target's bank, it still doesn't display the message.

kleenexfeu said:
Also, are you sure you're using the good string ? Some of them are blank for some reason, like the one use by earthquake, so that also might be the problem.

I'm pretty sure the string I'm using is the endure one, yeah. I even changed it to one I know is a "correct" string and it didn't display, unfortunately.

kleenexfeu said:
Last thing, did you test sturdy with moves like dragon rage/seismic toss ? That would be surprising that FR doesn't need the second routine since EM and FR use the same battle engine

Yeah, Sturdy works with things like Dragon Rage and Seismic Toss. Note that it is branched to at two places, it just didn't need a unique routine.

pokefreak890 · Oct 19, 2015

Can someone plz show me what I'm doing wrong I still can't get no guard to work this is my code this is emerald btw

.text
.align 2
.thumb
.thumb_func
.global noguard

AbilityBufferUser:
push {r0}
ldr r0, .Bank
ldrb r0, [r0]
mov r1, #0x58
ldr r2, .BattleData
mul r0, r1
add r0, r0, r2
ldrb r0, [r0]
NoGuardCheckUser:
cmp r0, #0x54 ( the place I'm putting my no guard)
beq AutoHit
AbilityBufferTarget:
ldr r0, .Bank
add r0, #0x1
ldrb r0, [r0]
mul r0, r1
add r0, r0, r2
ldrb r0, [r0]
NoGuardCheckTarget:
cmp r0, #0x54 ( same as above mentioned)
beq AutoHit
ToxicCheck:
ldr r0, .MoveLoc
ldrh r0, [r0]
cmp r0, #0x5C
bne InvulnerableCheck
PoisonCheck:
ldr r0, .Bank
ldr r0, [r0]
mov r1, #0x58
ldr r2, .BattleData
mul r0, r1
add r2, r0, r2
ldrb r1, [r0, #1]
ldrb r0, [r0, #2]
cmp r0, #0x3
beq AutoHit
cmp r1, #0x3
beq AutoHit
InvulnerableCheck:
pop {r0}
bl Method
lsl r0, r0, #0x18
cmp r0, #0x0
bne Miss
Return:
ldr r1, .Return
bx r1
AutoHit:
pop {r0}
ldr r1, .Return2
bx r1
Miss:
ldr r1, .Return3
bx r1
Method:
ldr r1, .MethodLoc
bx r1

.align 2

.Bank: .word 0x0202420B
.BattleData: .word 0x020240A4
.MoveLoc: .word 0x020241EA
.Return: .word 0x08046761
.Return2: .word 0x080469CB
.Return3: .word 0x080469D3
.MethodLoc: .word 0x080464AD

kleenexfeu · Oct 20, 2015

Spherical Ice said:
Oh, you might be right because I used the user's bank there, but even after I changed it to be the target's bank, it still doesn't display the message.

I'm pretty sure the string I'm using is the endure one, yeah. I even changed it to one I know is a "correct" string and it didn't display, unfortunately.

Yeah, Sturdy works with things like Dragon Rage and Seismic Toss. Note that it is branched to at two places, it just didn't need a unique routine.

Return2: .word 0x801F216+1 should be 0x801F294+1, though I doubt it would solve the problem

Also I have a little update for Protean, it's a bit tricky but now the message lasts longer :

Update:

Spoiler:

Spherical Ice · Oct 20, 2015

kleenexfeu said:
Return2: .word 0x801F216+1 should be 0x801F294+1, though I doubt it would solve the problem

I don't think that's right, when I change it to that Sturdy doesn't work at all (moves that would inflict damage greater than the target's HP, which should trigger the endure BS, just faint it).

kleenexfeu · Oct 25, 2015

KDS said:

Defiant/Competitive:

Spoiler:

Fire Red:-

Spoiler:

Battle Script at XXXXXX:

Spoiler:

String at PPPPPP:

Code:

FD 10 B4 E7 00 FD 19 00 E7 DC D5 E6 E4 E0 ED FE E6 D5 DD E7 D9 D8 00 DD E8 E7 00 FD 00 AB FF

Main ASM Routine:

Spoiler:

Code:

.text
.align 2
.thumb
.thumb_func
.global defiantcompetitive


CheckFoeStatDropString:
                pop {r0}
                cmp r0, #0xD8
                bne Exit

CheckIfTargetIsAllyOrUser:
                ldr r0, =0x2023D6B
                ldrb r1, [r0]
                add r0, #0x1
                ldrb r2, [r0]
                mov r3, #0x1
                and r1, r3
                and r2, r3
                cmp r1, r2
                beq Exit

CheckAbility:
                mov r1, #0x58
                ldrb r2, [r0]
                mul r2, r1
                ldr r1, =0x2023c04
                add r1, r2
                ldrb r1, [r1]
                cmp r1, [U][B]#0xAD[/B][/U]   /*Index of Competitive*/
                beq Competitive
                cmp r1, [U][B]#0x81[/B][/U]   /*Index of Defiant*/
                bne Exit

Defiant:
                ldr r1, .StatBoostByte
                mov r0, #0x21
                b Common

Competitive:
                ldr r1, .StatBoostByte
                mov r0, #0x24

Common:
                
                strh r0, [r1]
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]
                bl ScriptPusher
                ldr r0, .StatBoostScript
                str r0, [r4]
                ldr r1, .StringArguement
                ldr r0, .StringOffset
                str r0, [r1]
                b Exit2

Exit:
                
                ldr r0, [r4]
                add r0, #0x5
                str r0, [r4]

Exit2:
                mov r0, #0x1
                strb r0, [r5, #0x7]
                pop {r4,r5}
                pop {r0}
                bx r0

ScriptPusher:
                ldr r1, =0x08017545
                bx r1

.align 2
.StatBoostScript: .word [B]0x8XXXXXX[/B]
.StatBoostByte: .word 0x2023FDE
.StringArguement: .word 0x203C020
.StringOffset: .word [B]0x8PPPPPP[/B]

@At x1fe60: 01 B4 00 00 F7 F7 A2 FA 00 48 00 47 ZZ+1 ZZ ZZ 08, where ZZZZZZ is the address of routine.

Will add the case of Intimidate later.

I think you're overwriting 0x801FE6E with your hook, which is pointed by a conditionnal branch at 0x801FE38, perhaps this should be corrected

Trainer 781 · Oct 25, 2015

kleenexfeu said:
I think you're overwriting 0x801FE6E with your hook, which is pointed by a conditionnal branch at 0x801FE38, perhaps this should be corrected

Fixed. Kudos!

DraconianWing · Oct 28, 2015

Posting to have this routine checked. It's a modified version of MrDS's Toxic Boost + Flare Boost routine for Emerald. Since only Toxic Boost is the ability in the routine planned to be added in SE, I've made attempts to change it so that Flare Boost and anything that relates to it in the code is gone. Index number(s) have been changed accordingly:

Code:

.text
.align 2
.thumb
.thumb_func
.global statusboostabilities
 
Main:
    ldrb r0, [r1]
    cmp r0, #0x81
    beq ToxicBoost
    cmp r0, #0x3E
    bne MarvelScaleCheck
Guts:
CheckStatus:
    ldr r0, [r6, #0x4C]
    cmp r0, #0x0
    beq MarvelScaleCheck
GutsReturn:
    ldr r0, .Return
    bx r0
ToxicBoost:
    ldr r0, [r6, #0x4C]
CheckPoison:
    cmp r0, #0x8
    beq AttackBoost
    cmp r0, #0x80
    bne MarvelScaleCheck
AttackBoost:
    lsr r0, r7, #0x1
    add r7, r0, r7
    b MarvelScaleCheck
CheckBurn:
    cmp r0, #0x10
    bne MarvelScaleCheck
MarvelScaleCheck:
    ldr r0, .Return2
    bx r0
 
.align 2
.Return: .word 0x08069909
.Return2: .word 0x08069917

MrDollSteak · Oct 28, 2015

DraconianWing said:
Posting to have this routine checked. It's a modified version of MrDS's Toxic Boost + Flare Boost routine for Emerald. Since only Toxic Boost is the ability in the routine planned to be added in SE, I've made attempts to change it so that Flare Boost and anything that relates to it in the code is gone. Index number(s) have been changed accordingly:

Code:

.text .align 2 .thumb .thumb_func .global statusboostabilities Main: ldrb r0, [r1] cmp r0, #0x81 beq ToxicBoost cmp r0, #0x3E bne MarvelScaleCheck Guts: CheckStatus: ldr r0, [r6, #0x4C] cmp r0, #0x0 beq MarvelScaleCheck GutsReturn: ldr r0, .Return bx r0 ToxicBoost: ldr r0, [r6, #0x4C] CheckPoison: cmp r0, #0x8 beq AttackBoost cmp r0, #0x80 bne MarvelScaleCheck AttackBoost: lsr r0, r7, #0x1 add r7, r0, r7 b MarvelScaleCheck CheckBurn: cmp r0, #0x10 bne MarvelScaleCheck MarvelScaleCheck: ldr r0, .Return2 bx r0 .align 2 .Return: .word 0x08069909 .Return2: .word 0x08069917

It'd be better just to PM me that. You can also get rid of check burn. But yeah not the best place for it because it can confuse people.

Code: Ability Resource Thread

More options

AkimotoBubble

kleenexfeu

AkimotoBubble

kleenexfeu

pokefreak890

The One that will make everything great

Trainer 781

Guest

pokefreak890

The One that will make everything great

kleenexfeu

Trainer 781

Guest

kleenexfeu

Spherical Ice

kleenexfeu

Spherical Ice

pokefreak890

The One that will make everything great

kleenexfeu

Spherical Ice

kleenexfeu

Trainer 781

Guest

DraconianWing

MrDollSteak

Formerly known as 11bayerf1