Quick Research & Development Thread

[RichterSnipes]

Faster Game Saving [FR]

Starting with Gen II, attempting to update the save on your current file would tell you that "There is already a save file. Is it OK to overwrite?" This needless extra step remained until Gen V, when it reverted the process back to one step.

To skip this step and save after just one prompt, change the byte at 0x6F874 from 0A to 56. This only applies to saving over your current profile. If you start a new game and try to save over the old profile, you'll still receive the extended overwrite warning.

Explanation: The subroutine at 0x6F86C gets loaded if the game detects there's already a save file. First it checks if the profile is different from the current one. If it's the same profile, it branches to 0x6F88C. This is indicated in hex by 0A D1. After branching, it'll load the "There is already a saved file" text string and corresponding subroutine.

What this change does is make the game branch instead to 0x6F924, which bypasses the already-present save subroutine and skips straight to saving the game.

I'm still not that good at ASM. If anything needs correcting, feel free to do so!

 

[dGxx]

I made a script with the help of some asm made by FBI, he had a custom wild battle asm that helped me create a very cool and desirable event where I give away a pokemon and in return I would get a perfect iv pokemon right back. I made this for FIRE RED obviously and here is the script I made and I need some help with one thing for perfection's sake.

Spoiler:

//this script will test the release imperfect/fight perfect pokemon script

#dyn 0x752000

#org @main
lock
faceplayer
msgbox @msg-ask
callstd MSG_YESNO
compare LASTRESULT NO
if == jump @end
msgbox @whichpoke-msg
callstd MSG_NORMAL
fadescreen FADEOUT_BLACK
special 0x9f // store a pokemon from a selection screen
waitspecial
compare 0x8004 0x6 //if player presses B, it cancels selection screen
if >= jump @canceled
special2 0x8005 0xBA // takes pk's id no. AND stores it in 0x8005
compare 0x8005 0x95 // if player chose a dragonite, it continues
if == jump @choseright
jump @end2 //if player didn't choose a dragonite, it ends

#org @choseright
msgbox @msg-take
callstd MSG_NOCLOSE
checksound
cry 0x8005 0x0
msgbox @msg-ok
callstd MSG_NORMAL
waitcry
copyvar 0x8004 0x8005
special 0xbb // removes the selected pkmn from party
call @fightpokemon
release
end

#org @canceled
msgbox @msg-cancel
callstd MSG_NOCLOSE
release
end

#org @end
msgbox @msg-saidno
callstd MSG_NOCLOSE
release
end

#org @end2
msgbox @not-poke
callstd MSG_NOCLOSE
release
end

#org @fightpokemon
setflag 0x807
special BATTLE_PIXELLATE
setvar 0x40FF 0x1
call @shinyornot
setvar 0x8000 0x93 // dratini
setvar 0x8001 0x5 // level 5
setvar 0x8002 0x0 //item
setvar 0x8003 0x1 // first attack (1 - pound)
setvar 0x8004 0x0 // second attack
setvar 0x8005 0x0 // third attack
setvar 0x8006 0x0 // fourth attack
setvar 0x8007 0x1f //ivs
setvar 0x8008 0x1f //
setvar 0x8009 0x1f
setvar 0x800a 0x1f
setvar 0x800b 0x1f
setvar 0x800c 0x1f
setvar 0x800d 0x1f //ivs
callasm 0x8780201
waitspecial
clearflag 0x807
fadescreen FADEOUT_BLACK
//disappear 0x //person no.
//setflag 0x //flag of person id
waitbutton
fadescreen FADEIN_BLACK
setvar 0x8003 0x0 // needs to be set back to 0 or else shinies appear after giveaway(thanks to HACKMEW's shinyzer)
setvar 0x40FF 0x0
return

#org @shinyornot
random 2
compare LASTRESULT 1
if == call @shiny
compare LASTRESULT 0
if == call @notshiny
return

#org @shiny
applymovement PLAYER @p
pauseevent 0x0
setvar 0x800f 0x1
return

#org @notshiny
setvar 0x800f 0x0
return

// strings
#org @not-poke
= That's not a Dragonite!\nCome again!

#org @msg-cancel
= Ok, come again!

#org @msg-saidno
= Come back with a Dragonite!

#org @msg-ok
= OK, I'm done!

#org @msg-take
= OK, I got your \v\h02!

#org @msg-ask
= It needs a Dragonite!\nWant to give Dragonite away?

#org @whichpoke-msg
= Choose a Dragonite!

#org @p
m say_:) end

Now, what I need help with is that I used special 0xbb. It is supposed to store the pokemon I selected into daycare, how I do I delete the daycare stored pokemon so there is no choice of getting it back, the whole point I made this was to get rid of the imperfect pokemon to fight a perfect version of it to re-raise. Thanks guys!

 

[Super Versekr Dark]

Pointer to expand object effect tables and limiter:

For Ruby:

Table:

AXVE- 0x1FCDE4

Limiters:

0x0803E2F8: 00 00 00 00

For Fire Red:

Table:

BPRE- 0x2528BC

Limiters:

0x08042508: 00 00 00 00

0x0804152C: 00 00 00 00

Credits to: JPAN

Spoiler:

 

[Dr. Seuss]

Update the AI Priority move effects table [FR]
If you open a trainer editor and you edit aany trainer, you'll notice there's an option for "Trainer AI". By default, most of trainers are set in 0, and important trainers like Gym Leaders have this set to 7. There's a good explanation about how to setup the trainer AI in this post made by Samu from Whack a Hack forums (In spanish). Well, the point of this post is not that research.

If you set the trainer AI to 7, any trainer with that AI will start the battle giving priority to some moves that set the battle, like poisoning your Pokémon, increasing their speed, attack stats, etc. There is a table of move effects located at 0x81DBAA7 with a set of 0x37 move effects that have priority over other move effects during the beggining of the battle. The table has the following entries.

        .byte EFFECT_ATTACK_UP
	.byte EFFECT_DEFENSE_UP
	.byte EFFECT_SPEED_UP
	.byte EFFECT_SPECIAL_ATTACK_UP
	.byte EFFECT_SPECIAL_DEFENSE_UP
	.byte EFFECT_ACCURACY_UP
	.byte EFFECT_EVASION_UP
	.byte EFFECT_ATTACK_DOWN
	.byte EFFECT_DEFENSE_DOWN
	.byte EFFECT_SPEED_DOWN
	.byte EFFECT_SPECIAL_ATTACK_DOWN
	.byte EFFECT_SPECIAL_DEFENSE_DOWN
	.byte EFFECT_ACCURACY_DOWN
	.byte EFFECT_EVASION_DOWN
	.byte EFFECT_CONVERSION
	.byte EFFECT_LIGHT_SCREEN
	.byte EFFECT_SPECIAL_DEFENSE_UP_2
	.byte EFFECT_FOCUS_ENERGY
	.byte EFFECT_CONFUSE
	.byte EFFECT_ATTACK_UP_2
	.byte EFFECT_DEFENSE_UP_2
	.byte EFFECT_SPEED_UP_2
	.byte EFFECT_SPECIAL_ATTACK_UP_2
	.byte EFFECT_SPECIAL_DEFENSE_UP_2
	.byte EFFECT_ACCURACY_UP_2
	.byte EFFECT_EVASION_UP_2
	.byte EFFECT_ATTACK_DOWN_2
	.byte EFFECT_DEFENSE_DOWN_2
	.byte EFFECT_SPEED_DOWN_2
	.byte EFFECT_SPECIAL_ATTACK_DOWN_2
	.byte EFFECT_SPECIAL_DEFENSE_DOWN_2
	.byte EFFECT_ACCURACY_DOWN_2
	.byte EFFECT_EVASION_DOWN_2
	.byte EFFECT_REFLECT
	.byte EFFECT_POISON
	.byte EFFECT_PARALYZE
	.byte EFFECT_SUBSTITUTE
	.byte EFFECT_LEECH_SEED
	.byte EFFECT_MINIMIZE
	.byte EFFECT_CURSE
	.byte EFFECT_SWAGGER
	.byte EFFECT_CAMOUFLAGE
	.byte EFFECT_YAWN
	.byte EFFECT_DEFENSE_CURL
	.byte EFFECT_TORMENT
	.byte EFFECT_FLATTER
	.byte EFFECT_WILL_O_WISP
	.byte EFFECT_INGRAIN
	.byte EFFECT_IMPRISON
	.byte EFFECT_TEETER_DANCE
	.byte EFFECT_TICKLE
	.byte EFFECT_COSMIC_POWER
	.byte EFFECT_BULK_UP
	.byte EFFECT_CALM_MIND
	.byte EFFECT_CAMOUFLAGE

The pointer of this table is located at 0x81DBA96 so you can repoint the table and add new entries to the table so trainers with a high Ai might use moves on this table firstly.

 

[El Diabeetus]

I combined my work with the one from Doesnt. As a result, there are less bytes to write into freespace.
So, here's what to do to give exp points when you catch a pokemon:
1-The bytes to put into freespace: 2E E0 3F 02 02 00 2E 0C 3C 02 02 00 2E 0D 3C 02 02 00 23 00 F1 63 9A 1D 08 28 58 9A 1D 08

2-The bytes to replace at 1D9A53: 41 XX XX XX 08 (XX = pointer to the code above).

3-Just like Doesnt wrote earlier, replace the bytes at 15A68 with A1 5A 01 08.

It should work without problems, as I tested it before posting.

Thanks to Doesnt for telling me how to fix a music issue.

Is there a way to get around Rattata appearing as the captured Pokémon if you have an extended Dex?

 

[colonelsalt]

[FR] Suppress Pokédex screen on new Pokémon capture
To prevent the Pokédex screen/animation from showing after catching a new Pokémon, nop the 22 bytes at 0x106B7A (that is, up to and including 0x106B8F). This will jump straight to the nickname prompt after a new Pokémon is caught (but will still show the "Pokémon X was added to the Pokédex" text if left unedited).

 

[Burtle]

Change Vs Seeker Step Requirement (FR)
Change 0x0810C50E to your number in hex

 

[Joseph 91]

Is there a way to get around Rattata appearing as the captured Pokémon if you have an extended Dex?

To prevent Rattata from appearing in the Pokedex and appearing the new captured Pokémon, you must expand the Habitats Table using a Hexadecimal editor and add each new Pokémon in the Habitats ... You can use PGE to add each new Pokémon to the habitats.

To find out where the Habitats table is located, and to learn more about it, go to the Froosty The_learner post.
FIRE RED habitat editing: https://www.pokecommunity.com/threads/379667

 

[DarkCyborg]

Making the EVs more "RBY/GSC-like" on FireRed

RBY and GSC are known for supporting "full EV spread", as the 510 EV limit didn't existed at the time. Bringing back the old Stat Exp system would be a very hard task, but I found a way to simulate the full EVs from past gens by limitting the max EV to 63 and reducing the EV divider from 4 to 1 (of course, removing the 510 EV limit would be a better solution, but I haven't found a way to do that with binary hacking).

This solution works on FireRed.

Step 1) Limit the EV cap to 63

From Touched's tutorial:
Address 0x0439FC = 0x3F (63)
Address 0x043A02 = 0x3F (63)

Step 2) Change EV divider to 1

I owe this one to Mr.Pkmn posting the hex addresses to do that. In that case, he shows how to change the EV divider from 4 to 2.

To make it 1, I have made some tests to find a value that A) stats would be correctly divided by 1 and B) would not screw up the stats (this one is dedicated to the HP EV divider).

The values I found are completely empirical, I have no idea of why they have worked and I haven't found any glitches until now (I have not tested link battles on my hack yet).

Here are the changes:

Address 0x03E582 = 0x02 (HP)
Address 0x03E5CE = 0x0F (ATK)
Address 0x03E614 = 0x0F (DEF)
Address 0x03E65A = 0x0F (SPD)
Address 0x03E6A0 = 0x0F (SAT)
Address 0x03E6E6 = 0x0F (SDE)


Credits:
- Touched
- Mr.Pkmn
________________

KNOWN PROBLEMS:

About that 63 limit... well, a Pokémon won't get past it by gaining EV by battle. However, Vitamins (HP Up, Protein, etc.) will completely ignore that, so your HP can reach 100 EV with HP Up (and the same for other stats).
For now, the best solution I have is to remove the access to every vitamin from the game with AdvanceMap, so you'll get EVs only by battle. I really don't know how to change the max EV you can get with vitamins (default = 100).

 

[Zeturic]

Static Levels For In-Game Trades [FR]

EDIT: Since this is just a simple byte change, I'm keeping this up, but I suggest you use this instead, which allows for this and more.

Prior to Gen V, Pokemon you receive from in-game trades will be at the same level as the Pokemon you traded. From Black and White onwards, however, they come at a particular level. To get that in FR, simply make the following change:

0x08053B5E: 3A 20 28 5C C0 46 C0 46 C0 46 C0 46 C0 46

To actually set the level for a particular Pokemon, you'll need a hex editor and a calculator. In an unmodified FR 1.0 ROM, sIngameTrades is stored at 0x0826CF8C. Each in game trade takes 0x3C bytes, and the level is stored at offset 0x3A from the start of the struct. So you'll need to calculate 0x0826CF8C + 0x3C * id + 0x3A, where id is the index of the in-game trade you're modifying (e.g. Reyley's Mimien is 0, and Norma's Tangela is 7). Pull up the resulting address in a hex editor, and modify that byte to set the level for that Pokemon.

Since this uses some of the padding bytes in the existing struct which were zeroed out (because they were originally unused), you'll need to set levels for all of them or they'll come at level 0.

If you have any problems, let me know.

 

[ME604]

Would anyone be able to provide or point me to a tutorial (inside or out of this thread) on extending the regional dex limit (past 255) or creating a completely custom regional dex in Fire Red?

 

[mgriffin]

Would anyone be able to provide or point me to a tutorial (inside or out of this thread) on extending the regional dex limit (preferably past 255) or creating a completely custom regional dex in Fire Red?

Not past 255, but this thread from earlier this week might help.

 

[Spherical Ice]

[FR] Remove TM/HM PP replenishing
If you want to port the behaviour of TMs/HMs' interaction with PP from Gen V+ to FireRed, where teaching a move retains its current PP, assemble and insert the following routine:

.thumb

.equ free_space, 0x @ Replace with your desired address
.equ move_data, 0x250C04 @ Replace with the address of your move data
.equ rom, 0x08000000

.org 0x124F48, 0xFF
branch1:
    ldr r1, =(rom + hack1 + 1)
    bx r1
.pool

.org 0x125FC4, 0xFF
branch2:
    ldr r1, =(rom + hack2 + 1)
    bx r1
.pool

.org 0x1260B4, 0xFF
branch3:
    ldr r1, =(rom + hack3 + 1)
    bx r1
.pool

.org free_space, 0xFF
hack1:
    mov r1, r0
    lsl r1, r1, #0x10
    lsr r1, r1, #0x10
    mov r0, r5
    mov r2, r4
    bl set_move_and_pp
    ldr r0, =(rom + 0x124F56 + 1)
    bx r0
.pool

hack2:
    mov r0, r9
    ldrh r1, [r0, #0xE]
    mov r0, r6
    mov r2, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x125FD0 + 1)
    bx r0
.pool

hack3:
    mov r2, r0
    lsl r2, r2, #0x18
    lsr r2, r2, #0x18
    mov r0, r4
    mov r1, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x1260C2 + 1)
    bx r0
.pool

set_move_and_pp:
    push {r4,r5,lr}
    sub sp, sp, #4
    mov r5, r0
    mov r4, r2
    mov r0, sp
    strh r1, [r0]
    lsl r4, r4, #0x18
    lsr r4, r4, #0x18
    mov r1, r4
    add r1, #0xD
    mov r0, r5
    mov r2, sp
    bl pokemon_setattr

    add r4, #0x11
    mov r0, r5
    mov r1, r4
    bl pokemon_getattr
    lsl r0, r0, #0x18
    lsr r3, r0, #0x18

    mov r0, sp
    ldrh r0, [r0]
    lsl r2, r0, #1
    add r2, r2, r0
    lsl r2, r2, #2
    ldr r0, =(rom + move_data + 4) @ move_data.pp
    add r2, r2, r0
    ldrb r0, [r2]

    cmp r3, r0
    blt dont_change_pp

    mov r0, r5
    mov r1, r4
    bl pokemon_setattr
    
dont_change_pp:
    add sp, sp, #4
    pop {r4,r5}
    pop {r0}
    bx r0
.pool

pokemon_getattr:
    ldr r3, =(rom + 0x3FBE8 + 1)
    bx r3
.pool

pokemon_setattr:
    ldr r3, =(rom + 0x4037C + 1)
    bx r3
.pool

EDIT 1st June 2020: Added two other hooks which are needed to ensure the same behaviour is applied when the player skips the TM learning animation.

 

[Super Versekr Dark]

Choice Specs [Ruby]

Spoiler:

FR: 08 98 01 28 04 D0 02 28 06 D0 78 08 3F 18 03 E0 40 46 43 08 1B 18 98 46 00 48 00 47 59 EF 03 08

3EF4A: 01 48 00 47 00 00 XX+1 XX XX 08

RB: 08 98 01 28 04 D0 02 28 06 D0 78 08 3F 18 03 E0 40 46 43 08 1B 18 98 46 00 48 00 47 F1 BC 03 08

3BCE2: 01 48 00 47 00 00 XX+1 XX XX 08

Choice Scarf [Ruby]

Spoiler:

XX XX XX 08 = Item Data

FR: 18 2E 12 D0 1D 2E 13 D1 E0 8D 10 B4 09 4C 00 04 00 0C 2C 21 48 43 00 19 C0 7C 10 BC 02 28 07 D1 42 46 51 08 52 18 90 46 02 E0 42 46 52 08 90 46 01 49 08 47 XX XX XX 08 47 4E 01 08

14E3C: 00 49 08 47 XX+1 XX XX 08

RB: 18 2E 12 D0 1D 2E 13 D1 E0 8D 10 B4 09 4C 00 04 00 0C 2C 21 48 43 00 19 C0 7C 10 BC 02 28 07 D1 42 46 51 08 52 18 90 46 02 E0 42 46 52 08 90 46 01 49 08 47 XX XX XX 08 5F 31 01 08

13154: 00 49 08 47 XX+1 XX XX 08

Light Ball [Ruby]

Spoiler:

RB: At 3BDB8: 00 49 08 47 XX XX XX 08 00 00 00 00 00 00 00 00 00 00

Rutina:

RB: 53 46 2D 2B 09 D0 41 2B 0C D1 30 88 68 38 00 04 00 0C 01 28 06 D8 04 49 08 47 30 88 19 28 01 D1 01 49 08 47 01 49 08 47 CB BD 03 08 CF BD 03 08

I don't have the routine since I took the data from the mrdollsteak database and adapted it to ruby

 

[Super Versekr Dark]

This information seems to be important enough and it's not mentioned in the main post, so I just took the liberty of bringing it here.

Forcing the Set Battle Style in Fire Red

Source.

Forcing the Set Battle Style in [Ruby]

1D8CFB: 28 66 8D 1D 08

 

[kalarie]

Didn't see this documented anywhere, so I thought I should share it here.

On the credits section in Fire Red:
The maps shown in the credits section are determined by a table at 0x414588. It's a table with 13 pointers, starting at 0x4143e8. Every entry has a length of 0x20.

The bytes that determine the starting point are as follows:
0x3 = The map bank
0x5 = The map number
0x9 = X starting coordinate
0xB = Y starting coordinate

Byte 0x11 to 0x14 of the entry determines the direction in which the camera moves:
00 00 01 00 = Down
00 00 FF FF = Up
01 00 00 00 = Right
FF FF 00 00 = Left
01 00 FF FF = Up-right Diagonally
01 00 01 00 = Down-right Diagonally
FF FF FF FF = Up-left Diagonally
FF FF 01 00 = Down-left Diagonally

That's all.

Credits to Spherical Ice.

 

[RichterSnipes]

[FR] Remove TM/HM PP replenishing
If you want to port the behaviour of TMs/HMs' interaction with PP from Gen V+ to FireRed, where teaching a move retains its current PP, assemble and insert the following routine:

Spoiler:

.thumb

.equ free_space, 0x @ Replace with your desired address
.equ move_data, 0x250C04 @ Replace with the address of your move data
.equ rom, 0x08000000

.org 0x124f48, 0xFF
branch:
    ldr r1, =(rom + hack + 1)
    bx r1
.pool

.org free_space, 0xFF
hack:
    mov r1, r0
    lsl r1, r1, #0x10
    lsr r1, r1, #0x10
    mov r0, r5
    mov r2, r4
    bl set_move_and_pp

return:
    ldr r0, =(rom + 0x124F56 + 1)
    bx r0    

.pool

set_move_and_pp:
    push {r4,r5,lr}
    sub sp, sp, #4
    mov r5, r0
    mov r4, r2
    mov r0, sp
    strh r1, [r0]
    lsl r4, r4, #0x18
    lsr r4, r4, #0x18
    mov r1, r4
    add r1, #0xD
    mov r0, r5
    mov r2, sp
    bl pokemon_setattr

    add r4, #0x11
    mov r0, r5
    mov r1, r4
    bl pokemon_getattr
    lsl r0, r0, #0x18
    lsr r3, r0, #0x18

    mov r0, sp
    ldrh r0, [r0]
    lsl r2, r0, #1
    add r2, r2, r0
    lsl r2, r2, #2
    ldr r0, =(rom + move_data + 4) @ move_data.pp
    add r2, r2, r0
    ldrb r0, [r2]

    cmp r3, r0
    blt dont_change_pp

    mov r0, r5
    mov r1, r4
    bl pokemon_setattr
    
dont_change_pp:
    add sp, sp, #4
    pop {r4,r5}
    pop {r0}
    bx r0
.pool

pokemon_getattr:
    ldr r3, =(rom + 0x3FBE8 + 1)
    bx r3
.pool

pokemon_setattr:
    ldr r3, =(rom + 0x4037C + 1)
    bx r3
.pool

There's an issue with this ASM routine, and it's similar to something I recall happening years ago with a different piece of ASM code.

If you press the B button to cancel out of the TM/HM "learning" animation, the PP amount for the taught move is completely filled up. I'm guessing that's not intended behavior?

 

[Spherical Ice]

There's an issue with this ASM routine, and it's similar to something I recall happening years ago with a different piece of ASM code.

If you press the B button to cancel out of the TM/HM "learning" animation, the PP amount for the taught move is completely filled up. I'm guessing that's not intended behavior?

Ah, I missed two other places where I need to hook. This is the updated routine, I have edited my original post with this too:

.thumb

.equ free_space, 0x @ Replace with your desired address
.equ move_data, 0x250C04 @ Replace with the address of your move data
.equ rom, 0x08000000

.org 0x124F48, 0xFF
branch1:
    ldr r1, =(rom + hack1 + 1)
    bx r1
.pool

.org 0x125FC4, 0xFF
branch2:
    ldr r1, =(rom + hack2 + 1)
    bx r1
.pool

.org 0x1260B4, 0xFF
branch3:
    ldr r1, =(rom + hack3 + 1)
    bx r1
.pool

.org free_space, 0xFF
hack1:
    mov r1, r0
    lsl r1, r1, #0x10
    lsr r1, r1, #0x10
    mov r0, r5
    mov r2, r4
    bl set_move_and_pp
    ldr r0, =(rom + 0x124F56 + 1)
    bx r0
.pool

hack2:
    mov r0, r9
    ldrh r1, [r0, #0xE]
    mov r0, r6
    mov r2, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x125FD0 + 1)
    bx r0
.pool

hack3:
    mov r2, r0
    lsl r2, r2, #0x18
    lsr r2, r2, #0x18
    mov r0, r4
    mov r1, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x1260C2 + 1)
    bx r0
.pool

set_move_and_pp:
    push {r4,r5,lr}
    sub sp, sp, #4
    mov r5, r0
    mov r4, r2
    mov r0, sp
    strh r1, [r0]
    lsl r4, r4, #0x18
    lsr r4, r4, #0x18
    mov r1, r4
    add r1, #0xD
    mov r0, r5
    mov r2, sp
    bl pokemon_setattr

    add r4, #0x11
    mov r0, r5
    mov r1, r4
    bl pokemon_getattr
    lsl r0, r0, #0x18
    lsr r3, r0, #0x18

    mov r0, sp
    ldrh r0, [r0]
    lsl r2, r0, #1
    add r2, r2, r0
    lsl r2, r2, #2
    ldr r0, =(rom + move_data + 4) @ move_data.pp
    add r2, r2, r0
    ldrb r0, [r2]

    cmp r3, r0
    blt dont_change_pp

    mov r0, r5
    mov r1, r4
    bl pokemon_setattr
    
dont_change_pp:
    add sp, sp, #4
    pop {r4,r5}
    pop {r0}
    bx r0
.pool

pokemon_getattr:
    ldr r3, =(rom + 0x3FBE8 + 1)
    bx r3
.pool

pokemon_setattr:
    ldr r3, =(rom + 0x4037C + 1)
    bx r3
.pool

Thanks for letting me know, and if there is anything else I've missed please let me know!

 

[RichterSnipes]

Ah, I missed two other places where I need to hook. This is the updated routine, I have edited my original post with this too:

Spoiler:

.thumb

.equ free_space, 0x @ Replace with your desired address
.equ move_data, 0x250C04 @ Replace with the address of your move data
.equ rom, 0x08000000

.org 0x124F48, 0xFF
branch1:
    ldr r1, =(rom + hack1 + 1)
    bx r1
.pool

.org 0x125FC4, 0xFF
branch2:
    ldr r1, =(rom + hack2 + 1)
    bx r1
.pool

.org 0x1260B4, 0xFF
branch3:
    ldr r1, =(rom + hack3 + 1)
    bx r1
.pool

.org free_space, 0xFF
hack1:
    mov r1, r0
    lsl r1, r1, #0x10
    lsr r1, r1, #0x10
    mov r0, r5
    mov r2, r4
    bl set_move_and_pp
    ldr r0, =(rom + 0x124F56 + 1)
    bx r0
.pool

hack2:
    mov r0, r9
    ldrh r1, [r0, #0xE]
    mov r0, r6
    mov r2, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x125FD0 + 1)
    bx r0
.pool

hack3:
    mov r2, r0
    lsl r2, r2, #0x18
    lsr r2, r2, #0x18
    mov r0, r4
    mov r1, r5
    bl set_move_and_pp
    ldr r0, =(rom + 0x1260C2 + 1)
    bx r0
.pool

set_move_and_pp:
    push {r4,r5,lr}
    sub sp, sp, #4
    mov r5, r0
    mov r4, r2
    mov r0, sp
    strh r1, [r0]
    lsl r4, r4, #0x18
    lsr r4, r4, #0x18
    mov r1, r4
    add r1, #0xD
    mov r0, r5
    mov r2, sp
    bl pokemon_setattr

    add r4, #0x11
    mov r0, r5
    mov r1, r4
    bl pokemon_getattr
    lsl r0, r0, #0x18
    lsr r3, r0, #0x18

    mov r0, sp
    ldrh r0, [r0]
    lsl r2, r0, #1
    add r2, r2, r0
    lsl r2, r2, #2
    ldr r0, =(rom + move_data + 4) @ move_data.pp
    add r2, r2, r0
    ldrb r0, [r2]

    cmp r3, r0
    blt dont_change_pp

    mov r0, r5
    mov r1, r4
    bl pokemon_setattr
    
dont_change_pp:
    add sp, sp, #4
    pop {r4,r5}
    pop {r0}
    bx r0
.pool

pokemon_getattr:
    ldr r3, =(rom + 0x3FBE8 + 1)
    bx r3
.pool

pokemon_setattr:
    ldr r3, =(rom + 0x4037C + 1)
    bx r3
.pool

Thanks for letting me know, and if there is anything else I've missed please let me know!

That seemed to do the trick. Thank you so much! This is an incredibly helpful complement to the hacks using infinite TMs.

 

[__fred__40]

In Fire Red,at 3C68DC the 18 stands for the width of the area lightened up by flash