RB (Blue): Never played it.
GS (Silver): Never played it.
RS (May): Cutesy rival, honestly takes the friend aspect well. You forgot her btw.
RS (Wally): ORAS makes him more substantial, but I would've honestly preferred Norman as a rival. Or even just May.
DP (Barry): If only I could get past how slow this game is, I could vote for certain here. (Get it? Because Barry's obsessed over speed?)
BW (Cheren + Bianca): Cheren's cool, Bianca's annoying. This is retained in B2W2. Also, you forgot N, otherwise this would be a solid vote for N above even Barry and Hau.
B2W2 (Hugh): DUDE, that was 5 years ago, GET OVER IT! (Referring to Hugh's stupid Plasma vendetta about a Purrloin that wasn't even his that got stolen well before the events of even BW.)
XY (Serena): Better than the other XY rivals, although Serena's disposition toward the player and Shauna's should be switched lest you play as Serena making your rival Calem. Also, you forgot her too.
XY (Shauna): Don't pick Serena unless you want to call Shauna gay.
XY (Tierno + Trevor): The worst rivals to come out of the games. One's a buffoon who only cares about his Swords Dancing Vice Gripping Crawdaunt, the other is a nerd who only cares about the Pokédex until Route 19 near the end of the game.
SM (Hau): Pretty nice friendly rival. Haven't played enough to see if he is bad, which means he probably isn't because I'm already done with the first island.
SM (Gladion): Haven't gotten there yet.
Final verdict: Cheren, Barry and Hau were the best. N is better if he even counts. Serena and May are close. Blue and Silver sound cool, but I haven't played any games before Gen 4, really, so they take the middle, alongside Wally, of the "good rival" 1/2 and the "bad rival" half, a major downfall from the good rival half, those being Shauna, Buffoon And Nerd, Bianca (too annoying) and Hugh (the one blemish in the imo best games of the pre-Mega timeline).