Report bugs and errors in unmodified Essentials version 21

[TACHAN]

Other bug:

Only if USENEWBATTLEMECHANICS = true

Hoopa used Nature Power
Nature Power turned in to Tri Attack, and appears error message:

Exception: NoMethodError
Message: undefined method `index' for nil:NilClass
PokeBattle_MoveEffects:4741:in `pbEffect'
PokeBattle_Battler:3118:in `pbUseMove'
PokeBattle_Battler:3117:in `logonerr'
PokeBattle_Battler:3117:in `pbUseMove'
PokeBattle_Battler:3348:in `pbProcessTurn'
PokeBattle_Battler:3347:in `logonerr'
PokeBattle_Battler:3347:in `pbProcessTurn'
PokeBattle_Battle:2944:in `pbAttackPhase'
PokeBattle_Battle:2941:in `each'
PokeBattle_Battle:2941:in `pbAttackPhase'

If you use Tri-Attack without being called by Nature Power, it works well and no error message appears.

 

[Lucidious89]

I found a minor error the other day with the move Spiky Shield. It deals damage to the Pokemon using the move, instead of the attacker. I was able to fix it by replacing some of the instances of the word "target" with "user" in the appropriate areas in PokeBattle_Battler. I don't have the project in front of me right now, though.

 

[TACHAN]

Bug?
My pokemon with level 100 doesn't increase EVs in battles.

 

[mewlover22]

has anyone fixed the hoppa issue and second is it just me or have the victory animations gotten faster when you gain exp.

 

[ptisnjunk95]

Hi, while investigating the Hoopa/Forfrou SystemStackError, I decided to add Hoopa and only hoopa (nothing else) to essentials. To add it I used Alakazam's Moveset to avoid compatibility with the other PBS files as shown below:

Spoiler:

[650]
Name=Hoopa
InternalName=HOOPA
Type1=PSYCHIC
Type2=GHOST
BaseStats=80,110,60,70,150,130
GenderRate=Genderless
GrowthRate=Slow
BaseEXP=14
EffortPoints=1,1,0,1,1,0
Rareness=3
Happiness=0
Abilities=SYNCHRONIZE,INNERFOCUS
HiddenAbility=MAGICGUARD
Moves=1,TELEPORT,1,KINESIS,1,CONFUSION,16,CONFUSION,18,DISABLE,22,MIRACLEEYE,24,ALLYSWITCH,28,PSYBEAM,30,REFLECT,34,TELEKINESIS,36,RECOVER,40,PSYCHOCUT,42,CALMMIND,46,PSYCHIC,48,FUTURESIGHT,52,TRICK
Compatibility=Undiscovered
StepsToHatch=30855
Height=0.5
Weight=9.0
Color=Pink
Kind=Mischief
Pokedex=It gathers things it likes and pushes them through its loop to teleport them to a secret place.
BattlerPlayerY=15
BattlerEnemyY=7
BattlerAltitude=1
Evolutions=

So I decided to Fill the Storage the check if it was Project Gen 6 or not. I got the error and the error log:

Spoiler:

Exception: SystemStackError
Message: stack level too deep
Event:80:in `fromSymbol'
Event:129:in `[]'
Pokemon_MultipleForms:183:in `call'
Pokemon_MultipleForms:6:in `form'
Pokemon_MultipleForms:973
Pokemon_MultipleForms:971:in `call'
Pokemon_MultipleForms:185:in `call'
Pokemon_MultipleForms:6:in `form'
Pokemon_MultipleForms:973
Pokemon_MultipleForms:971:in `call'

With the help of a friend, I'm trying to find the bug and fix it.

 

[Rot8er_ConeX]

In reference to the above comment:

EDIT: I've checked all Pokémon with Multiple forms in Gen 6, it appears that only Hoopa and Forfrou crash the game.

Which means it likely has to do with the "change back after a certain amount of time" code.

EDIT: Yep, I was right.

MultipleForms.register(:HOOPA,{
[COLOR="red"]"getForm"[/COLOR]=>proc{|pokemon|
   timenow=pbGetTimeNow
   if [COLOR="Red"]pokemon.form[/COLOR]>0 && (!pokemon.formTime ||
                         timenow.to_i>pokemon.formTime.to_i+60*60*24*3) # 3 days
     next 0
   end
   next
},

If the getForm function exists, the game will run that every time the you check the Pokemon's form. Including...in the getForm function.

 

[Sir_Tman]

I apear to be missing the Ability Text in my Summary Screen.

Spoiler:

 

[ptisnjunk95]

I apear to be missing the Ability Text in my Summary Screen.

Spoiler:

That's a secondary effect of Reposition Sprites. When you use it, it deletes the Abilities (as you can check on your pokemon.txt).

 

[Sir_Tman]

That's a secondary effect of Reposition Sprites. When you use it, it deletes the Abilities (as you can check on your pokemon.txt).

Ah Cheers mate and thus why i back up my psb.

DARN YOU ESSENTIALS V16.1

 

[ptisnjunk95]

Original Post
If you are looking for the final fix, it isn't. Don't use this code!!!!!
Also it would be great if someone give us feedback and some suggestions to try, and finnally manage this error.

Spoiler:

I made some results at Hoopa/Furfrou bug
I finally manage to add a Hoopa. However, you can't use Unbound form and Furfrou. And you still can't Debug -> Fill Storage Boxes
If you are looking for the final fix, it isn't. Don't use this code!!!!!
I only made changes on Pokemon_MultipleForms.

I tried adding a Hoopa without debugging. I get this error.

Spoiler:

---------------------------
Tears of Vengeance
---------------------------
Script 'Interpreter' line 276: RuntimeError occurred.

Script error within event 1, map 3 (MAP003):

Exception: SystemStackError

Message: Section110:5:in `pbGetTimeNow'stack level too deep

***Full script:

pbAddPokemon(:HOOPA,5)


Interpreter:243:in `pbExecuteScript'

Pokemon_MultipleForms:867

Pokemon_MultipleForms:866:in `call'

Pokemon_MultipleForms:185:in `call'

Pokemon_MultipleForms:6:in `form'

Pokemon_MultipleForms:868

Pokemon_MultipleForms:866:in `call'

Pokemon_MultipleForms:185:in `call'

Pokemon_MultipleForms:6:in `form'

Pokemon_MultipleForms:868


---------------------------
OK
---------------------------

As you can see it starts looping in those lines. Those lines are Furfrou's lines. Since the Form Changing is similar (The forms only last for limited time), I decided to add a Furfrou. You can Add a Furfrou without getting this error. But if you try Debug -> Change Form, appears another error that led me to line 5:

Original Essentials v16.1 Code (line 4)

Spoiler:

def form
    return @forcedform if @forcedform!=nil #this is line 5
    v=MultipleForms.call("getForm",self)
    if v!=nil
      self.form=v if !@form || v!=@form
      return v
    end
    return @form || 0
  end

I went to Hoopa and Furfrou's "Multiforms.register" and i added some parentheses to see that it could help:

Original Essentials v16.1 Code (Furfrou "getForm" Section):

Spoiler:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         timenow.to_i>pokemon.formTime.to_i+60*60*24*5) # 5 days
     next 0
   end
   next
}

My Edit (at red)

Spoiler:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         [COLOR="red"]([/COLOR]timenow.to_i>(pokemon.formTime.to_i+60*60*24*5[COLOR="Red"]))[/COLOR]) # 5 days
     next 0
   end
   next
}

And the same on Hoopa's:

Original Essentials v16.1 Code (Hoopa's "getForm" Section):

Spoiler:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         timenow.to_i>pokemon.formTime.to_i+60*60*24*3) # 3 days
     next 0
   end
   next
}

My Edit:

Spoiler:

"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   if pokemon.form>0 && (!pokemon.formTime ||
                         [COLOR="red"]([/COLOR]timenow.to_i>(pokemon.formTime.to_i+60*60*24*3[COLOR="Red"]))[/COLOR]) # 3 days
     next 0
     end
   next
}

Then I edited form at line 4, replacing nil for a "0" (Original code shown above):

Spoiler:

def form
    return @forcedform if @forcedform!=[COLOR="Red"]0[/COLOR]
    v=MultipleForms.call("getForm",self)
    if v!=nil
      self.form=v if !@form || v!=@form
      return v
    end
    return @form || 0
  end

And I successfully added a Hoopa.

Spoiler:

Then I tested the Prison Bottle to change his form, it says that Hoopa changed form, but it didn't. Then tried changing the form through Debug and gave this error:

Spoiler:

Also ocurred with Furfrou.

My friend decided to do it by a different way. Now Furfrou and Hoopa change forms, but in battle they return to form 0.

So ignoring what I've done before, my friend did this instead

Hoopa's Section

Spoiler:

MultipleForms.register(:HOOPA,{
"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   echo "Hoopa check"
   echo "Form Time : "
   echo pokemon.formTime
   echo "\ntimenow : "
   echo timenow.to_i
   echo "\nDiff : "
   echo "timenow.to_i - pokemon.formTime "
   echo "\n"
   if(timenow.to_i > pokemon.formTime.to_i + 432000)
       echo "yes\n"
   else echo "no\n"
   end
   if(!pokemon.formTime || timenow.to_i>pokemon.formTime.to_i+60*60*24*3) # 3 days
     next 0
   end
   next
},
"type2"=>proc{|pokemon|
   next if pokemon.form==0     # Confined
   next getID(PBTypes,:DARK)   # Unbound
},
"getBaseStats"=>proc{|pokemon|
   next if pokemon.form==0       # Confined
   next [80,160,60,80,170,130]   # Unbound
},
"height"=>proc{|pokemon|
   next if pokemon.form==0   # Confined
   next 65                   # Unbound
},
"weight"=>proc{|pokemon|
   next if pokemon.form==0   # Confined
   next 4900                 # Unbound
},
"getMoveList"=>proc{|pokemon|
   next if pokemon.form==0
   movelist=[[1,:HYPERSPACEFURY],[1,:TRICK],[1,:DESTINYBOND],[1,:ALLYSWITCH],
             [1,:CONFUSION],[6,:ASTONISH],[10,:MAGICCOAT],[15,:LIGHTSCREEN],
             [19,:PSYBEAM],[25,:SKILLSWAP],[29,:POWERSPLIT],[29,:GUARDSPLIT],
             [46,:KNOCKOFF],[50,:WONDERROOM],[50,:TRICKROOM],[55,:DARKPULSE],
             [75,:PSYCHIC],[85,:HYPERSPACEFURY]]
   for i in movelist
     i[1]=getConst(PBMoves,i[1])
   end
   next movelist
},
"kind"=>proc{|pokemon|
   next if pokemon.form==0   # Confined
   next _INTL("Djinn")       # Unbound
},
"onSetForm"=>proc{|pokemon,form|
   echo "Setting hoppa form\n"
   echo "Time : "
   echo pbGetTimeNow.to_i
   echo "\n"
   echo "To what form ? "
   echo form
   echo "\n"
   pokemon.formTime=pbGetTimeNow.to_i
   #pokemon.form = form
}
})

Furfrou Section

Spoiler:

MultipleForms.register(:FURFROU,{
"getForm"=>proc{|pokemon|
   timenow=pbGetTimeNow
   echo "Form Time : "
   echo pokemon.formTime
   echo "\ntimenow : "
   echo timenow.to_i
   echo "\n"
   
   if(timenow.to_i > pokemon.formTime + 432000)
       echo "yes\n"
     else echo "no\n"
    end
   
   
   if !pokemon.formTime || timenow.to_i>pokemon.formTime.to_i+432000 # 5 days
     #next 0
     pokemon.form = 0
   end
   next
},
"onSetForm"=>proc{|pokemon,form|
   pokemon.formTime= pbGetTimeNow.to_i
}
})

 

[The Master]

Hi guys! I found a working solution.

First of all, in PRISONBOTTLE ItemEffects script section, after scene.pbRefresh line, add this:

timenow=pbGetTimeNow.to_i
pokemon.formTime=(timenow+(60*60*24*3)).to_i

After this, in MultipleForms script section, replace the old HOOPA and FURFROU "getForm" with this code:

"getForm"=>proc{|pokemon|
next 1 if (pbGetTimeNow.to_i)<(pokemon.formTime.to_i)
next 0 if ((pokemon.formTime.to_i==0) || ((pbGetTimeNow.to_i)>=(pokemon.formTime.to_i)))
},

Don't forget to set this:

timenow=pbGetTimeNow.to_i
pokemon.formTime=(timenow+(60*60*24*5)).to_i

for Furfrou's grooming.

 

[ptisnjunk95]

Hi guys! I found a working solution.

First of all, in PRISONBOTTLE ItemEffects script section, after scene.pbRefresh line, add this:

timenow=pbGetTimeNow.to_i
pokemon.formTime=(timenow+(60*60*24*3)).to_i

After this, in MultipleForms script section, replace the old HOOPA and FURFROU "getForm" with this code:

"getForm"=>proc{|pokemon|
next 1 if (pbGetTimeNow.to_i)<(pokemon.formTime.to_i)
next 0 if ((pokemon.formTime.to_i==0) || ((pbGetTimeNow.to_i)>=(pokemon.formTime.to_i)))
},

Don't forget to set this:

timenow=pbGetTimeNow.to_i
pokemon.formTime=(timenow+(60*60*24*5)).to_i

for Furfrou's grooming.

It is forcing Hoopa to stay in form 1, even debugging. Also if test a battle, the opponent Hoopa is in form 1

 

[The Master]

It is forcing Hoopa to stay in form 1, even debugging. Also if test a battle, the opponent Hoopa is in form 1

It's strange, because this never happened to me. However, there is another bug and i'm working hard so that it's solved.


[EDIT]: The previous code is wrong. I'm working to fix it.

 

[Rot8er_ConeX]

Here's how the Gen VI Pack for v15.1 did it

"getForm"=>proc{|pokemon|
   next 0 if ((pbGetTimeNow-pokemon.form_change_time)/60/60/24)>3 || 
       !($Trainer.party).include?(pokemon)
   next
},

 

[TACHAN]

Bug: Deoxys-Attack (and other Deoxys forms), returns to his Normal Form at the end of a battle.
How do I fix it?

 

[Maruno]

Just to shut you lot up about this, here's the solution to Furfrou/Hoopa's form thing that will be in the next version of Essentials. All three of these things are in the script section Pokemon_MultipleForms.

Instructions can be found here, because this forum doesn't display code properly: https://pastebin.com/LFrSymPD

 

[The Master]

Thank you so much, Maruno! :)

 

[TACHAN]

I found a minor error the other day with the move Spiky Shield. It deals damage to the Pokemon using the move, instead of the attacker. I was able to fix it by replacing some of the instances of the word "target" with "user" in the appropriate areas in PokeBattle_Battler. I don't have the project in front of me right now, though.

Also Spiky Shield always protect. I protected 8 times in two battles

 

[Maruno]

Also Spiky Shield always protect. I protected 8 times in two battles

Sounds like you were lucky. It's entirely possible to do that, you know. My Spiky Shield tests failed in succession about half the time, as it should.

 

[TACHAN]

Sounds like you were lucky. It's entirely possible to do that, you know. My Spiky Shield tests failed in succession about half the time, as it should.

if USENEWBATTLEMECHANICS = true SpikyShield never fail (I've done more than 30 times and never fail)

if USENEWBATTLEMECHANICS = false Spiky Shield sometimes fails (one battle)