Help Thread: Script Help Thread

[destinedjagold]

Okay, thanks. The trainer battle worked, but the applymovement not. Did you know why? I try using the waitmovement 0x0, but nothing changed

The NPC is probably too far away from the player.

Spoiler:

As you can see, for applymovements to work on NPCs, they have to be 7 to 9 tiles away from the player's X axis, or 5 to 7 tiles away from the player's Y axis.

 

[Applausear]

The NPC is probably too far away from the player.

Spoiler:

As you can see, for applymovements to work on NPCs, they have to be 7 to 9 tiles away from the player's X axis, or 5 to 7 tiles away from the player's Y axis.

Thanks! This was the problem.

 

[DizzyEgg]

So I've now begun work on learning to create givepokemon scripts that includes a Yes/No box. For some reason, the following script isn't working properly. I tried fixing it by changing to an unused flag, but with no success. The script is optimized for FireRed. Here it is:

Spoiler:

#dynamic 0xE00000
#freespace 0xFF

#org @start
lock
faceplayer
checkflag 0x26A
if 0x1 goto @screwoff
msgbox @option 0x5
compare 0x800D 0x1
if 0x1 goto @getmon
compare 0x800D 0x0
if 0x1 goto @byebye
end

#org @getmon
givepokemon 0x014E 0x45 0x0 0x0 0x0 0x0
fanfare 0x13E
msgbox @obtain 0x4
waitfanfare
closeonkeypress
setflag 0x26A
msgbox @nickname 0x5
compare 0x800D 0x1
if 0x1 goto @name
compare 0x800D 0x0
if 0x1 goto @takecare
end

#org @byebye
msgbox @leavenow 0x6
release
end

#org @screwoff
msgbox @another 0x6
release
end

#org @name
setvar 0x8004 0x0
call @stuff
goto @takecare

#org @stuff
fadescreen 0x1
special 0x9E
waitstate
return

#org @takecare
msgbox @bepatient 0x6
release
end

#org @obtain
= \v\h01 received a Dragon Pokemon!

#org @nickname
= [black_fr]Would you like to name your\ndragon?

#org @option
= Did you know?\pDraconianWing's favorite Pokemon\ntype is Dragon!\pI know! I'll give you a Dragon\nPokemon so you can see why!\pHow about it?

#org @bepatient
= Be sure to raise it patiently.\pWhen trained properly, a Dragon\nPokemon becomes an absolute\lwrecking machine!\pLook out for Ice-types though.

#org @leavenow
= Ok then. Please go away.

#org @another
= So now you realized how awesome\nDragons are, and now you want\lanother one?\pSorry. Not gonna happen.

It always keeps assuming that the flag is set and goes right to @screwoff. (I've found and tried using several safe flags that aren't used according to the documentation linked on SphIce's post)

NOTE: I'm using a downloaded savefile for testing, so maybe the flag is indeed set. But I figured that it would be good to get the script checked here anyway.

So I compiled your script and there are some things I'd like to tell you.
First, the script works fine. Test it on a clean rom and you'll see the flag is not set.
Second, what's with the [/spoiler] thing? It's the first time I see it and it doesn't do anything in-game.
The last thing, change the give nickname part of the code. You don't check whether the player has place for a new Pokemon and that can cause trouble. Basically, test the script with and without a full team and try to name it. You'll see what I mean. How to fix that? See xse scripting tutorial, it's at the bottom.

 

[DraconianWing]

So I compiled your script and there are some things I'd like to tell you.
First, the script works fine. Test it on a clean rom and you'll see the flag is not set.
Second, what's with the [/spoiler] thing? It's the first time I see it and it doesn't do anything in-game.
The last thing, change the give nickname part of the code. You don't check whether the player has place for a new Pokemon and that can cause trouble. Basically, test the script with and without a full team and try to name it. You'll see what I mean. How to fix that? See xse scripting tutorial, it's at the bottom.

Thank you for testing the script! By [/spoiler] you mean [black_fr]? I was following a tutorial on scripting and it supposedly changes the color to black. As for checking for room, I couldn't find the tutorial you were referring to, so I'm trying to fix it by adding a countpokemon command at @getmon and will test on a new ROM. Here's the new script:

Spoiler:

#dynamic 0xE00000
#freespace 0xFF

#org @start
lock
faceplayer
checkflag 0x26A
if 0x1 goto @screwoff
msgbox @option 0x5
compare 0x800D 0x1
if 0x1 goto @getmon
compare 0x800D 0x0
if 0x1 goto @byebye
end

#org @getmon
countpokemon
compare 0x800D 0x6
if 0x1 goto @noroom
givepokemon 0x014E 0x45 0x0 0x0 0x0 0x0
fanfare 0x13E
msgbox @obtain 0x4
waitfanfare
closeonkeypress
setflag 0x26A
msgbox @nickname 0x5
compare 0x800D 0x1
if 0x1 goto @name
compare 0x800D 0x0
if 0x1 goto @takecare
end

#org @noroom
msgbox @getroom 0x6
release
end

#org @byebye
msgbox @leavenow 0x6
release
end

#org @screwoff
msgbox @another 0x6
release
end

#org @name
setvar 0x8004 0x0
call @stuff
goto @takecare

#org @stuff
fadescreen 0x1
special 0x9E
waitstate
return

#org @takecare
msgbox @bepatient 0x6
release
end

#org @getroom
= But you have no room in your\nparty!

#org @obtain
= \v\h01 received a Dragon Pokemon!

#org @nickname
= [black_fr]Would you like to name your\ndragon?

#org @option
= Did you know?\pDraconianWing's favorite Pokemon\ntype is Dragon!\pI know! I'll give you a Dragon\nPokemon so you can see why!\pHow about it?

#org @bepatient
= Be sure to raise it patiently.\pWhen trained properly, a Dragon\nPokemon becomes an absolute\lwrecking machine!\pLook out for Ice-types though.

#org @leavenow
= Ok then. Please go away.

#org @another
= So now you realized how awesome\nDragons are, and now you want\lanother one?\pSorry. Not gonna happen.

EDIT: The script now checks for room, but nicknames the wrong Pokemon (the one in the left slot of the party) so it turns out I was following a sample script on getting and naming the first/starter Pokemon.

YET ANOTHER EDIT: There! now the script works properly and nicknames the received Pokemon! Credits to Butterslave for the givepokemon tutorial :)

Spoiler:

#dynamic 0xE00000
#freespace 0xFF

#org @start
lock
faceplayer
checkflag 0x26A
if 0x1 goto @screwoff
msgbox @option 0x5
compare 0x800D 0x1
if 0x1 goto @getmon
compare 0x800D 0x0
if 0x1 goto @byebye
end

#org @getmon
countpokemon
compare 0x800D 0x6
if 0x1 goto @noroom
givepokemon 0x014E 0x45 0x0 0x0 0x0 0x0
fanfare 0x13E
msgbox @obtain 0x4
waitfanfare
closeonkeypress
setflag 0x26A
msgbox @nickname 0x5
compare 0x800D 0x1
if 0x1 goto @name
compare 0x800D 0x0
if 0x1 goto @takecare
end

#org @noroom
msgbox @getroom 0x6
release
end

#org @byebye
msgbox @leavenow 0x6
release
end

#org @screwoff
msgbox @another 0x6
release
end

#org @name
countpokemon
subvar 0x800D 0x1
copyvar 0x8004 0x800D
call @stuff
goto @takecare

#org @stuff
fadescreen 0x1
special 0x9E
waitstate
return

#org @takecare
msgbox @bepatient 0x6
release
end

#org @getroom
= But you have no room in your\nparty!

#org @obtain
= \v\h01 received a Dragon Pokemon!

#org @nickname
= [black_fr]Would you like to name your\ndragon?

#org @option
= Did you know?\pDraconianWing's favorite Pokemon\ntype is Dragon!\pI know! I'll give you a Dragon\nPokemon so you can see why!\pHow about it?

#org @bepatient
= Be sure to raise it patiently.\pWhen trained properly, a Dragon\nPokemon becomes an absolute\lwrecking machine!\pLook out for Ice-types though.

#org @leavenow
= Ok then. Please go away.

#org @another
= So now you realized how awesome\nDragons are, and now you want\lanother one?\pSorry. Not gonna happen.

 

[tkim]

Hi guys, I'm trying to create a legendary battle with mew by altering the mewtwo script in fire red. I'm trying change the cry and in-battle appearance to mew and also its level to 30. I am using XSE to save the mewtwo script as a .rbc file and altering it through notepad. Here is the script for mewtwo:

Spoiler:

'---------------
#org 0x1624F5
special 0x187
compare LASTRESULT 0x2
if 0x1 goto 0x81A7AE0
special 0x188
lock
faceplayer
checksound
cry 0x96 0x2
preparemsg 0x8177F9F '"Mew!"
waitmsg
waitcry
pause 0x14
playsong 0x156 0x0
waitkeypress
setwildbattle 0x96 0x46 0x0
setflag 0x807
special 0x138
waitstate
clearflag 0x807
special2 LASTRESULT 0xB4
compare LASTRESULT 0x1
if 0x1 goto 0x8162558
compare LASTRESULT 0x4
if 0x1 goto 0x8162561
compare LASTRESULT 0x5
if 0x1 goto 0x8162561
setflag 0x2BC
release
end

'---------------
#org 0x1A7AE0
release
end

'---------------
#org 0x162558
setflag 0x2BC
goto 0x81A922D

'---------------
#org 0x162561
setvar 0x8004 0x96
goto 0x81A9236

'---------------
#org 0x1A922D
fadescreen 0x1
hidesprite LASTTALKED
fadescreen 0x0
release
end

'---------------
#org 0x1A9236
fadescreen 0x1
hidesprite LASTTALKED
fadescreen 0x0
bufferpokemon 0x0 0x8004
msgbox 0x81A63C4 MSG_KEEPOPEN '"The [buffer1] flew away!"
release
end


'---------
' Strings
'---------
#org 0x177F9F
= Mew!

#org 0x1A63C4
= The [buffer1] flew away!

From what I know, I am supposed to change the 0x96 in cry to 0x97 (mew?) , the 0x96 and 0x46 in wildbattle to 0x97 and 0x1E (level 30?) respectively. What else do I have to do in order for this to work? I've already tried what I just said, but after compiling the altered script and giving the script to a new sprite ingame, I do not get the results I want. Instead the text glitches out when speaking to the sprite and the game doesn't allow any other input afterwards. I've also tried changing the setflag 0x2BC at the bottom of section #org 0x1624F5 of the script to setflag 0x1201. One last thing, is there a flag to make the mew obey?

 

[Applausear]

Spoiler:

'---------------
#org 0x234E7F
playsong 0x11B 0x0
trainerbattle 0x0 0x59 0x0 0x8234EEF 0x8234F22
msgbox 0x8234F34 MSG_NORMAL '"Meu Ratatta me ajudará a virar \nc..."
fadedefault
release
end


'---------
' Strings
'---------
#org 0x234EEF
= Irei te destruir!!!

#org 0x234F22
= Inacreditável!!

#org 0x234F34
= Meu Ratatta me ajudará a virar \ncampeao.

These scripts are bugging my head. Really.
Okay, the script at the start worked very well, but after I put another trainer in the map the script stopped working.

Here is an image of the error:

Spoiler:

 

[Mana1]

Spoiler:

'---------------
#org 0x234E7F
playsong 0x11B 0x0
trainerbattle 0x0 0x59 0x0 0x8234EEF 0x8234F22
msgbox 0x8234F34 MSG_NORMAL '"Meu Ratatta me ajudará a virar \nc..."
fadedefault
release
end


'---------
' Strings
'---------
#org 0x234EEF
= Irei te destruir!!!

#org 0x234F22
= Inacreditável!!

#org 0x234F34
= Meu Ratatta me ajudará a virar \ncampeao.

These scripts are bugging my head. Really.
Okay, the script at the start worked very well, but after I put another trainer in the map the script stopped working.

Here is an image of the error:

Spoiler:

You're using very low offsets, are you sure this is in free space? Not sure what the problem could be other than some scripts clashing or you editing and recompiling over something important? :(

#dynamic 0x800000 at the start of your scripts, then just use @pointers and let XSE do the searching for you.

 

[Applausear]

You're using very low offsets, are you sure this is in free space? Not sure what the problem could be other than some scripts clashing or you editing and recompiling over something important? :(

#dynamic 0x800000 at the start of your scripts, then just use @pointers and let XSE do the searching for you.

:(
This wasn't the problem.
D:

 

[Spherical Ice]

Spoiler:

'---------------
#org 0x234E7F
playsong 0x11B 0x0
trainerbattle 0x0 0x59 0x0 0x8234EEF 0x8234F22
msgbox 0x8234F34 MSG_NORMAL '"Meu Ratatta me ajudará a virar \nc..."
fadedefault
release
end


'---------
' Strings
'---------
#org 0x234EEF
= Irei te destruir!!!

#org 0x234F22
= Inacreditável!!

#org 0x234F34
= Meu Ratatta me ajudará a virar \ncampeao.

These scripts are bugging my head. Really.
Okay, the script at the start worked very well, but after I put another trainer in the map the script stopped working.

Here is an image of the error:

Spoiler:

The first command for trainerbattle scripts that are activated by the player walking into their view radius should be the trainerbattle command.

It's also worth noting the string you're using has a space before \n, which is just a waste of space.

 

[Applausear]

The first command for trainerbattle scripts that are activated by the player walking into their view radius should be the trainerbattle command.

It's also worth noting the string you're using has a space before \n, which is just a waste of space.

Thanks!
Wow.
You are helping me a lot. Is there anything I can do for you?

 

[DraconianWing]

Alright, now we're onto wildbattle scripts! :)

I've written up a regular encounter against a lv5 Rayquaza without changes to the default music or anything, just to see if I can get a battle to work. Everything goes relatively smoothly until after the encounter, where the screen goes completely black when the sprite is supposed to disappear:

Spoiler:

#dynamic 0xE00000
#freespace 0xFF

#org @start
lock
faceplayer
cry 0x196 0x0
msgbox @roar 0x6
waitcry
wildbattle 0x196 0x5 0x0
fadescreen 0x0
hidesprite 0x800F
fadescreen 0x1
setflag 0x2AA
release
end

#org @roar
= [green_em]Aaaaaaaaaabk!

Swapping the fade bytes around (ie. 0x0 to 0x1 and 0x1 to 0x0) results in some pretty hilarious mishaps:

Spoiler:

View attachment 76506

 

[C me]

I was wondering how to do a counter battle script. For example in normal scripting it would be this:

Spoiler:

comparevar 0x800D 0x3
if 0x1 goto @happened3timesscript
[main script here]
addvar 0x800D 0x1

#happened3timesscript
[stuff to be done]
setvar 0x800D 0x0

(I know I missed out end and stuff)

Is this possible in a battle script? Have a var you can write to which resets after the battle.

Thanks

 

[NewDenverCity]

I was wondering how to do a counter battle script. For example in normal scripting it would be this:

Spoiler:

comparevar 0x800D 0x3
if 0x1 goto @happened3timesscript
[main script here]
addvar 0x800D 0x1

#happened3timesscript
[stuff to be done]
setvar 0x800D 0x0

(I know I missed out end and stuff)

Is this possible in a battle script? Have a var you can write to which resets after the battle.

Thanks

You mean a battle script, like Pokémon moves, or do you mean regular scripts?
If you mean regular scripts, then yeah. I wouldn't use x800D though, as that gets overwritten constantly.

 

[C me]

You mean a battle script, like Pokémon moves, or do you mean regular scripts?
If you mean regular scripts, then yeah. I wouldn't use x800D though, as that gets overwritten constantly.

I mean as in move effects, I just used 0x800D as an example to show what I mean by a counter script.

 

[Teh Blazer]

This is an odd one I just noticed. Whenever I try to create a new level script by pressing the "Add" Button under Headers it creates a new script but when I set that new script to be 0x2, it suddenly links itself to a level script on another map. And I've tried this with other maps that I haven't touched (adding a new level script and setting it to 0x2) and they all link to the same level script on another map.

And by link, I mean if I try to change the script offset or the flag value or anything on one map, it'll do the same to the other. And since I need separate level scripts for both maps, this is kind of a toughie.

Was there anything I did wrong? Is it an easy fix?

 

[Danny0317]

This is an odd one I just noticed. Whenever I try to create a new level script by pressing the "Add" Button under Headers it creates a new script but when I set that new script to be 0x2, it suddenly links itself to a level script on another map. And I've tried this with other maps that I haven't touched (adding a new level script and setting it to 0x2) and they all link to the same level script on another map.

And by link, I mean if I try to change the script offset or the flag value or anything on one map, it'll do the same to the other. And since I need separate level scripts for both maps, this is kind of a toughie.

Was there anything I did wrong? Is it an easy fix?

Try repointing the level scripts for one of the maps.

 

[Teh Blazer]

Try repointing the level scripts for one of the maps.

At the risk of sounding like a total noob nugget, how do i repoint the level script for one of the maps? As soon as I make the new map's level script to type 0x2, it automatically fills in the information from the other map's level script. And then trying to change the offset that was filled in will change the offset that is in the original map as well.

 

[Danny0317]

At the risk of sounding like a total noob nugget, how do i repoint the level script for one of the maps? As soon as I make the new map's level script to type 0x2, it automatically fills in the information from the other map's level script. And then trying to change the offset that was filled in will change the offset that is in the original map as well.

I'd go on fsf, get a free offset, go to the professional header view on one of the maps, and change it.

 

[DraconianWing]

When editing a very long script in a game, would it be viable to add any stuff that you want to implement and leave the rest as is? For example, I would like to have Wallace's dialogue and team change in Emerald after the first Hall of Fame; (similar to the newer games) however, it turns out that the script for the champ battle is over 300 lines long and would take ages to replicate, unlike the E4 scripts. Here's the dump from the ROM

Spoiler:

'---------------
#org 0x228A1E
lockall
applymovement MOVE_PLAYER 0x82725C1
waitmovement 0x0
pause 0x28
applymovement MOVE_PLAYER 0x8228A42
waitmovement 0x0
setvar 0x4001 0x1
goto 0x8228A45

'---------------
#org 0x228A45
playsong 0x1C6 0x0
msgbox 0x8228C4C MSG_KEEPOPEN '"Wallace: Welcome, [player]\v\h05.\..."
trainerbattle 0x3 0x14F 0x0 0x8228EAC
goto 0x8228A61

'---------------
#org 0x228A61
sound 0x8
setmaptile 0x6 0x1 0x346 0x0
setmaptile 0x6 0x2 0x347 0x0
special 0x91
msgbox 0x8228F66 MSG_KEEPOPEN '"Wallace: The Pokémon you sent into..."
closeonkeypress
sound 0x8
checkgender
compare LASTRESULT 0x0
if 0x1 call 0x8228ABC
compare LASTRESULT 0x1
if 0x1 call 0x8228AC1
showsprite 0x2
call 0x8228BFD
checkgender
compare LASTRESULT 0x0
if 0x1 goto 0x8228AC6
compare LASTRESULT 0x1
if 0x1 goto 0x8228AFB
end

'---------------
#org 0x228ABC
playsong 0x19F 0x0
return

'---------------
#org 0x228AC1
playsong 0x1A5 0x0
return

'---------------
#org 0x228BFD
applymovement 0x2 0x8228C26
waitmovement 0x0
applymovement MOVE_PLAYER 0x82725A4
waitmovement 0x0
return

'---------------
#org 0x228AC6
msgbox 0x82290CA MSG_KEEPOPEN '"May: [player]\v\h05!\pHere's some ..."
pause 0x28
sound 0x15
applymovement 0x2 0x8272598
waitmovement 0x0
applymovement 0x2 0x827259A
waitmovement 0x0
call 0x8228C12
msgbox 0x822910B MSG_KEEPOPEN '"May: Huh?\nWhat, what, what?\p[pla..."
goto 0x8228B30

'---------------
#org 0x228AFB
msgbox 0x8229152 MSG_KEEPOPEN '"Brendan: [player]!\pHow would you ..."
pause 0x28
sound 0x15
applymovement 0x2 0x8272598
waitmovement 0x0
applymovement 0x2 0x827259A
waitmovement 0x0
call 0x8228C12
msgbox 0x82291A2 MSG_KEEPOPEN '"Brendan: [player][.]\pAre you tryi..."
goto 0x8228B30

'---------------
#org 0x228C12
applymovement 0x2 0x8228C2F
waitmovement 0x0
return

'---------------
#org 0x228B30
closeonkeypress
showsprite 0x3
applymovement 0x3 0x8228C43
waitmovement 0x0
applymovement MOVE_PLAYER 0x82725A8
waitmovement 0x0
msgbox 0x82291E6 MSG_KEEPOPEN '"Prof. Birch: See?\nWhat did I tell..."
call 0x8272184
msgbox 0x822934D MSG_KEEPOPEN '"Prof. Birch: Anyways,\ncongratulat..."
applymovement 0x1 0x82725A6
waitmovement 0x0
pause 0x14
applymovement 0x1 0x82725AA
waitmovement 0x0
msgbox 0x8229399 MSG_KEEPOPEN '"Wallace: [player]\v\h05[.]\pNo, le..."
closeonkeypress
pause 0x1E
applymovement 0x1 0x8228C3B
applymovement MOVE_PLAYER 0x8228C1D
applymovement 0x3 0x82725A6
applymovement 0x2 0x8228C38
waitmovement 0x0
pause 0x14
applymovement MOVE_PLAYER 0x82725AA
waitmovement 0x0
msgbox 0x82293EB MSG_KEEPOPEN '"Wallace: I'm sorry, but[.]\pFrom h..."
checkgender
compare LASTRESULT 0x0
if 0x1 call 0x8228BEB
compare LASTRESULT 0x1
if 0x1 call 0x8228BF4
closeonkeypress
applymovement 0x1 0x8228C3F
applymovement MOVE_PLAYER 0x8228C20
waitmovement 0x0
setflag 0x30D
warp 0x10 0xB 0xFF 0x7 0x10
waitstate
releaseall
end

'---------------
#org 0x272184
setvar 0x8004 0x0
special2 LASTRESULT 0xD7
copyvar 0x8008 0x8005
copyvar 0x8009 0x8006
copyvar 0x800A LASTRESULT
buffernumber 0x0 0x8008
buffernumber 0x1 0x8009
msgbox 0x82A5D2C MSG_KEEPOPEN '"Hmhm[.]\pSo, you've seen [buffer1]..."
call 0x8272179
compare 0x800A 0x0
if 0x1 goto 0x827374E
setvar 0x8004 0x1
special2 LASTRESULT 0xD7
copyvar 0x8008 0x8005
copyvar 0x8009 0x8006
buffernumber 0x0 0x8008
buffernumber 0x1 0x8009
msgbox 0x82A633D MSG_KEEPOPEN '"Hmhm[.]\nOn a nationwide basis[.]\..."
return

'---------------
#org 0x228BEB
msgbox 0x8229479 MSG_KEEPOPEN '"May: Groan[.]\p[.] [.] [.] [.] [.]..."
return

'---------------
#org 0x228BF4
msgbox 0x82294F5 MSG_KEEPOPEN '"Brendan: Whaaaat?! [.] [.] [.] [.]..."
return

'---------------
#org 0x272179
copyvar 0x8004 0x8009
special 0xD8
waitmsg
waitkeypress
return

'---------------
#org 0x27374E
return


'---------
' Strings
'---------
#org 0x228C4C
= Wallace: Welcome, [player]\v\h05.\pThat incident in Sootopolis City[.]\nThat was superb work, putting an end\lto that crisis all by yourself.\pOops!\pIt wouldn't be fair to say that you\nalone ended the crisis.\pYou overcame that difficult situation\nby working as one with your Pokémon.\pWe trainers raise Pokémon by giving\nthem items and by teaching them new\ltechniques for battle.\pBut we ourselves also learn many\nthings from Pokémon.\pAnd this is where your achievements\nare put to the test against what\lothers like you have achieved.\pNow!\pWho can most elegantly dance with\ntheir Pokémon in Hoenn?\pShow me right here and now!

#org 0x228EAC
= I, the Champion, fall in defeat[.]\pThat was wonderful work.\nYou were elegant, infuriatingly so.\lAnd yet it was utterly glorious!\pKudos to you, [player]\v\h05!\pYou are a truly noble Pokémon\nTrainer!

#org 0x228F66
= Wallace: The Pokémon you sent into\nbattle[.]\pAt times they danced like a spring\nbreeze, and at times they struck\llike lightning.\pIt was with light, yet surefooted,\nelegance that you led your Pokémon.\pEven I felt bedazzled by your\nmasterful performance!\pYou now stand at the glorious peak\nof the Pokémon League.\pI now proclaim you to be the new\nHoenn region[.]

#org 0x2290CA
= May: [player]\v\h05!\pHere's some advice before you challenge\nthe Champion[.]

#org 0x22910B
= May: Huh?\nWhat, what, what?\p[player]\v\h05[.]\nCould it be that[.]\lIt's already over?

#org 0x229152
= Brendan: [player]!\pHow would you like some advice before\nyou challenge the Champion?[.]

#org 0x2291A2
= Brendan: [player][.]\pAre you trying to tell me[.]\nYou've beaten the Champion?

#org 0x2291E6
= Prof. Birch: See?\nWhat did I tell you, [rival]?\pDidn't I tell you that you don't need\nto worry about [player]\v\h05?\p[.] [.] [.] [.] [.] [.] [.] [.]\n[player]\v\h05, you've finally done it.\pWhen I heard that you defeated your\nown father at the Petalburg Gym,\lI thought perhaps you had a chance[.]\pBut to think you've actually become\nthe Champion!\pAh, yes!\pWhat became of your Pokédex?\nHere, let me see.

#org 0x22934D
= Prof. Birch: Anyways,\ncongratulations!\pNow, go proudly into the final room!

#org 0x229399
= Wallace: [player]\v\h05[.]\pNo, let me rephrase that properly.\pThe new Champion!\pCome with me.

#org 0x2293EB
= Wallace: I'm sorry, but[.]\pFrom here on, only those trainers who\nhave become Champions may enter.\pYou'll have to wait outside with\nProf. Birch.

#org 0x2A5D2C
= Hmhm[.]\pSo, you've seen [buffer1] Pokémon,\nand you've caught [buffer2] Pokémon[.]

#org 0x2A633D
= Hmhm[.]\nOn a nationwide basis[.]\pYou've seen [buffer1] Pokémon,\nand you've caught [buffer2] Pokémon[.]

#org 0x229479
= May: Groan[.]\p[.] [.] [.] [.] [.] [.] [.] [.]\n[.] [.] [.] [.] [.] [.] [.] [.]\pI'm just joking! That's okay!\nThat's the rule!\p[player]\v\h05!\nHonestly, congratulations!

#org 0x2294F5
= Brendan: Whaaaat?! [.] [.] [.] [.] [.]\n[.] [.] [.] [.] [.] [.] [.] [.]\pIt can't be helped if that's the rule.\p[player], way to go!\nCongratulations!


'-----------
' Movements
'-----------
#org 0x2725C1
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x228A42
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x228C26
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xA 'Step Left (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x28 'Step on the Spot Right (Fastest)
#raw 0xFE 'End of Movements

#org 0x2725A4
#raw 0x27 'Step on the Spot Left (Fastest)
#raw 0xFE 'End of Movements

#org 0x272598
#raw 0x56 'Exclamation Mark (!)
#raw 0xFE 'End of Movements

#org 0x27259A
#raw 0x14 'Delay5
#raw 0x14 'Delay5
#raw 0x14 'Delay5
#raw 0xFE 'End of Movements

#org 0x228C2F
#raw 0x26 'Step on the Spot Up (Fastest)
#raw 0x14 'Delay5
#raw 0x28 'Step on the Spot Right (Fastest)
#raw 0x14 'Delay5
#raw 0x26 'Step on the Spot Up (Fastest)
#raw 0x13 'Delay4
#raw 0x28 'Step on the Spot Right (Fastest)
#raw 0x14 'Delay5
#raw 0xFE 'End of Movements

#org 0x228C43
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xB 'Step Right (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x27 'Step on the Spot Left (Fastest)
#raw 0xFE 'End of Movements

#org 0x2725A8
#raw 0x28 'Step on the Spot Right (Fastest)
#raw 0xFE 'End of Movements

#org 0x2725A6
#raw 0x26 'Step on the Spot Up (Fastest)
#raw 0xFE 'End of Movements

#org 0x2725AA
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0xFE 'End of Movements

#org 0x228C3B
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0x25 'Step on the Spot Down (Fastest)
#raw 0xFE 'End of Movements

#org 0x228C1D
#raw 0x9 'Step Up (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x228C38
#raw 0xB 'Step Right (Normal)
#raw 0x9 'Step Up (Normal)
#raw 0xFE 'End of Movements

#org 0x228C3F
#raw 0x9 'Step Up (Normal)
#raw 0x13 'Delay4
#raw 0x54 'Hide
#raw 0xFE 'End of Movements

#org 0x228C20
#raw 0x9 'Step Up (Normal)
#raw 0x14 'Delay5
#raw 0x9 'Step Up (Normal)
#raw 0x13 'Delay4
#raw 0x54 'Hide
#raw 0xFE 'End of Movements

My plan is to insert a check for 0x87F (the HoF flag), redirect to the new "before battle" msgbox and team, then go back to the regular script events. Everything else will be kept untouched. Of course, dynamic and freespace will be put on top to prevent overwriting or corrupting anything. And as usual, help is greatly appreciated!

 

[bradmarx]

I am attempting to make a script that makes Oak give you the national dex after you fight your rival before you leave his lab. I have the movement working that brings you front and center to Oak but nothing continues after that. Thanks for any help.

Spoiler:

#org 0x877021F
'-----------------------------------
lockall
setvar 0x4002 0x1
jump 0x877022A

#org 0x877022A
'-----------------------------------
textcolor BLUE
playsound 0x1 0x1
msgbox 0x87703FE ' OAK: Wait \v\h01!
callstd MSG_NOCLOSE ' Non-closing message
closemsg
compare 0x4002 0x1
if == jump 0x877040C ' Equal To
compare 0x4002 0x2
if == jump 0x8770417 ' Equal To
compare 0x4002 0x3
if == jump 0x8770422 ' Equal To
textcolor BLUE
playsound 0x1 0x22
msgbox 0x87703E2 ' OAK: \v\h01 take thi...
callstd MSG_NOCLOSE ' Non-closing message
closemsg
pauseevent 0x0
disappear 0x9
disappear 0x10
disappear 0x12
pause 0xA
textcolor GRAY
fanfare 0x13E
message 0x87703BA ' \v\h01 received the ...
showmsg
waitfanfare
call 0x87703B4
special FR_NATIONAL_DEX
msgbox 0x87702AF ' To make a complete g...
callstd MSG_NOCLOSE ' Non-closing message
closemsg
playsound 0x22 0x22
fadedefault
setvar 0x4055 0x6
setvar 0x4057 0x2
setvar 0x4051 0x1
setvar 0x4058 0x1
setvar 0x4054 0x1
release
end

#org 0x877040C
'-----------------------------------
applymovement PLAYER 0x877042D ' walk_up walk_up walk...
pauseevent 0x0
return

#org 0x8770417
'-----------------------------------
applymovement PLAYER 0x8770434 ' walk_left walk_up wa...
pauseevent 0x0
return

#org 0x8770422
'-----------------------------------
applymovement PLAYER 0x877043D ' walk_right walk_up w...
pauseevent 0x0
return

#org 0x87703B4
'-----------------------------------
copyvar 0x8012 0x8013
return


#org 0x87703FE
= OAK: Wait \v\h01!

#org 0x87703E2
= OAK: \v\h01 take this with you.

#org 0x87703BA
= \v\h01 received the POK\eDEX\nfrom PROF. OAK.

#org 0x87702AF
= To make a complete guide on all\nthe POK\eMON in the world[.]\pThat was my dream!\pBut, I'm too old.\nI can't get the job done.\pSo, I want you to fulfill my\ndream for me.\pGet moving.\pThis is a great undertaking in\nPOK\eMON history!\nI will give \v\h06 and \v\h07 theirs later.

#org 0x877042D
M walk_up walk_up walk_up walk_up walk_up walk_up end

#org 0x8770434
M walk_left walk_up walk_up walk_up walk_up walk_up walk_up walk_up end

#org 0x877043D
M walk_right walk_up walk_up walk_up walk_up walk_up walk_up walk_up end