Patch: MrDollSteak's Decap. and Attack Rombase

Chaos Rush · Dec 23, 2014

Wigger15 said:
This project moves at a freaking snail's pace, my god. When is 1.5 even due out? You've made almost no progress in the last year.

He's not obligated to make this ROM base for you; why don't you go make your own ROM base then?

Deokishisu · Dec 23, 2014

It's probably better not to reply to the obvious troll. Honestly, this project is a much lower priority (and should be!) than someone's education. Children, idiots, and idiot children are too selfish to understand that.

MrDollSteak, this is more than worth the wait. Study hard and don't let morons get you down. You're doing amazing work for the community.

MrDollSteak · Dec 23, 2014

Wigger15 said:
Until the final glitch-free version is out, nothing else matters. The ROM base is useless right now considering half the abilities and moves freeze the game. Who the frick wants to make a hack based off that?

You're on PC and all the other hacker sites all day, you clearly have time to do more than fix like 3 minor bugs and go up 0.1 versions in 12 months. You've just simply gotten lazy.

Don't take all this the wrong way, it's just an honest critique for you to better yourself.

Did you not read my previous post?
I've identified and listed fixes for 'half the abilities and moves [that] freeze the game',
which are in fact only 2 or 3 abilities. The only move that freezes the game is Toxic Spikes which has also been fixed.

The other bugs present are either very slight graphical bugs or incomplete Move Effects such as Bug Bite only dealing damage.

The only 'game-breaking' bugs that people have reported for the latest build are the Day-Care people, and In-game trades, which I am working on, and are only really problems for people that are not building hacks, and rather playing the game themselves.

Rather than whinging and flaming the thread repeatedly, you could actually read my replies, and more importantly the OP to understand the existing bugs.

Also, even better, why not test the rombase yourself, then you would realise how ridiculous you sound.

Volt-Ikazuchi · Dec 23, 2014

MrDollSteak said:
You only need a hex editor as KDS said. They're all stored in different tables.
That being said, I haven't left extra space for new moves so you'll need to repoint them.

908720 - Reckless Table
908738 - Iron Fist Table
908758 - Sheer Force Table
908844 - Mega Launcher Table
908850 - Strong Jaw Table

Thanks. I don't really want to add more moves. (It's not like I actually know how to do it anyway)
I just wanted to add the new abilities properties to some moves. For example, Seed Bomb being boosted by Mega Launcher and etc. Really helpful rom base, thanks for the hard work.

KurisuSan · Dec 23, 2014

Hey MrDollSteak, first of all great, ROMbase, spent about two days doing about a third of what ya have in your base before I found this so it definitely helped me a lot, so thanks for that.

Also, I was wondering why it wont let me open up the FR rom with AM? It worked before I applied the patch and after I applied the patch it tells me:

Spoiler:

MrDollSteak · Dec 23, 2014

Hiroshi Sotomura said:
Now would be a great time to cool it and not derail the thread any further.

Could we go ahead and delete all these comments?
Maybe get the thread locked too?

It's probably for the best if the thread is closed for a while.

Blah · Dec 27, 2014

- In Game Trades and the Day Care apparently freeze the game

Ingame trades don't freeze the game. Mine worked fine. If someone has these problems, please repatch/learn to apply patches.

I also took a look at the daycare thing. I can't say I'm impressed at how long this bug's been around for what it is (and whoever reported this didn't bother to decompile the script?). It turned out to be just that the script at the daycare guy was overwritten in places, you can just assign him a copied script from a fresh ROM...

Spoiler:

Code:

#dyn 0x740000
#org @start
'-----------------------------------
special INIT_STEPCOUNT
compare LASTRESULT 0x2
if == jump @00D0 ' Equal To
lock
faceplayer
showmoney 0x0 0x0
special2 LASTRESULT 0x178
compare LASTRESULT 0x1
if == jump @00D2 ' Equal To
msgbox @0239 ' I run the DAY-CARE s...
callstd MSG_YESNO ' Yes/No message
compare LASTRESULT YES
if == jump @011F ' Equal To
msgbox @0285 ' Come again.
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @00D0
'-----------------------------------
release
end

#org @00D2
'-----------------------------------
setvar 0x8004 0x0
special2 LASTRESULT 0x179
compare LASTRESULT 0x0
if != call @010D ' Not Equal To
compare LASTRESULT 0x0
if == call @0116 ' Equal To
special 0x177
msgbox @0291 ' You owe me [p]\v\h03...
callstd MSG_YESNO ' Yes/No message
compare LASTRESULT YES
if == jump @01B1 ' Equal To
jump @0197

#org @010D
'-----------------------------------
msgbox @02C0 ' Your \v\h02 has grow...
callstd MSG_NOCLOSE ' Non-closing message
return

#org @0116
'-----------------------------------
msgbox @032C ' You're back already?...
callstd MSG_NOCLOSE ' Non-closing message
return

#org @011F
'-----------------------------------
special2 LASTRESULT 0x84
compare LASTRESULT 0x1
if == jump @0185 ' Equal To
msgbox @0370 ' Which POK\eMON shoul...
callstd MSG_NOCLOSE ' Non-closing message
fadescreen FADEOUT_BLACK
hidemoney 0x0 0x0
special 0xBC
waitspecial
showmoney 0x0 0x0
compare 0x8004 0x6
if >= jump @0197 ' Larger Than or Equal To
special2 LASTRESULT 0x85
compare LASTRESULT 0x0
if == jump @01A4 ' Equal To
special2 0x8005 0xBA
msgbox @038E ' Fine, I'll look afte...
callstd MSG_NOCLOSE ' Non-closing message
checksound
cry 0x8005 0x0
msgbox @03B9 ' Come see me in a whi...
callstd MSG_NOCLOSE ' Non-closing message
waitcry
special 0x176
CMD_C3 0x2F
jump @0192

#org @0185
'-----------------------------------
msgbox @03D1 ' Oh? You only have on...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @0192
'-----------------------------------
hidemoney 0x0 0x0
release
end

#org @0197
'-----------------------------------
msgbox @03F9 ' Fine.\nCome anytime ...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01A4
'-----------------------------------
msgbox @0416 ' If you leave me that...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01B1
'-----------------------------------
special2 LASTRESULT 0x83
compare LASTRESULT 0x6
if == jump @01DE ' Equal To
special2 LASTRESULT 0xC5
compare LASTRESULT 0x1
if == jump @01EB ' Equal To
msgbox @044F ' You don't have enoug...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01DE
'-----------------------------------
msgbox @046C ' You can't take this ...
callstd MSG_NOCLOSE ' Non-closing message
jump @0192

#org @01EB
'-----------------------------------
setvar 0x8004 0x0
special2 LASTRESULT 0x17A
special 0xC6
updatemoney 0x0 0x0 0x0
copyvar 0x8008 LASTRESULT
countpokemon
subtractvar LASTRESULT 0x1
storepartypokemon 0x0 0x800D
copyvar LASTRESULT 0x8008
msgbox @04AB ' Thank you!\nHere's y...
callstd MSG_NOCLOSE ' Non-closing message
textcolor GRAY
checksound
cry 0x800D 0x0
msgbox @04CB ' \v\h01 got \v\h02 ba...
callstd MSG_NOCLOSE ' Non-closing message
call @0233
waitcry
jump @0192

#org @0233
'-----------------------------------
copyvar 0x8012 0x8013
return


#org @0239
= I run the DAY-CARE service.\pWould you like me to raise one of\nyour POK\eMON?

#org @0285
= Come again.

#org @0291
= You owe me [p]\v\h03 for the return\nof this POK\eMON.

#org @02C0
= Your \v\h02 has grown a lot.\nYes, quite a lot, I'd say.\pLet me see[.]\nBy level, it's grown by \v\h03.\pAren't I great?

#org @032C
= You're back already?\pYour \v\h02 needs to spend\nsome more time with me.

#org @0370
= Which POK\eMON should I raise?

#org @038E
= Fine, I'll look after your\n\v\h02 for a while.

#org @03B9
= Come see me in a while.

#org @03D1
= Oh? You only have one POK\eMON\nwith you.

#org @03F9
= Fine.\nCome anytime you like.

#org @0416
= If you leave me that POK\eMON,\nwhat will you battle with?

#org @044F
= You don't have enough money.

#org @046C
= You can't take this POK\eMON back\nif you've got no room for it.

#org @04AB
= Thank you!\nHere's your POK\eMON.

#org @04CB
= \v\h01 got \v\h02 back\nfrom the DAY-CARE MAN.

I was expecting a more interesting problem, but this was kinda a let down :P

MrDollSteak · Dec 27, 2014

FBI agent said:
Ingame trades don't freeze the game. Mine worked fine. If someone has these problems, please repatch/learn to apply patches.

I also took a look at the daycare thing. I can't say I'm impressed at how long this bug's been around for what it is (and whoever reported this didn't bother to decompile the script?). It turned out to be just that the script at the daycare guy was overwritten in places, you can just assign him a copied script from a fresh ROM...

Cheers FBI, and as I said in the IRC, I'd been aware of that potential fix, but was told it didn't work, for whatever reason.

This does raise a good point. I'd just like to ask people that when reporting bugs, you are absolutely sure they are problems with the rombase, and not modified hacks (ie. the in-game trade issue, which a few people reported, but FBI or I could never replicate).

Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.

SS Goku · Dec 27, 2014

When I use U-turn in your rombase, it works a little different from the official games.

In the main games, if your party have more than one Pokemon and your leading 'mon uses U-turn to KO a foe, it will gain full Exp and won't switch.
Same situation but in the rombase, after KOing a foe, your leading 'mon will switch to another and the Exp is split between them.

If I use U-turn the way it is now, I'll be forced to share Exp with another Pokemon even if I don't want to, like when grinding. Out of curiosity, I tried the U-turn script (in the Move Resource thread) with a regular FR rom; it also has the same problem.

And this is a minor typo: the "t" in U-turn isn't capitalized in the main games, unlike the rombase.

jAvAcOlA · Dec 27, 2014

MrDollSteak said:
Cheers FBI, and as I said in the IRC, I'd been aware of that potential fix, but was told it didn't work, for whatever reason.

This does raise a good point. I'd just like to ask people that when reporting bugs, you are absolutely sure they are problems with the rombase, and not modified hacks (ie. the in-game trade issue, which a few people reported, but FBI or I could never replicate).

Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.

Hey, not to be up your *** about this, but what's the status on you implementing Imposter? I'm only bothering you about this because you told DaniilS not to work on it for me because you apparently had it done. Is it going to be in this update? Or if not can you just tell me how to do it? I've been holding off progress on my hack waiting for this Ditto thing.

The ??? · Dec 28, 2014

Hello Mr.DollSteak!
I would like to ask some questions / suggest something :
- Since you are adding lots of new moves and items, would you add 100 Tms as well?

Many regards and thanks for this :) It really helps for people who don't have knowledge of HACKING but still wants to enjoy, and I owe this to each n everyone who helped with this!

LCCoolJ95 · Dec 28, 2014

MrDollSteak said:
Good news, this means that 1.5a will be out shortly. I'm thinking the start of the new year,
once I'm back home.

So, that means the Emerald is almost done as well? Since you said you release both at the same time.

MrDollSteak · Dec 28, 2014

SS Goku said:
When I use U-turn in your rombase, it works a little different from the official games.

In the main games, if your party have more than one Pokemon and your leading 'mon uses U-turn to KO a foe, it will gain full Exp and won't switch.

Same situation but in the rombase, after KOing a foe, your leading 'mon will switch to another and the Exp is split between them.

If I use U-turn the way it is now, I'll be forced to share Exp with another Pokemon even if I don't want to, like when grinding. Out of curiosity, I tried the U-turn script (in the Move Resource thread) with a regular FR rom; it also has the same problem.

And this is a minor typo: the "t" in U-turn isn't capitalized in the main games, unlike the rombase.

Thanks for the typo thing!
As for the Exp. bug, that'll be difficult to solve, because if we want it to get the exp. after switching it'll split it. If we put it before, then it could lead to other problems. I'll look into it.

Hey, not to be up your *** about this, but what's the status on you implementing Imposter? I'm only bothering you about this because you told DaniilS not to work on it for me because you apparently had it done. Is it going to be in this update? Or if not can you just tell me how to do it? I've been holding off progress on my hack waiting for this Ditto thing.

Well I haven't got it done, but it isn't hard to do. I can put that on the list for 1.5a.
Basically I can hook it into my switch-in abilities table. I don't think you'd be able to
do it (not for lack of ability) but because it has to interact with some other pre-requisites
that are in the rombase.

I wouldn't put off hacking. It'll be in the next update.

Hello Mr.DollSteak!
I would like to ask some questions / suggest something :
- Since you are adding lots of new moves and items, would you add 100 Tms as well?

Many regards and thanks for this It really helps for people who don't have knowledge of HACKING but still wants to enjoy, and I owe this to each n everyone who helped with this!

Short answer, No.

Long answer, it'll be very difficult to do because of the ram allocated to the bag.

So, that means the Emerald is almost done as well? Since you said you release both at the same time.

No. Not even close. My original plan was to do them both, but since people have been getting impatient, I'd rather release the FR one first.

The ??? · Dec 28, 2014

Oh okay :( So if I add them somehow in my rom, there will be problems like lagging and stuff?
Kinda off topic, pardon me.

GUMI 02 · Dec 28, 2014

if i want to apply MrDs's Rom base (Version 1.5) and this titlescreen patch, which to i patch first?

MrDs's patch: https://www.pokecommunity.com/threads/326301

Titlescreen Patch: https://www.pokecommunity.com/threads/341174

Thanks!

TheRabbit · Dec 28, 2014

Have the in-game trainers whos' pokemon have custom movesets been edited to reflect the new movesets?

And related to that, which trainer editor works with this base anyway? Advance and Unnamed are both a no-go for me.

mkarthick98 · Dec 29, 2014

MrDollSteak said:
Bug Fixes

Spoiler:

2579A6 - Replace E9 F5 with 1D F6 (Fixes Toxic Spikes)

90BBE8 - Insert the following (Fixes Aftermath)

1F B4 13 20 00 21 06 22 03 23 00 F0 27 F8 00 28 21 D1 1F BC 14 49 60 00 00 19 80 00 40 18 00 7A 01 21 08 40 00 28 17 D0 10 48 40 78 58 21 48 43 0F 49 40 18 01 8D 00 29 0E D1 0C 48 00 78 58 21 48 43 0B 49 40 18 80 8D 80 08 0A 49 08 60 00 F0 07 F8 09 49 08 47 1F BC 00 F0 04 F8 07 4C 20 47 07 48 00 47 07 4C 20 47 00 00 90 08 6B 3D 02 02 E4 3B 02 02 50 3D 02 02 E9 AA 01 08 19 9F 01 08 45 75 01 08 AB BB 01 08 FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF FF

90C118 - Replace FE with 0D (Fixes Motor Drive)
90C4DE - Replace 3F with 03 (Fixes Choice Items)
90C504 - Replace EC with E8 (Fixes Aftermath)
90C51C - Replace 70 with 72 (Fixes Mummy)

About the bug fixes, I made all the changes mentioned above, but when I start my ROM in VBA, it doesn't work. The title screen doesn't load. From what I've found, the second bug fix, the Aftermath fix, is the problem. The ROM works fine when I change everything else, but once I insert those 136 bytes, it freezes.

Am I the only one with this problem?

BLAx501! · Dec 29, 2014

mkarthick98 said:
About the bug fixes, I made all the changes mentioned above, but when I start my ROM in VBA, it doesn't work. The title screen doesn't load. From what I've found, the second bug fix, the Aftermath fix, is the problem. The ROM works fine when I change everything else, but once I insert those 136 bytes, it freezes.

Am I the only one with this problem?

Maybe the problem is the way you are "inserting" those bytes. The proper way is selecting all the bytes in HEX MrDollSteak gave us and then you copy the selection. After that you open your patched ROM with an Hexadecimal Editor such as HxD and you go to the ROM offset he gave us; 90BBE8. Here is the problem. If you just paste the bytes with Ctrl+V, it will expand the ROM and if it happens yhe final size is not a multiple of 4, the emulator won't be able to read the data from it. The solution?? Paste inserting by pressing Ctrl+B or by selecting an amount of bytes from the ROM of the same size you arre going to paste.

If your problem is this, don't worry because it is easy to solve ;)

TheRealOCD said:
if i want to apply MrDs's Rom base (Version 1.5) and this titlescreen patch, which to i patch first?

MrDs's patch: https://www.pokecommunity.com/threads/326301

Titlescreen Patch: https://www.pokecommunity.com/threads/341174

Thanks!

If the Titlescreen doesn't change anything on the ROM that MrDollSteak Patch does, it wouldn't mind the order, but just to make sure I'll say that I prefer to patch MrDollSteak's first because inserting a titlescreen is not that difficult after all xD

GUMI 02 · Dec 29, 2014

Spoiler:

Well, Thanks for the help!

Chronosplit · Dec 29, 2014

TheRabbit said:
Have the in-game trainers whos' pokemon have custom movesets been edited to reflect the new movesets?

And related to that, which trainer editor works with this base anyway? Advance and Unnamed are both a no-go for me.

Nope!

I have an INI file for unnamed trainer editor and (an earlier version of) G3T earlier in the thread.

Patch: MrDollSteak's Decap. and Attack Rombase

More options

Chaos Rush

Deokishisu

Mr. Magius

MrDollSteak

Formerly known as 11bayerf1

Volt-Ikazuchi

KurisuSan

Lord of Reality

MrDollSteak

Formerly known as 11bayerf1

Blah

Free supporter

MrDollSteak

Formerly known as 11bayerf1

SS Goku

jAvAcOlA

Banned

The ???

The one true question mark

LCCoolJ95

Limited Capacity

MrDollSteak

Formerly known as 11bayerf1

The ???

The one true question mark

GUMI 02

Canada Goose

TheRabbit

Banned

mkarthick98

Tensai

BLAx501!

Pokemon Flux

GUMI 02

Canada Goose

Chronosplit

I play for keeps!